All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Moshe Shemesh <moshe@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Alexander Duyck <alexander.duyck@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next RFC 3/3] net/mlx5: Add FW upgrade reset support
Date: Wed, 15 Jan 2020 07:01:45 -0800	[thread overview]
Message-ID: <20200115070145.3db10fe4@cakuba.hsd1.ca.comcast.net> (raw)
In-Reply-To: <1579017328-19643-4-git-send-email-moshe@mellanox.com>

On Tue, 14 Jan 2020 17:55:28 +0200, Moshe Shemesh wrote:
> Add support for FW upgrade reset.
> On devlink reload the driver checks if there is a FW stored pending
> upgrade reset. In such case the driver will set the device to FW upgrade
> reset on next PCI link toggle and do link toggle after unload.
> 
> To do PCI link toggle, the driver ensures that no other device ID under
> the same bridge by checking that all the PF functions under the same PCI
> bridge have same device ID. If no other device it uses PCI bridge link
> control to turn link down and up.
> 
> Signed-off-by: Moshe Shemesh <moshe@mellanox.com>

I'd have a slight preference for the reset to be an explicit command
rather than something the driver does automatically on the reload if
there are pending changes. Won't there ever be scenarios where users
just want to hard reset the device for their own reason?

If multiple devices under one bridge are a real concern (or otherwise
interdependencies) would it make sense to mark the devices as "reload
pending" and perform the reloads once all devices in the group has this
mark set?

  reply	other threads:[~2020-01-15 15:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14 15:55 [PATCH net-next RFC 0/3] Add mlx5 devices FW upgrade reset support Moshe Shemesh
2020-01-14 15:55 ` [PATCH net-next RFC 1/3] net/mlx5: Add structure layout and defines for MFRL register Moshe Shemesh
2020-01-14 15:55 ` [PATCH net-next RFC 2/3] net/mlx5: Add functions to set/query " Moshe Shemesh
2020-01-14 15:55 ` [PATCH net-next RFC 3/3] net/mlx5: Add FW upgrade reset support Moshe Shemesh
2020-01-15 15:01   ` Jakub Kicinski [this message]
2020-01-16 14:52     ` Moshe Shemesh
2020-01-17  1:26       ` Jakub Kicinski
2020-01-18 19:57         ` Moshe Shemesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200115070145.3db10fe4@cakuba.hsd1.ca.comcast.net \
    --to=kuba@kernel.org \
    --cc=alexander.duyck@gmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=moshe@mellanox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.