From: Jakub Kicinski <kuba@kernel.org>
To: Moshe Shemesh <moshe@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexander Duyck <alexander.duyck@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next RFC 3/3] net/mlx5: Add FW upgrade reset support
Date: Thu, 16 Jan 2020 17:26:33 -0800 [thread overview]
Message-ID: <20200116172633.5d873c17@cakuba.hsd1.ca.comcast.net> (raw)
In-Reply-To: <2f7a4d81-6ed9-7c93-1562-1df4dc7f9578@mellanox.com>
On Thu, 16 Jan 2020 14:52:35 +0000, Moshe Shemesh wrote:
> > If multiple devices under one bridge are a real concern (or otherwise
> > interdependencies) would it make sense to mark the devices as "reload
> > pending" and perform the reloads once all devices in the group has this
> > mark set?
>
> All mlx5 current devices support PCI - Express only.
>
> PCI-Express device should have its own PCI-Express bridge, it is 1x1
> connection.
>
> So the check here is just to verify, all functions found under the
> bridge are expected to be the same device functions (PFs and VFs).
Ah, good, I couldn't confirm that PCIe fact with google fast enough :)
The check sounds good then, with perhaps a small suggestion to add
a helper in PCIe core if it's already done by two drivers? Can be as
a follow up..
next prev parent reply other threads:[~2020-01-17 1:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 15:55 [PATCH net-next RFC 0/3] Add mlx5 devices FW upgrade reset support Moshe Shemesh
2020-01-14 15:55 ` [PATCH net-next RFC 1/3] net/mlx5: Add structure layout and defines for MFRL register Moshe Shemesh
2020-01-14 15:55 ` [PATCH net-next RFC 2/3] net/mlx5: Add functions to set/query " Moshe Shemesh
2020-01-14 15:55 ` [PATCH net-next RFC 3/3] net/mlx5: Add FW upgrade reset support Moshe Shemesh
2020-01-15 15:01 ` Jakub Kicinski
2020-01-16 14:52 ` Moshe Shemesh
2020-01-17 1:26 ` Jakub Kicinski [this message]
2020-01-18 19:57 ` Moshe Shemesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116172633.5d873c17@cakuba.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.