All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Jyri Sarha <jsarha@ti.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	tomi.valkeinen@ti.com, laurent.pinchart@ideasonboard.com,
	peter.ujfalusi@ti.com, bparrot@ti.com, praneeth@ti.com,
	yamonkar@cadence.com, sjakhade@cadence.com, maxime@cerno.tech
Subject: Re: [PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem
Date: Wed, 15 Jan 2020 13:22:53 +0100	[thread overview]
Message-ID: <20200115122253.GA22854@ravnborg.org> (raw)
In-Reply-To: <66c57bb30685920f040933ada9ccd4f5035d099f.1579086894.git.jsarha@ti.com>

Hi Jyri.

On Wed, Jan 15, 2020 at 01:45:38PM +0200, Jyri Sarha wrote:
> This patch adds a new DRM driver for Texas Instruments DSS IPs used on
> Texas Instruments Keystone K2G, AM65x, and J721e SoCs. The new DSS IP is
> a major change to the older DSS IP versions, which are supported by
> the omapdrm driver. While on higher level the Keystone DSS resembles
> the older DSS versions, the registers are completely different and the
> internal pipelines differ a lot.
> 
> DSS IP found on K2G is an "ultra-light" version, and has only a single
> plane and a single output. The K3 DSS IPs are found on AM65x and J721E
> SoCs. AM65x DSS has two video ports, one full video plane, and another
> "lite" plane without scaling support. J721E has 4 video ports, 2 video
> planes and 2 lite planes. AM65x DSS has also an integrated OLDI (LVDS)
> output.
> 
...
> v6: - Check CTM and gamma support from dispc_features when creating crtc
>     - Implement CTM support for k2g and fix k3 CTM implementation
>     - Remove gamma property persistence and always write color properties
>       in a new modeset

I applied this, just to throw this throgh my build setup.

checkpatch reported:
total: 0 errors, 45 warnings, 46 checks, 4920 lines checked

- space after cast
- CamelCase
- Macro argument
- length warnings
- alignment

I would ignore the line length warnings for the coefficients, but fix the
rest.

	Sam

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Jyri Sarha <jsarha@ti.com>
Cc: devicetree@vger.kernel.org, yamonkar@cadence.com,
	praneeth@ti.com, dri-devel@lists.freedesktop.org,
	peter.ujfalusi@ti.com, tomi.valkeinen@ti.com,
	laurent.pinchart@ideasonboard.com, sjakhade@cadence.com,
	maxime@cerno.tech
Subject: Re: [PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem
Date: Wed, 15 Jan 2020 13:22:53 +0100	[thread overview]
Message-ID: <20200115122253.GA22854@ravnborg.org> (raw)
In-Reply-To: <66c57bb30685920f040933ada9ccd4f5035d099f.1579086894.git.jsarha@ti.com>

Hi Jyri.

On Wed, Jan 15, 2020 at 01:45:38PM +0200, Jyri Sarha wrote:
> This patch adds a new DRM driver for Texas Instruments DSS IPs used on
> Texas Instruments Keystone K2G, AM65x, and J721e SoCs. The new DSS IP is
> a major change to the older DSS IP versions, which are supported by
> the omapdrm driver. While on higher level the Keystone DSS resembles
> the older DSS versions, the registers are completely different and the
> internal pipelines differ a lot.
> 
> DSS IP found on K2G is an "ultra-light" version, and has only a single
> plane and a single output. The K3 DSS IPs are found on AM65x and J721E
> SoCs. AM65x DSS has two video ports, one full video plane, and another
> "lite" plane without scaling support. J721E has 4 video ports, 2 video
> planes and 2 lite planes. AM65x DSS has also an integrated OLDI (LVDS)
> output.
> 
...
> v6: - Check CTM and gamma support from dispc_features when creating crtc
>     - Implement CTM support for k2g and fix k3 CTM implementation
>     - Remove gamma property persistence and always write color properties
>       in a new modeset

I applied this, just to throw this throgh my build setup.

checkpatch reported:
total: 0 errors, 45 warnings, 46 checks, 4920 lines checked

- space after cast
- CamelCase
- Macro argument
- length warnings
- alignment

I would ignore the line length warnings for the coefficients, but fix the
rest.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-01-15 12:23 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-15 11:45 [PATCH v6 0/5] drm/tidss: New driver for TI Keystone platform Display SubSystem Jyri Sarha
2020-01-15 11:45 ` Jyri Sarha
2020-01-15 11:45 ` [PATCH v6 1/5] dt-bindings: display: ti,k2g-dss: Add dt-schema yaml binding Jyri Sarha
2020-01-15 11:45   ` [PATCH v6 1/5] dt-bindings: display: ti, k2g-dss: " Jyri Sarha
2020-01-15 11:45 ` [PATCH v6 2/5] dt-bindings: display: ti,am65x-dss: " Jyri Sarha
2020-01-15 11:45   ` [PATCH v6 2/5] dt-bindings: display: ti, am65x-dss: " Jyri Sarha
2020-01-15 11:45 ` [PATCH v6 3/5] dt-bindings: display: ti,j721e-dss: " Jyri Sarha
2020-01-15 11:45   ` [PATCH v6 3/5] dt-bindings: display: ti, j721e-dss: " Jyri Sarha
2020-01-15 11:45 ` [PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem Jyri Sarha
2020-01-15 11:45   ` Jyri Sarha
2020-01-15 12:22   ` Sam Ravnborg [this message]
2020-01-15 12:22     ` Sam Ravnborg
2020-01-15 14:27     ` Jyri Sarha
2020-01-15 14:27       ` Jyri Sarha
2020-01-15 14:43       ` Sam Ravnborg
2020-01-15 14:43         ` Sam Ravnborg
2020-01-15 14:58         ` Jyri Sarha
2020-01-15 14:58           ` Jyri Sarha
2020-01-15 17:13           ` Sam Ravnborg
2020-01-15 17:13             ` Sam Ravnborg
2020-01-16 13:16             ` Jyri Sarha
2020-01-16 13:16               ` Jyri Sarha
2020-01-15 12:29   ` Sam Ravnborg
2020-01-15 12:29     ` Sam Ravnborg
2020-01-15 11:45 ` [PATCH v6 5/5] MAINTAINERS: add entry for tidss Jyri Sarha
2020-01-15 11:45   ` Jyri Sarha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200115122253.GA22854@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=bparrot@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=maxime@cerno.tech \
    --cc=peter.ujfalusi@ti.com \
    --cc=praneeth@ti.com \
    --cc=sjakhade@cadence.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=yamonkar@cadence.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.