* missing backports for x86 syscall function prototype cleanups
@ 2020-01-16 1:41 Kees Cook
2020-01-16 8:28 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Kees Cook @ 2020-01-16 1:41 UTC (permalink / raw)
To: Greg Kroah-Hartman, Sasha Levin; +Cc: stable, Sami Tolvanen
Hi!
Sami pointed out to me that 4 of 6 patches in Linus's tree that were
cleaning up the x86 syscall function prototypes didn't make it into
-stable.
These were backported:
8661d769ab77 ("syscalls/x86: Use the correct function type in SYSCALL_DEFINE0")
(as e79138ba8e0ec84f3ab5daa4761e4d534bbc682d)
f53e2cd0b8ab ("x86/mm: Use the correct function type for native_set_fixmap()")
(as a823d762a57519adeb33f5f12f761d636e42d32e)
But these are missing, leading to some confusion when working with v5.4
under CFI:
cf3b83e19d7c928e05a5d193c375463182c6029a
00198a6eaf66609de5e4de9163bb42c7ca9dd7b7
f48f01a92cca09e86d46c91d8edf9d5a71c61727
6e4847640c6aebcaa2d9b3686cecc91b41f09269
Can these get added please?
Thanks!
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: missing backports for x86 syscall function prototype cleanups
2020-01-16 1:41 missing backports for x86 syscall function prototype cleanups Kees Cook
@ 2020-01-16 8:28 ` Greg Kroah-Hartman
2020-01-16 23:53 ` Kees Cook
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2020-01-16 8:28 UTC (permalink / raw)
To: Kees Cook; +Cc: Sasha Levin, stable, Sami Tolvanen
On Wed, Jan 15, 2020 at 05:41:07PM -0800, Kees Cook wrote:
> Hi!
>
> Sami pointed out to me that 4 of 6 patches in Linus's tree that were
> cleaning up the x86 syscall function prototypes didn't make it into
> -stable.
>
> These were backported:
>
> 8661d769ab77 ("syscalls/x86: Use the correct function type in SYSCALL_DEFINE0")
> (as e79138ba8e0ec84f3ab5daa4761e4d534bbc682d)
> f53e2cd0b8ab ("x86/mm: Use the correct function type for native_set_fixmap()")
> (as a823d762a57519adeb33f5f12f761d636e42d32e)
>
> But these are missing, leading to some confusion when working with v5.4
> under CFI:
>
> cf3b83e19d7c928e05a5d193c375463182c6029a
> 00198a6eaf66609de5e4de9163bb42c7ca9dd7b7
> f48f01a92cca09e86d46c91d8edf9d5a71c61727
> 6e4847640c6aebcaa2d9b3686cecc91b41f09269
>
> Can these get added please?
I've queued them up now. But for 4.19, are these also needed? If so,
f48f01a92cca ("syscalls/x86: Use the correct function type for
sys_ni_syscall") needs a backport for it to work properly.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: missing backports for x86 syscall function prototype cleanups
2020-01-16 8:28 ` Greg Kroah-Hartman
@ 2020-01-16 23:53 ` Kees Cook
0 siblings, 0 replies; 3+ messages in thread
From: Kees Cook @ 2020-01-16 23:53 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Sasha Levin, stable, Sami Tolvanen
On Thu, Jan 16, 2020 at 09:28:48AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Jan 15, 2020 at 05:41:07PM -0800, Kees Cook wrote:
> > Hi!
> >
> > Sami pointed out to me that 4 of 6 patches in Linus's tree that were
> > cleaning up the x86 syscall function prototypes didn't make it into
> > -stable.
> >
> > These were backported:
> >
> > 8661d769ab77 ("syscalls/x86: Use the correct function type in SYSCALL_DEFINE0")
> > (as e79138ba8e0ec84f3ab5daa4761e4d534bbc682d)
> > f53e2cd0b8ab ("x86/mm: Use the correct function type for native_set_fixmap()")
> > (as a823d762a57519adeb33f5f12f761d636e42d32e)
> >
> > But these are missing, leading to some confusion when working with v5.4
> > under CFI:
> >
> > cf3b83e19d7c928e05a5d193c375463182c6029a
> > 00198a6eaf66609de5e4de9163bb42c7ca9dd7b7
> > f48f01a92cca09e86d46c91d8edf9d5a71c61727
> > 6e4847640c6aebcaa2d9b3686cecc91b41f09269
> >
> > Can these get added please?
>
> I've queued them up now. But for 4.19, are these also needed? If so,
> f48f01a92cca ("syscalls/x86: Use the correct function type for
> sys_ni_syscall") needs a backport for it to work properly.
I think, for now, we don't need to. v5.4 should be enough. Thanks!
-Kees
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-16 23:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-16 1:41 missing backports for x86 syscall function prototype cleanups Kees Cook
2020-01-16 8:28 ` Greg Kroah-Hartman
2020-01-16 23:53 ` Kees Cook
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.