From: Sam Ravnborg <sam@ravnborg.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] video: fbdev: controlfb: small cleanup
Date: Fri, 17 Jan 2020 20:32:23 +0100 [thread overview]
Message-ID: <20200117193223.GD24812@ravnborg.org> (raw)
In-Reply-To: <20200116140900.26363-1-b.zolnierkie@samsung.com>
Hi Bartlomiej
On Thu, Jan 16, 2020 at 03:08:54PM +0100, Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> Small cleanup for controlfb driver:
>
> - fix sparse warnings
> - remove not working module support
> - add COMPILE_TEST support
> - remove redundant function prototypes
Nice cleanup - with a few comments.
The last three patches are the good ones.
With my comments considered - and then up to you if you cahnge anything
- then all patches are:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
>
>
> Bartlomiej Zolnierkiewicz (6):
> video: fbdev: controlfb: fix sparse warning about using incorrect type
> video: fbdev: controlfb: remove obsolete module support
> video: fbdev: controlfb: add COMPILE_TEST support
> video: fbdev: controlfb: remove function prototypes part #1
> video: fbdev: controlfb: remove function prototypes part #2
> video: fbdev: controlfb: remove function prototypes part #3
>
> drivers/video/fbdev/Kconfig | 2 +-
> drivers/video/fbdev/controlfb.c | 810 +++++++++++++++-----------------
> 2 files changed, 383 insertions(+), 429 deletions(-)
>
> --
> 2.24.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/6] video: fbdev: controlfb: small cleanup
Date: Fri, 17 Jan 2020 19:32:23 +0000 [thread overview]
Message-ID: <20200117193223.GD24812@ravnborg.org> (raw)
In-Reply-To: <20200116140900.26363-1-b.zolnierkie@samsung.com>
Hi Bartlomiej
On Thu, Jan 16, 2020 at 03:08:54PM +0100, Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> Small cleanup for controlfb driver:
>
> - fix sparse warnings
> - remove not working module support
> - add COMPILE_TEST support
> - remove redundant function prototypes
Nice cleanup - with a few comments.
The last three patches are the good ones.
With my comments considered - and then up to you if you cahnge anything
- then all patches are:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
>
>
> Bartlomiej Zolnierkiewicz (6):
> video: fbdev: controlfb: fix sparse warning about using incorrect type
> video: fbdev: controlfb: remove obsolete module support
> video: fbdev: controlfb: add COMPILE_TEST support
> video: fbdev: controlfb: remove function prototypes part #1
> video: fbdev: controlfb: remove function prototypes part #2
> video: fbdev: controlfb: remove function prototypes part #3
>
> drivers/video/fbdev/Kconfig | 2 +-
> drivers/video/fbdev/controlfb.c | 810 +++++++++++++++-----------------
> 2 files changed, 383 insertions(+), 429 deletions(-)
>
> --
> 2.24.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/6] video: fbdev: controlfb: small cleanup
Date: Fri, 17 Jan 2020 20:32:23 +0100 [thread overview]
Message-ID: <20200117193223.GD24812@ravnborg.org> (raw)
In-Reply-To: <20200116140900.26363-1-b.zolnierkie@samsung.com>
Hi Bartlomiej
On Thu, Jan 16, 2020 at 03:08:54PM +0100, Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> Small cleanup for controlfb driver:
>
> - fix sparse warnings
> - remove not working module support
> - add COMPILE_TEST support
> - remove redundant function prototypes
Nice cleanup - with a few comments.
The last three patches are the good ones.
With my comments considered - and then up to you if you cahnge anything
- then all patches are:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
>
>
> Bartlomiej Zolnierkiewicz (6):
> video: fbdev: controlfb: fix sparse warning about using incorrect type
> video: fbdev: controlfb: remove obsolete module support
> video: fbdev: controlfb: add COMPILE_TEST support
> video: fbdev: controlfb: remove function prototypes part #1
> video: fbdev: controlfb: remove function prototypes part #2
> video: fbdev: controlfb: remove function prototypes part #3
>
> drivers/video/fbdev/Kconfig | 2 +-
> drivers/video/fbdev/controlfb.c | 810 +++++++++++++++-----------------
> 2 files changed, 383 insertions(+), 429 deletions(-)
>
> --
> 2.24.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-17 19:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200116140914eucas1p1a62794ad40589e818614176ea8e817ff@eucas1p1.samsung.com>
2020-01-16 14:08 ` [PATCH 0/6] video: fbdev: controlfb: small cleanup Bartlomiej Zolnierkiewicz
2020-01-16 14:08 ` Bartlomiej Zolnierkiewicz
2020-01-16 14:08 ` Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200116140915eucas1p2d6a2c654a66a78b6c3c1fc710f8a65b8@eucas1p2.samsung.com>
2020-01-16 14:08 ` [PATCH 1/6] video: fbdev: controlfb: fix sparse warning about using incorrect type Bartlomiej Zolnierkiewicz
2020-01-16 14:08 ` Bartlomiej Zolnierkiewicz
2020-01-16 14:08 ` Bartlomiej Zolnierkiewicz
2020-01-17 19:13 ` Sam Ravnborg
2020-01-17 19:13 ` Sam Ravnborg
2020-01-17 19:13 ` Sam Ravnborg
[not found] ` <CGME20200116140915eucas1p1d3696cbe492d55a4e4946c7e2d13f9d2@eucas1p1.samsung.com>
2020-01-16 14:08 ` [PATCH 2/6] video: fbdev: controlfb: remove obsolete module support Bartlomiej Zolnierkiewicz
2020-01-16 14:08 ` Bartlomiej Zolnierkiewicz
2020-01-16 14:08 ` Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200116140915eucas1p28dfeecf8a58cecb00262fe86fd19c4f5@eucas1p2.samsung.com>
2020-01-16 14:08 ` [PATCH 3/6] video: fbdev: controlfb: add COMPILE_TEST support Bartlomiej Zolnierkiewicz
2020-01-16 14:08 ` Bartlomiej Zolnierkiewicz
2020-01-16 14:08 ` Bartlomiej Zolnierkiewicz
2020-01-17 19:31 ` Sam Ravnborg
2020-01-17 19:31 ` Sam Ravnborg
2020-01-17 19:31 ` Sam Ravnborg
[not found] ` <CGME20200116140916eucas1p1a6aff99bd371c4e23b1cc287bc3c42a8@eucas1p1.samsung.com>
2020-01-16 14:08 ` [PATCH 4/6] video: fbdev: controlfb: remove function prototypes part #1 Bartlomiej Zolnierkiewicz
2020-01-16 14:08 ` Bartlomiej Zolnierkiewicz
2020-01-16 14:08 ` Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200116140916eucas1p112ff962e85e6feb4dbc2ff65443ef1ce@eucas1p1.samsung.com>
2020-01-16 14:08 ` [PATCH 5/6] video: fbdev: controlfb: remove function prototypes part #2 Bartlomiej Zolnierkiewicz
2020-01-16 14:08 ` Bartlomiej Zolnierkiewicz
2020-01-16 14:08 ` Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200116140916eucas1p2bd3480995a55fdc646481a8fa5a5aff3@eucas1p2.samsung.com>
2020-01-16 14:09 ` [PATCH 6/6] video: fbdev: controlfb: remove function prototypes part #3 Bartlomiej Zolnierkiewicz
2020-01-16 14:09 ` Bartlomiej Zolnierkiewicz
2020-01-16 14:09 ` Bartlomiej Zolnierkiewicz
2020-01-17 19:32 ` Sam Ravnborg [this message]
2020-01-17 19:32 ` [PATCH 0/6] video: fbdev: controlfb: small cleanup Sam Ravnborg
2020-01-17 19:32 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117193223.GD24812@ravnborg.org \
--to=sam@ravnborg.org \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.