Re: [PATCH v2] drivers: soc: ti: knav_qmss_queue: Pass lockdep expression to RCU lists

From: Amol Grover <frextrite@gmail.com>
To: Olof Johansson <olof@lixom.net>
Cc: santosh.shilimkar@oracle.com, arm-soc <arm@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	Joel Fernandes <joel@joelfernandes.org>,
	Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>,
	"Paul E . McKenney" <paulmck@kernel.org>
Subject: Re: [PATCH v2] drivers: soc: ti: knav_qmss_queue: Pass lockdep expression to RCU lists
Date: Sat, 18 Jan 2020 09:37:30 +0530	[thread overview]
Message-ID: <20200118040730.GA6783@workstation-portable> (raw)
In-Reply-To: <20200117192555.baoxu4xd7krxgfjz@localhost>

On Fri, Jan 17, 2020 at 11:25:55AM -0800, Olof Johansson wrote:
> On Fri, Jan 17, 2020 at 10:24:04AM -0800, santosh.shilimkar@oracle.com wrote:
> > On 1/17/20 5:30 AM, Amol Grover wrote:
> > > inst->handles is traversed using list_for_each_entry_rcu
> > > outside an RCU read-side critical section but under the protection
> > > of knav_dev_lock.
> > > 
> > > Hence, add corresponding lockdep expression to silence false-positive
> > > lockdep warnings, and harden RCU lists.
> > > 
> > > Add macro for the corresponding lockdep expression.
> > > 
> > > Signed-off-by: Amol Grover <frextrite@gmail.com>
> > > ---
> > > v2:
> > > - Remove rcu_read_lock_held() from lockdep expression since it is
> > >    implicitly checked for.
> > > 
> > Looks fine to me.
> > 
> > Hi Olof, Arnd,
> > Can you please pick this one and apply to your driver-soc branch ?
> > I already sent out pull request and hence the request.
> 
> Hi,
> 
> Can you please email the whole patch with sign-off to
> soc@kernel.org? Otherwise it won't end up in patchwork, which is how we track
> patches and pull requests these days.
> 

Thank you Santosh and Olof. I'm resending the patch to soc@kernel.org
as well.

Thanks
Amol

> 
> Thanks,
> 
> -Olof