From: Jonathan Cameron <jic23@kernel.org> To: Fabrice Gasnier <fabrice.gasnier@st.com> Cc: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <mcoquelin.stm32@gmail.com>, <alexandre.torgue@st.com>, <olivier.moysan@st.com>, <linux-iio@vger.kernel.org>, <lars@metafoo.de>, <knaack.h@gmx.de>, <pmeerw@pmeerw.net>, <linux-stm32@st-md-mailman.stormreply.com>, <etienne.carriere@st.com> Subject: Re: [PATCH 1/2] iio: dac: stm32-dac: use reset controller only at probe time Date: Sat, 18 Jan 2020 14:30:46 +0000 [thread overview] Message-ID: <20200118143046.4e6a6b95@archlinux> (raw) In-Reply-To: <1578921266-6025-2-git-send-email-fabrice.gasnier@st.com> On Mon, 13 Jan 2020 14:14:25 +0100 Fabrice Gasnier <fabrice.gasnier@st.com> wrote: > From: Etienne Carriere <etienne.carriere@st.com> > > This change removes the reset controller reference from the local > DAC instance since it is used only at probe time. > > Signed-off-by: Etienne Carriere <etienne.carriere@st.com> > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> Makes sense. Applied to the togreg branch of iio.git and pushed out as testing to let those autobuilders poke at it for a few hours. Thanks, Jonathan > --- > drivers/iio/dac/stm32-dac-core.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/iio/dac/stm32-dac-core.c b/drivers/iio/dac/stm32-dac-core.c > index 9e6b4cd..4d93446 100644 > --- a/drivers/iio/dac/stm32-dac-core.c > +++ b/drivers/iio/dac/stm32-dac-core.c > @@ -20,13 +20,11 @@ > /** > * struct stm32_dac_priv - stm32 DAC core private data > * @pclk: peripheral clock common for all DACs > - * @rst: peripheral reset control > * @vref: regulator reference > * @common: Common data for all DAC instances > */ > struct stm32_dac_priv { > struct clk *pclk; > - struct reset_control *rst; > struct regulator *vref; > struct stm32_dac_common common; > }; > @@ -94,6 +92,7 @@ static int stm32_dac_probe(struct platform_device *pdev) > struct regmap *regmap; > struct resource *res; > void __iomem *mmio; > + struct reset_control *rst; > int ret; > > if (!dev->of_node) > @@ -148,11 +147,11 @@ static int stm32_dac_probe(struct platform_device *pdev) > priv->common.vref_mv = ret / 1000; > dev_dbg(dev, "vref+=%dmV\n", priv->common.vref_mv); > > - priv->rst = devm_reset_control_get_exclusive(dev, NULL); > - if (!IS_ERR(priv->rst)) { > - reset_control_assert(priv->rst); > + rst = devm_reset_control_get_exclusive(dev, NULL); > + if (!IS_ERR(rst)) { > + reset_control_assert(rst); > udelay(2); > - reset_control_deassert(priv->rst); > + reset_control_deassert(rst); > } > > if (cfg && cfg->has_hfsel) {
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org> To: Fabrice Gasnier <fabrice.gasnier@st.com> Cc: etienne.carriere@st.com, lars@metafoo.de, olivier.moysan@st.com, alexandre.torgue@st.com, linux-iio@vger.kernel.org, pmeerw@pmeerw.net, linux-kernel@vger.kernel.org, mcoquelin.stm32@gmail.com, knaack.h@gmx.de, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] iio: dac: stm32-dac: use reset controller only at probe time Date: Sat, 18 Jan 2020 14:30:46 +0000 [thread overview] Message-ID: <20200118143046.4e6a6b95@archlinux> (raw) In-Reply-To: <1578921266-6025-2-git-send-email-fabrice.gasnier@st.com> On Mon, 13 Jan 2020 14:14:25 +0100 Fabrice Gasnier <fabrice.gasnier@st.com> wrote: > From: Etienne Carriere <etienne.carriere@st.com> > > This change removes the reset controller reference from the local > DAC instance since it is used only at probe time. > > Signed-off-by: Etienne Carriere <etienne.carriere@st.com> > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> Makes sense. Applied to the togreg branch of iio.git and pushed out as testing to let those autobuilders poke at it for a few hours. Thanks, Jonathan > --- > drivers/iio/dac/stm32-dac-core.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/iio/dac/stm32-dac-core.c b/drivers/iio/dac/stm32-dac-core.c > index 9e6b4cd..4d93446 100644 > --- a/drivers/iio/dac/stm32-dac-core.c > +++ b/drivers/iio/dac/stm32-dac-core.c > @@ -20,13 +20,11 @@ > /** > * struct stm32_dac_priv - stm32 DAC core private data > * @pclk: peripheral clock common for all DACs > - * @rst: peripheral reset control > * @vref: regulator reference > * @common: Common data for all DAC instances > */ > struct stm32_dac_priv { > struct clk *pclk; > - struct reset_control *rst; > struct regulator *vref; > struct stm32_dac_common common; > }; > @@ -94,6 +92,7 @@ static int stm32_dac_probe(struct platform_device *pdev) > struct regmap *regmap; > struct resource *res; > void __iomem *mmio; > + struct reset_control *rst; > int ret; > > if (!dev->of_node) > @@ -148,11 +147,11 @@ static int stm32_dac_probe(struct platform_device *pdev) > priv->common.vref_mv = ret / 1000; > dev_dbg(dev, "vref+=%dmV\n", priv->common.vref_mv); > > - priv->rst = devm_reset_control_get_exclusive(dev, NULL); > - if (!IS_ERR(priv->rst)) { > - reset_control_assert(priv->rst); > + rst = devm_reset_control_get_exclusive(dev, NULL); > + if (!IS_ERR(rst)) { > + reset_control_assert(rst); > udelay(2); > - reset_control_deassert(priv->rst); > + reset_control_deassert(rst); > } > > if (cfg && cfg->has_hfsel) { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-18 14:30 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-13 13:14 [PATCH 0/2] iio: dac: stm32-dac: improve reset controller use Fabrice Gasnier 2020-01-13 13:14 ` Fabrice Gasnier 2020-01-13 13:14 ` [PATCH 1/2] iio: dac: stm32-dac: use reset controller only at probe time Fabrice Gasnier 2020-01-13 13:14 ` Fabrice Gasnier 2020-01-18 14:30 ` Jonathan Cameron [this message] 2020-01-18 14:30 ` Jonathan Cameron 2020-01-13 13:14 ` [PATCH 2/2] iio: dac: stm32-dac: better handle reset controller failures Fabrice Gasnier 2020-01-13 13:14 ` Fabrice Gasnier 2020-01-18 14:32 ` Jonathan Cameron 2020-01-18 14:32 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200118143046.4e6a6b95@archlinux \ --to=jic23@kernel.org \ --cc=alexandre.torgue@st.com \ --cc=etienne.carriere@st.com \ --cc=fabrice.gasnier@st.com \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=olivier.moysan@st.com \ --cc=pmeerw@pmeerw.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.