All of lore.kernel.org
 help / color / mirror / Atom feed
* [linux-next:master 7161/9861] security/apparmor/policy_unpack_test.c:51:15: sparse: sparse: symbol 'build_aa_ext_struct' was not declared. Should it be static?
@ 2020-01-18 10:52 ` kbuild test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2020-01-18 10:52 UTC (permalink / raw)
  To: Mike Salvatore
  Cc: kbuild-all, Shuah Khan, Brendan Higgins, Kees Cook,
	John Johansen, James Morris, Serge E. Hallyn,
	linux-security-module, linux-kernel

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   de970dffa7d19eae1d703c3534825308ef8d5dec
commit: 4d944bcd4e731ab7bfe8d01a7041ea0ebdc090f1 [7161/9861] apparmor: add AppArmor KUnit tests for policy unpack
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-131-g22978b6b-dirty
        git checkout 4d944bcd4e731ab7bfe8d01a7041ea0ebdc090f1
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> security/apparmor/policy_unpack_test.c:51:15: sparse: sparse: symbol 'build_aa_ext_struct' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [linux-next:master 7161/9861] security/apparmor/policy_unpack_test.c:51:15: sparse: sparse: symbol 'build_aa_ext_struct' was not declared. Should it be static?
@ 2020-01-18 10:52 ` kbuild test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2020-01-18 10:52 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   de970dffa7d19eae1d703c3534825308ef8d5dec
commit: 4d944bcd4e731ab7bfe8d01a7041ea0ebdc090f1 [7161/9861] apparmor: add AppArmor KUnit tests for policy unpack
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-131-g22978b6b-dirty
        git checkout 4d944bcd4e731ab7bfe8d01a7041ea0ebdc090f1
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> security/apparmor/policy_unpack_test.c:51:15: sparse: sparse: symbol 'build_aa_ext_struct' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [RFC PATCH linux-next] apparmor: build_aa_ext_struct() can be static
  2020-01-18 10:52 ` kbuild test robot
@ 2020-01-18 10:52   ` kbuild test robot
  -1 siblings, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2020-01-18 10:52 UTC (permalink / raw)
  To: Mike Salvatore
  Cc: kbuild-all, Shuah Khan, Brendan Higgins, Kees Cook,
	John Johansen, James Morris, Serge E. Hallyn,
	linux-security-module, linux-kernel


Fixes: 4d944bcd4e73 ("apparmor: add AppArmor KUnit tests for policy unpack")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 policy_unpack_test.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/security/apparmor/policy_unpack_test.c b/security/apparmor/policy_unpack_test.c
index 533137f45361c..dbcfeb12a019f 100644
--- a/security/apparmor/policy_unpack_test.c
+++ b/security/apparmor/policy_unpack_test.c
@@ -48,8 +48,8 @@ struct policy_unpack_fixture {
 	size_t e_size;
 };
 
-struct aa_ext *build_aa_ext_struct(struct policy_unpack_fixture *puf,
-				   struct kunit *test, size_t buf_size)
+static struct aa_ext *build_aa_ext_struct(struct policy_unpack_fixture *puf,
+					  struct kunit *test, size_t buf_size)
 {
 	char *buf;
 	struct aa_ext *e;

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [RFC PATCH linux-next] apparmor: build_aa_ext_struct() can be static
@ 2020-01-18 10:52   ` kbuild test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2020-01-18 10:52 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


Fixes: 4d944bcd4e73 ("apparmor: add AppArmor KUnit tests for policy unpack")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 policy_unpack_test.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/security/apparmor/policy_unpack_test.c b/security/apparmor/policy_unpack_test.c
index 533137f45361c..dbcfeb12a019f 100644
--- a/security/apparmor/policy_unpack_test.c
+++ b/security/apparmor/policy_unpack_test.c
@@ -48,8 +48,8 @@ struct policy_unpack_fixture {
 	size_t e_size;
 };
 
-struct aa_ext *build_aa_ext_struct(struct policy_unpack_fixture *puf,
-				   struct kunit *test, size_t buf_size)
+static struct aa_ext *build_aa_ext_struct(struct policy_unpack_fixture *puf,
+					  struct kunit *test, size_t buf_size)
 {
 	char *buf;
 	struct aa_ext *e;

^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-18 10:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-18 10:52 [linux-next:master 7161/9861] security/apparmor/policy_unpack_test.c:51:15: sparse: sparse: symbol 'build_aa_ext_struct' was not declared. Should it be static? kbuild test robot
2020-01-18 10:52 ` kbuild test robot
2020-01-18 10:52 ` [RFC PATCH linux-next] apparmor: build_aa_ext_struct() can be static kbuild test robot
2020-01-18 10:52   ` kbuild test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.