[Patch nf] netfilter: nft_osf: NFTA_OSF_DREG must not be null

[Patch nf] netfilter: nft_osf: NFTA_OSF_DREG must not be null

[Cong Wang]

Fixes: b96af92d6eaf ("netfilter: nf_tables: implement Passive OS fingerprint module in nft_osf")
Reported-by: syzbot+cf23983d697c26c34f60@syzkaller.appspotmail.com
Cc: Florian Westphal <fw@strlen.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Fernando Fernandez Mancera <ffmancera@riseup.net>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
---
 net/netfilter/nft_osf.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/netfilter/nft_osf.c b/net/netfilter/nft_osf.c
index f54d6ae15bb1..b42247aa48a9 100644
--- a/net/netfilter/nft_osf.c
+++ b/net/netfilter/nft_osf.c
@@ -61,6 +61,9 @@ static int nft_osf_init(const struct nft_ctx *ctx,
 	int err;
 	u8 ttl;
 
+	if (!tb[NFTA_OSF_DREG])
+		return -EINVAL;
+
 	if (tb[NFTA_OSF_TTL]) {
 		ttl = nla_get_u8(tb[NFTA_OSF_TTL]);
 		if (ttl > 2)
-- 
2.21.1

Re: [Patch nf] netfilter: nft_osf: NFTA_OSF_DREG must not be null

[Pablo Neira Ayuso]

Thanks. This is a dup though:

https://patchwork.ozlabs.org/patch/1225125/

Thanks in any case.

Re: [Patch nf] netfilter: nft_osf: NFTA_OSF_DREG must not be null

[Cong Wang]

On Sat, Jan 18, 2020 at 12:19 PM Pablo Neira Ayuso <pablo@netfilter.org> wrote:
>
> Thanks. This is a dup though:
>
> https://patchwork.ozlabs.org/patch/1225125/
>
> Thanks in any case.

I didn't see it on netdev. But glad to see there is already a fix.

Thanks.