[miquelraynal:ecc-engine 57/60] drivers/mtd/nand/ecc-mxic.c:155:32: sparse: sparse: symbol 'mxic_ecc_ooblayout_ops' was not declared. Should it be static?

[miquelraynal:ecc-engine 57/60] drivers/mtd/nand/ecc-mxic.c:155:32: sparse: sparse: symbol 'mxic_ecc_ooblayout_ops' was not declared. Should it be static?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]

tree:   https://github.com/miquelraynal/linux-0day.git ecc-engine
head:   6864d344e2877ab874d2d2d1bee09cb7964342fd
commit: 907d0202f41f5586c4742ea320c2606c014abc4a [57/60] mtd: nand: mxic-ecc: Add Macronix external ECC engine support
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-131-g22978b6b-dirty
        git checkout 907d0202f41f5586c4742ea320c2606c014abc4a
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/mtd/nand/ecc-mxic.c:155:32: sparse: sparse: symbol 'mxic_ecc_ooblayout_ops' was not declared. Should it be static?
>> drivers/mtd/nand/ecc-mxic.c:605:5: sparse: sparse: symbol 'mxic_ecc_probe' was not declared. Should it be static?
>> drivers/mtd/nand/ecc-mxic.c:628:5: sparse: sparse: symbol 'mxic_ecc_remove' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

[RFC PATCH miquelraynal] mtd: nand: mxic-ecc: mxic_ecc_ooblayout_ops can be static

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]


Fixes: 907d0202f41f ("mtd: nand: mxic-ecc: Add Macronix external ECC engine support")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 ecc-mxic.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/nand/ecc-mxic.c b/drivers/mtd/nand/ecc-mxic.c
index 5da3d7e1431a3..0b7d617dc2394 100644
--- a/drivers/mtd/nand/ecc-mxic.c
+++ b/drivers/mtd/nand/ecc-mxic.c
@@ -152,7 +152,7 @@ static int mxic_ecc_ooblayout_free(struct mtd_info *mtd, int section,
 	return 0;
 }
 
-const struct mtd_ooblayout_ops mxic_ecc_ooblayout_ops = {
+static const struct mtd_ooblayout_ops mxic_ecc_ooblayout_ops = {
 	.ecc = mxic_ecc_ooblayout_ecc,
 	.free = mxic_ecc_ooblayout_free,
 };
@@ -602,7 +602,7 @@ static struct nand_ecc_engine_ops mxic_ecc_engine_external_ops = {
 	.finish_io_req = mxic_ecc_finish_io_req_external,
 };
 
-int mxic_ecc_probe(struct platform_device *pdev)
+static int mxic_ecc_probe(struct platform_device *pdev)
 {
 	const struct mxic_ecc_drvdata *d = of_device_get_match_data(&pdev->dev);
 	struct device *dev = &pdev->dev;
@@ -625,7 +625,7 @@ int mxic_ecc_probe(struct platform_device *pdev)
 	return 0;
 }
 
-int mxic_ecc_remove(struct platform_device *pdev)
+static int mxic_ecc_remove(struct platform_device *pdev)
 {
 	struct nand_ecc_engine *ecceng = nand_ecc_match_hw_engine(&pdev->dev);