From: Michael Straube <straube.linux@gmail.com> To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Michael Straube <straube.linux@gmail.com> Subject: [PATCH 2/3] staging: rtl8192u: simplify rtl819x_evm_dbtopercentage() Date: Sat, 18 Jan 2020 20:53:04 +0100 [thread overview] Message-ID: <20200118195305.16685-2-straube.linux@gmail.com> (raw) In-Reply-To: <20200118195305.16685-1-straube.linux@gmail.com> Use clamp() to simplify function rtl819x_evm_dbtopercentage() and reduce object file size. Signed-off-by: Michael Straube <straube.linux@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index 00fdcbf64b0b..a40ce0d7a467 100644 --- a/drivers/staging/rtl8192u/r8192U_core.c +++ b/drivers/staging/rtl8192u/r8192U_core.c @@ -3954,18 +3954,11 @@ static u8 rtl819x_query_rxpwrpercentage(s8 antpower) static u8 rtl819x_evm_dbtopercentage(s8 value) { - s8 ret_val; + s8 ret_val = clamp(-value, 0, 33) * 3; - ret_val = value; - - if (ret_val >= 0) - ret_val = 0; - if (ret_val <= -33) - ret_val = -33; - ret_val = 0 - ret_val; - ret_val *= 3; if (ret_val == 99) ret_val = 100; + return ret_val; } -- 2.24.1
WARNING: multiple messages have this Message-ID (diff)
From: Michael Straube <straube.linux@gmail.com> To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com, linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net Subject: [PATCH 2/3] staging: rtl8192u: simplify rtl819x_evm_dbtopercentage() Date: Sat, 18 Jan 2020 20:53:04 +0100 [thread overview] Message-ID: <20200118195305.16685-2-straube.linux@gmail.com> (raw) In-Reply-To: <20200118195305.16685-1-straube.linux@gmail.com> Use clamp() to simplify function rtl819x_evm_dbtopercentage() and reduce object file size. Signed-off-by: Michael Straube <straube.linux@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index 00fdcbf64b0b..a40ce0d7a467 100644 --- a/drivers/staging/rtl8192u/r8192U_core.c +++ b/drivers/staging/rtl8192u/r8192U_core.c @@ -3954,18 +3954,11 @@ static u8 rtl819x_query_rxpwrpercentage(s8 antpower) static u8 rtl819x_evm_dbtopercentage(s8 value) { - s8 ret_val; + s8 ret_val = clamp(-value, 0, 33) * 3; - ret_val = value; - - if (ret_val >= 0) - ret_val = 0; - if (ret_val <= -33) - ret_val = -33; - ret_val = 0 - ret_val; - ret_val *= 3; if (ret_val == 99) ret_val = 100; + return ret_val; } -- 2.24.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-01-18 19:55 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-18 19:53 [PATCH 1/3] staging: rtl8192e: simplify rtl92e_evm_db_to_percent() Michael Straube 2020-01-18 19:53 ` Michael Straube 2020-01-18 19:53 ` Michael Straube [this message] 2020-01-18 19:53 ` [PATCH 2/3] staging: rtl8192u: simplify rtl819x_evm_dbtopercentage() Michael Straube 2020-01-18 19:53 ` [PATCH 3/3] staging: rtl8712: simplify evm_db2percentage() Michael Straube 2020-01-18 19:53 ` Michael Straube
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200118195305.16685-2-straube.linux@gmail.com \ --to=straube.linux@gmail.com \ --cc=Larry.Finger@lwfinger.net \ --cc=devel@driverdev.osuosl.org \ --cc=florian.c.schilhabel@googlemail.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.