All of lore.kernel.org
 help / color / mirror / Atom feed
* [kraxel:drm-virtio-buffers 3/3] drivers/gpu/drm/virtio/virtio-buffers.c:48:21: sparse: sparse: restricted __le32 degrades to integer
@ 2020-01-19  0:12 kbuild test robot
  2020-01-19  0:12 ` [RFC PATCH kraxel] [wip] virtio-buffers: virtbufs_ctrl_ack() can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2020-01-19  0:12 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1568 bytes --]

tree:   git://git.kraxel.org/linux drm-virtio-buffers
head:   45c447e91f0c14344e0552dd72a65201673ff19b
commit: 45c447e91f0c14344e0552dd72a65201673ff19b [3/3] [wip] virtio-buffers: guest driver
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-131-g22978b6b-dirty
        git checkout 45c447e91f0c14344e0552dd72a65201673ff19b
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/gpu/drm/virtio/virtio-buffers.c:48:21: sparse: sparse: restricted __le32 degrades to integer
>> drivers/gpu/drm/virtio/virtio-buffers.c:41:6: sparse: sparse: symbol 'virtbufs_ctrl_ack' was not declared. Should it be static?

Please review and possibly fold the followup patch.

vim +48 drivers/gpu/drm/virtio/virtio-buffers.c

    40	
  > 41	void virtbufs_ctrl_ack(struct virtqueue *vq)
    42	{
    43		// struct virtbufs_device *vb = vq->vdev->priv;
    44		struct virtbufs_request *req;
    45		int length;
    46	
    47		req = virtqueue_get_buf(vq, &length);
  > 48		if (req->rsp.response != VIRTIO_BUFFERS_RSP_OK)
    49			DRM_ERROR("command 0x%04x -> error 0x%4x\n",
    50				  req->cmd.command, req->rsp.response);
    51		kfree(req);
    52	}
    53	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [RFC PATCH kraxel] [wip] virtio-buffers: virtbufs_ctrl_ack() can be static
  2020-01-19  0:12 [kraxel:drm-virtio-buffers 3/3] drivers/gpu/drm/virtio/virtio-buffers.c:48:21: sparse: sparse: restricted __le32 degrades to integer kbuild test robot
@ 2020-01-19  0:12 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2020-01-19  0:12 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]


Fixes: 45c447e91f0c ("[wip] virtio-buffers: guest driver")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 virtio-buffers.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/virtio/virtio-buffers.c b/drivers/gpu/drm/virtio/virtio-buffers.c
index 58ef2ddccf6f2..f091084b20e4c 100644
--- a/drivers/gpu/drm/virtio/virtio-buffers.c
+++ b/drivers/gpu/drm/virtio/virtio-buffers.c
@@ -38,7 +38,7 @@ struct virtbufs_request {
 
 /* ------------------------------------------------------------------ */
 
-void virtbufs_ctrl_ack(struct virtqueue *vq)
+static void virtbufs_ctrl_ack(struct virtqueue *vq)
 {
 	// struct virtbufs_device *vb = vq->vdev->priv;
 	struct virtbufs_request *req;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-01-19  0:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-19  0:12 [kraxel:drm-virtio-buffers 3/3] drivers/gpu/drm/virtio/virtio-buffers.c:48:21: sparse: sparse: restricted __le32 degrades to integer kbuild test robot
2020-01-19  0:12 ` [RFC PATCH kraxel] [wip] virtio-buffers: virtbufs_ctrl_ack() can be static kbuild test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.