From: Mark Brown <broonie@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Cezary Rojewski <cezary.rojewski@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 9/9] ASoC: Intel: Switch DMI table match to a test of variable
Date: Mon, 20 Jan 2020 17:55:54 +0000 [thread overview]
Message-ID: <20200120175554.GK6852@sirena.org.uk> (raw)
In-Reply-To: <20200120160801.53089-10-andriy.shevchenko@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 505 bytes --]
On Mon, Jan 20, 2020 at 06:08:01PM +0200, Andy Shevchenko wrote:
> Since we have a common x86 quirk that provides an exported variable,
> use it instead of local DMI table match.
Acked-by: Mark Brown <broonie@kernel.org>
> - if (cht_machine_id == CHT_SURFACE_MACH)
> - return &cht_surface_mach;
> - else
> - return mach;
> + return x86_microsoft_surface_3_machine ? &cht_surface_mach : arg;
but if you're respinning this please replace this with a normal
conditional statement to improve legibility.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
alsa-devel@alsa-project.org, x86@kernel.org,
Jie Yang <yang.jie@linux.intel.com>,
linux-kernel@vger.kernel.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [alsa-devel] [PATCH v2 9/9] ASoC: Intel: Switch DMI table match to a test of variable
Date: Mon, 20 Jan 2020 17:55:54 +0000 [thread overview]
Message-ID: <20200120175554.GK6852@sirena.org.uk> (raw)
In-Reply-To: <20200120160801.53089-10-andriy.shevchenko@linux.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 505 bytes --]
On Mon, Jan 20, 2020 at 06:08:01PM +0200, Andy Shevchenko wrote:
> Since we have a common x86 quirk that provides an exported variable,
> use it instead of local DMI table match.
Acked-by: Mark Brown <broonie@kernel.org>
> - if (cht_machine_id == CHT_SURFACE_MACH)
> - return &cht_surface_mach;
> - else
> - return mach;
> + return x86_microsoft_surface_3_machine ? &cht_surface_mach : arg;
but if you're respinning this please replace this with a normal
conditional statement to improve legibility.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-01-20 17:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 16:07 [PATCH v2 0/9] x86: Easy way of detecting MS Surface 3 Andy Shevchenko
2020-01-20 16:07 ` [alsa-devel] " Andy Shevchenko
2020-01-20 16:07 ` [PATCH v2 1/9] x86/platform: Rename x86/apple.h -> x86/machine.h Andy Shevchenko
2020-01-20 16:07 ` [PATCH v2 2/9] x86/quirks: Add missed include to satisfy static checker Andy Shevchenko
2020-01-20 16:07 ` [PATCH v2 3/9] x86/quirks: Introduce hpet_dev_print_force_hpet_address() helper Andy Shevchenko
2020-01-20 16:07 ` [PATCH v2 4/9] x86/quirks: Join string literals back Andy Shevchenko
2020-01-20 16:07 ` [PATCH v2 5/9] x86/quirks: Convert DMI matching to use a table Andy Shevchenko
2020-01-21 11:51 ` Jonathan McDowell
2020-01-21 15:20 ` Andy Shevchenko
2020-01-20 16:07 ` [PATCH v2 6/9] x86/quirks: Add a DMI quirk for Microsoft Surface 3 Andy Shevchenko
2020-01-20 16:07 ` [alsa-devel] " Andy Shevchenko
2020-01-20 16:07 ` [PATCH v2 7/9] platform/x86: surface3_wmi: Switch DMI table match to a test of variable Andy Shevchenko
2020-01-20 16:08 ` [PATCH v2 8/9] ASoC: rt5645: " Andy Shevchenko
2020-01-20 16:08 ` [alsa-devel] " Andy Shevchenko
2020-01-20 17:46 ` Mark Brown
2020-01-20 17:46 ` [alsa-devel] " Mark Brown
2020-01-20 16:08 ` [PATCH v2 9/9] ASoC: Intel: " Andy Shevchenko
2020-01-20 16:08 ` [alsa-devel] " Andy Shevchenko
2020-01-20 17:55 ` Mark Brown [this message]
2020-01-20 17:55 ` Mark Brown
2020-01-21 15:20 ` Andy Shevchenko
2020-01-21 15:20 ` [alsa-devel] " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120175554.GK6852@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=cezary.rojewski@intel.com \
--cc=hpa@zytor.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.