From: Sam Ravnborg <sam@ravnborg.org> To: David Lechner <david@lechnology.com> Cc: "Geert Uytterhoeven" <geert+renesas@glider.be>, "Noralf Trønnes" <noralf@tronnes.org>, "David Airlie" <airlied@linux.ie>, "Daniel Vetter" <daniel@ffwll.ch>, "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>, "Maxime Ripard" <mripard@kernel.org>, "Rob Herring" <robh+dt@kernel.org>, "Mark Rutland" <mark.rutland@arm.com>, "Chris Brandt" <chris.brandt@renesas.com>, "Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, "Rob Herring" <robh@kernel.org> Subject: [PATCH] dt-bindings: restrict properties for sitronix,st7735r Date: Mon, 20 Jan 2020 20:02:49 +0100 [thread overview] Message-ID: <20200120190249.GA9619@ravnborg.org> (raw) In-Reply-To: <ba21d2c8-ccc6-2704-fa1f-d28239700547@lechnology.com> Hi David. > > +allOf: > > + - $ref: panel/panel-common.yaml# > > not all of these properties are applicable. > > > +required: > > + - compatible > > + - reg > > + - dc-gpios > > + - reset-gpios > > Missing optional rotation and backlight properties. Thanks for catching this. I have written a little .yaml files since I applied this - and learned a little more of the syntax. See attached patch for my attempt to fix this. Please review. Sam From 6b54fb0a071c0732cd4bd5b88f456b5a85bcf4f2 Mon Sep 17 00:00:00 2001 From: Sam Ravnborg <sam@ravnborg.org> Date: Mon, 20 Jan 2020 19:55:04 +0100 Subject: [PATCH] dt-bindings: restrict properties for sitronix,st7735r David Lechner noticed (paraphrased): - not all properties from panel-common are applicable. - missing optional rotation and backlight properties Fix this by listing all allowed properties, and do not allow other properties. Fixes: abdd9e3705c8 ("dt-bindings: display: sitronix,st7735r: Convert to DT schema") Reported-by: David Lechner <david@lechnology.com> Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: David Lechner <david@lechnology.com> Cc: Rob Herring <robh@kernel.org> Cc: dri-devel@lists.freedesktop.org --- .../devicetree/bindings/display/sitronix,st7735r.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml index 8892d79e6e10..0cebaaefda03 100644 --- a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml @@ -39,12 +39,19 @@ properties: maxItems: 1 description: Display data/command selection (D/CX) + backlight: true + reg: true + reset-gpios: true + rotation: true + required: - compatible - reg - dc-gpios - reset-gpios +additionalProperties: false + examples: - | #include <dt-bindings/gpio/gpio.h> -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org> To: David Lechner <david@lechnology.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Geert Uytterhoeven <geert+renesas@glider.be>, David Airlie <airlied@linux.ie>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Chris Brandt <chris.brandt@renesas.com>, dri-devel@lists.freedesktop.org Subject: [PATCH] dt-bindings: restrict properties for sitronix,st7735r Date: Mon, 20 Jan 2020 20:02:49 +0100 [thread overview] Message-ID: <20200120190249.GA9619@ravnborg.org> (raw) In-Reply-To: <ba21d2c8-ccc6-2704-fa1f-d28239700547@lechnology.com> Hi David. > > +allOf: > > + - $ref: panel/panel-common.yaml# > > not all of these properties are applicable. > > > +required: > > + - compatible > > + - reg > > + - dc-gpios > > + - reset-gpios > > Missing optional rotation and backlight properties. Thanks for catching this. I have written a little .yaml files since I applied this - and learned a little more of the syntax. See attached patch for my attempt to fix this. Please review. Sam From 6b54fb0a071c0732cd4bd5b88f456b5a85bcf4f2 Mon Sep 17 00:00:00 2001 From: Sam Ravnborg <sam@ravnborg.org> Date: Mon, 20 Jan 2020 19:55:04 +0100 Subject: [PATCH] dt-bindings: restrict properties for sitronix,st7735r David Lechner noticed (paraphrased): - not all properties from panel-common are applicable. - missing optional rotation and backlight properties Fix this by listing all allowed properties, and do not allow other properties. Fixes: abdd9e3705c8 ("dt-bindings: display: sitronix,st7735r: Convert to DT schema") Reported-by: David Lechner <david@lechnology.com> Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: David Lechner <david@lechnology.com> Cc: Rob Herring <robh@kernel.org> Cc: dri-devel@lists.freedesktop.org --- .../devicetree/bindings/display/sitronix,st7735r.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml index 8892d79e6e10..0cebaaefda03 100644 --- a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml @@ -39,12 +39,19 @@ properties: maxItems: 1 description: Display data/command selection (D/CX) + backlight: true + reg: true + reset-gpios: true + rotation: true + required: - compatible - reg - dc-gpios - reset-gpios +additionalProperties: false + examples: - | #include <dt-bindings/gpio/gpio.h> -- 2.20.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-20 19:02 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-15 12:45 [PATCH v2 0/5] drm: Add support for Okaya RH128128T Geert Uytterhoeven 2020-01-15 12:45 ` Geert Uytterhoeven 2020-01-15 12:45 ` [PATCH v2 1/5] dt-bindings: display: sitronix,st7735r: Convert to DT schema Geert Uytterhoeven 2020-01-15 12:45 ` [PATCH v2 1/5] dt-bindings: display: sitronix, st7735r: " Geert Uytterhoeven 2020-01-15 21:01 ` [PATCH v2 1/5] dt-bindings: display: sitronix,st7735r: " Sam Ravnborg 2020-01-15 21:01 ` Sam Ravnborg 2020-01-15 22:06 ` Geert Uytterhoeven 2020-01-15 22:06 ` [PATCH v2 1/5] dt-bindings: display: sitronix, st7735r: " Geert Uytterhoeven 2020-01-20 16:00 ` [PATCH v2 1/5] dt-bindings: display: sitronix,st7735r: " David Lechner 2020-01-20 16:00 ` [PATCH v2 1/5] dt-bindings: display: sitronix, st7735r: " David Lechner 2020-01-20 19:02 ` Sam Ravnborg [this message] 2020-01-20 19:02 ` [PATCH] dt-bindings: restrict properties for sitronix,st7735r Sam Ravnborg 2020-01-23 7:24 ` Sam Ravnborg 2020-01-23 7:24 ` Sam Ravnborg 2020-01-23 7:43 ` Geert Uytterhoeven 2020-01-23 7:43 ` Geert Uytterhoeven 2020-01-23 18:19 ` Sam Ravnborg 2020-01-23 18:19 ` Sam Ravnborg 2020-01-23 14:41 ` Rob Herring 2020-01-23 14:41 ` Rob Herring 2020-01-15 12:45 ` [PATCH v2 2/5] dt-bindings: display: sitronix,st7735r: Add Okaya RH128128T Geert Uytterhoeven 2020-01-15 12:45 ` [PATCH v2 2/5] dt-bindings: display: sitronix, st7735r: " Geert Uytterhoeven 2020-01-15 21:01 ` [PATCH v2 2/5] dt-bindings: display: sitronix,st7735r: " Sam Ravnborg 2020-01-15 21:01 ` [PATCH v2 2/5] dt-bindings: display: sitronix, st7735r: " Sam Ravnborg 2020-01-15 12:45 ` [PATCH v2 3/5] drm/mipi_dbi: Add support for display offsets Geert Uytterhoeven 2020-01-15 12:45 ` Geert Uytterhoeven 2020-01-17 21:12 ` Sam Ravnborg 2020-01-17 21:12 ` Sam Ravnborg 2020-01-19 16:03 ` Noralf Trønnes 2020-01-19 16:03 ` Noralf Trønnes 2020-01-15 12:45 ` [PATCH v2 4/5] drm: tiny: st7735r: Prepare for adding support for more displays Geert Uytterhoeven 2020-01-15 12:45 ` Geert Uytterhoeven 2020-01-15 12:45 ` [PATCH v2 5/5] drm: tiny: st7735r: Add support for Okaya RH128128T Geert Uytterhoeven 2020-01-15 12:45 ` Geert Uytterhoeven 2020-01-19 17:15 ` [PATCH v2 0/5] drm: " Sam Ravnborg 2020-01-19 17:15 ` Sam Ravnborg
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200120190249.GA9619@ravnborg.org \ --to=sam@ravnborg.org \ --cc=airlied@linux.ie \ --cc=chris.brandt@renesas.com \ --cc=daniel@ffwll.ch \ --cc=david@lechnology.com \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert+renesas@glider.be \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mark.rutland@arm.com \ --cc=mripard@kernel.org \ --cc=noralf@tronnes.org \ --cc=robh+dt@kernel.org \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.