* Build failed in Jenkins: libcamera #72
@ 2020-01-15 0:03 Jenkins Builder Robot
2020-01-16 17:48 ` Build failed in Jenkins: libcamera #73 Jenkins Builder Robot
2020-01-19 21:16 ` Build failed in Jenkins: libcamera #72 Kieran Bingham
0 siblings, 2 replies; 18+ messages in thread
From: Jenkins Builder Robot @ 2020-01-15 0:03 UTC (permalink / raw)
To: mchehab, linux-media
See <https://builder.linuxtv.org/job/libcamera/72/display/redirect?page=changes>
Changes:
[laurent.pinchart] meson.build: Switch to C++14
[laurent.pinchart] libcamera: Switch from utils::make_unique to std::make_unique
------------------------------------------
Started by an SCM change
Running as SYSTEM
Building remotely on slave1 in workspace <https://builder.linuxtv.org/job/libcamera/ws/>
No credentials specified
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url git://linuxtv.org/libcamera.git # timeout=10
Fetching upstream changes from git://linuxtv.org/libcamera.git
> git --version # timeout=10
> git fetch --tags --force --progress -- git://linuxtv.org/libcamera.git +refs/heads/*:refs/remotes/origin/* # timeout=10
> git rev-parse refs/remotes/origin/master^{commit} # timeout=10
> git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision acf18e4265dec2991e62f7c8baecfacf1a6708b3 (refs/remotes/origin/master)
> git config core.sparsecheckout # timeout=10
> git checkout -f acf18e4265dec2991e62f7c8baecfacf1a6708b3 # timeout=10
Commit message: "libcamera: Switch from utils::make_unique to std::make_unique"
> git rev-list --no-walk 055335bf49dbcb8c149bdcd4e96004c68e6b6ece # timeout=10
[libcamera] $ /bin/sh -xe /tmp/jenkins2777310540601637282.sh
+ meson build -Dandroid=true
Directory already configured.
Just run your build command (e.g. ninja) and Meson will regenerate as necessary.
If ninja fails, run "ninja reconfigure" or "meson --reconfigure"
to force Meson to regenerate.
If build failures persist, run "meson setup --wipe" to rebuild from scratch
using the same options as passed when configuring the build.
To change option values, run "meson configure" instead.
+ cd build
+ ninja
[0/1] Regenerating build files.
The Meson build system
Version: 0.49.2
Source dir: <https://builder.linuxtv.org/job/libcamera/ws/>
Build dir: <https://builder.linuxtv.org/job/libcamera/ws/build>
Build type: native build
Project name: libcamera
Project version: 0.0.0
Native C compiler: ccache cc (gcc 8.3.0 "cc (Debian 8.3.0-6) 8.3.0")
Native C++ compiler: ccache c++ (gcc 8.3.0 "c++ (Debian 8.3.0-6) 8.3.0")
Build machine cpu family: x86_64
Build machine cpu: x86_64
Header <execinfo.h> has symbol "backtrace" : YES
Header <stdlib.h> has symbol "secure_getenv" : YES
Configuring version.h using configuration
Dependency libudev found: YES (cached)
Library atomic found: YES
Library dl found: YES
Dependency threads found: YES (cached)
WARNING: rcc dependencies will not work reliably until this upstream issue is fixed: https://bugreports.qt.io/browse/QTBUG-45460
Dependency qt5 found: YES (cached)
Detecting Qt5 tools
moc: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/moc, 5.11.3)
uic: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/uic, 5.11.3)
rcc: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/rcc, 5.11.3)
lrelease: NO
Program doxygen found: YES (/usr/bin/doxygen)
Configuring Doxyfile using configuration
Program sphinx-build-3 found: NO
Program sphinx-build found: YES (/usr/bin/sphinx-build)
Configuring config.h using configuration
Build targets in project: 68
Option werror is: True [default: true]
Option cpp_std is: c++11 [default: c++14]
Found ninja-1.8.2 at /usr/bin/ninja
[1/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/buffer.cpp.o'.
[2/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/message.cpp.o'.
[3/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/object.cpp.o'.
[4/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/media_object.cpp.o'.
[5/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/process.cpp.o'.
[6/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o' -c ../src/libcamera/pipeline/vimc.cpp
../src/libcamera/pipeline/vimc.cpp: In member function ‘virtual bool libcamera::PipelineHandlerVimc::match(libcamera::DeviceEnumerator*)’:
../src/libcamera/pipeline/vimc.cpp:368:46: error: ‘make_unique’ is not a member of ‘std’
std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
^~~~~~~~~~~
../src/libcamera/pipeline/vimc.cpp:368:46: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/pipeline/vimc.cpp:34:1:
+#include <memory>
../src/libcamera/pipeline/vimc.cpp:368:46:
std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
^~~~~~~~~~~
../src/libcamera/pipeline/vimc.cpp:368:72: error: expected primary-expression before ‘>’ token
std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
^
[7/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/framebuffer_allocator.cpp.o'.
[8/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o' -c ../src/libcamera/pipeline/ipu3/ipu3.cpp
../src/libcamera/pipeline/ipu3/ipu3.cpp: In member function ‘int libcamera::PipelineHandlerIPU3::registerCameras()’:
../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9: error: ‘make_unique’ is not a member of ‘std’
std::make_unique<IPU3CameraData>(this);
^~~~~~~~~~~
../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/pipeline/ipu3/ipu3.cpp:29:1:
+#include <memory>
../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9:
std::make_unique<IPU3CameraData>(this);
^~~~~~~~~~~
../src/libcamera/pipeline/ipu3/ipu3.cpp:879:35: error: expected primary-expression before ‘>’ token
std::make_unique<IPU3CameraData>(this);
^
[9/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/request.cpp.o'.
[10/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_timeline.cpp.o'.
[11/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_handler.cpp.o'.
[12/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o' -c ../src/libcamera/proxy/ipa_proxy_linux.cpp
In file included from ../src/libcamera/proxy/ipa_proxy_linux.cpp:14:
../src/libcamera/proxy/ipa_proxy_linux.cpp: In member function ‘virtual std::unique_ptr<libcamera::IPAProxy> libcamera::IPAProxyLinuxFactory::create(libcamera::IPAModule*)’:
../src/libcamera/include/ipa_proxy.h:58:15: error: ‘make_unique’ is not a member of ‘std’
return std::make_unique<proxy>(ipam); \
^~~~~~~~~~~
../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
REGISTER_IPA_PROXY(IPAProxyLinux)
^~~~~~~~~~~~~~~~~~
../src/libcamera/include/ipa_proxy.h:58:15: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
return std::make_unique<proxy>(ipam); \
^~~~~~~~~~~
../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
REGISTER_IPA_PROXY(IPAProxyLinux)
^~~~~~~~~~~~~~~~~~
../src/libcamera/include/ipa_proxy.h:58:32: error: expected primary-expression before ‘>’ token
return std::make_unique<proxy>(ipam); \
^
../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
REGISTER_IPA_PROXY(IPAProxyLinux)
^~~~~~~~~~~~~~~~~~
[13/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/.._android_camera3_hal.cpp.o'.
[14/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/device_enumerator_udev.cpp.o'.
[15/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o' -c ../src/libcamera/pipeline/rkisp1/rkisp1.cpp
../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘void libcamera::RkISP1CameraData::queueFrameAction(unsigned int, const libcamera::IPAOperationData&)’:
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33: error: ‘make_unique’ is not a member of ‘std’
timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
^~~~~~~~~~~
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:34:1:
+#include <memory>
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33:
timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
^~~~~~~~~~~
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:66: error: expected primary-expression before ‘>’ token
timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
^
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:392:12: error: left operand of comma operator has no effect [-Werror=unused-value]
sensor_,
^~~~~~~
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:392:12: error: right operand of comma operator has no effect [-Werror=unused-value]
../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘virtual int libcamera::PipelineHandlerRkISP1::queueRequestDevice(libcamera::Camera*, libcamera::Request*)’:
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:38: error: ‘make_unique’ is not a member of ‘std’
data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
^~~~~~~~~~~
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:38: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:74: error: expected primary-expression before ‘>’ token
data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
^
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:82: error: left operand of comma operator has no effect [-Werror=unused-value]
data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
~~~~~~^~~~~~
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:851:13: error: right operand of comma operator has no effect [-Werror=unused-value]
this));
^~~~
../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘int libcamera::PipelineHandlerRkISP1::createCamera(libcamera::MediaEntity*)’:
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:8: error: ‘make_unique’ is not a member of ‘std’
std::make_unique<RkISP1CameraData>(this);
^~~~~~~~~~~
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:8: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:36: error: expected primary-expression before ‘>’ token
std::make_unique<RkISP1CameraData>(this);
^
cc1plus: all warnings being treated as errors
ninja: build stopped: subcommand failed.
Build step 'Execute shell' marked build as failure
^ permalink raw reply [flat|nested] 18+ messages in thread
* Build failed in Jenkins: libcamera #73
2020-01-15 0:03 Build failed in Jenkins: libcamera #72 Jenkins Builder Robot
@ 2020-01-16 17:48 ` Jenkins Builder Robot
2020-01-16 23:33 ` Build failed in Jenkins: libcamera #74 Jenkins Builder Robot
2020-01-19 21:16 ` Build failed in Jenkins: libcamera #72 Kieran Bingham
1 sibling, 1 reply; 18+ messages in thread
From: Jenkins Builder Robot @ 2020-01-16 17:48 UTC (permalink / raw)
To: mchehab, linux-media
See <https://builder.linuxtv.org/job/libcamera/73/display/redirect?page=changes>
Changes:
[laurent.pinchart] libcamera: Remove std::piecewise_construct where not necessary
------------------------------------------
Started by an SCM change
Running as SYSTEM
Building remotely on slave1 in workspace <https://builder.linuxtv.org/job/libcamera/ws/>
No credentials specified
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url git://linuxtv.org/libcamera.git # timeout=10
Fetching upstream changes from git://linuxtv.org/libcamera.git
> git --version # timeout=10
> git fetch --tags --force --progress -- git://linuxtv.org/libcamera.git +refs/heads/*:refs/remotes/origin/* # timeout=10
> git rev-parse refs/remotes/origin/master^{commit} # timeout=10
> git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 38dd90307ab2b0d25a0a233eae04455f769153b4 (refs/remotes/origin/master)
> git config core.sparsecheckout # timeout=10
> git checkout -f 38dd90307ab2b0d25a0a233eae04455f769153b4 # timeout=10
Commit message: "libcamera: Remove std::piecewise_construct where not necessary"
> git rev-list --no-walk acf18e4265dec2991e62f7c8baecfacf1a6708b3 # timeout=10
[libcamera] $ /bin/sh -xe /tmp/jenkins7841465350713820008.sh
+ meson build -Dandroid=true
Directory already configured.
Just run your build command (e.g. ninja) and Meson will regenerate as necessary.
If ninja fails, run "ninja reconfigure" or "meson --reconfigure"
to force Meson to regenerate.
If build failures persist, run "meson setup --wipe" to rebuild from scratch
using the same options as passed when configuring the build.
To change option values, run "meson configure" instead.
+ cd build
+ ninja
[1/133] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o' -c ../src/libcamera/bound_method.cpp
../src/libcamera/bound_method.cpp: In member function ‘bool libcamera::BoundMethodBase::activatePack(std::shared_ptr<libcamera::BoundMethodPackBase>, bool)’:
../src/libcamera/bound_method.cpp:86:9: error: ‘make_unique’ is not a member of ‘std’
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~~~~~~~~
../src/libcamera/bound_method.cpp:86:9: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/bound_method.cpp:13:1:
+#include <memory>
../src/libcamera/bound_method.cpp:86:9:
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~~~~~~~~
../src/libcamera/bound_method.cpp:86:34: error: expected primary-expression before ‘>’ token
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^
../src/libcamera/bound_method.cpp:86:42: error: left operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~
../src/libcamera/bound_method.cpp:86:48: error: right operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~~~~
../src/libcamera/bound_method.cpp:86:57: error: right operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~~~~~~~~~
../src/libcamera/bound_method.cpp:95:9: error: ‘make_unique’ is not a member of ‘std’
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^~~~~~~~~~~
../src/libcamera/bound_method.cpp:95:9: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/bound_method.cpp:95:34: error: expected primary-expression before ‘>’ token
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^
../src/libcamera/bound_method.cpp:95:42: error: left operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^~~~
../src/libcamera/bound_method.cpp:95:49: error: right operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^~~~~~~~~
../src/libcamera/bound_method.cpp:95:48: error: right operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^~~~~~~~~~
cc1plus: all warnings being treated as errors
[2/133] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/byte_stream_buffer.cpp.o'.
[3/133] Generating version.cpp with a custom command.
[4/133] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o' -c ../src/libcamera/device_enumerator.cpp
../src/libcamera/device_enumerator.cpp: In static member function ‘static std::unique_ptr<libcamera::DeviceEnumerator> libcamera::DeviceEnumerator::create()’:
../src/libcamera/device_enumerator.cpp:147:20: error: ‘make_unique’ is not a member of ‘std’
enumerator = std::make_unique<DeviceEnumeratorUdev>();
^~~~~~~~~~~
../src/libcamera/device_enumerator.cpp:147:20: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/device_enumerator.cpp:16:1:
+#include <memory>
../src/libcamera/device_enumerator.cpp:147:20:
enumerator = std::make_unique<DeviceEnumeratorUdev>();
^~~~~~~~~~~
../src/libcamera/device_enumerator.cpp:147:52: error: expected primary-expression before ‘>’ token
enumerator = std::make_unique<DeviceEnumeratorUdev>();
^
../src/libcamera/device_enumerator.cpp:147:54: error: expected primary-expression before ‘)’ token
enumerator = std::make_unique<DeviceEnumeratorUdev>();
^
../src/libcamera/device_enumerator.cpp:156:20: error: ‘make_unique’ is not a member of ‘std’
enumerator = std::make_unique<DeviceEnumeratorSysfs>();
^~~~~~~~~~~
../src/libcamera/device_enumerator.cpp:156:20: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/device_enumerator.cpp:156:53: error: expected primary-expression before ‘>’ token
enumerator = std::make_unique<DeviceEnumeratorSysfs>();
^
../src/libcamera/device_enumerator.cpp:156:55: error: expected primary-expression before ‘)’ token
enumerator = std::make_unique<DeviceEnumeratorSysfs>();
^
[5/133] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o' -c ../src/libcamera/control_serializer.cpp
../src/libcamera/control_serializer.cpp: In member function ‘T libcamera::ControlSerializer::deserialize(libcamera::ByteStreamBuffer&) [with T = libcamera::ControlInfoMap]’:
../src/libcamera/control_serializer.cpp:417:33: error: ‘make_unique’ is not a member of ‘std’
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
^~~~~~~~~~~
../src/libcamera/control_serializer.cpp:417:33: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/control_serializer.cpp:20:1:
+#include <memory>
../src/libcamera/control_serializer.cpp:417:33:
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
^~~~~~~~~~~
../src/libcamera/control_serializer.cpp:417:54: error: expected primary-expression before ‘>’ token
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
^
../src/libcamera/control_serializer.cpp:417:62: error: left operand of comma operator has no effect [-Werror=unused-value]
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
~~~~~~^~
../src/libcamera/control_serializer.cpp:417:70: error: right operand of comma operator has no effect [-Werror=unused-value]
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
^~~~
cc1plus: all warnings being treated as errors
[6/133] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/device_enumerator_sysfs.cpp.o'.
[7/133] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/camera_sensor.cpp.o'.
[8/133] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/controls.cpp.o'.
[9/133] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/camera.cpp.o'.
[10/133] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/camera_manager.cpp.o'.
ninja: build stopped: subcommand failed.
Build step 'Execute shell' marked build as failure
^ permalink raw reply [flat|nested] 18+ messages in thread
* Build failed in Jenkins: libcamera #74
2020-01-16 17:48 ` Build failed in Jenkins: libcamera #73 Jenkins Builder Robot
@ 2020-01-16 23:33 ` Jenkins Builder Robot
2020-01-16 23:48 ` Build failed in Jenkins: libcamera #75 Jenkins Builder Robot
0 siblings, 1 reply; 18+ messages in thread
From: Jenkins Builder Robot @ 2020-01-16 23:33 UTC (permalink / raw)
To: mchehab, linux-media
See <https://builder.linuxtv.org/job/libcamera/74/display/redirect?page=changes>
Changes:
[laurent.pinchart] meson: Bump required version to 0.47
------------------------------------------
Started by an SCM change
Running as SYSTEM
Building remotely on slave1 in workspace <https://builder.linuxtv.org/job/libcamera/ws/>
No credentials specified
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url git://linuxtv.org/libcamera.git # timeout=10
Fetching upstream changes from git://linuxtv.org/libcamera.git
> git --version # timeout=10
> git fetch --tags --force --progress -- git://linuxtv.org/libcamera.git +refs/heads/*:refs/remotes/origin/* # timeout=10
> git rev-parse refs/remotes/origin/master^{commit} # timeout=10
> git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 2de78434ca710bb71590d71cf9d9c2e0aa4b22ba (refs/remotes/origin/master)
> git config core.sparsecheckout # timeout=10
> git checkout -f 2de78434ca710bb71590d71cf9d9c2e0aa4b22ba # timeout=10
Commit message: "meson: Bump required version to 0.47"
> git rev-list --no-walk 38dd90307ab2b0d25a0a233eae04455f769153b4 # timeout=10
[libcamera] $ /bin/sh -xe /tmp/jenkins12517306139968746637.sh
+ meson build -Dandroid=true
Directory already configured.
Just run your build command (e.g. ninja) and Meson will regenerate as necessary.
If ninja fails, run "ninja reconfigure" or "meson --reconfigure"
to force Meson to regenerate.
If build failures persist, run "meson setup --wipe" to rebuild from scratch
using the same options as passed when configuring the build.
To change option values, run "meson configure" instead.
+ cd build
+ ninja
[0/1] Regenerating build files.
The Meson build system
Version: 0.49.2
Source dir: <https://builder.linuxtv.org/job/libcamera/ws/>
Build dir: <https://builder.linuxtv.org/job/libcamera/ws/build>
Build type: native build
Project name: libcamera
Project version: 0.0.0
Native C compiler: ccache cc (gcc 8.3.0 "cc (Debian 8.3.0-6) 8.3.0")
Native C++ compiler: ccache c++ (gcc 8.3.0 "c++ (Debian 8.3.0-6) 8.3.0")
Build machine cpu family: x86_64
Build machine cpu: x86_64
Header <execinfo.h> has symbol "backtrace" : YES
Header <stdlib.h> has symbol "secure_getenv" : YES
Configuring version.h using configuration
Dependency libudev found: YES (cached)
Library atomic found: YES
Library dl found: YES
Dependency threads found: YES (cached)
WARNING: rcc dependencies will not work reliably until this upstream issue is fixed: https://bugreports.qt.io/browse/QTBUG-45460
Dependency qt5 found: YES (cached)
Detecting Qt5 tools
moc: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/moc, 5.11.3)
uic: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/uic, 5.11.3)
rcc: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/rcc, 5.11.3)
lrelease: NO
Program doxygen found: YES (/usr/bin/doxygen)
Configuring Doxyfile using configuration
Program sphinx-build-3 found: NO
Program sphinx-build found: YES (/usr/bin/sphinx-build)
Configuring config.h using configuration
Build targets in project: 68
Option werror is: True [default: true]
Option cpp_std is: c++11 [default: c++14]
Found ninja-1.8.2 at /usr/bin/ninja
[1/127] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/ipc_unixsocket.cpp.o'.
[2/127] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o' -c ../src/libcamera/proxy/ipa_proxy_linux.cpp
In file included from ../src/libcamera/proxy/ipa_proxy_linux.cpp:14:
../src/libcamera/proxy/ipa_proxy_linux.cpp: In member function ‘virtual std::unique_ptr<libcamera::IPAProxy> libcamera::IPAProxyLinuxFactory::create(libcamera::IPAModule*)’:
../src/libcamera/include/ipa_proxy.h:58:15: error: ‘make_unique’ is not a member of ‘std’
return std::make_unique<proxy>(ipam); \
^~~~~~~~~~~
../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
REGISTER_IPA_PROXY(IPAProxyLinux)
^~~~~~~~~~~~~~~~~~
../src/libcamera/include/ipa_proxy.h:58:15: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
return std::make_unique<proxy>(ipam); \
^~~~~~~~~~~
../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
REGISTER_IPA_PROXY(IPAProxyLinux)
^~~~~~~~~~~~~~~~~~
../src/libcamera/include/ipa_proxy.h:58:32: error: expected primary-expression before ‘>’ token
return std::make_unique<proxy>(ipam); \
^
../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
REGISTER_IPA_PROXY(IPAProxyLinux)
^~~~~~~~~~~~~~~~~~
[3/127] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/log.cpp.o'.
[4/127] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/.._android_camera_hal_manager.cpp.o'.
[5/127] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o' -c ../src/libcamera/pipeline/vimc.cpp
../src/libcamera/pipeline/vimc.cpp: In member function ‘virtual bool libcamera::PipelineHandlerVimc::match(libcamera::DeviceEnumerator*)’:
../src/libcamera/pipeline/vimc.cpp:368:46: error: ‘make_unique’ is not a member of ‘std’
std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
^~~~~~~~~~~
../src/libcamera/pipeline/vimc.cpp:368:46: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/pipeline/vimc.cpp:34:1:
+#include <memory>
../src/libcamera/pipeline/vimc.cpp:368:46:
std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
^~~~~~~~~~~
../src/libcamera/pipeline/vimc.cpp:368:72: error: expected primary-expression before ‘>’ token
std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
^
[6/127] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/thread.cpp.o'.
[7/127] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/ipa_context_wrapper.cpp.o'.
[8/127] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/stream.cpp.o'.
[9/127] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o' -c ../src/libcamera/pipeline/ipu3/ipu3.cpp
../src/libcamera/pipeline/ipu3/ipu3.cpp: In member function ‘int libcamera::PipelineHandlerIPU3::registerCameras()’:
../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9: error: ‘make_unique’ is not a member of ‘std’
std::make_unique<IPU3CameraData>(this);
^~~~~~~~~~~
../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/pipeline/ipu3/ipu3.cpp:29:1:
+#include <memory>
../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9:
std::make_unique<IPU3CameraData>(this);
^~~~~~~~~~~
../src/libcamera/pipeline/ipu3/ipu3.cpp:879:35: error: expected primary-expression before ‘>’ token
std::make_unique<IPU3CameraData>(this);
^
[10/127] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o' -c ../src/libcamera/pipeline/rkisp1/rkisp1.cpp
../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘void libcamera::RkISP1CameraData::queueFrameAction(unsigned int, const libcamera::IPAOperationData&)’:
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33: error: ‘make_unique’ is not a member of ‘std’
timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
^~~~~~~~~~~
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:34:1:
+#include <memory>
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33:
timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
^~~~~~~~~~~
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:66: error: expected primary-expression before ‘>’ token
timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
^
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:392:12: error: left operand of comma operator has no effect [-Werror=unused-value]
sensor_,
^~~~~~~
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:392:12: error: right operand of comma operator has no effect [-Werror=unused-value]
../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘virtual int libcamera::PipelineHandlerRkISP1::queueRequestDevice(libcamera::Camera*, libcamera::Request*)’:
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:38: error: ‘make_unique’ is not a member of ‘std’
data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
^~~~~~~~~~~
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:38: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:74: error: expected primary-expression before ‘>’ token
data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
^
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:82: error: left operand of comma operator has no effect [-Werror=unused-value]
data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
~~~~~~^~~~~~
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:851:13: error: right operand of comma operator has no effect [-Werror=unused-value]
this));
^~~~
../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘int libcamera::PipelineHandlerRkISP1::createCamera(libcamera::MediaEntity*)’:
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:8: error: ‘make_unique’ is not a member of ‘std’
std::make_unique<RkISP1CameraData>(this);
^~~~~~~~~~~
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:8: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:36: error: expected primary-expression before ‘>’ token
std::make_unique<RkISP1CameraData>(this);
^
cc1plus: all warnings being treated as errors
[11/127] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/timer.cpp.o'.
ninja: build stopped: subcommand failed.
Build step 'Execute shell' marked build as failure
^ permalink raw reply [flat|nested] 18+ messages in thread
* Build failed in Jenkins: libcamera #75
2020-01-16 23:33 ` Build failed in Jenkins: libcamera #74 Jenkins Builder Robot
@ 2020-01-16 23:48 ` Jenkins Builder Robot
2020-01-18 20:48 ` Build failed in Jenkins: libcamera #76 Jenkins Builder Robot
0 siblings, 1 reply; 18+ messages in thread
From: Jenkins Builder Robot @ 2020-01-16 23:48 UTC (permalink / raw)
To: mchehab, linux-media
See <https://builder.linuxtv.org/job/libcamera/75/display/redirect?page=changes>
Changes:
[laurent.pinchart] README: Remove duplicated line
------------------------------------------
Started by an SCM change
Running as SYSTEM
Building remotely on slave1 in workspace <https://builder.linuxtv.org/job/libcamera/ws/>
No credentials specified
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url git://linuxtv.org/libcamera.git # timeout=10
Fetching upstream changes from git://linuxtv.org/libcamera.git
> git --version # timeout=10
> git fetch --tags --force --progress -- git://linuxtv.org/libcamera.git +refs/heads/*:refs/remotes/origin/* # timeout=10
> git rev-parse refs/remotes/origin/master^{commit} # timeout=10
> git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 30f9624f894ae50044dd367c6560198940d9b702 (refs/remotes/origin/master)
> git config core.sparsecheckout # timeout=10
> git checkout -f 30f9624f894ae50044dd367c6560198940d9b702 # timeout=10
Commit message: "README: Remove duplicated line"
> git rev-list --no-walk 2de78434ca710bb71590d71cf9d9c2e0aa4b22ba # timeout=10
[libcamera] $ /bin/sh -xe /tmp/jenkins5343542985076092399.sh
+ meson build -Dandroid=true
Directory already configured.
Just run your build command (e.g. ninja) and Meson will regenerate as necessary.
If ninja fails, run "ninja reconfigure" or "meson --reconfigure"
to force Meson to regenerate.
If build failures persist, run "meson setup --wipe" to rebuild from scratch
using the same options as passed when configuring the build.
To change option values, run "meson configure" instead.
+ cd build
+ ninja
[1/120] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o' -c ../src/libcamera/bound_method.cpp
../src/libcamera/bound_method.cpp: In member function ‘bool libcamera::BoundMethodBase::activatePack(std::shared_ptr<libcamera::BoundMethodPackBase>, bool)’:
../src/libcamera/bound_method.cpp:86:9: error: ‘make_unique’ is not a member of ‘std’
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~~~~~~~~
../src/libcamera/bound_method.cpp:86:9: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/bound_method.cpp:13:1:
+#include <memory>
../src/libcamera/bound_method.cpp:86:9:
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~~~~~~~~
../src/libcamera/bound_method.cpp:86:34: error: expected primary-expression before ‘>’ token
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^
../src/libcamera/bound_method.cpp:86:42: error: left operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~
../src/libcamera/bound_method.cpp:86:48: error: right operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~~~~
../src/libcamera/bound_method.cpp:86:57: error: right operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~~~~~~~~~
../src/libcamera/bound_method.cpp:95:9: error: ‘make_unique’ is not a member of ‘std’
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^~~~~~~~~~~
../src/libcamera/bound_method.cpp:95:9: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/bound_method.cpp:95:34: error: expected primary-expression before ‘>’ token
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^
../src/libcamera/bound_method.cpp:95:42: error: left operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^~~~
../src/libcamera/bound_method.cpp:95:49: error: right operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^~~~~~~~~
../src/libcamera/bound_method.cpp:95:48: error: right operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^~~~~~~~~~
cc1plus: all warnings being treated as errors
[2/120] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/event_dispatcher.cpp.o'.
[3/120] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/file_descriptor.cpp.o'.
[4/120] Generating version.cpp with a custom command.
[5/120] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o' -c ../src/libcamera/control_serializer.cpp
../src/libcamera/control_serializer.cpp: In member function ‘T libcamera::ControlSerializer::deserialize(libcamera::ByteStreamBuffer&) [with T = libcamera::ControlInfoMap]’:
../src/libcamera/control_serializer.cpp:417:33: error: ‘make_unique’ is not a member of ‘std’
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
^~~~~~~~~~~
../src/libcamera/control_serializer.cpp:417:33: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/control_serializer.cpp:20:1:
+#include <memory>
../src/libcamera/control_serializer.cpp:417:33:
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
^~~~~~~~~~~
../src/libcamera/control_serializer.cpp:417:54: error: expected primary-expression before ‘>’ token
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
^
../src/libcamera/control_serializer.cpp:417:62: error: left operand of comma operator has no effect [-Werror=unused-value]
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
~~~~~~^~
../src/libcamera/control_serializer.cpp:417:70: error: right operand of comma operator has no effect [-Werror=unused-value]
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
^~~~
cc1plus: all warnings being treated as errors
[6/120] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o' -c ../src/libcamera/device_enumerator.cpp
../src/libcamera/device_enumerator.cpp: In static member function ‘static std::unique_ptr<libcamera::DeviceEnumerator> libcamera::DeviceEnumerator::create()’:
../src/libcamera/device_enumerator.cpp:147:20: error: ‘make_unique’ is not a member of ‘std’
enumerator = std::make_unique<DeviceEnumeratorUdev>();
^~~~~~~~~~~
../src/libcamera/device_enumerator.cpp:147:20: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/device_enumerator.cpp:16:1:
+#include <memory>
../src/libcamera/device_enumerator.cpp:147:20:
enumerator = std::make_unique<DeviceEnumeratorUdev>();
^~~~~~~~~~~
../src/libcamera/device_enumerator.cpp:147:52: error: expected primary-expression before ‘>’ token
enumerator = std::make_unique<DeviceEnumeratorUdev>();
^
../src/libcamera/device_enumerator.cpp:147:54: error: expected primary-expression before ‘)’ token
enumerator = std::make_unique<DeviceEnumeratorUdev>();
^
../src/libcamera/device_enumerator.cpp:156:20: error: ‘make_unique’ is not a member of ‘std’
enumerator = std::make_unique<DeviceEnumeratorSysfs>();
^~~~~~~~~~~
../src/libcamera/device_enumerator.cpp:156:20: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/device_enumerator.cpp:156:53: error: expected primary-expression before ‘>’ token
enumerator = std::make_unique<DeviceEnumeratorSysfs>();
^
../src/libcamera/device_enumerator.cpp:156:55: error: expected primary-expression before ‘)’ token
enumerator = std::make_unique<DeviceEnumeratorSysfs>();
^
[7/120] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/ipa_manager.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/ipa_manager.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/ipa_manager.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/ipa_manager.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/ipa_manager.cpp.o' -c ../src/libcamera/ipa_manager.cpp
../src/libcamera/ipa_manager.cpp: In member function ‘std::unique_ptr<libcamera::IPAInterface> libcamera::IPAManager::createIPA(libcamera::PipelineHandler*, uint32_t, uint32_t)’:
../src/libcamera/ipa_manager.cpp:267:14: error: ‘make_unique’ is not a member of ‘std’
return std::make_unique<IPAContextWrapper>(ctx);
^~~~~~~~~~~
../src/libcamera/ipa_manager.cpp:267:14: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/ipa_manager.cpp:21:1:
+#include <memory>
../src/libcamera/ipa_manager.cpp:267:14:
return std::make_unique<IPAContextWrapper>(ctx);
^~~~~~~~~~~
../src/libcamera/ipa_manager.cpp:267:43: error: expected primary-expression before ‘>’ token
return std::make_unique<IPAContextWrapper>(ctx);
^
[8/120] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/event_dispatcher_poll.cpp.o'.
[9/120] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/ipa_module.cpp.o'.
[10/120] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/ipa_proxy.cpp.o'.
ninja: build stopped: subcommand failed.
Build step 'Execute shell' marked build as failure
^ permalink raw reply [flat|nested] 18+ messages in thread
* Build failed in Jenkins: libcamera #76
2020-01-16 23:48 ` Build failed in Jenkins: libcamera #75 Jenkins Builder Robot
@ 2020-01-18 20:48 ` Jenkins Builder Robot
2020-01-20 17:03 ` Build failed in Jenkins: libcamera #77 Jenkins Builder Robot
0 siblings, 1 reply; 18+ messages in thread
From: Jenkins Builder Robot @ 2020-01-18 20:48 UTC (permalink / raw)
To: mchehab, linux-media
See <https://builder.linuxtv.org/job/libcamera/76/display/redirect?page=changes>
Changes:
[laurent.pinchart] checkstyle: Move from pep8 to pycodestyle
[laurent.pinchart] checkstyle: Exit with 1 status if issues are found
[laurent.pinchart] checkstyle: Introduce a Commit class
[laurent.pinchart] checkstyle: Add support for checking style on staged changes
[laurent.pinchart] checkstyle: Add support for checking style on amendments
[laurent.pinchart] checkstyle: Add a pre-commit hook script
------------------------------------------
Started by an SCM change
Running as SYSTEM
Building remotely on slave1 in workspace <https://builder.linuxtv.org/job/libcamera/ws/>
No credentials specified
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url git://linuxtv.org/libcamera.git # timeout=10
Fetching upstream changes from git://linuxtv.org/libcamera.git
> git --version # timeout=10
> git fetch --tags --force --progress -- git://linuxtv.org/libcamera.git +refs/heads/*:refs/remotes/origin/* # timeout=10
> git rev-parse refs/remotes/origin/master^{commit} # timeout=10
> git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 3628fb704b49101000ea901bfa5132a3e8a781cd (refs/remotes/origin/master)
> git config core.sparsecheckout # timeout=10
> git checkout -f 3628fb704b49101000ea901bfa5132a3e8a781cd # timeout=10
Commit message: "checkstyle: Add a pre-commit hook script"
> git rev-list --no-walk 30f9624f894ae50044dd367c6560198940d9b702 # timeout=10
[libcamera] $ /bin/sh -xe /tmp/jenkins9160886239119585653.sh
+ meson build -Dandroid=true
Directory already configured.
Just run your build command (e.g. ninja) and Meson will regenerate as necessary.
If ninja fails, run "ninja reconfigure" or "meson --reconfigure"
to force Meson to regenerate.
If build failures persist, run "meson setup --wipe" to rebuild from scratch
using the same options as passed when configuring the build.
To change option values, run "meson configure" instead.
+ cd build
+ ninja
[1/115] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o' -c ../src/libcamera/bound_method.cpp
../src/libcamera/bound_method.cpp: In member function ‘bool libcamera::BoundMethodBase::activatePack(std::shared_ptr<libcamera::BoundMethodPackBase>, bool)’:
../src/libcamera/bound_method.cpp:86:9: error: ‘make_unique’ is not a member of ‘std’
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~~~~~~~~
../src/libcamera/bound_method.cpp:86:9: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/bound_method.cpp:13:1:
+#include <memory>
../src/libcamera/bound_method.cpp:86:9:
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~~~~~~~~
../src/libcamera/bound_method.cpp:86:34: error: expected primary-expression before ‘>’ token
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^
../src/libcamera/bound_method.cpp:86:42: error: left operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~
../src/libcamera/bound_method.cpp:86:48: error: right operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~~~~
../src/libcamera/bound_method.cpp:86:57: error: right operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~~~~~~~~~
../src/libcamera/bound_method.cpp:95:9: error: ‘make_unique’ is not a member of ‘std’
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^~~~~~~~~~~
../src/libcamera/bound_method.cpp:95:9: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/bound_method.cpp:95:34: error: expected primary-expression before ‘>’ token
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^
../src/libcamera/bound_method.cpp:95:42: error: left operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^~~~
../src/libcamera/bound_method.cpp:95:49: error: right operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^~~~~~~~~
../src/libcamera/bound_method.cpp:95:48: error: right operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^~~~~~~~~~
cc1plus: all warnings being treated as errors
[2/115] Generating version.cpp with a custom command.
[3/115] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/utils.cpp.o'.
[4/115] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o' -c ../src/libcamera/device_enumerator.cpp
../src/libcamera/device_enumerator.cpp: In static member function ‘static std::unique_ptr<libcamera::DeviceEnumerator> libcamera::DeviceEnumerator::create()’:
../src/libcamera/device_enumerator.cpp:147:20: error: ‘make_unique’ is not a member of ‘std’
enumerator = std::make_unique<DeviceEnumeratorUdev>();
^~~~~~~~~~~
../src/libcamera/device_enumerator.cpp:147:20: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/device_enumerator.cpp:16:1:
+#include <memory>
../src/libcamera/device_enumerator.cpp:147:20:
enumerator = std::make_unique<DeviceEnumeratorUdev>();
^~~~~~~~~~~
../src/libcamera/device_enumerator.cpp:147:52: error: expected primary-expression before ‘>’ token
enumerator = std::make_unique<DeviceEnumeratorUdev>();
^
../src/libcamera/device_enumerator.cpp:147:54: error: expected primary-expression before ‘)’ token
enumerator = std::make_unique<DeviceEnumeratorUdev>();
^
../src/libcamera/device_enumerator.cpp:156:20: error: ‘make_unique’ is not a member of ‘std’
enumerator = std::make_unique<DeviceEnumeratorSysfs>();
^~~~~~~~~~~
../src/libcamera/device_enumerator.cpp:156:20: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/device_enumerator.cpp:156:53: error: expected primary-expression before ‘>’ token
enumerator = std::make_unique<DeviceEnumeratorSysfs>();
^
../src/libcamera/device_enumerator.cpp:156:55: error: expected primary-expression before ‘)’ token
enumerator = std::make_unique<DeviceEnumeratorSysfs>();
^
[5/115] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/v4l2_device.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/v4l2_device.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/v4l2_device.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/v4l2_device.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/v4l2_device.cpp.o' -c ../src/libcamera/v4l2_device.cpp
../src/libcamera/v4l2_device.cpp: In member function ‘void libcamera::V4L2Device::listControls()’:
../src/libcamera/v4l2_device.cpp:383:33: error: ‘make_unique’ is not a member of ‘std’
controlIds_.emplace_back(std::make_unique<V4L2ControlId>(ctrl));
^~~~~~~~~~~
../src/libcamera/v4l2_device.cpp:383:33: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/v4l2_device.cpp:20:1:
+#include <memory>
../src/libcamera/v4l2_device.cpp:383:33:
controlIds_.emplace_back(std::make_unique<V4L2ControlId>(ctrl));
^~~~~~~~~~~
../src/libcamera/v4l2_device.cpp:383:58: error: expected primary-expression before ‘>’ token
controlIds_.emplace_back(std::make_unique<V4L2ControlId>(ctrl));
^
[6/115] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/ipa_manager.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/ipa_manager.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/ipa_manager.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/ipa_manager.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/ipa_manager.cpp.o' -c ../src/libcamera/ipa_manager.cpp
../src/libcamera/ipa_manager.cpp: In member function ‘std::unique_ptr<libcamera::IPAInterface> libcamera::IPAManager::createIPA(libcamera::PipelineHandler*, uint32_t, uint32_t)’:
../src/libcamera/ipa_manager.cpp:267:14: error: ‘make_unique’ is not a member of ‘std’
return std::make_unique<IPAContextWrapper>(ctx);
^~~~~~~~~~~
../src/libcamera/ipa_manager.cpp:267:14: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/ipa_manager.cpp:21:1:
+#include <memory>
../src/libcamera/ipa_manager.cpp:267:14:
return std::make_unique<IPAContextWrapper>(ctx);
^~~~~~~~~~~
../src/libcamera/ipa_manager.cpp:267:43: error: expected primary-expression before ‘>’ token
return std::make_unique<IPAContextWrapper>(ctx);
^
[7/115] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/media_device.cpp.o'.
[8/115] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o' -c ../src/libcamera/control_serializer.cpp
../src/libcamera/control_serializer.cpp: In member function ‘T libcamera::ControlSerializer::deserialize(libcamera::ByteStreamBuffer&) [with T = libcamera::ControlInfoMap]’:
../src/libcamera/control_serializer.cpp:417:33: error: ‘make_unique’ is not a member of ‘std’
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
^~~~~~~~~~~
../src/libcamera/control_serializer.cpp:417:33: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/control_serializer.cpp:20:1:
+#include <memory>
../src/libcamera/control_serializer.cpp:417:33:
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
^~~~~~~~~~~
../src/libcamera/control_serializer.cpp:417:54: error: expected primary-expression before ‘>’ token
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
^
../src/libcamera/control_serializer.cpp:417:62: error: left operand of comma operator has no effect [-Werror=unused-value]
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
~~~~~~^~
../src/libcamera/control_serializer.cpp:417:70: error: right operand of comma operator has no effect [-Werror=unused-value]
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
^~~~
cc1plus: all warnings being treated as errors
[9/115] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/v4l2_videodevice.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/v4l2_videodevice.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/v4l2_videodevice.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/v4l2_videodevice.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/v4l2_videodevice.cpp.o' -c ../src/libcamera/v4l2_videodevice.cpp
../src/libcamera/v4l2_videodevice.cpp: In member function ‘std::unique_ptr<libcamera::FrameBuffer> libcamera::V4L2VideoDevice::createBuffer(const v4l2_buffer&)’:
../src/libcamera/v4l2_videodevice.cpp:1057:14: error: ‘make_unique’ is not a member of ‘std’
return std::make_unique<FrameBuffer>(std::move(planes));
^~~~~~~~~~~
../src/libcamera/v4l2_videodevice.cpp:1057:14: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/v4l2_videodevice.cpp:30:1:
+#include <memory>
../src/libcamera/v4l2_videodevice.cpp:1057:14:
return std::make_unique<FrameBuffer>(std::move(planes));
^~~~~~~~~~~
../src/libcamera/v4l2_videodevice.cpp:1057:37: error: expected primary-expression before ‘>’ token
return std::make_unique<FrameBuffer>(std::move(planes));
^
[10/115] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/v4l2_subdevice.cpp.o'.
ninja: build stopped: subcommand failed.
Build step 'Execute shell' marked build as failure
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: Build failed in Jenkins: libcamera #72
2020-01-15 0:03 Build failed in Jenkins: libcamera #72 Jenkins Builder Robot
2020-01-16 17:48 ` Build failed in Jenkins: libcamera #73 Jenkins Builder Robot
@ 2020-01-19 21:16 ` Kieran Bingham
2020-01-21 13:12 ` Mauro Carvalho Chehab
2020-01-21 13:14 ` Mauro Carvalho Chehab
1 sibling, 2 replies; 18+ messages in thread
From: Kieran Bingham @ 2020-01-19 21:16 UTC (permalink / raw)
To: Jenkins Builder Robot, mchehab, linux-media, LibCamera Devel
Hi Mauro,
It looks like the Jenkins jobs for Libcamera are failing continuously.
I believe it looks like the jobs reuse an existing build configuration,
and that doesn't get reconfigured if we change the top level meson.build
or such.
In particular, here we have changed to C++14, and the build should
certainly be done from clean, as compiler flags should be updated.
As a side note, is it possible (or desirable?) to cc
<libcamera-devel@lists.libcamera.org> on these failures to make sure we
see them?
Thanks
--
Kieran
On 15/01/2020 00:03, Jenkins Builder Robot wrote:
> See <https://builder.linuxtv.org/job/libcamera/72/display/redirect?page=changes>
>
> Changes:
>
> [laurent.pinchart] meson.build: Switch to C++14
>
> [laurent.pinchart] libcamera: Switch from utils::make_unique to std::make_unique
>
>
> ------------------------------------------
> Started by an SCM change
> Running as SYSTEM
> Building remotely on slave1 in workspace <https://builder.linuxtv.org/job/libcamera/ws/>
> No credentials specified
> > git rev-parse --is-inside-work-tree # timeout=10
> Fetching changes from the remote Git repository
> > git config remote.origin.url git://linuxtv.org/libcamera.git # timeout=10
> Fetching upstream changes from git://linuxtv.org/libcamera.git
> > git --version # timeout=10
> > git fetch --tags --force --progress -- git://linuxtv.org/libcamera.git +refs/heads/*:refs/remotes/origin/* # timeout=10
> > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
> > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
> Checking out Revision acf18e4265dec2991e62f7c8baecfacf1a6708b3 (refs/remotes/origin/master)
> > git config core.sparsecheckout # timeout=10
> > git checkout -f acf18e4265dec2991e62f7c8baecfacf1a6708b3 # timeout=10
> Commit message: "libcamera: Switch from utils::make_unique to std::make_unique"
> > git rev-list --no-walk 055335bf49dbcb8c149bdcd4e96004c68e6b6ece # timeout=10
> [libcamera] $ /bin/sh -xe /tmp/jenkins2777310540601637282.sh
> + meson build -Dandroid=true
> Directory already configured.
^^ This implies the previous build is being re-used.
Perhaps for a CI job, would it make more sense to do from-scratch clean
configure and rebuilds?
It would be nice if meson always knew when to reconfigure, but I'm not
sure how to make sure that always happens :-D
>
> Just run your build command (e.g. ninja) and Meson will regenerate as necessary.
> If ninja fails, run "ninja reconfigure" or "meson --reconfigure"
> to force Meson to regenerate.
>
> If build failures persist, run "meson setup --wipe" to rebuild from scratch
> using the same options as passed when configuring the build.
> To change option values, run "meson configure" instead.
> + cd build
> + ninja
> [0/1] Regenerating build files.
> The Meson build system
> Version: 0.49.2
> Source dir: <https://builder.linuxtv.org/job/libcamera/ws/>
> Build dir: <https://builder.linuxtv.org/job/libcamera/ws/build>
> Build type: native build
> Project name: libcamera
> Project version: 0.0.0
> Native C compiler: ccache cc (gcc 8.3.0 "cc (Debian 8.3.0-6) 8.3.0")
> Native C++ compiler: ccache c++ (gcc 8.3.0 "c++ (Debian 8.3.0-6) 8.3.0")
> Build machine cpu family: x86_64
> Build machine cpu: x86_64
> Header <execinfo.h> has symbol "backtrace" : YES
> Header <stdlib.h> has symbol "secure_getenv" : YES
> Configuring version.h using configuration
> Dependency libudev found: YES (cached)
> Library atomic found: YES
> Library dl found: YES
> Dependency threads found: YES (cached)
> WARNING: rcc dependencies will not work reliably until this upstream issue is fixed: https://bugreports.qt.io/browse/QTBUG-45460
> Dependency qt5 found: YES (cached)
> Detecting Qt5 tools
> moc: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/moc, 5.11.3)
> uic: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/uic, 5.11.3)
> rcc: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/rcc, 5.11.3)
> lrelease: NO
> Program doxygen found: YES (/usr/bin/doxygen)
> Configuring Doxyfile using configuration
> Program sphinx-build-3 found: NO
> Program sphinx-build found: YES (/usr/bin/sphinx-build)
> Configuring config.h using configuration
> Build targets in project: 68
> Option werror is: True [default: true]
> Option cpp_std is: c++11 [default: c++14]
> Found ninja-1.8.2 at /usr/bin/ninja
> [1/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/buffer.cpp.o'.
> [2/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/message.cpp.o'.
> [3/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/object.cpp.o'.
> [4/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/media_object.cpp.o'.
> [5/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/process.cpp.o'.
> [6/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o'.
> FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o
> ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o' -c ../src/libcamera/pipeline/vimc.cpp
> ../src/libcamera/pipeline/vimc.cpp: In member function ‘virtual bool libcamera::PipelineHandlerVimc::match(libcamera::DeviceEnumerator*)’:
> ../src/libcamera/pipeline/vimc.cpp:368:46: error: ‘make_unique’ is not a member of ‘std’
> std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
> ^~~~~~~~~~~
> ../src/libcamera/pipeline/vimc.cpp:368:46: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> ../src/libcamera/pipeline/vimc.cpp:34:1:
> +#include <memory>
>
> ../src/libcamera/pipeline/vimc.cpp:368:46:
> std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
> ^~~~~~~~~~~
> ../src/libcamera/pipeline/vimc.cpp:368:72: error: expected primary-expression before ‘>’ token
> std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
> ^
> [7/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/framebuffer_allocator.cpp.o'.
> [8/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o'.
> FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o
> ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o' -c ../src/libcamera/pipeline/ipu3/ipu3.cpp
> ../src/libcamera/pipeline/ipu3/ipu3.cpp: In member function ‘int libcamera::PipelineHandlerIPU3::registerCameras()’:
> ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9: error: ‘make_unique’ is not a member of ‘std’
> std::make_unique<IPU3CameraData>(this);
> ^~~~~~~~~~~
> ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> ../src/libcamera/pipeline/ipu3/ipu3.cpp:29:1:
> +#include <memory>
>
> ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9:
> std::make_unique<IPU3CameraData>(this);
> ^~~~~~~~~~~
> ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:35: error: expected primary-expression before ‘>’ token
> std::make_unique<IPU3CameraData>(this);
> ^
> [9/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/request.cpp.o'.
> [10/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_timeline.cpp.o'.
> [11/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_handler.cpp.o'.
> [12/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o'.
> FAILED: src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o
> ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o' -c ../src/libcamera/proxy/ipa_proxy_linux.cpp
> In file included from ../src/libcamera/proxy/ipa_proxy_linux.cpp:14:
> ../src/libcamera/proxy/ipa_proxy_linux.cpp: In member function ‘virtual std::unique_ptr<libcamera::IPAProxy> libcamera::IPAProxyLinuxFactory::create(libcamera::IPAModule*)’:
> ../src/libcamera/include/ipa_proxy.h:58:15: error: ‘make_unique’ is not a member of ‘std’
> return std::make_unique<proxy>(ipam); \
> ^~~~~~~~~~~
> ../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
> REGISTER_IPA_PROXY(IPAProxyLinux)
> ^~~~~~~~~~~~~~~~~~
> ../src/libcamera/include/ipa_proxy.h:58:15: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> return std::make_unique<proxy>(ipam); \
> ^~~~~~~~~~~
> ../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
> REGISTER_IPA_PROXY(IPAProxyLinux)
> ^~~~~~~~~~~~~~~~~~
> ../src/libcamera/include/ipa_proxy.h:58:32: error: expected primary-expression before ‘>’ token
> return std::make_unique<proxy>(ipam); \
> ^
> ../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
> REGISTER_IPA_PROXY(IPAProxyLinux)
> ^~~~~~~~~~~~~~~~~~
> [13/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/.._android_camera3_hal.cpp.o'.
> [14/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/device_enumerator_udev.cpp.o'.
> [15/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o'.
> FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o
> ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o' -c ../src/libcamera/pipeline/rkisp1/rkisp1.cpp
> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘void libcamera::RkISP1CameraData::queueFrameAction(unsigned int, const libcamera::IPAOperationData&)’:
> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33: error: ‘make_unique’ is not a member of ‘std’
> timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
> ^~~~~~~~~~~
> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:34:1:
> +#include <memory>
>
> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33:
> timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
> ^~~~~~~~~~~
> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:66: error: expected primary-expression before ‘>’ token
> timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
> ^
> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:392:12: error: left operand of comma operator has no effect [-Werror=unused-value]
> sensor_,
> ^~~~~~~
> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:392:12: error: right operand of comma operator has no effect [-Werror=unused-value]
> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘virtual int libcamera::PipelineHandlerRkISP1::queueRequestDevice(libcamera::Camera*, libcamera::Request*)’:
> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:38: error: ‘make_unique’ is not a member of ‘std’
> data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
> ^~~~~~~~~~~
> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:38: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:74: error: expected primary-expression before ‘>’ token
> data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
> ^
> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:82: error: left operand of comma operator has no effect [-Werror=unused-value]
> data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
> ~~~~~~^~~~~~
> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:851:13: error: right operand of comma operator has no effect [-Werror=unused-value]
> this));
> ^~~~
> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘int libcamera::PipelineHandlerRkISP1::createCamera(libcamera::MediaEntity*)’:
> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:8: error: ‘make_unique’ is not a member of ‘std’
> std::make_unique<RkISP1CameraData>(this);
> ^~~~~~~~~~~
> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:8: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:36: error: expected primary-expression before ‘>’ token
> std::make_unique<RkISP1CameraData>(this);
> ^
> cc1plus: all warnings being treated as errors
> ninja: build stopped: subcommand failed.
> Build step 'Execute shell' marked build as failure
>
--
Regards
--
Kieran
^ permalink raw reply [flat|nested] 18+ messages in thread
* Build failed in Jenkins: libcamera #77
2020-01-18 20:48 ` Build failed in Jenkins: libcamera #76 Jenkins Builder Robot
@ 2020-01-20 17:03 ` Jenkins Builder Robot
2020-01-21 13:26 ` Build failed in Jenkins: libcamera #78 Jenkins Builder Robot
0 siblings, 1 reply; 18+ messages in thread
From: Jenkins Builder Robot @ 2020-01-20 17:03 UTC (permalink / raw)
To: mchehab, linux-media
See <https://builder.linuxtv.org/job/libcamera/77/display/redirect?page=changes>
Changes:
[laurent.pinchart] v4l2: Extend device caps with V4L2_CAP_STREAMING
[laurent.pinchart] test: buffer_import: Propagate status code from buffer allocation
[laurent.pinchart] libcamera: thread: Add a method to return the ID of the current thread
[laurent.pinchart] libcamera: log: Print the thread ID in the log
[laurent.pinchart] qcam: Support scaling of the viewfinder
------------------------------------------
Started by an SCM change
Running as SYSTEM
Building remotely on slave1 in workspace <https://builder.linuxtv.org/job/libcamera/ws/>
No credentials specified
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url git://linuxtv.org/libcamera.git # timeout=10
Fetching upstream changes from git://linuxtv.org/libcamera.git
> git --version # timeout=10
> git fetch --tags --force --progress -- git://linuxtv.org/libcamera.git +refs/heads/*:refs/remotes/origin/* # timeout=10
> git rev-parse refs/remotes/origin/master^{commit} # timeout=10
> git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 9977fc3fcbfa0a6aaab04118fc67f0b9b9627570 (refs/remotes/origin/master)
> git config core.sparsecheckout # timeout=10
> git checkout -f 9977fc3fcbfa0a6aaab04118fc67f0b9b9627570 # timeout=10
Commit message: "qcam: Support scaling of the viewfinder"
> git rev-list --no-walk 3628fb704b49101000ea901bfa5132a3e8a781cd # timeout=10
[libcamera] $ /bin/sh -xe /tmp/jenkins14450769163462849448.sh
+ meson build -Dandroid=true
Directory already configured.
Just run your build command (e.g. ninja) and Meson will regenerate as necessary.
If ninja fails, run "ninja reconfigure" or "meson --reconfigure"
to force Meson to regenerate.
If build failures persist, run "meson setup --wipe" to rebuild from scratch
using the same options as passed when configuring the build.
To change option values, run "meson configure" instead.
+ cd build
+ ninja
[1/133] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o' -c ../src/libcamera/bound_method.cpp
../src/libcamera/bound_method.cpp: In member function ‘bool libcamera::BoundMethodBase::activatePack(std::shared_ptr<libcamera::BoundMethodPackBase>, bool)’:
../src/libcamera/bound_method.cpp:86:9: error: ‘make_unique’ is not a member of ‘std’
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~~~~~~~~
../src/libcamera/bound_method.cpp:86:9: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/bound_method.cpp:13:1:
+#include <memory>
../src/libcamera/bound_method.cpp:86:9:
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~~~~~~~~
../src/libcamera/bound_method.cpp:86:34: error: expected primary-expression before ‘>’ token
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^
../src/libcamera/bound_method.cpp:86:42: error: left operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~
../src/libcamera/bound_method.cpp:86:48: error: right operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~~~~
../src/libcamera/bound_method.cpp:86:57: error: right operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~~~~~~~~~
../src/libcamera/bound_method.cpp:95:9: error: ‘make_unique’ is not a member of ‘std’
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^~~~~~~~~~~
../src/libcamera/bound_method.cpp:95:9: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/bound_method.cpp:95:34: error: expected primary-expression before ‘>’ token
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^
../src/libcamera/bound_method.cpp:95:42: error: left operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^~~~
../src/libcamera/bound_method.cpp:95:49: error: right operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^~~~~~~~~
../src/libcamera/bound_method.cpp:95:48: error: right operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^~~~~~~~~~
cc1plus: all warnings being treated as errors
[2/133] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/event_notifier.cpp.o'.
[3/133] Generating version.cpp with a custom command.
[4/133] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o' -c ../src/libcamera/device_enumerator.cpp
../src/libcamera/device_enumerator.cpp: In static member function ‘static std::unique_ptr<libcamera::DeviceEnumerator> libcamera::DeviceEnumerator::create()’:
../src/libcamera/device_enumerator.cpp:147:20: error: ‘make_unique’ is not a member of ‘std’
enumerator = std::make_unique<DeviceEnumeratorUdev>();
^~~~~~~~~~~
../src/libcamera/device_enumerator.cpp:147:20: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/device_enumerator.cpp:16:1:
+#include <memory>
../src/libcamera/device_enumerator.cpp:147:20:
enumerator = std::make_unique<DeviceEnumeratorUdev>();
^~~~~~~~~~~
../src/libcamera/device_enumerator.cpp:147:52: error: expected primary-expression before ‘>’ token
enumerator = std::make_unique<DeviceEnumeratorUdev>();
^
../src/libcamera/device_enumerator.cpp:147:54: error: expected primary-expression before ‘)’ token
enumerator = std::make_unique<DeviceEnumeratorUdev>();
^
../src/libcamera/device_enumerator.cpp:156:20: error: ‘make_unique’ is not a member of ‘std’
enumerator = std::make_unique<DeviceEnumeratorSysfs>();
^~~~~~~~~~~
../src/libcamera/device_enumerator.cpp:156:20: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/device_enumerator.cpp:156:53: error: expected primary-expression before ‘>’ token
enumerator = std::make_unique<DeviceEnumeratorSysfs>();
^
../src/libcamera/device_enumerator.cpp:156:55: error: expected primary-expression before ‘)’ token
enumerator = std::make_unique<DeviceEnumeratorSysfs>();
^
[5/133] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o' -c ../src/libcamera/control_serializer.cpp
../src/libcamera/control_serializer.cpp: In member function ‘T libcamera::ControlSerializer::deserialize(libcamera::ByteStreamBuffer&) [with T = libcamera::ControlInfoMap]’:
../src/libcamera/control_serializer.cpp:417:33: error: ‘make_unique’ is not a member of ‘std’
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
^~~~~~~~~~~
../src/libcamera/control_serializer.cpp:417:33: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/control_serializer.cpp:20:1:
+#include <memory>
../src/libcamera/control_serializer.cpp:417:33:
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
^~~~~~~~~~~
../src/libcamera/control_serializer.cpp:417:54: error: expected primary-expression before ‘>’ token
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
^
../src/libcamera/control_serializer.cpp:417:62: error: left operand of comma operator has no effect [-Werror=unused-value]
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
~~~~~~^~
../src/libcamera/control_serializer.cpp:417:70: error: right operand of comma operator has no effect [-Werror=unused-value]
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
^~~~
cc1plus: all warnings being treated as errors
[6/133] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/ipa_manager.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/ipa_manager.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/ipa_manager.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/ipa_manager.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/ipa_manager.cpp.o' -c ../src/libcamera/ipa_manager.cpp
../src/libcamera/ipa_manager.cpp: In member function ‘std::unique_ptr<libcamera::IPAInterface> libcamera::IPAManager::createIPA(libcamera::PipelineHandler*, uint32_t, uint32_t)’:
../src/libcamera/ipa_manager.cpp:267:14: error: ‘make_unique’ is not a member of ‘std’
return std::make_unique<IPAContextWrapper>(ctx);
^~~~~~~~~~~
../src/libcamera/ipa_manager.cpp:267:14: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/ipa_manager.cpp:21:1:
+#include <memory>
../src/libcamera/ipa_manager.cpp:267:14:
return std::make_unique<IPAContextWrapper>(ctx);
^~~~~~~~~~~
../src/libcamera/ipa_manager.cpp:267:43: error: expected primary-expression before ‘>’ token
return std::make_unique<IPAContextWrapper>(ctx);
^
[7/133] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/object.cpp.o'.
[8/133] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/event_dispatcher_poll.cpp.o'.
[9/133] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/log.cpp.o'.
[10/133] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/camera_manager.cpp.o'.
ninja: build stopped: subcommand failed.
Build step 'Execute shell' marked build as failure
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: Build failed in Jenkins: libcamera #72
2020-01-19 21:16 ` Build failed in Jenkins: libcamera #72 Kieran Bingham
@ 2020-01-21 13:12 ` Mauro Carvalho Chehab
2020-01-21 13:46 ` Mauro Carvalho Chehab
` (2 more replies)
2020-01-21 13:14 ` Mauro Carvalho Chehab
1 sibling, 3 replies; 18+ messages in thread
From: Mauro Carvalho Chehab @ 2020-01-21 13:12 UTC (permalink / raw)
To: Kieran Bingham; +Cc: Jenkins Builder Robot, linux-media, LibCamera Devel
Em Sun, 19 Jan 2020 21:16:31 +0000
Kieran Bingham <kieran.bingham@ideasonboard.com> escreveu:
> Hi Mauro,
>
> It looks like the Jenkins jobs for Libcamera are failing continuously.
>
> I believe it looks like the jobs reuse an existing build configuration,
> and that doesn't get reconfigured if we change the top level meson.build
> or such.
>
> In particular, here we have changed to C++14, and the build should
> certainly be done from clean, as compiler flags should be updated.
>
>
> As a side note, is it possible (or desirable?) to cc
> <libcamera-devel@lists.libcamera.org> on these failures to make sure we
> see them?
>
> Thanks
> --
> Kieran
>
> On 15/01/2020 00:03, Jenkins Builder Robot wrote:
> > See <https://builder.linuxtv.org/job/libcamera/72/display/redirect?page=changes>
> >
> > Changes:
> >
> > [laurent.pinchart] meson.build: Switch to C++14
> >
> > [laurent.pinchart] libcamera: Switch from utils::make_unique to std::make_unique
> >
> >
> > ------------------------------------------
> > Started by an SCM change
> > Running as SYSTEM
> > Building remotely on slave1 in workspace <https://builder.linuxtv.org/job/libcamera/ws/>
> > No credentials specified
> > > git rev-parse --is-inside-work-tree # timeout=10
> > Fetching changes from the remote Git repository
> > > git config remote.origin.url git://linuxtv.org/libcamera.git # timeout=10
> > Fetching upstream changes from git://linuxtv.org/libcamera.git
> > > git --version # timeout=10
> > > git fetch --tags --force --progress -- git://linuxtv.org/libcamera.git +refs/heads/*:refs/remotes/origin/* # timeout=10
> > > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
> > > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
> > Checking out Revision acf18e4265dec2991e62f7c8baecfacf1a6708b3 (refs/remotes/origin/master)
> > > git config core.sparsecheckout # timeout=10
> > > git checkout -f acf18e4265dec2991e62f7c8baecfacf1a6708b3 # timeout=10
> > Commit message: "libcamera: Switch from utils::make_unique to std::make_unique"
> > > git rev-list --no-walk 055335bf49dbcb8c149bdcd4e96004c68e6b6ece # timeout=10
> > [libcamera] $ /bin/sh -xe /tmp/jenkins2777310540601637282.sh
> > + meson build -Dandroid=true
> > Directory already configured.
>
> ^^ This implies the previous build is being re-used.
>
> Perhaps for a CI job, would it make more sense to do from-scratch clean
> configure and rebuilds?
>
>
> It would be nice if meson always knew when to reconfigure, but I'm not
> sure how to make sure that always happens :-D
>
>
>
> >
> > Just run your build command (e.g. ninja) and Meson will regenerate as necessary.
> > If ninja fails, run "ninja reconfigure" or "meson --reconfigure"
> > to force Meson to regenerate.
> >
> > If build failures persist, run "meson setup --wipe" to rebuild from scratch
> > using the same options as passed when configuring the build.
> > To change option values, run "meson configure" instead.
> > + cd build
> > + ninja
> > [0/1] Regenerating build files.
> > The Meson build system
> > Version: 0.49.2
> > Source dir: <https://builder.linuxtv.org/job/libcamera/ws/>
> > Build dir: <https://builder.linuxtv.org/job/libcamera/ws/build>
> > Build type: native build
> > Project name: libcamera
> > Project version: 0.0.0
> > Native C compiler: ccache cc (gcc 8.3.0 "cc (Debian 8.3.0-6) 8.3.0")
> > Native C++ compiler: ccache c++ (gcc 8.3.0 "c++ (Debian 8.3.0-6) 8.3.0")
> > Build machine cpu family: x86_64
> > Build machine cpu: x86_64
> > Header <execinfo.h> has symbol "backtrace" : YES
> > Header <stdlib.h> has symbol "secure_getenv" : YES
> > Configuring version.h using configuration
> > Dependency libudev found: YES (cached)
> > Library atomic found: YES
> > Library dl found: YES
> > Dependency threads found: YES (cached)
> > WARNING: rcc dependencies will not work reliably until this upstream issue is fixed: https://bugreports.qt.io/browse/QTBUG-45460
> > Dependency qt5 found: YES (cached)
> > Detecting Qt5 tools
> > moc: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/moc, 5.11.3)
> > uic: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/uic, 5.11.3)
> > rcc: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/rcc, 5.11.3)
> > lrelease: NO
> > Program doxygen found: YES (/usr/bin/doxygen)
> > Configuring Doxyfile using configuration
> > Program sphinx-build-3 found: NO
> > Program sphinx-build found: YES (/usr/bin/sphinx-build)
> > Configuring config.h using configuration
> > Build targets in project: 68
> > Option werror is: True [default: true]
> > Option cpp_std is: c++11 [default: c++14]
> > Found ninja-1.8.2 at /usr/bin/ninja
> > [1/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/buffer.cpp.o'.
> > [2/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/message.cpp.o'.
> > [3/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/object.cpp.o'.
> > [4/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/media_object.cpp.o'.
> > [5/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/process.cpp.o'.
> > [6/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o'.
> > FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o
> > ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o' -c ../src/libcamera/pipeline/vimc.cpp
> > ../src/libcamera/pipeline/vimc.cpp: In member function ‘virtual bool libcamera::PipelineHandlerVimc::match(libcamera::DeviceEnumerator*)’:
> > ../src/libcamera/pipeline/vimc.cpp:368:46: error: ‘make_unique’ is not a member of ‘std’
> > std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
> > ^~~~~~~~~~~
> > ../src/libcamera/pipeline/vimc.cpp:368:46: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > ../src/libcamera/pipeline/vimc.cpp:34:1:
> > +#include <memory>
> >
> > ../src/libcamera/pipeline/vimc.cpp:368:46:
> > std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
> > ^~~~~~~~~~~
> > ../src/libcamera/pipeline/vimc.cpp:368:72: error: expected primary-expression before ‘>’ token
> > std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
> > ^
> > [7/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/framebuffer_allocator.cpp.o'.
> > [8/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o'.
> > FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o
> > ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o' -c ../src/libcamera/pipeline/ipu3/ipu3.cpp
> > ../src/libcamera/pipeline/ipu3/ipu3.cpp: In member function ‘int libcamera::PipelineHandlerIPU3::registerCameras()’:
> > ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9: error: ‘make_unique’ is not a member of ‘std’
> > std::make_unique<IPU3CameraData>(this);
> > ^~~~~~~~~~~
> > ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > ../src/libcamera/pipeline/ipu3/ipu3.cpp:29:1:
> > +#include <memory>
> >
> > ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9:
> > std::make_unique<IPU3CameraData>(this);
> > ^~~~~~~~~~~
> > ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:35: error: expected primary-expression before ‘>’ token
> > std::make_unique<IPU3CameraData>(this);
> > ^
> > [9/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/request.cpp.o'.
> > [10/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_timeline.cpp.o'.
> > [11/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_handler.cpp.o'.
> > [12/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o'.
> > FAILED: src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o
> > ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o' -c ../src/libcamera/proxy/ipa_proxy_linux.cpp
> > In file included from ../src/libcamera/proxy/ipa_proxy_linux.cpp:14:
> > ../src/libcamera/proxy/ipa_proxy_linux.cpp: In member function ‘virtual std::unique_ptr<libcamera::IPAProxy> libcamera::IPAProxyLinuxFactory::create(libcamera::IPAModule*)’:
> > ../src/libcamera/include/ipa_proxy.h:58:15: error: ‘make_unique’ is not a member of ‘std’
> > return std::make_unique<proxy>(ipam); \
> > ^~~~~~~~~~~
> > ../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
> > REGISTER_IPA_PROXY(IPAProxyLinux)
> > ^~~~~~~~~~~~~~~~~~
> > ../src/libcamera/include/ipa_proxy.h:58:15: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > return std::make_unique<proxy>(ipam); \
> > ^~~~~~~~~~~
> > ../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
> > REGISTER_IPA_PROXY(IPAProxyLinux)
> > ^~~~~~~~~~~~~~~~~~
> > ../src/libcamera/include/ipa_proxy.h:58:32: error: expected primary-expression before ‘>’ token
> > return std::make_unique<proxy>(ipam); \
> > ^
> > ../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
> > REGISTER_IPA_PROXY(IPAProxyLinux)
> > ^~~~~~~~~~~~~~~~~~
> > [13/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/.._android_camera3_hal.cpp.o'.
> > [14/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/device_enumerator_udev.cpp.o'.
> > [15/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o'.
> > FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o
> > ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o' -c ../src/libcamera/pipeline/rkisp1/rkisp1.cpp
> > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘void libcamera::RkISP1CameraData::queueFrameAction(unsigned int, const libcamera::IPAOperationData&)’:
> > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33: error: ‘make_unique’ is not a member of ‘std’
> > timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
> > ^~~~~~~~~~~
> > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:34:1:
> > +#include <memory>
> >
> > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33:
> > timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
> > ^~~~~~~~~~~
> > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:66: error: expected primary-expression before ‘>’ token
> > timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
> > ^
> > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:392:12: error: left operand of comma operator has no effect [-Werror=unused-value]
> > sensor_,
> > ^~~~~~~
> > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:392:12: error: right operand of comma operator has no effect [-Werror=unused-value]
> > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘virtual int libcamera::PipelineHandlerRkISP1::queueRequestDevice(libcamera::Camera*, libcamera::Request*)’:
> > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:38: error: ‘make_unique’ is not a member of ‘std’
> > data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
> > ^~~~~~~~~~~
> > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:38: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:74: error: expected primary-expression before ‘>’ token
> > data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
> > ^
> > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:82: error: left operand of comma operator has no effect [-Werror=unused-value]
> > data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
> > ~~~~~~^~~~~~
> > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:851:13: error: right operand of comma operator has no effect [-Werror=unused-value]
> > this));
> > ^~~~
> > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘int libcamera::PipelineHandlerRkISP1::createCamera(libcamera::MediaEntity*)’:
> > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:8: error: ‘make_unique’ is not a member of ‘std’
> > std::make_unique<RkISP1CameraData>(this);
> > ^~~~~~~~~~~
> > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:8: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:36: error: expected primary-expression before ‘>’ token
> > std::make_unique<RkISP1CameraData>(this);
> > ^
> > cc1plus: all warnings being treated as errors
> > ninja: build stopped: subcommand failed.
> > Build step 'Execute shell' marked build as failure
I added a clean step, just to be sure, e. g. the current build script is:
ninja -C build clean
meson build -Dandroid=true
ninja -C build
But it still produces errors when trying to build.
Cheers,
Mauro
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: Build failed in Jenkins: libcamera #72
2020-01-19 21:16 ` Build failed in Jenkins: libcamera #72 Kieran Bingham
2020-01-21 13:12 ` Mauro Carvalho Chehab
@ 2020-01-21 13:14 ` Mauro Carvalho Chehab
1 sibling, 0 replies; 18+ messages in thread
From: Mauro Carvalho Chehab @ 2020-01-21 13:14 UTC (permalink / raw)
To: Kieran Bingham; +Cc: Jenkins Builder Robot, linux-media, LibCamera Devel
Em Sun, 19 Jan 2020 21:16:31 +0000
Kieran Bingham <kieran.bingham@ideasonboard.com> escreveu:
> Hi Mauro,
>
> As a side note, is it possible (or desirable?) to cc
> <libcamera-devel@lists.libcamera.org> on these failures to make sure we
> see them?
Added.
Cheers,
Mauro
^ permalink raw reply [flat|nested] 18+ messages in thread
* Build failed in Jenkins: libcamera #78
2020-01-20 17:03 ` Build failed in Jenkins: libcamera #77 Jenkins Builder Robot
@ 2020-01-21 13:26 ` Jenkins Builder Robot
2020-01-21 13:38 ` Jenkins build is back to normal : libcamera #79 Jenkins Builder Robot
0 siblings, 1 reply; 18+ messages in thread
From: Jenkins Builder Robot @ 2020-01-21 13:26 UTC (permalink / raw)
To: mchehab, linux-media, libcamera-devel
See <https://builder.linuxtv.org/job/libcamera/78/display/redirect>
Changes:
------------------------------------------
[...truncated 1.66 KB...]
[2/2] Cleaning.
Cleaning... 50 files.
+ meson build -Dandroid=true
Directory already configured.
Just run your build command (e.g. ninja) and Meson will regenerate as necessary.
If ninja fails, run "ninja reconfigure" or "meson --reconfigure"
to force Meson to regenerate.
If build failures persist, run "meson setup --wipe" to rebuild from scratch
using the same options as passed when configuring the build.
To change option values, run "meson configure" instead.
+ ninja -C build
ninja: Entering directory `build'
[1/212] Compiling C object 'utils/ipu3/5b60d53@@ipu3-unpack@exe/ipu3-unpack.c.o'.
[2/212] Compiling C object 'src/android/e7e5733@@camera_metadata@sta/metadata_camera_metadata.c.o'.
[3/212] Linking static target src/android/libcamera_metadata.a.
[4/212] Generating gen-header with a custom command.
[5/212] Linking target utils/ipu3/ipu3-unpack.
[6/212] Generating control_ids_h with a custom command.
[7/212] Generating control_ids_cpp with a custom command.
[8/212] Generating 'src/qcam/9916d8b@@qcam@exe/moc_main_window.cpp'.
[9/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/buffer.cpp.o'.
[10/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/byte_stream_buffer.cpp.o'.
[11/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/camera_controls.cpp.o'.
[12/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/camera_manager.cpp.o'.
[13/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/camera.cpp.o'.
[14/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/control_validator.cpp.o'.
[15/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/controls.cpp.o'.
[16/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/camera_sensor.cpp.o'.
[17/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/device_enumerator_sysfs.cpp.o'.
[18/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/event_dispatcher.cpp.o'.
[19/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/event_dispatcher_poll.cpp.o'.
[20/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/event_notifier.cpp.o'.
[21/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/formats.cpp.o'.
[22/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/file_descriptor.cpp.o'.
[23/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/geometry.cpp.o'.
[24/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/ipa_controls.cpp.o'.
[25/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/framebuffer_allocator.cpp.o'.
[26/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/ipa_interface.cpp.o'.
[27/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/meson-generated_.._control_ids.cpp.o'.
[28/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/ipa_context_wrapper.cpp.o'.
[29/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/ipa_module.cpp.o'.
[30/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/ipc_unixsocket.cpp.o'.
[31/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/ipa_proxy.cpp.o'.
[32/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/log.cpp.o'.
[33/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/media_device.cpp.o'.
[34/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/media_object.cpp.o'.
[35/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/message.cpp.o'.
[36/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/object.cpp.o'.
[37/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pixelformats.cpp.o'.
[38/212] Compiling C++ object 'src/qcam/9916d8b@@qcam@exe/meson-generated_moc_main_window.cpp.o'.
[39/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_handler.cpp.o'.
[40/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/process.cpp.o'.
[41/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/request.cpp.o'.
[42/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/semaphore.cpp.o'.
[43/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/signal.cpp.o'.
[44/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/stream.cpp.o'.
[45/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/thread.cpp.o'.
[46/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/utils.cpp.o'.
[47/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/timer.cpp.o'.
[48/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/v4l2_controls.cpp.o'.
[49/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/v4l2_subdevice.cpp.o'.
[50/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/bound_method.cpp.o' -c ../src/libcamera/bound_method.cpp
../src/libcamera/bound_method.cpp: In member function ‘bool libcamera::BoundMethodBase::activatePack(std::shared_ptr<libcamera::BoundMethodPackBase>, bool)’:
../src/libcamera/bound_method.cpp:86:9: error: ‘make_unique’ is not a member of ‘std’
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~~~~~~~~
../src/libcamera/bound_method.cpp:86:9: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/bound_method.cpp:13:1:
+#include <memory>
../src/libcamera/bound_method.cpp:86:9:
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~~~~~~~~
../src/libcamera/bound_method.cpp:86:34: error: expected primary-expression before ‘>’ token
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^
../src/libcamera/bound_method.cpp:86:42: error: left operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~
../src/libcamera/bound_method.cpp:86:48: error: right operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~~~~
../src/libcamera/bound_method.cpp:86:57: error: right operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, nullptr, deleteMethod);
^~~~~~~~~~~~
../src/libcamera/bound_method.cpp:95:9: error: ‘make_unique’ is not a member of ‘std’
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^~~~~~~~~~~
../src/libcamera/bound_method.cpp:95:9: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/bound_method.cpp:95:34: error: expected primary-expression before ‘>’ token
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^
../src/libcamera/bound_method.cpp:95:42: error: left operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^~~~
../src/libcamera/bound_method.cpp:95:49: error: right operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^~~~~~~~~
../src/libcamera/bound_method.cpp:95:48: error: right operand of comma operator has no effect [-Werror=unused-value]
std::make_unique<InvokeMessage>(this, pack, &semaphore, deleteMethod);
^~~~~~~~~~
cc1plus: all warnings being treated as errors
[51/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/device_enumerator.cpp.o' -c ../src/libcamera/device_enumerator.cpp
../src/libcamera/device_enumerator.cpp: In static member function ‘static std::unique_ptr<libcamera::DeviceEnumerator> libcamera::DeviceEnumerator::create()’:
../src/libcamera/device_enumerator.cpp:147:20: error: ‘make_unique’ is not a member of ‘std’
enumerator = std::make_unique<DeviceEnumeratorUdev>();
^~~~~~~~~~~
../src/libcamera/device_enumerator.cpp:147:20: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/device_enumerator.cpp:16:1:
+#include <memory>
../src/libcamera/device_enumerator.cpp:147:20:
enumerator = std::make_unique<DeviceEnumeratorUdev>();
^~~~~~~~~~~
../src/libcamera/device_enumerator.cpp:147:52: error: expected primary-expression before ‘>’ token
enumerator = std::make_unique<DeviceEnumeratorUdev>();
^
../src/libcamera/device_enumerator.cpp:147:54: error: expected primary-expression before ‘)’ token
enumerator = std::make_unique<DeviceEnumeratorUdev>();
^
../src/libcamera/device_enumerator.cpp:156:20: error: ‘make_unique’ is not a member of ‘std’
enumerator = std::make_unique<DeviceEnumeratorSysfs>();
^~~~~~~~~~~
../src/libcamera/device_enumerator.cpp:156:20: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/device_enumerator.cpp:156:53: error: expected primary-expression before ‘>’ token
enumerator = std::make_unique<DeviceEnumeratorSysfs>();
^
../src/libcamera/device_enumerator.cpp:156:55: error: expected primary-expression before ‘)’ token
enumerator = std::make_unique<DeviceEnumeratorSysfs>();
^
[52/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/control_serializer.cpp.o' -c ../src/libcamera/control_serializer.cpp
../src/libcamera/control_serializer.cpp: In member function ‘T libcamera::ControlSerializer::deserialize(libcamera::ByteStreamBuffer&) [with T = libcamera::ControlInfoMap]’:
../src/libcamera/control_serializer.cpp:417:33: error: ‘make_unique’ is not a member of ‘std’
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
^~~~~~~~~~~
../src/libcamera/control_serializer.cpp:417:33: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/control_serializer.cpp:20:1:
+#include <memory>
../src/libcamera/control_serializer.cpp:417:33:
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
^~~~~~~~~~~
../src/libcamera/control_serializer.cpp:417:54: error: expected primary-expression before ‘>’ token
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
^
../src/libcamera/control_serializer.cpp:417:62: error: left operand of comma operator has no effect [-Werror=unused-value]
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
~~~~~~^~
../src/libcamera/control_serializer.cpp:417:70: error: right operand of comma operator has no effect [-Werror=unused-value]
controlIds_.emplace_back(std::make_unique<ControlId>(entry.id, "", type));
^~~~
cc1plus: all warnings being treated as errors
[53/212] Generating version.cpp with a custom command.
[54/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/ipa_manager.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/ipa_manager.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/ipa_manager.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/ipa_manager.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/ipa_manager.cpp.o' -c ../src/libcamera/ipa_manager.cpp
../src/libcamera/ipa_manager.cpp: In member function ‘std::unique_ptr<libcamera::IPAInterface> libcamera::IPAManager::createIPA(libcamera::PipelineHandler*, uint32_t, uint32_t)’:
../src/libcamera/ipa_manager.cpp:267:14: error: ‘make_unique’ is not a member of ‘std’
return std::make_unique<IPAContextWrapper>(ctx);
^~~~~~~~~~~
../src/libcamera/ipa_manager.cpp:267:14: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/ipa_manager.cpp:21:1:
+#include <memory>
../src/libcamera/ipa_manager.cpp:267:14:
return std::make_unique<IPAContextWrapper>(ctx);
^~~~~~~~~~~
../src/libcamera/ipa_manager.cpp:267:43: error: expected primary-expression before ‘>’ token
return std::make_unique<IPAContextWrapper>(ctx);
^
[55/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/v4l2_device.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/v4l2_device.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/v4l2_device.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/v4l2_device.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/v4l2_device.cpp.o' -c ../src/libcamera/v4l2_device.cpp
../src/libcamera/v4l2_device.cpp: In member function ‘void libcamera::V4L2Device::listControls()’:
../src/libcamera/v4l2_device.cpp:383:33: error: ‘make_unique’ is not a member of ‘std’
controlIds_.emplace_back(std::make_unique<V4L2ControlId>(ctrl));
^~~~~~~~~~~
../src/libcamera/v4l2_device.cpp:383:33: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/v4l2_device.cpp:20:1:
+#include <memory>
../src/libcamera/v4l2_device.cpp:383:33:
controlIds_.emplace_back(std::make_unique<V4L2ControlId>(ctrl));
^~~~~~~~~~~
../src/libcamera/v4l2_device.cpp:383:58: error: expected primary-expression before ‘>’ token
controlIds_.emplace_back(std::make_unique<V4L2ControlId>(ctrl));
^
[56/212] Generating documentation with a custom command.
[57/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/v4l2_videodevice.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/v4l2_videodevice.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/v4l2_videodevice.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/v4l2_videodevice.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/v4l2_videodevice.cpp.o' -c ../src/libcamera/v4l2_videodevice.cpp
../src/libcamera/v4l2_videodevice.cpp: In member function ‘std::unique_ptr<libcamera::FrameBuffer> libcamera::V4L2VideoDevice::createBuffer(const v4l2_buffer&)’:
../src/libcamera/v4l2_videodevice.cpp:1057:14: error: ‘make_unique’ is not a member of ‘std’
return std::make_unique<FrameBuffer>(std::move(planes));
^~~~~~~~~~~
../src/libcamera/v4l2_videodevice.cpp:1057:14: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/v4l2_videodevice.cpp:30:1:
+#include <memory>
../src/libcamera/v4l2_videodevice.cpp:1057:14:
return std::make_unique<FrameBuffer>(std::move(planes));
^~~~~~~~~~~
../src/libcamera/v4l2_videodevice.cpp:1057:37: error: expected primary-expression before ‘>’ token
return std::make_unique<FrameBuffer>(std::move(planes));
^
[58/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_uvcvideo.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_uvcvideo.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_uvcvideo.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_uvcvideo.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_uvcvideo.cpp.o' -c ../src/libcamera/pipeline/uvcvideo.cpp
../src/libcamera/pipeline/uvcvideo.cpp: In member function ‘virtual bool libcamera::PipelineHandlerUVC::match(libcamera::DeviceEnumerator*)’:
../src/libcamera/pipeline/uvcvideo.cpp:299:45: error: ‘make_unique’ is not a member of ‘std’
std::unique_ptr<UVCCameraData> data = std::make_unique<UVCCameraData>(this);
^~~~~~~~~~~
../src/libcamera/pipeline/uvcvideo.cpp:299:45: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/pipeline/uvcvideo.cpp:26:1:
+#include <memory>
../src/libcamera/pipeline/uvcvideo.cpp:299:45:
std::unique_ptr<UVCCameraData> data = std::make_unique<UVCCameraData>(this);
^~~~~~~~~~~
../src/libcamera/pipeline/uvcvideo.cpp:299:70: error: expected primary-expression before ‘>’ token
std::unique_ptr<UVCCameraData> data = std::make_unique<UVCCameraData>(this);
^
[59/212] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o'.
FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o
ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o' -c ../src/libcamera/pipeline/vimc.cpp
../src/libcamera/pipeline/vimc.cpp: In member function ‘virtual bool libcamera::PipelineHandlerVimc::match(libcamera::DeviceEnumerator*)’:
../src/libcamera/pipeline/vimc.cpp:368:46: error: ‘make_unique’ is not a member of ‘std’
std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
^~~~~~~~~~~
../src/libcamera/pipeline/vimc.cpp:368:46: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
../src/libcamera/pipeline/vimc.cpp:34:1:
+#include <memory>
../src/libcamera/pipeline/vimc.cpp:368:46:
std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
^~~~~~~~~~~
../src/libcamera/pipeline/vimc.cpp:368:72: error: expected primary-expression before ‘>’ token
std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
^
ninja: build stopped: subcommand failed.
Build step 'Execute shell' marked build as failure
^ permalink raw reply [flat|nested] 18+ messages in thread
* Jenkins build is back to normal : libcamera #79
2020-01-21 13:26 ` Build failed in Jenkins: libcamera #78 Jenkins Builder Robot
@ 2020-01-21 13:38 ` Jenkins Builder Robot
0 siblings, 0 replies; 18+ messages in thread
From: Jenkins Builder Robot @ 2020-01-21 13:38 UTC (permalink / raw)
To: mchehab, linux-media, libcamera-devel
See <https://builder.linuxtv.org/job/libcamera/79/display/redirect>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: Build failed in Jenkins: libcamera #72
2020-01-21 13:12 ` Mauro Carvalho Chehab
@ 2020-01-21 13:46 ` Mauro Carvalho Chehab
2020-01-21 13:48 ` Kieran Bingham
2020-01-21 13:47 ` Kieran Bingham
2020-01-21 13:51 ` [libcamera-devel] " Laurent Pinchart
2 siblings, 1 reply; 18+ messages in thread
From: Mauro Carvalho Chehab @ 2020-01-21 13:46 UTC (permalink / raw)
To: Kieran Bingham; +Cc: Jenkins Builder Robot, linux-media, LibCamera Devel
Em Tue, 21 Jan 2020 14:12:46 +0100
Mauro Carvalho Chehab <mchehab@kernel.org> escreveu:
> Em Sun, 19 Jan 2020 21:16:31 +0000
> Kieran Bingham <kieran.bingham@ideasonboard.com> escreveu:
>
> > Hi Mauro,
> >
> > It looks like the Jenkins jobs for Libcamera are failing continuously.
> >
> > I believe it looks like the jobs reuse an existing build configuration,
> > and that doesn't get reconfigured if we change the top level meson.build
> > or such.
> >
> > In particular, here we have changed to C++14, and the build should
> > certainly be done from clean, as compiler flags should be updated.
> >
> >
> > As a side note, is it possible (or desirable?) to cc
> > <libcamera-devel@lists.libcamera.org> on these failures to make sure we
> > see them?
> >
> > Thanks
> > --
> > Kieran
> >
> > On 15/01/2020 00:03, Jenkins Builder Robot wrote:
> > > See <https://builder.linuxtv.org/job/libcamera/72/display/redirect?page=changes>
> > >
> > > Changes:
> > >
> > > [laurent.pinchart] meson.build: Switch to C++14
> > >
> > > [laurent.pinchart] libcamera: Switch from utils::make_unique to std::make_unique
> > >
> > >
> > > ------------------------------------------
> > > Started by an SCM change
> > > Running as SYSTEM
> > > Building remotely on slave1 in workspace <https://builder.linuxtv.org/job/libcamera/ws/>
> > > No credentials specified
> > > > git rev-parse --is-inside-work-tree # timeout=10
> > > Fetching changes from the remote Git repository
> > > > git config remote.origin.url git://linuxtv.org/libcamera.git # timeout=10
> > > Fetching upstream changes from git://linuxtv.org/libcamera.git
> > > > git --version # timeout=10
> > > > git fetch --tags --force --progress -- git://linuxtv.org/libcamera.git +refs/heads/*:refs/remotes/origin/* # timeout=10
> > > > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
> > > > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
> > > Checking out Revision acf18e4265dec2991e62f7c8baecfacf1a6708b3 (refs/remotes/origin/master)
> > > > git config core.sparsecheckout # timeout=10
> > > > git checkout -f acf18e4265dec2991e62f7c8baecfacf1a6708b3 # timeout=10
> > > Commit message: "libcamera: Switch from utils::make_unique to std::make_unique"
> > > > git rev-list --no-walk 055335bf49dbcb8c149bdcd4e96004c68e6b6ece # timeout=10
> > > [libcamera] $ /bin/sh -xe /tmp/jenkins2777310540601637282.sh
> > > + meson build -Dandroid=true
> > > Directory already configured.
> >
> > ^^ This implies the previous build is being re-used.
> >
> > Perhaps for a CI job, would it make more sense to do from-scratch clean
> > configure and rebuilds?
> >
> >
> > It would be nice if meson always knew when to reconfigure, but I'm not
> > sure how to make sure that always happens :-D
> >
> >
> >
> > >
> > > Just run your build command (e.g. ninja) and Meson will regenerate as necessary.
> > > If ninja fails, run "ninja reconfigure" or "meson --reconfigure"
> > > to force Meson to regenerate.
> > >
> > > If build failures persist, run "meson setup --wipe" to rebuild from scratch
> > > using the same options as passed when configuring the build.
> > > To change option values, run "meson configure" instead.
> > > + cd build
> > > + ninja
> > > [0/1] Regenerating build files.
> > > The Meson build system
> > > Version: 0.49.2
> > > Source dir: <https://builder.linuxtv.org/job/libcamera/ws/>
> > > Build dir: <https://builder.linuxtv.org/job/libcamera/ws/build>
> > > Build type: native build
> > > Project name: libcamera
> > > Project version: 0.0.0
> > > Native C compiler: ccache cc (gcc 8.3.0 "cc (Debian 8.3.0-6) 8.3.0")
> > > Native C++ compiler: ccache c++ (gcc 8.3.0 "c++ (Debian 8.3.0-6) 8.3.0")
> > > Build machine cpu family: x86_64
> > > Build machine cpu: x86_64
> > > Header <execinfo.h> has symbol "backtrace" : YES
> > > Header <stdlib.h> has symbol "secure_getenv" : YES
> > > Configuring version.h using configuration
> > > Dependency libudev found: YES (cached)
> > > Library atomic found: YES
> > > Library dl found: YES
> > > Dependency threads found: YES (cached)
> > > WARNING: rcc dependencies will not work reliably until this upstream issue is fixed: https://bugreports.qt.io/browse/QTBUG-45460
> > > Dependency qt5 found: YES (cached)
> > > Detecting Qt5 tools
> > > moc: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/moc, 5.11.3)
> > > uic: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/uic, 5.11.3)
> > > rcc: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/rcc, 5.11.3)
> > > lrelease: NO
> > > Program doxygen found: YES (/usr/bin/doxygen)
> > > Configuring Doxyfile using configuration
> > > Program sphinx-build-3 found: NO
> > > Program sphinx-build found: YES (/usr/bin/sphinx-build)
> > > Configuring config.h using configuration
> > > Build targets in project: 68
> > > Option werror is: True [default: true]
> > > Option cpp_std is: c++11 [default: c++14]
> > > Found ninja-1.8.2 at /usr/bin/ninja
> > > [1/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/buffer.cpp.o'.
> > > [2/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/message.cpp.o'.
> > > [3/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/object.cpp.o'.
> > > [4/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/media_object.cpp.o'.
> > > [5/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/process.cpp.o'.
> > > [6/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o'.
> > > FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o
> > > ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o' -c ../src/libcamera/pipeline/vimc.cpp
> > > ../src/libcamera/pipeline/vimc.cpp: In member function ‘virtual bool libcamera::PipelineHandlerVimc::match(libcamera::DeviceEnumerator*)’:
> > > ../src/libcamera/pipeline/vimc.cpp:368:46: error: ‘make_unique’ is not a member of ‘std’
> > > std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
> > > ^~~~~~~~~~~
> > > ../src/libcamera/pipeline/vimc.cpp:368:46: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > > ../src/libcamera/pipeline/vimc.cpp:34:1:
> > > +#include <memory>
> > >
> > > ../src/libcamera/pipeline/vimc.cpp:368:46:
> > > std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
> > > ^~~~~~~~~~~
> > > ../src/libcamera/pipeline/vimc.cpp:368:72: error: expected primary-expression before ‘>’ token
> > > std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
> > > ^
> > > [7/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/framebuffer_allocator.cpp.o'.
> > > [8/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o'.
> > > FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o
> > > ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o' -c ../src/libcamera/pipeline/ipu3/ipu3.cpp
> > > ../src/libcamera/pipeline/ipu3/ipu3.cpp: In member function ‘int libcamera::PipelineHandlerIPU3::registerCameras()’:
> > > ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9: error: ‘make_unique’ is not a member of ‘std’
> > > std::make_unique<IPU3CameraData>(this);
> > > ^~~~~~~~~~~
> > > ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > > ../src/libcamera/pipeline/ipu3/ipu3.cpp:29:1:
> > > +#include <memory>
> > >
> > > ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9:
> > > std::make_unique<IPU3CameraData>(this);
> > > ^~~~~~~~~~~
> > > ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:35: error: expected primary-expression before ‘>’ token
> > > std::make_unique<IPU3CameraData>(this);
> > > ^
> > > [9/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/request.cpp.o'.
> > > [10/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_timeline.cpp.o'.
> > > [11/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_handler.cpp.o'.
> > > [12/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o'.
> > > FAILED: src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o
> > > ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o' -c ../src/libcamera/proxy/ipa_proxy_linux.cpp
> > > In file included from ../src/libcamera/proxy/ipa_proxy_linux.cpp:14:
> > > ../src/libcamera/proxy/ipa_proxy_linux.cpp: In member function ‘virtual std::unique_ptr<libcamera::IPAProxy> libcamera::IPAProxyLinuxFactory::create(libcamera::IPAModule*)’:
> > > ../src/libcamera/include/ipa_proxy.h:58:15: error: ‘make_unique’ is not a member of ‘std’
> > > return std::make_unique<proxy>(ipam); \
> > > ^~~~~~~~~~~
> > > ../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
> > > REGISTER_IPA_PROXY(IPAProxyLinux)
> > > ^~~~~~~~~~~~~~~~~~
> > > ../src/libcamera/include/ipa_proxy.h:58:15: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > > return std::make_unique<proxy>(ipam); \
> > > ^~~~~~~~~~~
> > > ../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
> > > REGISTER_IPA_PROXY(IPAProxyLinux)
> > > ^~~~~~~~~~~~~~~~~~
> > > ../src/libcamera/include/ipa_proxy.h:58:32: error: expected primary-expression before ‘>’ token
> > > return std::make_unique<proxy>(ipam); \
> > > ^
> > > ../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
> > > REGISTER_IPA_PROXY(IPAProxyLinux)
> > > ^~~~~~~~~~~~~~~~~~
> > > [13/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/.._android_camera3_hal.cpp.o'.
> > > [14/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/device_enumerator_udev.cpp.o'.
> > > [15/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o'.
> > > FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o
> > > ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o' -c ../src/libcamera/pipeline/rkisp1/rkisp1.cpp
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘void libcamera::RkISP1CameraData::queueFrameAction(unsigned int, const libcamera::IPAOperationData&)’:
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33: error: ‘make_unique’ is not a member of ‘std’
> > > timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
> > > ^~~~~~~~~~~
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:34:1:
> > > +#include <memory>
> > >
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33:
> > > timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
> > > ^~~~~~~~~~~
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:66: error: expected primary-expression before ‘>’ token
> > > timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
> > > ^
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:392:12: error: left operand of comma operator has no effect [-Werror=unused-value]
> > > sensor_,
> > > ^~~~~~~
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:392:12: error: right operand of comma operator has no effect [-Werror=unused-value]
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘virtual int libcamera::PipelineHandlerRkISP1::queueRequestDevice(libcamera::Camera*, libcamera::Request*)’:
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:38: error: ‘make_unique’ is not a member of ‘std’
> > > data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
> > > ^~~~~~~~~~~
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:38: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:74: error: expected primary-expression before ‘>’ token
> > > data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
> > > ^
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:82: error: left operand of comma operator has no effect [-Werror=unused-value]
> > > data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
> > > ~~~~~~^~~~~~
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:851:13: error: right operand of comma operator has no effect [-Werror=unused-value]
> > > this));
> > > ^~~~
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘int libcamera::PipelineHandlerRkISP1::createCamera(libcamera::MediaEntity*)’:
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:8: error: ‘make_unique’ is not a member of ‘std’
> > > std::make_unique<RkISP1CameraData>(this);
> > > ^~~~~~~~~~~
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:8: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:36: error: expected primary-expression before ‘>’ token
> > > std::make_unique<RkISP1CameraData>(this);
> > > ^
> > > cc1plus: all warnings being treated as errors
> > > ninja: build stopped: subcommand failed.
> > > Build step 'Execute shell' marked build as failure
>
> I added a clean step, just to be sure, e. g. the current build script is:
>
> ninja -C build clean
> meson build -Dandroid=true
> ninja -C build
>
> But it still produces errors when trying to build.
Changed the recipe to:
meson setup --wipe build
meson configure build
ninja -C build
This way, it should wipe the build information every time, and display the
config it will use for the build.
Job is succeeding with the above.
Cheers,
Mauro
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: Build failed in Jenkins: libcamera #72
2020-01-21 13:12 ` Mauro Carvalho Chehab
2020-01-21 13:46 ` Mauro Carvalho Chehab
@ 2020-01-21 13:47 ` Kieran Bingham
2020-01-21 14:22 ` Mauro Carvalho Chehab
2020-01-21 13:51 ` [libcamera-devel] " Laurent Pinchart
2 siblings, 1 reply; 18+ messages in thread
From: Kieran Bingham @ 2020-01-21 13:47 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Jenkins Builder Robot, linux-media, LibCamera Devel
Hi Mauro,
On 21/01/2020 13:12, Mauro Carvalho Chehab wrote:
> Em Sun, 19 Jan 2020 21:16:31 +0000
> Kieran Bingham <kieran.bingham@ideasonboard.com> escreveu:
>
>> Hi Mauro,
>>
>> It looks like the Jenkins jobs for Libcamera are failing continuously.
>>
>> I believe it looks like the jobs reuse an existing build configuration,
>> and that doesn't get reconfigured if we change the top level meson.build
>> or such.
>>
>> In particular, here we have changed to C++14, and the build should
>> certainly be done from clean, as compiler flags should be updated.
>>
>>
>> As a side note, is it possible (or desirable?) to cc
>> <libcamera-devel@lists.libcamera.org> on these failures to make sure we
>> see them?
>>
>> Thanks
>> --
>> Kieran
>>
>> On 15/01/2020 00:03, Jenkins Builder Robot wrote:
>>> See <https://builder.linuxtv.org/job/libcamera/72/display/redirect?page=changes>
>>>
>>> Changes:
>>>
>>> [laurent.pinchart] meson.build: Switch to C++14
>>>
>>> [laurent.pinchart] libcamera: Switch from utils::make_unique to std::make_unique
>>>
>>>
>>> ------------------------------------------
>>> Started by an SCM change
>>> Running as SYSTEM
>>> Building remotely on slave1 in workspace <https://builder.linuxtv.org/job/libcamera/ws/>
>>> No credentials specified
>>> > git rev-parse --is-inside-work-tree # timeout=10
>>> Fetching changes from the remote Git repository
>>> > git config remote.origin.url git://linuxtv.org/libcamera.git # timeout=10
>>> Fetching upstream changes from git://linuxtv.org/libcamera.git
>>> > git --version # timeout=10
>>> > git fetch --tags --force --progress -- git://linuxtv.org/libcamera.git +refs/heads/*:refs/remotes/origin/* # timeout=10
>>> > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
>>> > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
>>> Checking out Revision acf18e4265dec2991e62f7c8baecfacf1a6708b3 (refs/remotes/origin/master)
>>> > git config core.sparsecheckout # timeout=10
>>> > git checkout -f acf18e4265dec2991e62f7c8baecfacf1a6708b3 # timeout=10
>>> Commit message: "libcamera: Switch from utils::make_unique to std::make_unique"
>>> > git rev-list --no-walk 055335bf49dbcb8c149bdcd4e96004c68e6b6ece # timeout=10
>>> [libcamera] $ /bin/sh -xe /tmp/jenkins2777310540601637282.sh
>>> + meson build -Dandroid=true
>>> Directory already configured.
>>
>> ^^ This implies the previous build is being re-used.
>>
>> Perhaps for a CI job, would it make more sense to do from-scratch clean
>> configure and rebuilds?
>>
>>
>> It would be nice if meson always knew when to reconfigure, but I'm not
>> sure how to make sure that always happens :-D
>>
>>
>>
>>>
>>> Just run your build command (e.g. ninja) and Meson will regenerate as necessary.
>>> If ninja fails, run "ninja reconfigure" or "meson --reconfigure"
>>> to force Meson to regenerate.
>>>
>>> If build failures persist, run "meson setup --wipe" to rebuild from scratch
>>> using the same options as passed when configuring the build.
>>> To change option values, run "meson configure" instead.
>>> + cd build
>>> + ninja
>>> [0/1] Regenerating build files.
>>> The Meson build system
>>> Version: 0.49.2
>>> Source dir: <https://builder.linuxtv.org/job/libcamera/ws/>
>>> Build dir: <https://builder.linuxtv.org/job/libcamera/ws/build>
>>> Build type: native build
>>> Project name: libcamera
>>> Project version: 0.0.0
>>> Native C compiler: ccache cc (gcc 8.3.0 "cc (Debian 8.3.0-6) 8.3.0")
>>> Native C++ compiler: ccache c++ (gcc 8.3.0 "c++ (Debian 8.3.0-6) 8.3.0")
>>> Build machine cpu family: x86_64
>>> Build machine cpu: x86_64
>>> Header <execinfo.h> has symbol "backtrace" : YES
>>> Header <stdlib.h> has symbol "secure_getenv" : YES
>>> Configuring version.h using configuration
>>> Dependency libudev found: YES (cached)
>>> Library atomic found: YES
>>> Library dl found: YES
>>> Dependency threads found: YES (cached)
>>> WARNING: rcc dependencies will not work reliably until this upstream issue is fixed: https://bugreports.qt.io/browse/QTBUG-45460
>>> Dependency qt5 found: YES (cached)
>>> Detecting Qt5 tools
>>> moc: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/moc, 5.11.3)
>>> uic: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/uic, 5.11.3)
>>> rcc: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/rcc, 5.11.3)
>>> lrelease: NO
>>> Program doxygen found: YES (/usr/bin/doxygen)
>>> Configuring Doxyfile using configuration
>>> Program sphinx-build-3 found: NO
>>> Program sphinx-build found: YES (/usr/bin/sphinx-build)
>>> Configuring config.h using configuration
>>> Build targets in project: 68
>>> Option werror is: True [default: true]
>>> Option cpp_std is: c++11 [default: c++14]
>>> Found ninja-1.8.2 at /usr/bin/ninja
>>> [1/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/buffer.cpp.o'.
>>> [2/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/message.cpp.o'.
>>> [3/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/object.cpp.o'.
>>> [4/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/media_object.cpp.o'.
>>> [5/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/process.cpp.o'.
>>> [6/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o'.
>>> FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o
>>> ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o' -c ../src/libcamera/pipeline/vimc.cpp
>>> ../src/libcamera/pipeline/vimc.cpp: In member function ‘virtual bool libcamera::PipelineHandlerVimc::match(libcamera::DeviceEnumerator*)’:
>>> ../src/libcamera/pipeline/vimc.cpp:368:46: error: ‘make_unique’ is not a member of ‘std’
>>> std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
>>> ^~~~~~~~~~~
>>> ../src/libcamera/pipeline/vimc.cpp:368:46: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
>>> ../src/libcamera/pipeline/vimc.cpp:34:1:
>>> +#include <memory>
>>>
>>> ../src/libcamera/pipeline/vimc.cpp:368:46:
>>> std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
>>> ^~~~~~~~~~~
>>> ../src/libcamera/pipeline/vimc.cpp:368:72: error: expected primary-expression before ‘>’ token
>>> std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
>>> ^
>>> [7/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/framebuffer_allocator.cpp.o'.
>>> [8/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o'.
>>> FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o
>>> ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o' -c ../src/libcamera/pipeline/ipu3/ipu3.cpp
>>> ../src/libcamera/pipeline/ipu3/ipu3.cpp: In member function ‘int libcamera::PipelineHandlerIPU3::registerCameras()’:
>>> ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9: error: ‘make_unique’ is not a member of ‘std’
>>> std::make_unique<IPU3CameraData>(this);
>>> ^~~~~~~~~~~
>>> ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
>>> ../src/libcamera/pipeline/ipu3/ipu3.cpp:29:1:
>>> +#include <memory>
>>>
>>> ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9:
>>> std::make_unique<IPU3CameraData>(this);
>>> ^~~~~~~~~~~
>>> ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:35: error: expected primary-expression before ‘>’ token
>>> std::make_unique<IPU3CameraData>(this);
>>> ^
>>> [9/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/request.cpp.o'.
>>> [10/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_timeline.cpp.o'.
>>> [11/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_handler.cpp.o'.
>>> [12/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o'.
>>> FAILED: src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o
>>> ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o' -c ../src/libcamera/proxy/ipa_proxy_linux.cpp
>>> In file included from ../src/libcamera/proxy/ipa_proxy_linux.cpp:14:
>>> ../src/libcamera/proxy/ipa_proxy_linux.cpp: In member function ‘virtual std::unique_ptr<libcamera::IPAProxy> libcamera::IPAProxyLinuxFactory::create(libcamera::IPAModule*)’:
>>> ../src/libcamera/include/ipa_proxy.h:58:15: error: ‘make_unique’ is not a member of ‘std’
>>> return std::make_unique<proxy>(ipam); \
>>> ^~~~~~~~~~~
>>> ../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
>>> REGISTER_IPA_PROXY(IPAProxyLinux)
>>> ^~~~~~~~~~~~~~~~~~
>>> ../src/libcamera/include/ipa_proxy.h:58:15: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
>>> return std::make_unique<proxy>(ipam); \
>>> ^~~~~~~~~~~
>>> ../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
>>> REGISTER_IPA_PROXY(IPAProxyLinux)
>>> ^~~~~~~~~~~~~~~~~~
>>> ../src/libcamera/include/ipa_proxy.h:58:32: error: expected primary-expression before ‘>’ token
>>> return std::make_unique<proxy>(ipam); \
>>> ^
>>> ../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
>>> REGISTER_IPA_PROXY(IPAProxyLinux)
>>> ^~~~~~~~~~~~~~~~~~
>>> [13/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/.._android_camera3_hal.cpp.o'.
>>> [14/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/device_enumerator_udev.cpp.o'.
>>> [15/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o'.
>>> FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o
>>> ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o' -c ../src/libcamera/pipeline/rkisp1/rkisp1.cpp
>>> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘void libcamera::RkISP1CameraData::queueFrameAction(unsigned int, const libcamera::IPAOperationData&)’:
>>> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33: error: ‘make_unique’ is not a member of ‘std’
>>> timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
>>> ^~~~~~~~~~~
>>> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
>>> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:34:1:
>>> +#include <memory>
>>>
>>> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33:
>>> timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
>>> ^~~~~~~~~~~
>>> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:66: error: expected primary-expression before ‘>’ token
>>> timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
>>> ^
>>> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:392:12: error: left operand of comma operator has no effect [-Werror=unused-value]
>>> sensor_,
>>> ^~~~~~~
>>> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:392:12: error: right operand of comma operator has no effect [-Werror=unused-value]
>>> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘virtual int libcamera::PipelineHandlerRkISP1::queueRequestDevice(libcamera::Camera*, libcamera::Request*)’:
>>> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:38: error: ‘make_unique’ is not a member of ‘std’
>>> data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
>>> ^~~~~~~~~~~
>>> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:38: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
>>> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:74: error: expected primary-expression before ‘>’ token
>>> data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
>>> ^
>>> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:82: error: left operand of comma operator has no effect [-Werror=unused-value]
>>> data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
>>> ~~~~~~^~~~~~
>>> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:851:13: error: right operand of comma operator has no effect [-Werror=unused-value]
>>> this));
>>> ^~~~
>>> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘int libcamera::PipelineHandlerRkISP1::createCamera(libcamera::MediaEntity*)’:
>>> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:8: error: ‘make_unique’ is not a member of ‘std’
>>> std::make_unique<RkISP1CameraData>(this);
>>> ^~~~~~~~~~~
>>> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:8: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
>>> ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:36: error: expected primary-expression before ‘>’ token
>>> std::make_unique<RkISP1CameraData>(this);
>>> ^
>>> cc1plus: all warnings being treated as errors
>>> ninja: build stopped: subcommand failed.
>>> Build step 'Execute shell' marked build as failure
>
> I added a clean step, just to be sure, e. g. the current build script is:
>
> ninja -C build clean
> meson build -Dandroid=true
> ninja -C build
>
> But it still produces errors when trying to build.
Thanks, in this instance I believe it's the (re)configure (not just a
clean) that needs to happen because of a change in toolchain parameters.
Perhaps in the future Meson will detect this is required and reconfigure
itself automatically, but that is not happening in this case.
The command line used to build the objects shows the old compiler flags
(-std=c++11) instead of (-std=c++14)
The output above mentions the following:
>>>> Just run your build command (e.g. ninja) and Meson will regenerate as necessary.
>>>> If ninja fails, run "ninja reconfigure" or "meson --reconfigure"
>>>> to force Meson to regenerate.
So perhaps we should just add a meson --reconfigure to the start of the
script?
Thanks again.
--
Regards
--
Kieran
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: Build failed in Jenkins: libcamera #72
2020-01-21 13:46 ` Mauro Carvalho Chehab
@ 2020-01-21 13:48 ` Kieran Bingham
0 siblings, 0 replies; 18+ messages in thread
From: Kieran Bingham @ 2020-01-21 13:48 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Jenkins Builder Robot, linux-media, LibCamera Devel
Hi Mauro,
On 21/01/2020 13:46, Mauro Carvalho Chehab wrote:
> Em Tue, 21 Jan 2020 14:12:46 +0100
> Mauro Carvalho Chehab <mchehab@kernel.org> escreveu:
>
>> But it still produces errors when trying to build.
>
> Changed the recipe to:
>
> meson setup --wipe build
> meson configure build
> ninja -C build
>
> This way, it should wipe the build information every time, and display the
> config it will use for the build.
>
> Job is succeeding with the above.
Aha, excellent :-D
> Cheers,
> Mauro
>
--
Regards
--
Kieran
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [libcamera-devel] Build failed in Jenkins: libcamera #72
2020-01-21 13:12 ` Mauro Carvalho Chehab
2020-01-21 13:46 ` Mauro Carvalho Chehab
2020-01-21 13:47 ` Kieran Bingham
@ 2020-01-21 13:51 ` Laurent Pinchart
2020-01-21 13:54 ` Laurent Pinchart
2020-01-21 14:28 ` Mauro Carvalho Chehab
2 siblings, 2 replies; 18+ messages in thread
From: Laurent Pinchart @ 2020-01-21 13:51 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Kieran Bingham, LibCamera Devel, Jenkins Builder Robot, linux-media
Hi Mauro,
On Tue, Jan 21, 2020 at 02:12:46PM +0100, Mauro Carvalho Chehab wrote:
> Em Sun, 19 Jan 2020 21:16:31 +0000 Kieran Bingham escreveu:
> > Hi Mauro,
> >
> > It looks like the Jenkins jobs for Libcamera are failing continuously.
> >
> > I believe it looks like the jobs reuse an existing build configuration,
> > and that doesn't get reconfigured if we change the top level meson.build
> > or such.
> >
> > In particular, here we have changed to C++14, and the build should
> > certainly be done from clean, as compiler flags should be updated.
> >
> > As a side note, is it possible (or desirable?) to cc
> > <libcamera-devel@lists.libcamera.org> on these failures to make sure we
> > see them?
> >
> > On 15/01/2020 00:03, Jenkins Builder Robot wrote:
> > > See <https://builder.linuxtv.org/job/libcamera/72/display/redirect?page=changes>
> > >
> > > Changes:
> > >
> > > [laurent.pinchart] meson.build: Switch to C++14
> > >
> > > [laurent.pinchart] libcamera: Switch from utils::make_unique to std::make_unique
> > >
> > >
> > > ------------------------------------------
> > > Started by an SCM change
> > > Running as SYSTEM
> > > Building remotely on slave1 in workspace <https://builder.linuxtv.org/job/libcamera/ws/>
> > > No credentials specified
> > > > git rev-parse --is-inside-work-tree # timeout=10
> > > Fetching changes from the remote Git repository
> > > > git config remote.origin.url git://linuxtv.org/libcamera.git # timeout=10
> > > Fetching upstream changes from git://linuxtv.org/libcamera.git
> > > > git --version # timeout=10
> > > > git fetch --tags --force --progress -- git://linuxtv.org/libcamera.git +refs/heads/*:refs/remotes/origin/* # timeout=10
> > > > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
> > > > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
> > > Checking out Revision acf18e4265dec2991e62f7c8baecfacf1a6708b3 (refs/remotes/origin/master)
> > > > git config core.sparsecheckout # timeout=10
> > > > git checkout -f acf18e4265dec2991e62f7c8baecfacf1a6708b3 # timeout=10
> > > Commit message: "libcamera: Switch from utils::make_unique to std::make_unique"
> > > > git rev-list --no-walk 055335bf49dbcb8c149bdcd4e96004c68e6b6ece # timeout=10
> > > [libcamera] $ /bin/sh -xe /tmp/jenkins2777310540601637282.sh
> > > + meson build -Dandroid=true
> > > Directory already configured.
> >
> > ^^ This implies the previous build is being re-used.
> >
> > Perhaps for a CI job, would it make more sense to do from-scratch clean
> > configure and rebuilds?
> >
> > It would be nice if meson always knew when to reconfigure, but I'm not
> > sure how to make sure that always happens :-D
> >
> > > Just run your build command (e.g. ninja) and Meson will regenerate as necessary.
> > > If ninja fails, run "ninja reconfigure" or "meson --reconfigure"
> > > to force Meson to regenerate.
> > >
> > > If build failures persist, run "meson setup --wipe" to rebuild from scratch
> > > using the same options as passed when configuring the build.
> > > To change option values, run "meson configure" instead.
> > > + cd build
> > > + ninja
> > > [0/1] Regenerating build files.
> > > The Meson build system
> > > Version: 0.49.2
> > > Source dir: <https://builder.linuxtv.org/job/libcamera/ws/>
> > > Build dir: <https://builder.linuxtv.org/job/libcamera/ws/build>
> > > Build type: native build
> > > Project name: libcamera
> > > Project version: 0.0.0
> > > Native C compiler: ccache cc (gcc 8.3.0 "cc (Debian 8.3.0-6) 8.3.0")
> > > Native C++ compiler: ccache c++ (gcc 8.3.0 "c++ (Debian 8.3.0-6) 8.3.0")
> > > Build machine cpu family: x86_64
> > > Build machine cpu: x86_64
> > > Header <execinfo.h> has symbol "backtrace" : YES
> > > Header <stdlib.h> has symbol "secure_getenv" : YES
> > > Configuring version.h using configuration
> > > Dependency libudev found: YES (cached)
> > > Library atomic found: YES
> > > Library dl found: YES
> > > Dependency threads found: YES (cached)
> > > WARNING: rcc dependencies will not work reliably until this upstream issue is fixed: https://bugreports.qt.io/browse/QTBUG-45460
> > > Dependency qt5 found: YES (cached)
> > > Detecting Qt5 tools
> > > moc: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/moc, 5.11.3)
> > > uic: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/uic, 5.11.3)
> > > rcc: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/rcc, 5.11.3)
> > > lrelease: NO
> > > Program doxygen found: YES (/usr/bin/doxygen)
> > > Configuring Doxyfile using configuration
> > > Program sphinx-build-3 found: NO
> > > Program sphinx-build found: YES (/usr/bin/sphinx-build)
> > > Configuring config.h using configuration
> > > Build targets in project: 68
> > > Option werror is: True [default: true]
> > > Option cpp_std is: c++11 [default: c++14]
> > > Found ninja-1.8.2 at /usr/bin/ninja
> > > [1/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/buffer.cpp.o'.
> > > [2/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/message.cpp.o'.
> > > [3/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/object.cpp.o'.
> > > [4/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/media_object.cpp.o'.
> > > [5/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/process.cpp.o'.
> > > [6/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o'.
> > > FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o
> > > ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o' -c ../src/libcamera/pipeline/vimc.cpp
> > > ../src/libcamera/pipeline/vimc.cpp: In member function ‘virtual bool libcamera::PipelineHandlerVimc::match(libcamera::DeviceEnumerator*)’:
> > > ../src/libcamera/pipeline/vimc.cpp:368:46: error: ‘make_unique’ is not a member of ‘std’
> > > std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
> > > ^~~~~~~~~~~
> > > ../src/libcamera/pipeline/vimc.cpp:368:46: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > > ../src/libcamera/pipeline/vimc.cpp:34:1:
> > > +#include <memory>
> > >
> > > ../src/libcamera/pipeline/vimc.cpp:368:46:
> > > std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
> > > ^~~~~~~~~~~
> > > ../src/libcamera/pipeline/vimc.cpp:368:72: error: expected primary-expression before ‘>’ token
> > > std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
> > > ^
> > > [7/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/framebuffer_allocator.cpp.o'.
> > > [8/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o'.
> > > FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o
> > > ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o' -c ../src/libcamera/pipeline/ipu3/ipu3.cpp
> > > ../src/libcamera/pipeline/ipu3/ipu3.cpp: In member function ‘int libcamera::PipelineHandlerIPU3::registerCameras()’:
> > > ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9: error: ‘make_unique’ is not a member of ‘std’
> > > std::make_unique<IPU3CameraData>(this);
> > > ^~~~~~~~~~~
> > > ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > > ../src/libcamera/pipeline/ipu3/ipu3.cpp:29:1:
> > > +#include <memory>
> > >
> > > ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9:
> > > std::make_unique<IPU3CameraData>(this);
> > > ^~~~~~~~~~~
> > > ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:35: error: expected primary-expression before ‘>’ token
> > > std::make_unique<IPU3CameraData>(this);
> > > ^
> > > [9/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/request.cpp.o'.
> > > [10/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_timeline.cpp.o'.
> > > [11/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_handler.cpp.o'.
> > > [12/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o'.
> > > FAILED: src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o
> > > ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o' -c ../src/libcamera/proxy/ipa_proxy_linux.cpp
> > > In file included from ../src/libcamera/proxy/ipa_proxy_linux.cpp:14:
> > > ../src/libcamera/proxy/ipa_proxy_linux.cpp: In member function ‘virtual std::unique_ptr<libcamera::IPAProxy> libcamera::IPAProxyLinuxFactory::create(libcamera::IPAModule*)’:
> > > ../src/libcamera/include/ipa_proxy.h:58:15: error: ‘make_unique’ is not a member of ‘std’
> > > return std::make_unique<proxy>(ipam); \
> > > ^~~~~~~~~~~
> > > ../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
> > > REGISTER_IPA_PROXY(IPAProxyLinux)
> > > ^~~~~~~~~~~~~~~~~~
> > > ../src/libcamera/include/ipa_proxy.h:58:15: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > > return std::make_unique<proxy>(ipam); \
> > > ^~~~~~~~~~~
> > > ../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
> > > REGISTER_IPA_PROXY(IPAProxyLinux)
> > > ^~~~~~~~~~~~~~~~~~
> > > ../src/libcamera/include/ipa_proxy.h:58:32: error: expected primary-expression before ‘>’ token
> > > return std::make_unique<proxy>(ipam); \
> > > ^
> > > ../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
> > > REGISTER_IPA_PROXY(IPAProxyLinux)
> > > ^~~~~~~~~~~~~~~~~~
> > > [13/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/.._android_camera3_hal.cpp.o'.
> > > [14/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/device_enumerator_udev.cpp.o'.
> > > [15/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o'.
> > > FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o
> > > ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o' -c ../src/libcamera/pipeline/rkisp1/rkisp1.cpp
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘void libcamera::RkISP1CameraData::queueFrameAction(unsigned int, const libcamera::IPAOperationData&)’:
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33: error: ‘make_unique’ is not a member of ‘std’
> > > timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
> > > ^~~~~~~~~~~
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:34:1:
> > > +#include <memory>
> > >
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33:
> > > timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
> > > ^~~~~~~~~~~
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:66: error: expected primary-expression before ‘>’ token
> > > timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
> > > ^
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:392:12: error: left operand of comma operator has no effect [-Werror=unused-value]
> > > sensor_,
> > > ^~~~~~~
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:392:12: error: right operand of comma operator has no effect [-Werror=unused-value]
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘virtual int libcamera::PipelineHandlerRkISP1::queueRequestDevice(libcamera::Camera*, libcamera::Request*)’:
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:38: error: ‘make_unique’ is not a member of ‘std’
> > > data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
> > > ^~~~~~~~~~~
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:38: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:74: error: expected primary-expression before ‘>’ token
> > > data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
> > > ^
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:82: error: left operand of comma operator has no effect [-Werror=unused-value]
> > > data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
> > > ~~~~~~^~~~~~
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:851:13: error: right operand of comma operator has no effect [-Werror=unused-value]
> > > this));
> > > ^~~~
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘int libcamera::PipelineHandlerRkISP1::createCamera(libcamera::MediaEntity*)’:
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:8: error: ‘make_unique’ is not a member of ‘std’
> > > std::make_unique<RkISP1CameraData>(this);
> > > ^~~~~~~~~~~
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:8: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:36: error: expected primary-expression before ‘>’ token
> > > std::make_unique<RkISP1CameraData>(this);
> > > ^
> > > cc1plus: all warnings being treated as errors
> > > ninja: build stopped: subcommand failed.
> > > Build step 'Execute shell' marked build as failure
>
> I added a clean step, just to be sure, e. g. the current build script is:
>
> ninja -C build clean
> meson build -Dandroid=true
> ninja -C build
The recommended steps are
meson -Dandroid=true build
ninja -C build clean
ninja -C build
This will ensure the build directory is created if it doesn't exist
before trying to run ninja in it. However, the meson step will will be a
no-op in case the directory exists. If you want to change options for an
existing build directory, you have to run
meson --reconfigure -Dandroid=true build
This will fail if the build directory doesn't exist. The following
script should work in all cases.
options="-Dandroid=true"
if [[ -d build ]] ; then
meson --reconfigure $options build
else
meson $options build
fi
ninja -C build clean
ninja -C build
> But it still produces errors when trying to build.
Clean is a good idea, but won't be enough when core configuration
options of the project change I'm afraid :-( We need to wipe out the
build directory completely, or run
meson configure -Dcpp_std=c++14 build
However, the only configuration option that requires such an operation
to prevent breakages is cpp_std, and we don't envision switching to
C++17 very soon. Even if we did, that would be a one time change, as
there's no other published C++ version after that :-)
Could you handle this manually to fix the build ? No further action
should be needed after that.
While at it, could you also set -Dv4l2=true to compile-test the V4L2
compatibility layer ?
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [libcamera-devel] Build failed in Jenkins: libcamera #72
2020-01-21 13:51 ` [libcamera-devel] " Laurent Pinchart
@ 2020-01-21 13:54 ` Laurent Pinchart
2020-01-21 14:28 ` Mauro Carvalho Chehab
1 sibling, 0 replies; 18+ messages in thread
From: Laurent Pinchart @ 2020-01-21 13:54 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Kieran Bingham, LibCamera Devel, Jenkins Builder Robot, linux-media
Hi Mauro,
On Tue, Jan 21, 2020 at 03:51:49PM +0200, Laurent Pinchart wrote:
> On Tue, Jan 21, 2020 at 02:12:46PM +0100, Mauro Carvalho Chehab wrote:
> > Em Sun, 19 Jan 2020 21:16:31 +0000 Kieran Bingham escreveu:
> > > Hi Mauro,
> > >
> > > It looks like the Jenkins jobs for Libcamera are failing continuously.
> > >
> > > I believe it looks like the jobs reuse an existing build configuration,
> > > and that doesn't get reconfigured if we change the top level meson.build
> > > or such.
> > >
> > > In particular, here we have changed to C++14, and the build should
> > > certainly be done from clean, as compiler flags should be updated.
> > >
> > > As a side note, is it possible (or desirable?) to cc
> > > <libcamera-devel@lists.libcamera.org> on these failures to make sure we
> > > see them?
> > >
> > > On 15/01/2020 00:03, Jenkins Builder Robot wrote:
> > > > See <https://builder.linuxtv.org/job/libcamera/72/display/redirect?page=changes>
> > > >
> > > > Changes:
> > > >
> > > > [laurent.pinchart] meson.build: Switch to C++14
> > > >
> > > > [laurent.pinchart] libcamera: Switch from utils::make_unique to std::make_unique
> > > >
> > > >
> > > > ------------------------------------------
> > > > Started by an SCM change
> > > > Running as SYSTEM
> > > > Building remotely on slave1 in workspace <https://builder.linuxtv.org/job/libcamera/ws/>
> > > > No credentials specified
> > > > > git rev-parse --is-inside-work-tree # timeout=10
> > > > Fetching changes from the remote Git repository
> > > > > git config remote.origin.url git://linuxtv.org/libcamera.git # timeout=10
> > > > Fetching upstream changes from git://linuxtv.org/libcamera.git
> > > > > git --version # timeout=10
> > > > > git fetch --tags --force --progress -- git://linuxtv.org/libcamera.git +refs/heads/*:refs/remotes/origin/* # timeout=10
> > > > > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
> > > > > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
> > > > Checking out Revision acf18e4265dec2991e62f7c8baecfacf1a6708b3 (refs/remotes/origin/master)
> > > > > git config core.sparsecheckout # timeout=10
> > > > > git checkout -f acf18e4265dec2991e62f7c8baecfacf1a6708b3 # timeout=10
> > > > Commit message: "libcamera: Switch from utils::make_unique to std::make_unique"
> > > > > git rev-list --no-walk 055335bf49dbcb8c149bdcd4e96004c68e6b6ece # timeout=10
> > > > [libcamera] $ /bin/sh -xe /tmp/jenkins2777310540601637282.sh
> > > > + meson build -Dandroid=true
> > > > Directory already configured.
> > >
> > > ^^ This implies the previous build is being re-used.
> > >
> > > Perhaps for a CI job, would it make more sense to do from-scratch clean
> > > configure and rebuilds?
> > >
> > > It would be nice if meson always knew when to reconfigure, but I'm not
> > > sure how to make sure that always happens :-D
> > >
> > > > Just run your build command (e.g. ninja) and Meson will regenerate as necessary.
> > > > If ninja fails, run "ninja reconfigure" or "meson --reconfigure"
> > > > to force Meson to regenerate.
> > > >
> > > > If build failures persist, run "meson setup --wipe" to rebuild from scratch
> > > > using the same options as passed when configuring the build.
> > > > To change option values, run "meson configure" instead.
> > > > + cd build
> > > > + ninja
> > > > [0/1] Regenerating build files.
> > > > The Meson build system
> > > > Version: 0.49.2
> > > > Source dir: <https://builder.linuxtv.org/job/libcamera/ws/>
> > > > Build dir: <https://builder.linuxtv.org/job/libcamera/ws/build>
> > > > Build type: native build
> > > > Project name: libcamera
> > > > Project version: 0.0.0
> > > > Native C compiler: ccache cc (gcc 8.3.0 "cc (Debian 8.3.0-6) 8.3.0")
> > > > Native C++ compiler: ccache c++ (gcc 8.3.0 "c++ (Debian 8.3.0-6) 8.3.0")
> > > > Build machine cpu family: x86_64
> > > > Build machine cpu: x86_64
> > > > Header <execinfo.h> has symbol "backtrace" : YES
> > > > Header <stdlib.h> has symbol "secure_getenv" : YES
> > > > Configuring version.h using configuration
> > > > Dependency libudev found: YES (cached)
> > > > Library atomic found: YES
> > > > Library dl found: YES
> > > > Dependency threads found: YES (cached)
> > > > WARNING: rcc dependencies will not work reliably until this upstream issue is fixed: https://bugreports.qt.io/browse/QTBUG-45460
> > > > Dependency qt5 found: YES (cached)
> > > > Detecting Qt5 tools
> > > > moc: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/moc, 5.11.3)
> > > > uic: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/uic, 5.11.3)
> > > > rcc: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/rcc, 5.11.3)
> > > > lrelease: NO
> > > > Program doxygen found: YES (/usr/bin/doxygen)
> > > > Configuring Doxyfile using configuration
> > > > Program sphinx-build-3 found: NO
> > > > Program sphinx-build found: YES (/usr/bin/sphinx-build)
> > > > Configuring config.h using configuration
> > > > Build targets in project: 68
> > > > Option werror is: True [default: true]
> > > > Option cpp_std is: c++11 [default: c++14]
> > > > Found ninja-1.8.2 at /usr/bin/ninja
> > > > [1/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/buffer.cpp.o'.
> > > > [2/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/message.cpp.o'.
> > > > [3/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/object.cpp.o'.
> > > > [4/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/media_object.cpp.o'.
> > > > [5/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/process.cpp.o'.
> > > > [6/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o'.
> > > > FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o
> > > > ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_vimc.cpp.o' -c ../src/libcamera/pipeline/vimc.cpp
> > > > ../src/libcamera/pipeline/vimc.cpp: In member function ‘virtual bool libcamera::PipelineHandlerVimc::match(libcamera::DeviceEnumerator*)’:
> > > > ../src/libcamera/pipeline/vimc.cpp:368:46: error: ‘make_unique’ is not a member of ‘std’
> > > > std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
> > > > ^~~~~~~~~~~
> > > > ../src/libcamera/pipeline/vimc.cpp:368:46: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > > > ../src/libcamera/pipeline/vimc.cpp:34:1:
> > > > +#include <memory>
> > > >
> > > > ../src/libcamera/pipeline/vimc.cpp:368:46:
> > > > std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
> > > > ^~~~~~~~~~~
> > > > ../src/libcamera/pipeline/vimc.cpp:368:72: error: expected primary-expression before ‘>’ token
> > > > std::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);
> > > > ^
> > > > [7/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/framebuffer_allocator.cpp.o'.
> > > > [8/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o'.
> > > > FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o
> > > > ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_ipu3_ipu3.cpp.o' -c ../src/libcamera/pipeline/ipu3/ipu3.cpp
> > > > ../src/libcamera/pipeline/ipu3/ipu3.cpp: In member function ‘int libcamera::PipelineHandlerIPU3::registerCameras()’:
> > > > ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9: error: ‘make_unique’ is not a member of ‘std’
> > > > std::make_unique<IPU3CameraData>(this);
> > > > ^~~~~~~~~~~
> > > > ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > > > ../src/libcamera/pipeline/ipu3/ipu3.cpp:29:1:
> > > > +#include <memory>
> > > >
> > > > ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:9:
> > > > std::make_unique<IPU3CameraData>(this);
> > > > ^~~~~~~~~~~
> > > > ../src/libcamera/pipeline/ipu3/ipu3.cpp:879:35: error: expected primary-expression before ‘>’ token
> > > > std::make_unique<IPU3CameraData>(this);
> > > > ^
> > > > [9/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/request.cpp.o'.
> > > > [10/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_timeline.cpp.o'.
> > > > [11/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_handler.cpp.o'.
> > > > [12/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o'.
> > > > FAILED: src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o
> > > > ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/proxy_ipa_proxy_linux.cpp.o' -c ../src/libcamera/proxy/ipa_proxy_linux.cpp
> > > > In file included from ../src/libcamera/proxy/ipa_proxy_linux.cpp:14:
> > > > ../src/libcamera/proxy/ipa_proxy_linux.cpp: In member function ‘virtual std::unique_ptr<libcamera::IPAProxy> libcamera::IPAProxyLinuxFactory::create(libcamera::IPAModule*)’:
> > > > ../src/libcamera/include/ipa_proxy.h:58:15: error: ‘make_unique’ is not a member of ‘std’
> > > > return std::make_unique<proxy>(ipam); \
> > > > ^~~~~~~~~~~
> > > > ../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
> > > > REGISTER_IPA_PROXY(IPAProxyLinux)
> > > > ^~~~~~~~~~~~~~~~~~
> > > > ../src/libcamera/include/ipa_proxy.h:58:15: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > > > return std::make_unique<proxy>(ipam); \
> > > > ^~~~~~~~~~~
> > > > ../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
> > > > REGISTER_IPA_PROXY(IPAProxyLinux)
> > > > ^~~~~~~~~~~~~~~~~~
> > > > ../src/libcamera/include/ipa_proxy.h:58:32: error: expected primary-expression before ‘>’ token
> > > > return std::make_unique<proxy>(ipam); \
> > > > ^
> > > > ../src/libcamera/proxy/ipa_proxy_linux.cpp:93:1: note: in expansion of macro ‘REGISTER_IPA_PROXY’
> > > > REGISTER_IPA_PROXY(IPAProxyLinux)
> > > > ^~~~~~~~~~~~~~~~~~
> > > > [13/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/.._android_camera3_hal.cpp.o'.
> > > > [14/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/device_enumerator_udev.cpp.o'.
> > > > [15/144] Compiling C++ object 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o'.
> > > > FAILED: src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o
> > > > ccache c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -I../include/android/hardware/libhardware/include/ -I../include/android/metadata/ -I../include/android/system/core/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++11 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/pipeline_rkisp1_rkisp1.cpp.o' -c ../src/libcamera/pipeline/rkisp1/rkisp1.cpp
> > > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘void libcamera::RkISP1CameraData::queueFrameAction(unsigned int, const libcamera::IPAOperationData&)’:
> > > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33: error: ‘make_unique’ is not a member of ‘std’
> > > > timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
> > > > ^~~~~~~~~~~
> > > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:34:1:
> > > > +#include <memory>
> > > >
> > > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:33:
> > > > timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
> > > > ^~~~~~~~~~~
> > > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:391:66: error: expected primary-expression before ‘>’ token
> > > > timeline_.scheduleAction(std::make_unique<RkISP1ActionSetSensor>(frame,
> > > > ^
> > > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:392:12: error: left operand of comma operator has no effect [-Werror=unused-value]
> > > > sensor_,
> > > > ^~~~~~~
> > > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:392:12: error: right operand of comma operator has no effect [-Werror=unused-value]
> > > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘virtual int libcamera::PipelineHandlerRkISP1::queueRequestDevice(libcamera::Camera*, libcamera::Request*)’:
> > > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:38: error: ‘make_unique’ is not a member of ‘std’
> > > > data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
> > > > ^~~~~~~~~~~
> > > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:38: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:74: error: expected primary-expression before ‘>’ token
> > > > data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
> > > > ^
> > > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:849:82: error: left operand of comma operator has no effect [-Werror=unused-value]
> > > > data->timeline_.scheduleAction(std::make_unique<RkISP1ActionQueueBuffers>(data->frame_,
> > > > ~~~~~~^~~~~~
> > > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:851:13: error: right operand of comma operator has no effect [-Werror=unused-value]
> > > > this));
> > > > ^~~~
> > > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp: In member function ‘int libcamera::PipelineHandlerRkISP1::createCamera(libcamera::MediaEntity*)’:
> > > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:8: error: ‘make_unique’ is not a member of ‘std’
> > > > std::make_unique<RkISP1CameraData>(this);
> > > > ^~~~~~~~~~~
> > > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:8: note: ‘std::make_unique’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
> > > > ../src/libcamera/pipeline/rkisp1/rkisp1.cpp:895:36: error: expected primary-expression before ‘>’ token
> > > > std::make_unique<RkISP1CameraData>(this);
> > > > ^
> > > > cc1plus: all warnings being treated as errors
> > > > ninja: build stopped: subcommand failed.
> > > > Build step 'Execute shell' marked build as failure
> >
> > I added a clean step, just to be sure, e. g. the current build script is:
> >
> > ninja -C build clean
> > meson build -Dandroid=true
> > ninja -C build
>
> The recommended steps are
>
> meson -Dandroid=true build
> ninja -C build clean
> ninja -C build
>
> This will ensure the build directory is created if it doesn't exist
> before trying to run ninja in it. However, the meson step will will be a
> no-op in case the directory exists. If you want to change options for an
> existing build directory, you have to run
>
> meson --reconfigure -Dandroid=true build
>
> This will fail if the build directory doesn't exist. The following
> script should work in all cases.
>
> options="-Dandroid=true"
>
> if [[ -d build ]] ; then
> meson --reconfigure $options build
> else
> meson $options build
> fi
>
> ninja -C build clean
> ninja -C build
It looks like you've solved this by wiping the build directory every
time. As you run ninja clean anyway, your solution won't incur much
extra cost and is simpler, so please ignore mine.
> > But it still produces errors when trying to build.
>
> Clean is a good idea, but won't be enough when core configuration
> options of the project change I'm afraid :-( We need to wipe out the
> build directory completely, or run
>
> meson configure -Dcpp_std=c++14 build
>
> However, the only configuration option that requires such an operation
> to prevent breakages is cpp_std, and we don't envision switching to
> C++17 very soon. Even if we did, that would be a one time change, as
> there's no other published C++ version after that :-)
>
> Could you handle this manually to fix the build ? No further action
> should be needed after that.
>
> While at it, could you also set -Dv4l2=true to compile-test the V4L2
> compatibility layer ?
This should however still be added.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: Build failed in Jenkins: libcamera #72
2020-01-21 13:47 ` Kieran Bingham
@ 2020-01-21 14:22 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 18+ messages in thread
From: Mauro Carvalho Chehab @ 2020-01-21 14:22 UTC (permalink / raw)
To: Kieran Bingham; +Cc: Jenkins Builder Robot, linux-media, LibCamera Devel
Em Tue, 21 Jan 2020 13:47:07 +0000
Kieran Bingham <kieran.bingham@ideasonboard.com> escreveu:
> So perhaps we should just add a meson --reconfigure to the start of the
> script?
I tried that, but it doesn't work. Wiping the config seems to be the only
sane way for this to work.
Cheers,
Mauro
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [libcamera-devel] Build failed in Jenkins: libcamera #72
2020-01-21 13:51 ` [libcamera-devel] " Laurent Pinchart
2020-01-21 13:54 ` Laurent Pinchart
@ 2020-01-21 14:28 ` Mauro Carvalho Chehab
1 sibling, 0 replies; 18+ messages in thread
From: Mauro Carvalho Chehab @ 2020-01-21 14:28 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Kieran Bingham, LibCamera Devel, Jenkins Builder Robot, linux-media
Em Tue, 21 Jan 2020 15:51:49 +0200
Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu:
> > I added a clean step, just to be sure, e. g. the current build script is:
> >
> > ninja -C build clean
> > meson build -Dandroid=true
> > ninja -C build
>
> The recommended steps are
>
> meson -Dandroid=true build
> ninja -C build clean
> ninja -C build
>
> This will ensure the build directory is created if it doesn't exist
> before trying to run ninja in it. However, the meson step will will be a
> no-op in case the directory exists. If you want to change options for an
> existing build directory, you have to run
>
> meson --reconfigure -Dandroid=true build
I tried it. Didn't work: it keeps preserving c++11 instead of using c++17.
>
> This will fail if the build directory doesn't exist. The following
> script should work in all cases.
>
> options="-Dandroid=true"
>
> if [[ -d build ]] ; then
> meson --reconfigure $options build
> else
> meson $options build
> fi
>
> ninja -C build clean
> ninja -C build
>
> > But it still produces errors when trying to build.
>
> Clean is a good idea, but won't be enough when core configuration
> options of the project change I'm afraid :-( We need to wipe out the
> build directory completely, or run
>
> meson configure -Dcpp_std=c++14 build
I prefer not doing that. As you're saying below, if the build changes
default to some later version, build will break again.
>
> However, the only configuration option that requires such an operation
> to prevent breakages is cpp_std, and we don't envision switching to
> C++17 very soon. Even if we did, that would be a one time change, as
> there's no other published C++ version after that :-)
>
> Could you handle this manually to fix the build ? No further action
> should be needed after that.
>
> While at it, could you also set -Dv4l2=true to compile-test the V4L2
> compatibility layer ?
After doing a 'mason setup --wipe', v4l2=true is automatically set. Anyway,
I added an option that will display the configuration. This way, someone can
check that all options that should be enabled are there.
Cheers,
Mauro
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2020-01-21 14:28 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-15 0:03 Build failed in Jenkins: libcamera #72 Jenkins Builder Robot
2020-01-16 17:48 ` Build failed in Jenkins: libcamera #73 Jenkins Builder Robot
2020-01-16 23:33 ` Build failed in Jenkins: libcamera #74 Jenkins Builder Robot
2020-01-16 23:48 ` Build failed in Jenkins: libcamera #75 Jenkins Builder Robot
2020-01-18 20:48 ` Build failed in Jenkins: libcamera #76 Jenkins Builder Robot
2020-01-20 17:03 ` Build failed in Jenkins: libcamera #77 Jenkins Builder Robot
2020-01-21 13:26 ` Build failed in Jenkins: libcamera #78 Jenkins Builder Robot
2020-01-21 13:38 ` Jenkins build is back to normal : libcamera #79 Jenkins Builder Robot
2020-01-19 21:16 ` Build failed in Jenkins: libcamera #72 Kieran Bingham
2020-01-21 13:12 ` Mauro Carvalho Chehab
2020-01-21 13:46 ` Mauro Carvalho Chehab
2020-01-21 13:48 ` Kieran Bingham
2020-01-21 13:47 ` Kieran Bingham
2020-01-21 14:22 ` Mauro Carvalho Chehab
2020-01-21 13:51 ` [libcamera-devel] " Laurent Pinchart
2020-01-21 13:54 ` Laurent Pinchart
2020-01-21 14:28 ` Mauro Carvalho Chehab
2020-01-21 13:14 ` Mauro Carvalho Chehab
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.