* [PATCH] of: irq: Export of_msi_get_domain
@ 2020-01-22 10:47 Peter Ujfalusi
2020-01-22 11:03 ` Matthias Brugger
0 siblings, 1 reply; 5+ messages in thread
From: Peter Ujfalusi @ 2020-01-22 10:47 UTC (permalink / raw)
To: robh+dt, frowand.list; +Cc: devicetree, linux-kernel, mbrugger
From: Matthias Brugger <matthias.bgg@gmail.com>
Export of_mis_get_domain to enable it for users from outside.
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
Hi Rob, Matthias,
I needed to resort to remove module build support for the new ringacc UDMA
drivers (now they are in next-20200122) due to the fact that of_msi_get_domain()
is not having the EXPORT_SYMBOL_GPL() which is used by both drivers.
I have found this old patch in lkml, but can not see the history of why it is
not applied.
Regards,
Peter
drivers/of/irq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index a296eaf52a5b..73017506ef00 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -673,6 +673,7 @@ struct irq_domain *of_msi_get_domain(struct device *dev,
return NULL;
}
+EXPORT_SYMBOL_GPL(of_msi_get_domain);
/**
* of_msi_configure - Set the msi_domain field of a device
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] of: irq: Export of_msi_get_domain
2020-01-22 10:47 [PATCH] of: irq: Export of_msi_get_domain Peter Ujfalusi
@ 2020-01-22 11:03 ` Matthias Brugger
0 siblings, 0 replies; 5+ messages in thread
From: Matthias Brugger @ 2020-01-22 11:03 UTC (permalink / raw)
To: Peter Ujfalusi, robh+dt, frowand.list; +Cc: devicetree, linux-kernel
On 22/01/2020 11:47, Peter Ujfalusi wrote:
> From: Matthias Brugger <matthias.bgg@gmail.com>
>
> Export of_mis_get_domain to enable it for users from outside.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> Hi Rob, Matthias,
>
> I needed to resort to remove module build support for the new ringacc UDMA
> drivers (now they are in next-20200122) due to the fact that of_msi_get_domain()
> is not having the EXPORT_SYMBOL_GPL() which is used by both drivers.
>
> I have found this old patch in lkml, but can not see the history of why it is
> not applied.
The series it was part of was abandoned. The itself shouldn't have an issue.
Regards,
Matthias
>
> Regards,
> Peter
>
> drivers/of/irq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/of/irq.c b/drivers/of/irq.c
> index a296eaf52a5b..73017506ef00 100644
> --- a/drivers/of/irq.c
> +++ b/drivers/of/irq.c
> @@ -673,6 +673,7 @@ struct irq_domain *of_msi_get_domain(struct device *dev,
>
> return NULL;
> }
> +EXPORT_SYMBOL_GPL(of_msi_get_domain);
>
> /**
> * of_msi_configure - Set the msi_domain field of a device
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] of: irq: Export of_msi_get_domain
2022-08-12 18:09 ` Rob Herring
@ 2022-08-16 17:40 ` Kevin Hilman
0 siblings, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2022-08-16 17:40 UTC (permalink / raw)
To: Rob Herring
Cc: Frank Rowand, devicetree, linux-kernel, Péter Ujfalusi,
Matthias Brugger, linux-omap
Rob Herring <robh+dt@kernel.org> writes:
> On Fri, Aug 12, 2022 at 11:44 AM Kevin Hilman <khilman@baylibre.com> wrote:
>>
>> From: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> Export of_mis_get_domain to enable it for users from outside.
>
> typo
>
>>
>> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>> Acked-by: Rob Herring <robh@kernel.org>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> Link: https://lore.kernel.org/r/20200122104723.16955-1-peter.ujfalusi@ti.com
>> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
>> ---
>> Peter tried to resurrect this in 2020 (c.f. Link tag in log) but it
>> didn't work. Here's one more attempt. I need this enable building
>> some TI DMA drivers as modules.
>
> Then apply this with that enabling. I've already acked it (which keeps
> it out of my queue, so drop that if you want to ensure I see it).
OK.
I assumed you'd want to take this through your tree, but if you're OK
with it getting merged with the series using it, I'll do that.
Thanks,
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] of: irq: Export of_msi_get_domain
2022-08-12 17:44 Kevin Hilman
@ 2022-08-12 18:09 ` Rob Herring
2022-08-16 17:40 ` Kevin Hilman
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2022-08-12 18:09 UTC (permalink / raw)
To: Kevin Hilman
Cc: Frank Rowand, devicetree, linux-kernel, Péter Ujfalusi,
Matthias Brugger, linux-omap
On Fri, Aug 12, 2022 at 11:44 AM Kevin Hilman <khilman@baylibre.com> wrote:
>
> From: Matthias Brugger <matthias.bgg@gmail.com>
>
> Export of_mis_get_domain to enable it for users from outside.
typo
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Link: https://lore.kernel.org/r/20200122104723.16955-1-peter.ujfalusi@ti.com
> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
> ---
> Peter tried to resurrect this in 2020 (c.f. Link tag in log) but it
> didn't work. Here's one more attempt. I need this enable building
> some TI DMA drivers as modules.
Then apply this with that enabling. I've already acked it (which keeps
it out of my queue, so drop that if you want to ensure I see it).
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] of: irq: Export of_msi_get_domain
@ 2022-08-12 17:44 Kevin Hilman
2022-08-12 18:09 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Kevin Hilman @ 2022-08-12 17:44 UTC (permalink / raw)
To: Rob Herring, Frank Rowand, devicetree
Cc: linux-kernel, Péter Ujfalusi, Matthias Brugger, linux-omap
From: Matthias Brugger <matthias.bgg@gmail.com>
Export of_mis_get_domain to enable it for users from outside.
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/20200122104723.16955-1-peter.ujfalusi@ti.com
Signed-off-by: Kevin Hilman <khilman@baylibre.com>
---
Peter tried to resurrect this in 2020 (c.f. Link tag in log) but it
didn't work. Here's one more attempt. I need this enable building
some TI DMA drivers as modules.
drivers/of/irq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index d22f605fa7ee..c9308baa32c5 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -727,6 +727,7 @@ struct irq_domain *of_msi_get_domain(struct device *dev,
return NULL;
}
+EXPORT_SYMBOL_GPL(of_msi_get_domain);
/**
* of_msi_configure - Set the msi_domain field of a device
--
2.34.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-16 17:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-22 10:47 [PATCH] of: irq: Export of_msi_get_domain Peter Ujfalusi
2020-01-22 11:03 ` Matthias Brugger
2022-08-12 17:44 Kevin Hilman
2022-08-12 18:09 ` Rob Herring
2022-08-16 17:40 ` Kevin Hilman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.