All of lore.kernel.org
 help / color / mirror / Atom feed
* [thud/zeus/master][PATCH] recipes-graphics: Add recipe for DevIL
@ 2020-01-22 17:36 Gowtham Tammana
  2020-01-28 23:45 ` Denys Dmytriyenko
  0 siblings, 1 reply; 7+ messages in thread
From: Gowtham Tammana @ 2020-01-22 17:36 UTC (permalink / raw)
  To: meta-arago, Denys Dmytriyenko; +Cc: vijayp

Developers Image Library (DevIL) is a cross-platfor image utility
library with simple syntax (openil.sourceforge.net). Adding recipe to
build from sources.

Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
---
 .../recipes-graphics/devil/devil_1.8.0.bb     | 30 +++++++++++++++++++
 .../devil/files/Remove-ILUT-dependency.patch  | 13 ++++++++
 2 files changed, 43 insertions(+)
 create mode 100644 meta-arago-extras/recipes-graphics/devil/devil_1.8.0.bb
 create mode 100644 meta-arago-extras/recipes-graphics/devil/files/Remove-ILUT-dependency.patch

diff --git a/meta-arago-extras/recipes-graphics/devil/devil_1.8.0.bb b/meta-arago-extras/recipes-graphics/devil/devil_1.8.0.bb
new file mode 100644
index 00000000..6ba7f34b
--- /dev/null
+++ b/meta-arago-extras/recipes-graphics/devil/devil_1.8.0.bb
@@ -0,0 +1,30 @@
+DESCRIPTION = "Developer's Image Library (DevIL) is a cross-platform image \
+               library utilizing simple syntax to load, save, convert, \
+               manipulate, filter and display a variety of images."
+HOMEPAGE = "https://github.com/DentonW/DevIL"
+LICENSE = "LGPLv2"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=fc178bcd425090939a8b634d1d6a9594"
+
+SRC_URI = "git://github.com/dentonw/devil.git;protocol=git;branch=master \
+           file://Remove-ILUT-dependency.patch"
+
+SRCREV = "e34284a7e07763769f671a74b4fec718174ad862"
+
+COMPATIBLE_MACHINE = "j7-evm"
+
+PR = "r1"
+S = "${WORKDIR}/git"
+
+# Build only DevIL
+OECMAKE_SOURCEPATH = "${S}/DevIL"
+
+PACKAGECONFIG ??= "png"
+PACKAGECONFIG[png] = "-DIL_NO_PNG=0,-DIL_NO_PNG=1,libpng,"
+
+DEPENDS += "libpng"
+
+inherit pkgconfig cmake
+
+INSANE_SKIP_${PN} += "file-rdeps dev-so"
+FILES_${PN} += "${libdir}/lib*${SOLIBSDEV}"
+FILES_SOLIBSDEV = ""
diff --git a/meta-arago-extras/recipes-graphics/devil/files/Remove-ILUT-dependency.patch b/meta-arago-extras/recipes-graphics/devil/files/Remove-ILUT-dependency.patch
new file mode 100644
index 00000000..4f0f9dfa
--- /dev/null
+++ b/meta-arago-extras/recipes-graphics/devil/files/Remove-ILUT-dependency.patch
@@ -0,0 +1,13 @@
+diff --git a/DevIL/CMakeLists.txt b/DevIL/CMakeLists.txt
+index e342f93d..fae40167 100644
+--- a/DevIL/CMakeLists.txt
++++ b/DevIL/CMakeLists.txt
+@@ -6,7 +6,7 @@ set (CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/Modules")
+ 
+ add_subdirectory(src-IL)
+ add_subdirectory(src-ILU)
+-add_subdirectory(src-ILUT)
++# add_subdirectory(src-ILUT)
+ option(IL_TESTS "build DevIL tests" ON)
+ if (IL_TESTS)
+     ENABLE_TESTING()
-- 
2.25.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [thud/zeus/master][PATCH] recipes-graphics: Add recipe for DevIL
  2020-01-22 17:36 [thud/zeus/master][PATCH] recipes-graphics: Add recipe for DevIL Gowtham Tammana
@ 2020-01-28 23:45 ` Denys Dmytriyenko
  2020-01-29 17:18   ` Tammana, Gowtham
  0 siblings, 1 reply; 7+ messages in thread
From: Denys Dmytriyenko @ 2020-01-28 23:45 UTC (permalink / raw)
  To: Gowtham Tammana; +Cc: meta-arago, vijayp

On Wed, Jan 22, 2020 at 11:36:26AM -0600, Gowtham Tammana wrote:
> Developers Image Library (DevIL) is a cross-platfor image utility
> library with simple syntax (openil.sourceforge.net). Adding recipe to
> build from sources.

Where is it coming from? I see there are many copies in other layers - is it 
based on something or completely done from scratch?


> Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
> ---
>  .../recipes-graphics/devil/devil_1.8.0.bb     | 30 +++++++++++++++++++
>  .../devil/files/Remove-ILUT-dependency.patch  | 13 ++++++++
>  2 files changed, 43 insertions(+)
>  create mode 100644 meta-arago-extras/recipes-graphics/devil/devil_1.8.0.bb
>  create mode 100644 meta-arago-extras/recipes-graphics/devil/files/Remove-ILUT-dependency.patch
> 
> diff --git a/meta-arago-extras/recipes-graphics/devil/devil_1.8.0.bb b/meta-arago-extras/recipes-graphics/devil/devil_1.8.0.bb
> new file mode 100644
> index 00000000..6ba7f34b
> --- /dev/null
> +++ b/meta-arago-extras/recipes-graphics/devil/devil_1.8.0.bb
> @@ -0,0 +1,30 @@
> +DESCRIPTION = "Developer's Image Library (DevIL) is a cross-platform image \
> +               library utilizing simple syntax to load, save, convert, \
> +               manipulate, filter and display a variety of images."

Would also need a short SUMMARY set.


> +HOMEPAGE = "https://github.com/DentonW/DevIL"
> +LICENSE = "LGPLv2"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=fc178bcd425090939a8b634d1d6a9594"
> +
> +SRC_URI = "git://github.com/dentonw/devil.git;protocol=git;branch=master \
> +           file://Remove-ILUT-dependency.patch"
> +
> +SRCREV = "e34284a7e07763769f671a74b4fec718174ad862"
> +
> +COMPATIBLE_MACHINE = "j7-evm"

Is it really compatible with j7 only? Looks to me as rather generic...


> +
> +PR = "r1"
> +S = "${WORKDIR}/git"
> +
> +# Build only DevIL
> +OECMAKE_SOURCEPATH = "${S}/DevIL"
> +
> +PACKAGECONFIG ??= "png"
> +PACKAGECONFIG[png] = "-DIL_NO_PNG=0,-DIL_NO_PNG=1,libpng,"
> +
> +DEPENDS += "libpng"

Dependency on libpng should be taken care by the PACKAGECONFIG above.


> +inherit pkgconfig cmake
> +
> +INSANE_SKIP_${PN} += "file-rdeps dev-so"
> +FILES_${PN} += "${libdir}/lib*${SOLIBSDEV}"
> +FILES_SOLIBSDEV = ""

Any way to package the libraries properly and not suppress QA checks?


> diff --git a/meta-arago-extras/recipes-graphics/devil/files/Remove-ILUT-dependency.patch b/meta-arago-extras/recipes-graphics/devil/files/Remove-ILUT-dependency.patch
> new file mode 100644
> index 00000000..4f0f9dfa
> --- /dev/null
> +++ b/meta-arago-extras/recipes-graphics/devil/files/Remove-ILUT-dependency.patch
> @@ -0,0 +1,13 @@
> +diff --git a/DevIL/CMakeLists.txt b/DevIL/CMakeLists.txt
> +index e342f93d..fae40167 100644
> +--- a/DevIL/CMakeLists.txt
> ++++ b/DevIL/CMakeLists.txt
> +@@ -6,7 +6,7 @@ set (CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/Modules")
> + 
> + add_subdirectory(src-IL)
> + add_subdirectory(src-ILU)
> +-add_subdirectory(src-ILUT)
> ++# add_subdirectory(src-ILUT)
> + option(IL_TESTS "build DevIL tests" ON)
> + if (IL_TESTS)
> +     ENABLE_TESTING()
> -- 
> 2.25.0
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [thud/zeus/master][PATCH] recipes-graphics: Add recipe for DevIL
  2020-01-28 23:45 ` Denys Dmytriyenko
@ 2020-01-29 17:18   ` Tammana, Gowtham
  2020-01-29 17:27     ` [EXTERNAL] " Tammana, Gowtham
  0 siblings, 1 reply; 7+ messages in thread
From: Tammana, Gowtham @ 2020-01-29 17:18 UTC (permalink / raw)
  To: Dmytriyenko, Denys; +Cc: meta-arago, Pothukuchi, Vijay



>-----Original Message-----
>From: Dmytriyenko, Denys
>Sent: Tuesday, January 28, 2020 5:46 PM
>To: Tammana, Gowtham
>Cc: meta-arago@arago-project.org; Pothukuchi, Vijay
>Subject: Re: [meta-arago][thud/zeus/master][PATCH] recipes-graphics: Add
>recipe for DevIL
>
>On Wed, Jan 22, 2020 at 11:36:26AM -0600, Gowtham Tammana wrote:
>> Developers Image Library (DevIL) is a cross-platfor image utility
>> library with simple syntax (openil.sourceforge.net). Adding recipe to
>> build from sources.
>
>Where is it coming from? I see there are many copies in other layers - is it
>based on something or completely done from scratch?

Do you mean the recipe, if so yes its done from scratch.

>
>> Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
>> ---
>>  .../recipes-graphics/devil/devil_1.8.0.bb     | 30 +++++++++++++++++++
>>  .../devil/files/Remove-ILUT-dependency.patch  | 13 ++++++++
>>  2 files changed, 43 insertions(+)
>>  create mode 100644 meta-arago-extras/recipes-graphics/devil/devil_1.8.0.bb
>>  create mode 100644 meta-arago-extras/recipes-graphics/devil/files/Remove-
>ILUT-dependency.patch
>>
>> diff --git a/meta-arago-extras/recipes-graphics/devil/devil_1.8.0.bb b/meta-
>arago-extras/recipes-graphics/devil/devil_1.8.0.bb
>> new file mode 100644
>> index 00000000..6ba7f34b
>> --- /dev/null
>> +++ b/meta-arago-extras/recipes-graphics/devil/devil_1.8.0.bb
>> @@ -0,0 +1,30 @@
>> +DESCRIPTION = "Developer's Image Library (DevIL) is a cross-platform image
>\
>> +               library utilizing simple syntax to load, save, convert, \
>> +               manipulate, filter and display a variety of images."
>
>Would also need a short SUMMARY set.

Ok, let me add include that.

>
>> +HOMEPAGE = "https://github.com/DentonW/DevIL"
>> +LICENSE = "LGPLv2"
>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=fc178bcd425090939a8b634d1d6a9594"
>> +
>> +SRC_URI = "git://github.com/dentonw/devil.git;protocol=git;branch=master \
>> +           file://Remove-ILUT-dependency.patch"
>> +
>> +SRCREV = "e34284a7e07763769f671a74b4fec718174ad862"
>> +
>> +COMPATIBLE_MACHINE = "j7-evm"
>
>Is it really compatible with j7 only? Looks to me as rather generic...

Yes, it is generic but haven't had chance to test on other platform. So included for J7 for now.

>
>> +
>> +PR = "r1"
>> +S = "${WORKDIR}/git"
>> +
>> +# Build only DevIL
>> +OECMAKE_SOURCEPATH = "${S}/DevIL"
>> +
>> +PACKAGECONFIG ??= "png"
>> +PACKAGECONFIG[png] = "-DIL_NO_PNG=0,-DIL_NO_PNG=1,libpng,"
>> +
>> +DEPENDS += "libpng"
>
>Dependency on libpng should be taken care by the PACKAGECONFIG above.

I see, will remove it.

>
>> +inherit pkgconfig cmake
>> +
>> +INSANE_SKIP_${PN} += "file-rdeps dev-so"
>> +FILES_${PN} += "${libdir}/lib*${SOLIBSDEV}"
>> +FILES_SOLIBSDEV = ""
>
>Any way to package the libraries properly and not suppress QA checks?

dev-so was needed, else it would complain on the symlinks. File-rdeps I couldn't quite resolve without suppressing them.

Thanks,
Gowtham



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [EXTERNAL] Re: [thud/zeus/master][PATCH] recipes-graphics: Add recipe for DevIL
  2020-01-29 17:18   ` Tammana, Gowtham
@ 2020-01-29 17:27     ` Tammana, Gowtham
  2020-01-29 17:34       ` Denys Dmytriyenko
  0 siblings, 1 reply; 7+ messages in thread
From: Tammana, Gowtham @ 2020-01-29 17:27 UTC (permalink / raw)
  To: Dmytriyenko, Denys; +Cc: meta-arago, Pothukuchi, Vijay



>>recipe for DevIL
>>
>>On Wed, Jan 22, 2020 at 11:36:26AM -0600, Gowtham Tammana wrote:
>>> Developers Image Library (DevIL) is a cross-platfor image utility
>>> library with simple syntax (openil.sourceforge.net). Adding recipe to
>>> build from sources.
>>
>>Where is it coming from? I see there are many copies in other layers - is it
>>based on something or completely done from scratch?
>
>Do you mean the recipe, if so yes its done from scratch.
>
>>
>>> index 00000000..6ba7f34b
>>> --- /dev/null
>>> +++ b/meta-arago-extras/recipes-graphics/devil/devil_1.8.0.bb
>>> @@ -0,0 +1,30 @@
>>> +DESCRIPTION = "Developer's Image Library (DevIL) is a cross-platform image
>>\
>>> +               library utilizing simple syntax to load, save, convert, \
>>> +               manipulate, filter and display a variety of images."
>>
>>Would also need a short SUMMARY set.
>
>Ok, let me add include that.
>
>>
>>> +HOMEPAGE = "https://github.com/DentonW/DevIL"
>>> +LICENSE = "LGPLv2"
>>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=fc178bcd425090939a8b634d1d6a9594"
>>> +
>>> +SRC_URI = "git://github.com/dentonw/devil.git;protocol=git;branch=master \
>>> +           file://Remove-ILUT-dependency.patch"
>>> +
>>> +SRCREV = "e34284a7e07763769f671a74b4fec718174ad862"
>>> +
>>> +COMPATIBLE_MACHINE = "j7-evm"
>>
>>Is it really compatible with j7 only? Looks to me as rather generic...
>
>Yes, it is generic but haven't had chance to test on other platform. So
>included for J7 for now.
>
>>
>>> +
>>> +PR = "r1"
>>> +S = "${WORKDIR}/git"
>>> +
>>> +# Build only DevIL
>>> +OECMAKE_SOURCEPATH = "${S}/DevIL"
>>> +
>>> +PACKAGECONFIG ??= "png"
>>> +PACKAGECONFIG[png] = "-DIL_NO_PNG=0,-DIL_NO_PNG=1,libpng,"
>>> +
>>> +DEPENDS += "libpng"
>>
>>Dependency on libpng should be taken care by the PACKAGECONFIG above.
>
>I see, will remove it.
>
>>
>>> +inherit pkgconfig cmake
>>> +
>>> +INSANE_SKIP_${PN} += "file-rdeps dev-so"
>>> +FILES_${PN} += "${libdir}/lib*${SOLIBSDEV}"
>>> +FILES_SOLIBSDEV = ""
>>
>>Any way to package the libraries properly and not suppress QA checks?
>
>dev-so was needed, else it would complain on the symlinks. File-rdeps I
>couldn't quite resolve without suppressing them.

ERROR: devil-1.8.0-r2 do_package_qa: QA Issue: /usr/lib/libIL.so.1 contained in package devil requires libc.so.6(GLIBC_2.17)(64bit), but no providers found in RDEPENDS_devil? [file-rdeps]
ERROR: devil-1.8.0-r2 do_package_qa: QA Issue: /usr/lib/libIL.so.1 contained in package devil requires libstdc++.so.6()(64bit), but no providers found in RDEPENDS_devil? [file-rdeps]

What does RDEPENDS_devil take the library target name or the recipe name.

Gowtham


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [EXTERNAL] Re: [thud/zeus/master][PATCH] recipes-graphics: Add recipe for DevIL
  2020-01-29 17:27     ` [EXTERNAL] " Tammana, Gowtham
@ 2020-01-29 17:34       ` Denys Dmytriyenko
  2020-01-29 17:52         ` Tammana, Gowtham
  0 siblings, 1 reply; 7+ messages in thread
From: Denys Dmytriyenko @ 2020-01-29 17:34 UTC (permalink / raw)
  To: Tammana, Gowtham; +Cc: meta-arago, Pothukuchi, Vijay

On Wed, Jan 29, 2020 at 12:27:50PM -0500, Tammana, Gowtham wrote:
> 
> 
> >>recipe for DevIL
> >>
> >>On Wed, Jan 22, 2020 at 11:36:26AM -0600, Gowtham Tammana wrote:
> >>> Developers Image Library (DevIL) is a cross-platfor image utility
> >>> library with simple syntax (openil.sourceforge.net). Adding recipe to
> >>> build from sources.
> >>
> >>Where is it coming from? I see there are many copies in other layers - is it
> >>based on something or completely done from scratch?
> >
> >Do you mean the recipe, if so yes its done from scratch.
> >
> >>
> >>> index 00000000..6ba7f34b
> >>> --- /dev/null
> >>> +++ b/meta-arago-extras/recipes-graphics/devil/devil_1.8.0.bb
> >>> @@ -0,0 +1,30 @@
> >>> +DESCRIPTION = "Developer's Image Library (DevIL) is a cross-platform image
> >>\
> >>> +               library utilizing simple syntax to load, save, convert, \
> >>> +               manipulate, filter and display a variety of images."
> >>
> >>Would also need a short SUMMARY set.
> >
> >Ok, let me add include that.
> >
> >>
> >>> +HOMEPAGE = "https://github.com/DentonW/DevIL"
> >>> +LICENSE = "LGPLv2"
> >>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=fc178bcd425090939a8b634d1d6a9594"
> >>> +
> >>> +SRC_URI = "git://github.com/dentonw/devil.git;protocol=git;branch=master \
> >>> +           file://Remove-ILUT-dependency.patch"
> >>> +
> >>> +SRCREV = "e34284a7e07763769f671a74b4fec718174ad862"
> >>> +
> >>> +COMPATIBLE_MACHINE = "j7-evm"
> >>
> >>Is it really compatible with j7 only? Looks to me as rather generic...
> >
> >Yes, it is generic but haven't had chance to test on other platform. So
> >included for J7 for now.
> >
> >>
> >>> +
> >>> +PR = "r1"
> >>> +S = "${WORKDIR}/git"
> >>> +
> >>> +# Build only DevIL
> >>> +OECMAKE_SOURCEPATH = "${S}/DevIL"
> >>> +
> >>> +PACKAGECONFIG ??= "png"
> >>> +PACKAGECONFIG[png] = "-DIL_NO_PNG=0,-DIL_NO_PNG=1,libpng,"
> >>> +
> >>> +DEPENDS += "libpng"
> >>
> >>Dependency on libpng should be taken care by the PACKAGECONFIG above.
> >
> >I see, will remove it.
> >
> >>
> >>> +inherit pkgconfig cmake
> >>> +
> >>> +INSANE_SKIP_${PN} += "file-rdeps dev-so"
> >>> +FILES_${PN} += "${libdir}/lib*${SOLIBSDEV}"
> >>> +FILES_SOLIBSDEV = ""
> >>
> >>Any way to package the libraries properly and not suppress QA checks?
> >
> >dev-so was needed, else it would complain on the symlinks. File-rdeps I

If it produces proper library libfoo.so.X.Y.Z with symlinks libfoo.so.X and 
libfoo.so, then just let the framework package everything automatically by 
removing FILES_*.


> >couldn't quite resolve without suppressing them.
> 
> ERROR: devil-1.8.0-r2 do_package_qa: QA Issue: /usr/lib/libIL.so.1 contained in package devil requires libc.so.6(GLIBC_2.17)(64bit), but no providers found in RDEPENDS_devil? [file-rdeps]
> ERROR: devil-1.8.0-r2 do_package_qa: QA Issue: /usr/lib/libIL.so.1 contained in package devil requires libstdc++.so.6()(64bit), but no providers found in RDEPENDS_devil? [file-rdeps]
> 
> What does RDEPENDS_devil take the library target name or the recipe name.

DEPENDS is build-time dependency and takes recipe names.
RDEPENDS is run-time dependency and takes package names.

But libc and libstdc++ dependencies are normally taken care by the framework. 
The only exception when you would see such errors is when the library was 
built outside of the framework, i.e. consumed as a binary in the recipe, not 
built from sources.

-- 
Denys


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [EXTERNAL] Re: [thud/zeus/master][PATCH] recipes-graphics: Add recipe for DevIL
  2020-01-29 17:34       ` Denys Dmytriyenko
@ 2020-01-29 17:52         ` Tammana, Gowtham
  2020-01-29 21:24           ` Tammana, Gowtham
  0 siblings, 1 reply; 7+ messages in thread
From: Tammana, Gowtham @ 2020-01-29 17:52 UTC (permalink / raw)
  To: Dmytriyenko, Denys; +Cc: meta-arago, Pothukuchi, Vijay



>-----Original Message-----
>From: Dmytriyenko, Denys
>Sent: Wednesday, January 29, 2020 11:35 AM
>To: Tammana, Gowtham
>Cc: meta-arago@arago-project.org; Pothukuchi, Vijay
>Subject: Re: [EXTERNAL] Re: [meta-arago] [thud/zeus/master][PATCH] recipes-
>graphics: Add recipe for DevIL
>
>On Wed, Jan 29, 2020 at 12:27:50PM -0500, Tammana, Gowtham wrote:
>>
>>
>> >>recipe for DevIL
>> >>
>> >>On Wed, Jan 22, 2020 at 11:36:26AM -0600, Gowtham Tammana wrote:
>> >>> Developers Image Library (DevIL) is a cross-platfor image utility
>> >>> library with simple syntax (openil.sourceforge.net). Adding recipe to
>> >>> build from sources.
>> >>
>> >>Where is it coming from? I see there are many copies in other layers - is
>it
>> >>based on something or completely done from scratch?
>> >
>> >Do you mean the recipe, if so yes its done from scratch.
>> >
>> >>
>> >>> index 00000000..6ba7f34b
>> >>> --- /dev/null
>> >>> +++ b/meta-arago-extras/recipes-graphics/devil/devil_1.8.0.bb
>> >>> @@ -0,0 +1,30 @@
>> >>> +DESCRIPTION = "Developer's Image Library (DevIL) is a cross-platform
>image
>> >>\
>> >>> +               library utilizing simple syntax to load, save, convert,
>\
>> >>> +               manipulate, filter and display a variety of images."
>> >>
>> >>Would also need a short SUMMARY set.
>> >
>> >Ok, let me add include that.
>> >
>> >>
>> >>> +HOMEPAGE = "https://github.com/DentonW/DevIL"
>> >>> +LICENSE = "LGPLv2"
>> >>> +LIC_FILES_CHKSUM =
>"file://LICENSE;md5=fc178bcd425090939a8b634d1d6a9594"
>> >>> +
>> >>> +SRC_URI =
>"git://github.com/dentonw/devil.git;protocol=git;branch=master \
>> >>> +           file://Remove-ILUT-dependency.patch"
>> >>> +
>> >>> +SRCREV = "e34284a7e07763769f671a74b4fec718174ad862"
>> >>> +
>> >>> +COMPATIBLE_MACHINE = "j7-evm"
>> >>
>> >>Is it really compatible with j7 only? Looks to me as rather generic...
>> >
>> >Yes, it is generic but haven't had chance to test on other platform. So
>> >included for J7 for now.
>> >
>> >>
>> >>> +
>> >>> +PR = "r1"
>> >>> +S = "${WORKDIR}/git"
>> >>> +
>> >>> +# Build only DevIL
>> >>> +OECMAKE_SOURCEPATH = "${S}/DevIL"
>> >>> +
>> >>> +PACKAGECONFIG ??= "png"
>> >>> +PACKAGECONFIG[png] = "-DIL_NO_PNG=0,-DIL_NO_PNG=1,libpng,"
>> >>> +
>> >>> +DEPENDS += "libpng"
>> >>
>> >>Dependency on libpng should be taken care by the PACKAGECONFIG above.
>> >
>> >I see, will remove it.
>> >
>> >>
>> >>> +inherit pkgconfig cmake
>> >>> +
>> >>> +INSANE_SKIP_${PN} += "file-rdeps dev-so"
>> >>> +FILES_${PN} += "${libdir}/lib*${SOLIBSDEV}"
>> >>> +FILES_SOLIBSDEV = ""
>> >>
>> >>Any way to package the libraries properly and not suppress QA checks?
>> >
>> >dev-so was needed, else it would complain on the symlinks. File-rdeps I
>
>If it produces proper library libfoo.so.X.Y.Z with symlinks libfoo.so.X and
>libfoo.so, then just let the framework package everything automatically by
>removing FILES_*.
>
>
>> >couldn't quite resolve without suppressing them.
>>
>> ERROR: devil-1.8.0-r2 do_package_qa: QA Issue: /usr/lib/libIL.so.1 contained
>in package devil requires libc.so.6(GLIBC_2.17)(64bit), but no providers found
>in RDEPENDS_devil? [file-rdeps]
>> ERROR: devil-1.8.0-r2 do_package_qa: QA Issue: /usr/lib/libIL.so.1 contained
>in package devil requires libstdc++.so.6()(64bit), but no providers found in
>RDEPENDS_devil? [file-rdeps]
>>
>> What does RDEPENDS_devil take the library target name or the recipe name.
>
>DEPENDS is build-time dependency and takes recipe names.
>RDEPENDS is run-time dependency and takes package names.
>
>But libc and libstdc++ dependencies are normally taken care by the framework.

That's my understanding. If I do say RDEPENDS_${PN} = "libstdc++6" I see
"Nothing RPROVIDES 'libstdc++6'", which seems right as there is no explicit provider for it.

>The only exception when you would see such errors is when the library was
>built outside of the framework, i.e. consumed as a binary in the recipe, not
>built from sources.

Interesting, there are no prebuilt binaries in here, everything should get built from source. Let me do a clean build.

Gowtham


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [EXTERNAL] Re: [thud/zeus/master][PATCH] recipes-graphics: Add recipe for DevIL
  2020-01-29 17:52         ` Tammana, Gowtham
@ 2020-01-29 21:24           ` Tammana, Gowtham
  0 siblings, 0 replies; 7+ messages in thread
From: Tammana, Gowtham @ 2020-01-29 21:24 UTC (permalink / raw)
  To: Dmytriyenko, Denys; +Cc: meta-arago, Pothukuchi, Vijay


11:36:26AM -0600, Gowtham Tammana wrote:
>>> >>> Developers Image Library (DevIL) is a cross-platfor image utility
>>> >>> library with simple syntax (openil.sourceforge.net). Adding recipe to
>>> >>> build from sources.
>>> >>
>>> >>Where is it coming from? I see there are many copies in other layers - is
>>it
>>> >>based on something or completely done from scratch?
>>> >
>>> >Do you mean the recipe, if so yes its done from scratch.
>>> >
>>> >>
>>> >>> index 00000000..6ba7f34b
>>> >>> --- /dev/null
>>> >>> +++ b/meta-arago-extras/recipes-graphics/devil/devil_1.8.0.bb
>>> >>> @@ -0,0 +1,30 @@
>>> >>> +DESCRIPTION = "Developer's Image Library (DevIL) is a cross-platform
>>image
>>> >>\
>>> >>> +               library utilizing simple syntax to load, save, convert,
>>\
>>> >>> +               manipulate, filter and display a variety of images."
>>> >>
>>> >>Would also need a short SUMMARY set.
>>> >
>>> >Ok, let me add include that.
>>> >
>>> >>
>>> >>> +HOMEPAGE = "https://github.com/DentonW/DevIL"
>>> >>> +LICENSE = "LGPLv2"
>>> >>> +LIC_FILES_CHKSUM =
>>"file://LICENSE;md5=fc178bcd425090939a8b634d1d6a9594"
>>> >>> +
>>> >>> +SRC_URI =
>>"git://github.com/dentonw/devil.git;protocol=git;branch=master \
>>> >>> +           file://Remove-ILUT-dependency.patch"
>>> >>> +
>>> >>> +SRCREV = "e34284a7e07763769f671a74b4fec718174ad862"
>>> >>> +
>>> >>> +COMPATIBLE_MACHINE = "j7-evm"
>>> >>
>>> >>Is it really compatible with j7 only? Looks to me as rather generic...
>>> >
>>> >Yes, it is generic but haven't had chance to test on other platform. So
>>> >included for J7 for now.
>>> >
>>> >>
>>> >>> +
>>> >>> +PR = "r1"
>>> >>> +S = "${WORKDIR}/git"
>>> >>> +
>>> >>> +# Build only DevIL
>>> >>> +OECMAKE_SOURCEPATH = "${S}/DevIL"
>>> >>> +
>>> >>> +PACKAGECONFIG ??= "png"
>>> >>> +PACKAGECONFIG[png] = "-DIL_NO_PNG=0,-DIL_NO_PNG=1,libpng,"
>>> >>> +
>>> >>> +DEPENDS += "libpng"
>>> >>
>>> >>Dependency on libpng should be taken care by the PACKAGECONFIG above.
>>> >
>>> >I see, will remove it.
>>> >
>>> >>
>>> >>> +inherit pkgconfig cmake
>>> >>> +
>>> >>> +INSANE_SKIP_${PN} += "file-rdeps dev-so"
>>> >>> +FILES_${PN} += "${libdir}/lib*${SOLIBSDEV}"
>>> >>> +FILES_SOLIBSDEV = ""
>>> >>
>>> >>Any way to package the libraries properly and not suppress QA checks?
>>> >
>>> >dev-so was needed, else it would complain on the symlinks. File-rdeps I
>>
>>If it produces proper library libfoo.so.X.Y.Z with symlinks libfoo.so.X and
>>libfoo.so, then just let the framework package everything automatically by
>>removing FILES_*.
>>
>>
>>> >couldn't quite resolve without suppressing them.
>>>
>>> ERROR: devil-1.8.0-r2 do_package_qa: QA Issue: /usr/lib/libIL.so.1
>contained
>>in package devil requires libc.so.6(GLIBC_2.17)(64bit), but no providers
>found
>>in RDEPENDS_devil? [file-rdeps]
>>> ERROR: devil-1.8.0-r2 do_package_qa: QA Issue: /usr/lib/libIL.so.1
>contained
>>in package devil requires libstdc++.so.6()(64bit), but no providers found in
>>RDEPENDS_devil? [file-rdeps]
>>>
>>> What does RDEPENDS_devil take the library target name or the recipe name.
>>
>>DEPENDS is build-time dependency and takes recipe names.
>>RDEPENDS is run-time dependency and takes package names.
>>
>>But libc and libstdc++ dependencies are normally taken care by the framework.
>
>That's my understanding. If I do say RDEPENDS_${PN} = "libstdc++6" I see
>"Nothing RPROVIDES 'libstdc++6'", which seems right as there is no explicit
>provider for it.
>
>>The only exception when you would see such errors is when the library was
>>built outside of the framework, i.e. consumed as a binary in the recipe, not
>>built from sources.
>
>Interesting, there are no prebuilt binaries in here, everything should get
>built from source. Let me do a clean build.

It looks like my earlier build was corrupted, doing a clean build didn't show any of the above errors. Pushed a v2.

Thanks,
Gowtham


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-01-29 21:26 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-22 17:36 [thud/zeus/master][PATCH] recipes-graphics: Add recipe for DevIL Gowtham Tammana
2020-01-28 23:45 ` Denys Dmytriyenko
2020-01-29 17:18   ` Tammana, Gowtham
2020-01-29 17:27     ` [EXTERNAL] " Tammana, Gowtham
2020-01-29 17:34       ` Denys Dmytriyenko
2020-01-29 17:52         ` Tammana, Gowtham
2020-01-29 21:24           ` Tammana, Gowtham

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.