* [PATCH] removing fdt_high from default set of variables for, dragonboard410c config
@ 2020-01-09 15:53 Matthias Schoepfer
2020-01-23 22:00 ` Tom Rini
0 siblings, 1 reply; 3+ messages in thread
From: Matthias Schoepfer @ 2020-01-09 15:53 UTC (permalink / raw)
To: u-boot
When using fitImage in AARCH64, the fdt is only 4 byte aligned.
According to linux kernel -> Documentation/arm64/booting.txt, the
fdt *must* be 8 byte aligned. Therefore, it is somewhat random,
if you build a kernel that the fdt is 4 or 8 byte aligned.
Removing fdt_high (or changing it to a valid 8 byte aligned
address) solves this issue.
Signed-off-by: Matthias Schoepfer <matthias.schoepfer@ithinx.io>
CC: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
---
include/configs/dragonboard410c.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/configs/dragonboard410c.h
b/include/configs/dragonboard410c.h
index 65149ad441..9362e9322c 100644
--- a/include/configs/dragonboard410c.h
+++ b/include/configs/dragonboard410c.h
@@ -69,7 +69,6 @@ REFLASH(dragonboard/u-boot.img, 8)\
#define CONFIG_EXTRA_ENV_SETTINGS \
"reflash="CONFIG_ENV_REFLASH"\0"\
"loadaddr=0x81000000\0" \
- "fdt_high=0xffffffffffffffff\0" \
"initrd_high=0xffffffffffffffff\0" \
"linux_image=Image\0" \
"kernel_addr_r=0x81000000\0"\
--
2.24.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] removing fdt_high from default set of variables for, dragonboard410c config
2020-01-09 15:53 [PATCH] removing fdt_high from default set of variables for, dragonboard410c config Matthias Schoepfer
@ 2020-01-23 22:00 ` Tom Rini
0 siblings, 0 replies; 3+ messages in thread
From: Tom Rini @ 2020-01-23 22:00 UTC (permalink / raw)
To: u-boot
On Thu, Jan 09, 2020 at 04:53:32PM +0100, Matthias Schoepfer wrote:
> When using fitImage in AARCH64, the fdt is only 4 byte aligned.
> According to linux kernel -> Documentation/arm64/booting.txt, the
> fdt *must* be 8 byte aligned. Therefore, it is somewhat random,
> if you build a kernel that the fdt is 4 or 8 byte aligned.
> Removing fdt_high (or changing it to a valid 8 byte aligned
> address) solves this issue.
>
> Signed-off-by: Matthias Schoepfer <matthias.schoepfer@ithinx.io>
> CC: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200123/0eda5597/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] removing fdt_high from default set of variables for dragonboard410c config
@ 2020-01-09 15:55 Matthias Schoepfer
0 siblings, 0 replies; 3+ messages in thread
From: Matthias Schoepfer @ 2020-01-09 15:55 UTC (permalink / raw)
To: u-boot
When using fitImage in AARCH64, the fdt is only 4 byte aligned. According
to linux kernel -> Documentation/arm64/booting.txt, the fdt *must* be 8
byte aligned. Therefore, it is somewhat random, if you build a kernel that
the fdt is 4 or 8 byte aligned. Removing fdt_high (or changing it to a
valid 8 byte aligned address) solves this issue.
Signed-off-by: Matthias Schoepfer <matthias.schoepfer@ithinx.io>
CC: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
---
include/configs/dragonboard410c.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/configs/dragonboard410c.h b/include/configs/dragonboard410c.h
index 65149ad441..9362e9322c 100644
--- a/include/configs/dragonboard410c.h
+++ b/include/configs/dragonboard410c.h
@@ -69,7 +69,6 @@ REFLASH(dragonboard/u-boot.img, 8)\
#define CONFIG_EXTRA_ENV_SETTINGS \
"reflash="CONFIG_ENV_REFLASH"\0"\
"loadaddr=0x81000000\0" \
- "fdt_high=0xffffffffffffffff\0" \
"initrd_high=0xffffffffffffffff\0" \
"linux_image=Image\0" \
"kernel_addr_r=0x81000000\0"\
--
2.24.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-23 22:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-09 15:53 [PATCH] removing fdt_high from default set of variables for, dragonboard410c config Matthias Schoepfer
2020-01-23 22:00 ` Tom Rini
2020-01-09 15:55 [PATCH] removing fdt_high from default set of variables for " Matthias Schoepfer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.