All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] module.h: Annotate mod_kallsyms with __rcu
@ 2020-01-22 17:04 ` madhuparnabhowmik10
  0 siblings, 0 replies; 6+ messages in thread
From: madhuparnabhowmik10 @ 2020-01-22 17:04 UTC (permalink / raw)
  To: jeyu
  Cc: linux-kernel, joel, frextrite, rcu, linux-kernel-mentees,
	paulmck, Madhuparna Bhowmik

From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>

This patch fixes the following sparse errors:

kernel/module.c:3623:9: error: incompatible types in comparison expression
kernel/module.c:4060:41: error: incompatible types in comparison expression
kernel/module.c:4203:28: error: incompatible types in comparison expression
kernel/module.c:4225:41: error: incompatible types in comparison expression

Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
---
 include/linux/module.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/module.h b/include/linux/module.h
index bd165ba68617..dfdc8863e26a 100644
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@ -429,7 +429,7 @@ struct module {
 
 #ifdef CONFIG_KALLSYMS
 	/* Protected by RCU and/or module_mutex: use rcu_dereference() */
-	struct mod_kallsyms *kallsyms;
+	struct mod_kallsyms __rcu *kallsyms;
 	struct mod_kallsyms core_kallsyms;
 
 	/* Section attributes */
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [Linux-kernel-mentees] [PATCH] module.h: Annotate mod_kallsyms with __rcu
@ 2020-01-22 17:04 ` madhuparnabhowmik10
  0 siblings, 0 replies; 6+ messages in thread
From: madhuparnabhowmik10 @ 2020-01-22 17:04 UTC (permalink / raw)
  To: jeyu
  Cc: paulmck, linux-kernel, rcu, Madhuparna Bhowmik, joel,
	linux-kernel-mentees

From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>

This patch fixes the following sparse errors:

kernel/module.c:3623:9: error: incompatible types in comparison expression
kernel/module.c:4060:41: error: incompatible types in comparison expression
kernel/module.c:4203:28: error: incompatible types in comparison expression
kernel/module.c:4225:41: error: incompatible types in comparison expression

Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
---
 include/linux/module.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/module.h b/include/linux/module.h
index bd165ba68617..dfdc8863e26a 100644
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@ -429,7 +429,7 @@ struct module {
 
 #ifdef CONFIG_KALLSYMS
 	/* Protected by RCU and/or module_mutex: use rcu_dereference() */
-	struct mod_kallsyms *kallsyms;
+	struct mod_kallsyms __rcu *kallsyms;
 	struct mod_kallsyms core_kallsyms;
 
 	/* Section attributes */
-- 
2.17.1

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] module.h: Annotate mod_kallsyms with __rcu
  2020-01-22 17:04 ` [Linux-kernel-mentees] " madhuparnabhowmik10
@ 2020-01-23 17:22   ` Jessica Yu
  -1 siblings, 0 replies; 6+ messages in thread
From: Jessica Yu @ 2020-01-23 17:22 UTC (permalink / raw)
  To: madhuparnabhowmik10
  Cc: linux-kernel, joel, frextrite, rcu, linux-kernel-mentees, paulmck

+++ madhuparnabhowmik10@gmail.com [22/01/20 22:34 +0530]:
>From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
>
>This patch fixes the following sparse errors:
>
>kernel/module.c:3623:9: error: incompatible types in comparison expression
>kernel/module.c:4060:41: error: incompatible types in comparison expression
>kernel/module.c:4203:28: error: incompatible types in comparison expression
>kernel/module.c:4225:41: error: incompatible types in comparison expression
>
>Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>

Hi Madhuparna,

Thanks, I can confirm this patch fixes the sparse warnings. I've
applied it to modules-next.

Jessica

>---
> include/linux/module.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/include/linux/module.h b/include/linux/module.h
>index bd165ba68617..dfdc8863e26a 100644
>--- a/include/linux/module.h
>+++ b/include/linux/module.h
>@@ -429,7 +429,7 @@ struct module {
>
> #ifdef CONFIG_KALLSYMS
> 	/* Protected by RCU and/or module_mutex: use rcu_dereference() */
>-	struct mod_kallsyms *kallsyms;
>+	struct mod_kallsyms __rcu *kallsyms;
> 	struct mod_kallsyms core_kallsyms;
>
> 	/* Section attributes */
>-- 
>2.17.1
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Linux-kernel-mentees] [PATCH] module.h: Annotate mod_kallsyms with __rcu
@ 2020-01-23 17:22   ` Jessica Yu
  0 siblings, 0 replies; 6+ messages in thread
From: Jessica Yu @ 2020-01-23 17:22 UTC (permalink / raw)
  To: madhuparnabhowmik10
  Cc: paulmck, linux-kernel, rcu, joel, linux-kernel-mentees

+++ madhuparnabhowmik10@gmail.com [22/01/20 22:34 +0530]:
>From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
>
>This patch fixes the following sparse errors:
>
>kernel/module.c:3623:9: error: incompatible types in comparison expression
>kernel/module.c:4060:41: error: incompatible types in comparison expression
>kernel/module.c:4203:28: error: incompatible types in comparison expression
>kernel/module.c:4225:41: error: incompatible types in comparison expression
>
>Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>

Hi Madhuparna,

Thanks, I can confirm this patch fixes the sparse warnings. I've
applied it to modules-next.

Jessica

>---
> include/linux/module.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/include/linux/module.h b/include/linux/module.h
>index bd165ba68617..dfdc8863e26a 100644
>--- a/include/linux/module.h
>+++ b/include/linux/module.h
>@@ -429,7 +429,7 @@ struct module {
>
> #ifdef CONFIG_KALLSYMS
> 	/* Protected by RCU and/or module_mutex: use rcu_dereference() */
>-	struct mod_kallsyms *kallsyms;
>+	struct mod_kallsyms __rcu *kallsyms;
> 	struct mod_kallsyms core_kallsyms;
>
> 	/* Section attributes */
>-- 
>2.17.1
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] module.h: Annotate mod_kallsyms with __rcu
  2020-01-23 17:22   ` [Linux-kernel-mentees] " Jessica Yu
@ 2020-01-24  4:31     ` Madhuparna Bhowmik
  -1 siblings, 0 replies; 6+ messages in thread
From: Madhuparna Bhowmik @ 2020-01-24  4:31 UTC (permalink / raw)
  To: Jessica Yu
  Cc: madhuparnabhowmik10, linux-kernel, joel, frextrite, rcu,
	linux-kernel-mentees, paulmck

On Thu, Jan 23, 2020 at 06:22:58PM +0100, Jessica Yu wrote:
> +++ madhuparnabhowmik10@gmail.com [22/01/20 22:34 +0530]:
> > From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
> > 
> > This patch fixes the following sparse errors:
> > 
> > kernel/module.c:3623:9: error: incompatible types in comparison expression
> > kernel/module.c:4060:41: error: incompatible types in comparison expression
> > kernel/module.c:4203:28: error: incompatible types in comparison expression
> > kernel/module.c:4225:41: error: incompatible types in comparison expression
> > 
> > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
> 
> Hi Madhuparna,
> 
> Thanks, I can confirm this patch fixes the sparse warnings. I've
> applied it to modules-next.
>
Thank you Jessica.

Regards,
Madhuparna

> Jessica
> 
> > ---
> > include/linux/module.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/linux/module.h b/include/linux/module.h
> > index bd165ba68617..dfdc8863e26a 100644
> > --- a/include/linux/module.h
> > +++ b/include/linux/module.h
> > @@ -429,7 +429,7 @@ struct module {
> > 
> > #ifdef CONFIG_KALLSYMS
> > 	/* Protected by RCU and/or module_mutex: use rcu_dereference() */
> > -	struct mod_kallsyms *kallsyms;
> > +	struct mod_kallsyms __rcu *kallsyms;
> > 	struct mod_kallsyms core_kallsyms;
> > 
> > 	/* Section attributes */
> > -- 
> > 2.17.1
> > 

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Linux-kernel-mentees] [PATCH] module.h: Annotate mod_kallsyms with __rcu
@ 2020-01-24  4:31     ` Madhuparna Bhowmik
  0 siblings, 0 replies; 6+ messages in thread
From: Madhuparna Bhowmik @ 2020-01-24  4:31 UTC (permalink / raw)
  To: Jessica Yu
  Cc: paulmck, linux-kernel, rcu, madhuparnabhowmik10, joel,
	linux-kernel-mentees

On Thu, Jan 23, 2020 at 06:22:58PM +0100, Jessica Yu wrote:
> +++ madhuparnabhowmik10@gmail.com [22/01/20 22:34 +0530]:
> > From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
> > 
> > This patch fixes the following sparse errors:
> > 
> > kernel/module.c:3623:9: error: incompatible types in comparison expression
> > kernel/module.c:4060:41: error: incompatible types in comparison expression
> > kernel/module.c:4203:28: error: incompatible types in comparison expression
> > kernel/module.c:4225:41: error: incompatible types in comparison expression
> > 
> > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
> 
> Hi Madhuparna,
> 
> Thanks, I can confirm this patch fixes the sparse warnings. I've
> applied it to modules-next.
>
Thank you Jessica.

Regards,
Madhuparna

> Jessica
> 
> > ---
> > include/linux/module.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/linux/module.h b/include/linux/module.h
> > index bd165ba68617..dfdc8863e26a 100644
> > --- a/include/linux/module.h
> > +++ b/include/linux/module.h
> > @@ -429,7 +429,7 @@ struct module {
> > 
> > #ifdef CONFIG_KALLSYMS
> > 	/* Protected by RCU and/or module_mutex: use rcu_dereference() */
> > -	struct mod_kallsyms *kallsyms;
> > +	struct mod_kallsyms __rcu *kallsyms;
> > 	struct mod_kallsyms core_kallsyms;
> > 
> > 	/* Section attributes */
> > -- 
> > 2.17.1
> > 
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-01-24  4:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-22 17:04 [PATCH] module.h: Annotate mod_kallsyms with __rcu madhuparnabhowmik10
2020-01-22 17:04 ` [Linux-kernel-mentees] " madhuparnabhowmik10
2020-01-23 17:22 ` Jessica Yu
2020-01-23 17:22   ` [Linux-kernel-mentees] " Jessica Yu
2020-01-24  4:31   ` Madhuparna Bhowmik
2020-01-24  4:31     ` [Linux-kernel-mentees] " Madhuparna Bhowmik

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.