[otc-clk-server-linux:ira/lck-4071-b8-v2 14/28] include/linux/fs.h:1921:31: error: 'lock_dax_state_static_key' undeclared; did you mean 'proc_do_static_key'?

[otc-clk-server-linux:ira/lck-4071-b8-v2 14/28] include/linux/fs.h:1921:31: error: 'lock_dax_state_static_key' undeclared; did you mean 'proc_do_static_key'?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 5407 bytes --]

tree:   otc-clk-server-linux/ira/lck-4071-b8-v2
head:   08333ed7d45cb9e8a2c4d602f97d0e9c2f56e8d3
commit: 64b72eb06dc626a3004298b0ea3811579d874ad4 [14/28] fs: Add locking for a dynamic DAX state
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 64b72eb06dc626a3004298b0ea3811579d874ad4
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/compat.h:17:0,
                    from include/linux/ethtool.h:17,
                    from drivers/net/wireless/intersil/hostap/hostap_ioctl.c:7:
   include/linux/fs.h:1918:1: warning: data definition has no type or storage class
    DECLARE_STATIC_KEY_FALSE(lock_dax_state_static_key);
    ^~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/fs.h:1918:1: error: type defaults to 'int' in declaration of 'DECLARE_STATIC_KEY_FALSE' [-Werror=implicit-int]
   include/linux/fs.h:1918:1: warning: parameter names (without types) in function declaration
   include/linux/fs.h: In function 'inode_dax_state_down_read':
   include/linux/fs.h:1921:7: error: implicit declaration of function 'static_branch_unlikely' [-Werror=implicit-function-declaration]
     if (!static_branch_unlikely(&lock_dax_state_static_key))
          ^~~~~~~~~~~~~~~~~~~~~~
>> include/linux/fs.h:1921:31: error: 'lock_dax_state_static_key' undeclared (first use in this function); did you mean 'proc_do_static_key'?
     if (!static_branch_unlikely(&lock_dax_state_static_key))
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~
                                  proc_do_static_key
   include/linux/fs.h:1921:31: note: each undeclared identifier is reported only once for each function it appears in
   include/linux/fs.h: In function 'inode_dax_state_up_read':
   include/linux/fs.h:1927:31: error: 'lock_dax_state_static_key' undeclared (first use in this function); did you mean 'proc_do_static_key'?
     if (!static_branch_unlikely(&lock_dax_state_static_key))
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~
                                  proc_do_static_key
   include/linux/fs.h: In function 'inode_dax_state_down_write':
   include/linux/fs.h:1933:31: error: 'lock_dax_state_static_key' undeclared (first use in this function); did you mean 'proc_do_static_key'?
     if (!static_branch_unlikely(&lock_dax_state_static_key))
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~
                                  proc_do_static_key
   include/linux/fs.h: In function 'inode_dax_state_up_write':
   include/linux/fs.h:1939:31: error: 'lock_dax_state_static_key' undeclared (first use in this function); did you mean 'proc_do_static_key'?
     if (!static_branch_unlikely(&lock_dax_state_static_key))
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~
                                  proc_do_static_key
   cc1: some warnings being treated as errors

vim +1921 include/linux/fs.h

  1904	
  1905	#if defined(CONFIG_FS_DAX)
  1906	/*
  1907	 * Filesystems wishing to support dynamic DAX states must do the following.
  1908	 *
  1909	 * 1) the direct_IO address_space_operation must be supported in all
  1910	 *    potential a_ops vectors for any state suported by the inode.
  1911	 * 2) FS's should enable the static branch lock_dax_state_static_key when a DAX
  1912	 *    capable device is detected.
  1913	 * 3) DAX state changes shall not be allowed while the file is mmap'ed
  1914	 * 4) For non-mmaped operations the VFS layer must take the read lock for any
  1915	 *    use of IS_DAX()
  1916	 * 5) Filesystems take the write lock when changing DAX states.
  1917	 */
> 1918	DECLARE_STATIC_KEY_FALSE(lock_dax_state_static_key);
  1919	static inline void inode_dax_state_down_read(struct inode *inode)
  1920	{
> 1921		if (!static_branch_unlikely(&lock_dax_state_static_key))
  1922			return;
  1923		percpu_down_read(&inode->i_sb->s_dax_sem);
  1924	}
  1925	static inline void inode_dax_state_up_read(struct inode *inode)
  1926	{
  1927		if (!static_branch_unlikely(&lock_dax_state_static_key))
  1928			return;
  1929		percpu_up_read(&inode->i_sb->s_dax_sem);
  1930	}
  1931	static inline void inode_dax_state_down_write(struct inode *inode)
  1932	{
  1933		if (!static_branch_unlikely(&lock_dax_state_static_key))
  1934			return;
  1935		percpu_down_write(&inode->i_sb->s_dax_sem);
  1936	}
  1937	static inline void inode_dax_state_up_write(struct inode *inode)
  1938	{
  1939		if (!static_branch_unlikely(&lock_dax_state_static_key))
  1940			return;
  1941		percpu_up_write(&inode->i_sb->s_dax_sem);
  1942	}
  1943	#else /* !CONFIG_FS_DAX */
  1944	#define inode_dax_state_down_read(inode) do { (void)(inode); } while (0)
  1945	#define inode_dax_state_up_read(inode) do { (void)(inode); } while (0)
  1946	#endif /* CONFIG_FS_DAX */
  1947	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 52694 bytes --]