* [PATCH] staging: rtl8723bs: core: fix condition with no effect
@ 2020-01-25 13:34 ` Saurav Girepunje
0 siblings, 0 replies; 4+ messages in thread
From: Saurav Girepunje @ 2020-01-25 13:34 UTC (permalink / raw)
To: gregkh, nishkadg.linux, wambui.karugax, julia.lawall,
benniciemanuel78, saurav.girepunje, devel, linux-kernel
Cc: saurav.girepunje
fix warning reorted by coccicheck
WARNING: possible condition with no effect (if == else)
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 71fcb46..5f110c3 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -2771,18 +2771,8 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *pie, uint ie_len, u8 channe
DBG_871X("+rtw_update_ht_cap()\n");
/* maybe needs check if ap supports rx ampdu. */
- if (!(phtpriv->ampdu_enable) && pregistrypriv->ampdu_enable == 1) {
- if (pregistrypriv->wifi_spec == 1) {
- /* remove this part because testbed AP should disable RX AMPDU */
- /* phtpriv->ampdu_enable = false; */
- phtpriv->ampdu_enable = true;
- } else {
- phtpriv->ampdu_enable = true;
- }
- } else if (pregistrypriv->ampdu_enable == 2) {
- /* remove this part because testbed AP should disable RX AMPDU */
- /* phtpriv->ampdu_enable = true; */
- }
+ if (!(phtpriv->ampdu_enable) && pregistrypriv->ampdu_enable == 1)
+ phtpriv->ampdu_enable = true;
/* check Max Rx A-MPDU Size */
len = 0;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] staging: rtl8723bs: core: fix condition with no effect
@ 2020-01-25 13:34 ` Saurav Girepunje
0 siblings, 0 replies; 4+ messages in thread
From: Saurav Girepunje @ 2020-01-25 13:34 UTC (permalink / raw)
To: gregkh, nishkadg.linux, wambui.karugax, julia.lawall,
benniciemanuel78, saurav.girepunje, devel, linux-kernel
Cc: saurav.girepunje
fix warning reorted by coccicheck
WARNING: possible condition with no effect (if == else)
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 71fcb46..5f110c3 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -2771,18 +2771,8 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *pie, uint ie_len, u8 channe
DBG_871X("+rtw_update_ht_cap()\n");
/* maybe needs check if ap supports rx ampdu. */
- if (!(phtpriv->ampdu_enable) && pregistrypriv->ampdu_enable == 1) {
- if (pregistrypriv->wifi_spec == 1) {
- /* remove this part because testbed AP should disable RX AMPDU */
- /* phtpriv->ampdu_enable = false; */
- phtpriv->ampdu_enable = true;
- } else {
- phtpriv->ampdu_enable = true;
- }
- } else if (pregistrypriv->ampdu_enable == 2) {
- /* remove this part because testbed AP should disable RX AMPDU */
- /* phtpriv->ampdu_enable = true; */
- }
+ if (!(phtpriv->ampdu_enable) && pregistrypriv->ampdu_enable == 1)
+ phtpriv->ampdu_enable = true;
/* check Max Rx A-MPDU Size */
len = 0;
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8723bs: core: fix condition with no effect
2020-01-25 13:34 ` Saurav Girepunje
@ 2020-01-27 8:26 ` Dan Carpenter
-1 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2020-01-27 8:26 UTC (permalink / raw)
To: Saurav Girepunje
Cc: gregkh, nishkadg.linux, wambui.karugax, julia.lawall,
benniciemanuel78, devel, linux-kernel, saurav.girepunje
On Sat, Jan 25, 2020 at 07:04:38PM +0530, Saurav Girepunje wrote:
> fix warning reorted by coccicheck
> WARNING: possible condition with no effect (if == else)
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
This one looks good.
The difference between this one and the last one, is that this stuff
looks like documentation but it's just a lot of garbage dead code so
it's good to delete it.
But unfortunately, these patches don't apply. Please read
Documentation/process/email-clients.rst
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8723bs: core: fix condition with no effect
@ 2020-01-27 8:26 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2020-01-27 8:26 UTC (permalink / raw)
To: Saurav Girepunje
Cc: devel, gregkh, linux-kernel, julia.lawall, saurav.girepunje,
nishkadg.linux, benniciemanuel78, wambui.karugax
On Sat, Jan 25, 2020 at 07:04:38PM +0530, Saurav Girepunje wrote:
> fix warning reorted by coccicheck
> WARNING: possible condition with no effect (if == else)
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
This one looks good.
The difference between this one and the last one, is that this stuff
looks like documentation but it's just a lot of garbage dead code so
it's good to delete it.
But unfortunately, these patches don't apply. Please read
Documentation/process/email-clients.rst
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-27 8:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-25 13:34 [PATCH] staging: rtl8723bs: core: fix condition with no effect Saurav Girepunje
2020-01-25 13:34 ` Saurav Girepunje
2020-01-27 8:26 ` Dan Carpenter
2020-01-27 8:26 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.