All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/kodi-visualisation-goom: needs glm
@ 2020-01-27 18:54 Bernd Kuhls
  2020-01-27 18:54 ` [Buildroot] [PATCH 2/2] package/kodi-visualisation-goom: fix build with gcc-4.9 Bernd Kuhls
  2020-01-28 14:58 ` [Buildroot] [PATCH 1/2] package/kodi-visualisation-goom: needs glm Peter Korsgaard
  0 siblings, 2 replies; 4+ messages in thread
From: Bernd Kuhls @ 2020-01-27 18:54 UTC (permalink / raw)
  To: buildroot

See CMakeLists.txt:
https://github.com/xbmc/visualization.goom/blob/Leia/CMakeLists.txt#L7

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/kodi-visualisation-goom/Config.in                  | 1 +
 package/kodi-visualisation-goom/kodi-visualisation-goom.mk | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/kodi-visualisation-goom/Config.in b/package/kodi-visualisation-goom/Config.in
index de4d2ef2ff..065bc1d773 100644
--- a/package/kodi-visualisation-goom/Config.in
+++ b/package/kodi-visualisation-goom/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_KODI_VISUALISATION_GOOM
 	bool "kodi-visualisation-goom"
 	depends on BR2_PACKAGE_HAS_LIBGL
+	select BR2_PACKAGE_GLM
 	help
 	  GOOM visualiser for Kodi
 
diff --git a/package/kodi-visualisation-goom/kodi-visualisation-goom.mk b/package/kodi-visualisation-goom/kodi-visualisation-goom.mk
index 487a520220..d742e00e5a 100644
--- a/package/kodi-visualisation-goom/kodi-visualisation-goom.mk
+++ b/package/kodi-visualisation-goom/kodi-visualisation-goom.mk
@@ -9,6 +9,6 @@ KODI_VISUALISATION_GOOM_SITE = $(call github,xbmc,visualization.goom,$(KODI_VISU
 KODI_VISUALISATION_GOOM_LICENSE = GPL-2.0+
 KODI_VISUALISATION_GOOM_LICENSE_FILES = src/Main.cpp
 
-KODI_VISUALISATION_GOOM_DEPENDENCIES = kodi
+KODI_VISUALISATION_GOOM_DEPENDENCIES = glm kodi
 
 $(eval $(cmake-package))
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/2] package/kodi-visualisation-goom: fix build with gcc-4.9
  2020-01-27 18:54 [Buildroot] [PATCH 1/2] package/kodi-visualisation-goom: needs glm Bernd Kuhls
@ 2020-01-27 18:54 ` Bernd Kuhls
  2020-01-28 14:59   ` Peter Korsgaard
  2020-01-28 14:58 ` [Buildroot] [PATCH 1/2] package/kodi-visualisation-goom: needs glm Peter Korsgaard
  1 sibling, 1 reply; 4+ messages in thread
From: Bernd Kuhls @ 2020-01-27 18:54 UTC (permalink / raw)
  To: buildroot

Fixes build error:

output/build/kodi-visualisation-goom-2.1.0-Leia/lib/goom/src/lines.c:
In function 'goom_lines_draw':
output/build/kodi-visualisation-goom-2.1.0-Leia/lib/goom/src/lines.c:232:3:
error: 'for' loop initial declarations are only allowed in C99 or C11 mode
   for (int i = 1; i < AUDIO_SAMPLE_LEN; i++) {

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/kodi-visualisation-goom/kodi-visualisation-goom.mk | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/kodi-visualisation-goom/kodi-visualisation-goom.mk b/package/kodi-visualisation-goom/kodi-visualisation-goom.mk
index d742e00e5a..0184d8474c 100644
--- a/package/kodi-visualisation-goom/kodi-visualisation-goom.mk
+++ b/package/kodi-visualisation-goom/kodi-visualisation-goom.mk
@@ -11,4 +11,7 @@ KODI_VISUALISATION_GOOM_LICENSE_FILES = src/Main.cpp
 
 KODI_VISUALISATION_GOOM_DEPENDENCIES = glm kodi
 
+KODI_VISUALISATION_GOOM_CONF_OPTS += \
+	-DCMAKE_C_FLAGS="-std=c11"
+
 $(eval $(cmake-package))
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/2] package/kodi-visualisation-goom: needs glm
  2020-01-27 18:54 [Buildroot] [PATCH 1/2] package/kodi-visualisation-goom: needs glm Bernd Kuhls
  2020-01-27 18:54 ` [Buildroot] [PATCH 2/2] package/kodi-visualisation-goom: fix build with gcc-4.9 Bernd Kuhls
@ 2020-01-28 14:58 ` Peter Korsgaard
  1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2020-01-28 14:58 UTC (permalink / raw)
  To: buildroot

>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:

 > See CMakeLists.txt:
 > https://github.com/xbmc/visualization.goom/blob/Leia/CMakeLists.txt#L7

 > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/2] package/kodi-visualisation-goom: fix build with gcc-4.9
  2020-01-27 18:54 ` [Buildroot] [PATCH 2/2] package/kodi-visualisation-goom: fix build with gcc-4.9 Bernd Kuhls
@ 2020-01-28 14:59   ` Peter Korsgaard
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2020-01-28 14:59 UTC (permalink / raw)
  To: buildroot

>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:

 > Fixes build error:
 > output/build/kodi-visualisation-goom-2.1.0-Leia/lib/goom/src/lines.c:
 > In function 'goom_lines_draw':
 > output/build/kodi-visualisation-goom-2.1.0-Leia/lib/goom/src/lines.c:232:3:
 > error: 'for' loop initial declarations are only allowed in C99 or C11 mode
 >    for (int i = 1; i < AUDIO_SAMPLE_LEN; i++) {

 > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-01-28 14:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-27 18:54 [Buildroot] [PATCH 1/2] package/kodi-visualisation-goom: needs glm Bernd Kuhls
2020-01-27 18:54 ` [Buildroot] [PATCH 2/2] package/kodi-visualisation-goom: fix build with gcc-4.9 Bernd Kuhls
2020-01-28 14:59   ` Peter Korsgaard
2020-01-28 14:58 ` [Buildroot] [PATCH 1/2] package/kodi-visualisation-goom: needs glm Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.