* [PATCH v1 0/5] uml: add more unspecified HAS_IOMEM dependencies
@ 2020-01-27 23:53 ` Brendan Higgins
0 siblings, 0 replies; 16+ messages in thread
From: Brendan Higgins @ 2020-01-27 23:53 UTC (permalink / raw)
To: jdike, richard, anton.ivanov, Kevin Hilman, Nishanth Menon,
Richard Cochran, Philipp Zabel, David S . Miller, Michal Simek,
Andrew Lunn, Robert Hancock, Esben Haabendal, Thomas Gleixner,
Radhey Shyam Pandey
Cc: heidifahim, Greg Kroah-Hartman, linux-pm, Brendan Higgins,
linux-kernel, linux-um, davidgow, netdev, linux-arm-kernel
# TL;DR
This patchset adds a missing HAS_IOMEM dependency to several drivers in
an attempt to get allyesconfig closer to working for ARCH=um. Although I
had caught all the broken ones in early 5.5[1], some new ones have
broken since then.
# What am I trying to do?
This patchset is part of my attempt to get `make ARCH=um allyesconfig`
to produce a config that will build *and* boot to init, so that I can
use it as a mechanism to run tests[2].
# Why won't allyesconfig break again after this series of fixes?
Well, in short, it will break again; however, as I mentioned above, I am
using UML for testing the kernel, and I am currently working on getting
my tests to run on KernelCI. As part of our testing procedure for
KernelCI, we are planning on building a UML kernel using allyesconfig
and running our tests on it. Thus, we will find out very quickly once
someone breaks allyesconfig again once we get this all working. So this
will keep breaking until we have a build test on KernelCI running, but
we will need to send out these fixes anyway.
Brendan Higgins (5):
net: axienet: add unspecified HAS_IOMEM dependency
reset: brcmstb-rescal: add unspecified HAS_IOMEM dependency
reset: intel: add unspecified HAS_IOMEM dependency
ptp: 1588_clock_ines: add unspecified HAS_IOMEM dependency
power: avs: qcom-cpr: add unspecified HAS_IOMEM dependency
drivers/net/ethernet/xilinx/Kconfig | 1 +
drivers/power/avs/Kconfig | 2 +-
drivers/ptp/Kconfig | 1 +
drivers/reset/Kconfig | 3 ++-
4 files changed, 5 insertions(+), 2 deletions(-)
[1] https://lore.kernel.org/lkml/20191211192742.95699-1-brendanhiggins@google.com/
[2] https://bugzilla.kernel.org/show_bug.cgi?id=205223
--
2.25.0.341.g760bfbb309-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v1 1/5] net: axienet: add unspecified HAS_IOMEM dependency
2020-01-27 23:53 ` Brendan Higgins
@ 2020-01-27 23:53 ` Brendan Higgins
-1 siblings, 0 replies; 16+ messages in thread
From: Brendan Higgins @ 2020-01-27 23:53 UTC (permalink / raw)
To: jdike, richard, anton.ivanov, David S . Miller, Michal Simek,
Andrew Lunn, Robert Hancock, Esben Haabendal, Thomas Gleixner,
Radhey Shyam Pandey
Cc: linux-um, linux-kernel, davidgow, heidifahim, Brendan Higgins,
Greg Kroah-Hartman, netdev, linux-arm-kernel
Currently CONFIG_XILINX_AXI_EMAC=y implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:
/usr/bin/ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.o: in function `axienet_probe':
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1680: undefined reference to `devm_ioremap_resource'
/usr/bin/ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1779: undefined reference to `devm_ioremap_resource'
/usr/bin/ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1789: undefined reference to `devm_ioremap_resource'
Fix the build error by adding the unspecified dependency.
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
drivers/net/ethernet/xilinx/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/xilinx/Kconfig b/drivers/net/ethernet/xilinx/Kconfig
index 6304ebd8b5c69..b1a285e693756 100644
--- a/drivers/net/ethernet/xilinx/Kconfig
+++ b/drivers/net/ethernet/xilinx/Kconfig
@@ -25,6 +25,7 @@ config XILINX_EMACLITE
config XILINX_AXI_EMAC
tristate "Xilinx 10/100/1000 AXI Ethernet support"
+ depends on HAS_IOMEM
select PHYLINK
---help---
This driver supports the 10/100/1000 Ethernet from Xilinx for the
--
2.25.0.341.g760bfbb309-goog
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v1 1/5] net: axienet: add unspecified HAS_IOMEM dependency
@ 2020-01-27 23:53 ` Brendan Higgins
0 siblings, 0 replies; 16+ messages in thread
From: Brendan Higgins @ 2020-01-27 23:53 UTC (permalink / raw)
To: jdike, richard, anton.ivanov, David S . Miller, Michal Simek,
Andrew Lunn, Robert Hancock, Esben Haabendal, Thomas Gleixner,
Radhey Shyam Pandey
Cc: heidifahim, Greg Kroah-Hartman, Brendan Higgins, linux-kernel,
linux-um, davidgow, netdev, linux-arm-kernel
Currently CONFIG_XILINX_AXI_EMAC=y implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:
/usr/bin/ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.o: in function `axienet_probe':
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1680: undefined reference to `devm_ioremap_resource'
/usr/bin/ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1779: undefined reference to `devm_ioremap_resource'
/usr/bin/ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1789: undefined reference to `devm_ioremap_resource'
Fix the build error by adding the unspecified dependency.
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
drivers/net/ethernet/xilinx/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/xilinx/Kconfig b/drivers/net/ethernet/xilinx/Kconfig
index 6304ebd8b5c69..b1a285e693756 100644
--- a/drivers/net/ethernet/xilinx/Kconfig
+++ b/drivers/net/ethernet/xilinx/Kconfig
@@ -25,6 +25,7 @@ config XILINX_EMACLITE
config XILINX_AXI_EMAC
tristate "Xilinx 10/100/1000 AXI Ethernet support"
+ depends on HAS_IOMEM
select PHYLINK
---help---
This driver supports the 10/100/1000 Ethernet from Xilinx for the
--
2.25.0.341.g760bfbb309-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v1 2/5] reset: brcmstb-rescal: add unspecified HAS_IOMEM dependency
2020-01-27 23:53 ` Brendan Higgins
@ 2020-01-27 23:53 ` Brendan Higgins
-1 siblings, 0 replies; 16+ messages in thread
From: Brendan Higgins @ 2020-01-27 23:53 UTC (permalink / raw)
To: jdike, richard, anton.ivanov, Philipp Zabel
Cc: linux-um, linux-kernel, davidgow, heidifahim, Brendan Higgins
Currently CONFIG_RESET_BRCMSTB_RESCAL=y implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:
/usr/bin/ld: drivers/reset/reset-brcmstb-rescal.o: in function `brcm_rescal_reset_probe':
drivers/reset/reset-brcmstb-rescal.c:76: undefined reference to `devm_ioremap_resource'
Fix the build error by adding the unspecified dependency.
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
drivers/reset/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 461b0e506a26f..a19bd303f31a9 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -51,6 +51,7 @@ config RESET_BRCMSTB
config RESET_BRCMSTB_RESCAL
bool "Broadcom STB RESCAL reset controller"
+ depends on HAS_IOMEM
default ARCH_BRCMSTB || COMPILE_TEST
help
This enables the RESCAL reset controller for SATA, PCIe0, or PCIe1 on
--
2.25.0.341.g760bfbb309-goog
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v1 2/5] reset: brcmstb-rescal: add unspecified HAS_IOMEM dependency
@ 2020-01-27 23:53 ` Brendan Higgins
0 siblings, 0 replies; 16+ messages in thread
From: Brendan Higgins @ 2020-01-27 23:53 UTC (permalink / raw)
To: jdike, richard, anton.ivanov, Philipp Zabel
Cc: Brendan Higgins, linux-um, linux-kernel, davidgow, heidifahim
Currently CONFIG_RESET_BRCMSTB_RESCAL=y implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:
/usr/bin/ld: drivers/reset/reset-brcmstb-rescal.o: in function `brcm_rescal_reset_probe':
drivers/reset/reset-brcmstb-rescal.c:76: undefined reference to `devm_ioremap_resource'
Fix the build error by adding the unspecified dependency.
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
drivers/reset/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 461b0e506a26f..a19bd303f31a9 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -51,6 +51,7 @@ config RESET_BRCMSTB
config RESET_BRCMSTB_RESCAL
bool "Broadcom STB RESCAL reset controller"
+ depends on HAS_IOMEM
default ARCH_BRCMSTB || COMPILE_TEST
help
This enables the RESCAL reset controller for SATA, PCIe0, or PCIe1 on
--
2.25.0.341.g760bfbb309-goog
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v1 2/5] reset: brcmstb-rescal: add unspecified HAS_IOMEM dependency
2020-01-27 23:53 ` Brendan Higgins
@ 2020-01-28 9:22 ` Philipp Zabel
-1 siblings, 0 replies; 16+ messages in thread
From: Philipp Zabel @ 2020-01-28 9:22 UTC (permalink / raw)
To: Brendan Higgins, jdike, richard, anton.ivanov
Cc: linux-um, linux-kernel, davidgow, heidifahim
On Mon, 2020-01-27 at 15:53 -0800, Brendan Higgins wrote:
> Currently CONFIG_RESET_BRCMSTB_RESCAL=y implicitly depends on
> CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> the following build error:
>
> /usr/bin/ld: drivers/reset/reset-brcmstb-rescal.o: in function `brcm_rescal_reset_probe':
> drivers/reset/reset-brcmstb-rescal.c:76: undefined reference to `devm_ioremap_resource'
>
> Fix the build error by adding the unspecified dependency.
>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> ---
> drivers/reset/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 461b0e506a26f..a19bd303f31a9 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -51,6 +51,7 @@ config RESET_BRCMSTB
>
> config RESET_BRCMSTB_RESCAL
> bool "Broadcom STB RESCAL reset controller"
> + depends on HAS_IOMEM
> default ARCH_BRCMSTB || COMPILE_TEST
> help
> This enables the RESCAL reset controller for SATA, PCIe0, or PCIe1 on
Thank you, I'll pick up the reset patches 2 and 3.
regards
Philipp
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v1 2/5] reset: brcmstb-rescal: add unspecified HAS_IOMEM dependency
@ 2020-01-28 9:22 ` Philipp Zabel
0 siblings, 0 replies; 16+ messages in thread
From: Philipp Zabel @ 2020-01-28 9:22 UTC (permalink / raw)
To: Brendan Higgins, jdike, richard, anton.ivanov
Cc: linux-um, linux-kernel, davidgow, heidifahim
On Mon, 2020-01-27 at 15:53 -0800, Brendan Higgins wrote:
> Currently CONFIG_RESET_BRCMSTB_RESCAL=y implicitly depends on
> CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> the following build error:
>
> /usr/bin/ld: drivers/reset/reset-brcmstb-rescal.o: in function `brcm_rescal_reset_probe':
> drivers/reset/reset-brcmstb-rescal.c:76: undefined reference to `devm_ioremap_resource'
>
> Fix the build error by adding the unspecified dependency.
>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> ---
> drivers/reset/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 461b0e506a26f..a19bd303f31a9 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -51,6 +51,7 @@ config RESET_BRCMSTB
>
> config RESET_BRCMSTB_RESCAL
> bool "Broadcom STB RESCAL reset controller"
> + depends on HAS_IOMEM
> default ARCH_BRCMSTB || COMPILE_TEST
> help
> This enables the RESCAL reset controller for SATA, PCIe0, or PCIe1 on
Thank you, I'll pick up the reset patches 2 and 3.
regards
Philipp
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v1 3/5] reset: intel: add unspecified HAS_IOMEM dependency
2020-01-27 23:53 ` Brendan Higgins
@ 2020-01-27 23:53 ` Brendan Higgins
-1 siblings, 0 replies; 16+ messages in thread
From: Brendan Higgins @ 2020-01-27 23:53 UTC (permalink / raw)
To: jdike, richard, anton.ivanov, Philipp Zabel
Cc: linux-um, linux-kernel, davidgow, heidifahim, Brendan Higgins
Currently CONFIG_RESET_INTEL_GW=y implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:
/usr/bin/ld: drivers/reset/reset-intel-gw.o: in function `intel_reset_probe':
drivers/reset/reset-intel-gw.c:185: undefined reference to `devm_platform_ioremap_resource'
Fix the build error by adding the unspecified dependency.
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
drivers/reset/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index a19bd303f31a9..d9efbfd296463 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -74,7 +74,7 @@ config RESET_IMX7
config RESET_INTEL_GW
bool "Intel Reset Controller Driver"
- depends on OF
+ depends on OF && HAS_IOMEM
select REGMAP_MMIO
help
This enables the reset controller driver for Intel Gateway SoCs.
--
2.25.0.341.g760bfbb309-goog
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v1 3/5] reset: intel: add unspecified HAS_IOMEM dependency
@ 2020-01-27 23:53 ` Brendan Higgins
0 siblings, 0 replies; 16+ messages in thread
From: Brendan Higgins @ 2020-01-27 23:53 UTC (permalink / raw)
To: jdike, richard, anton.ivanov, Philipp Zabel
Cc: Brendan Higgins, linux-um, linux-kernel, davidgow, heidifahim
Currently CONFIG_RESET_INTEL_GW=y implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:
/usr/bin/ld: drivers/reset/reset-intel-gw.o: in function `intel_reset_probe':
drivers/reset/reset-intel-gw.c:185: undefined reference to `devm_platform_ioremap_resource'
Fix the build error by adding the unspecified dependency.
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
drivers/reset/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index a19bd303f31a9..d9efbfd296463 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -74,7 +74,7 @@ config RESET_IMX7
config RESET_INTEL_GW
bool "Intel Reset Controller Driver"
- depends on OF
+ depends on OF && HAS_IOMEM
select REGMAP_MMIO
help
This enables the reset controller driver for Intel Gateway SoCs.
--
2.25.0.341.g760bfbb309-goog
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v1 4/5] ptp: 1588_clock_ines: add unspecified HAS_IOMEM dependency
2020-01-27 23:53 ` Brendan Higgins
@ 2020-01-27 23:53 ` Brendan Higgins
-1 siblings, 0 replies; 16+ messages in thread
From: Brendan Higgins @ 2020-01-27 23:53 UTC (permalink / raw)
To: jdike, richard, anton.ivanov, Richard Cochran
Cc: linux-um, linux-kernel, davidgow, heidifahim, Brendan Higgins, netdev
Currently CONFIG_PTP_1588_CLOCK_INES=y implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:
/usr/bin/ld: drivers/ptp/ptp_ines.o: in function `ines_ptp_ctrl_probe':
drivers/ptp/ptp_ines.c:795: undefined reference to `devm_ioremap_resource'
Fix the build error by adding the unspecified dependency.
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
drivers/ptp/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
index 475c60dccaa4f..17e670fa1d4c8 100644
--- a/drivers/ptp/Kconfig
+++ b/drivers/ptp/Kconfig
@@ -80,6 +80,7 @@ config PTP_1588_CLOCK_INES
depends on NETWORK_PHY_TIMESTAMPING
depends on PHYLIB
depends on PTP_1588_CLOCK
+ depends on HAS_IOMEM
help
This driver adds support for using the ZHAW InES 1588 IP
core. This clock is only useful if the MII bus of your MAC
--
2.25.0.341.g760bfbb309-goog
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v1 4/5] ptp: 1588_clock_ines: add unspecified HAS_IOMEM dependency
@ 2020-01-27 23:53 ` Brendan Higgins
0 siblings, 0 replies; 16+ messages in thread
From: Brendan Higgins @ 2020-01-27 23:53 UTC (permalink / raw)
To: jdike, richard, anton.ivanov, Richard Cochran
Cc: heidifahim, netdev, Brendan Higgins, linux-kernel, linux-um, davidgow
Currently CONFIG_PTP_1588_CLOCK_INES=y implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:
/usr/bin/ld: drivers/ptp/ptp_ines.o: in function `ines_ptp_ctrl_probe':
drivers/ptp/ptp_ines.c:795: undefined reference to `devm_ioremap_resource'
Fix the build error by adding the unspecified dependency.
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
drivers/ptp/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
index 475c60dccaa4f..17e670fa1d4c8 100644
--- a/drivers/ptp/Kconfig
+++ b/drivers/ptp/Kconfig
@@ -80,6 +80,7 @@ config PTP_1588_CLOCK_INES
depends on NETWORK_PHY_TIMESTAMPING
depends on PHYLIB
depends on PTP_1588_CLOCK
+ depends on HAS_IOMEM
help
This driver adds support for using the ZHAW InES 1588 IP
core. This clock is only useful if the MII bus of your MAC
--
2.25.0.341.g760bfbb309-goog
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v1 4/5] ptp: 1588_clock_ines: add unspecified HAS_IOMEM dependency
2020-01-27 23:53 ` Brendan Higgins
@ 2020-01-28 14:58 ` Richard Cochran
-1 siblings, 0 replies; 16+ messages in thread
From: Richard Cochran @ 2020-01-28 14:58 UTC (permalink / raw)
To: Brendan Higgins
Cc: jdike, richard, anton.ivanov, linux-um, linux-kernel, davidgow,
heidifahim, netdev
On Mon, Jan 27, 2020 at 03:53:55PM -0800, Brendan Higgins wrote:
> Currently CONFIG_PTP_1588_CLOCK_INES=y implicitly depends on
> CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> the following build error:
>
> /usr/bin/ld: drivers/ptp/ptp_ines.o: in function `ines_ptp_ctrl_probe':
> drivers/ptp/ptp_ines.c:795: undefined reference to `devm_ioremap_resource'
>
> Fix the build error by adding the unspecified dependency.
>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v1 4/5] ptp: 1588_clock_ines: add unspecified HAS_IOMEM dependency
@ 2020-01-28 14:58 ` Richard Cochran
0 siblings, 0 replies; 16+ messages in thread
From: Richard Cochran @ 2020-01-28 14:58 UTC (permalink / raw)
To: Brendan Higgins
Cc: heidifahim, richard, jdike, linux-um, linux-kernel, davidgow,
netdev, anton.ivanov
On Mon, Jan 27, 2020 at 03:53:55PM -0800, Brendan Higgins wrote:
> Currently CONFIG_PTP_1588_CLOCK_INES=y implicitly depends on
> CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> the following build error:
>
> /usr/bin/ld: drivers/ptp/ptp_ines.o: in function `ines_ptp_ctrl_probe':
> drivers/ptp/ptp_ines.c:795: undefined reference to `devm_ioremap_resource'
>
> Fix the build error by adding the unspecified dependency.
>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v1 5/5] power: avs: qcom-cpr: add unspecified HAS_IOMEM dependency
2020-01-27 23:53 ` Brendan Higgins
@ 2020-01-27 23:53 ` Brendan Higgins
-1 siblings, 0 replies; 16+ messages in thread
From: Brendan Higgins @ 2020-01-27 23:53 UTC (permalink / raw)
To: jdike, richard, anton.ivanov, Kevin Hilman, Nishanth Menon
Cc: linux-um, linux-kernel, davidgow, heidifahim, Brendan Higgins, linux-pm
Currently CONFIG_QCOM_CPR=y implicitly depends on CONFIG_HAS_IOMEM=y;
consequently, on architectures without IOMEM we get the following build
error:
/usr/bin/ld: drivers/power/avs/qcom-cpr.o: in function `cpr_probe':
drivers/power/avs/qcom-cpr.c:1690: undefined reference to `devm_ioremap_resource'
Fix the build error by adding the unspecified dependency.
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
drivers/power/avs/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/avs/Kconfig b/drivers/power/avs/Kconfig
index b8fe166cd0d9f..cdb4237bfd02e 100644
--- a/drivers/power/avs/Kconfig
+++ b/drivers/power/avs/Kconfig
@@ -14,7 +14,7 @@ menuconfig POWER_AVS
config QCOM_CPR
tristate "QCOM Core Power Reduction (CPR) support"
- depends on POWER_AVS
+ depends on POWER_AVS && HAS_IOMEM
select PM_OPP
select REGMAP
help
--
2.25.0.341.g760bfbb309-goog
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v1 5/5] power: avs: qcom-cpr: add unspecified HAS_IOMEM dependency
@ 2020-01-27 23:53 ` Brendan Higgins
0 siblings, 0 replies; 16+ messages in thread
From: Brendan Higgins @ 2020-01-27 23:53 UTC (permalink / raw)
To: jdike, richard, anton.ivanov, Kevin Hilman, Nishanth Menon
Cc: linux-pm, linux-um, heidifahim, Brendan Higgins, linux-kernel, davidgow
Currently CONFIG_QCOM_CPR=y implicitly depends on CONFIG_HAS_IOMEM=y;
consequently, on architectures without IOMEM we get the following build
error:
/usr/bin/ld: drivers/power/avs/qcom-cpr.o: in function `cpr_probe':
drivers/power/avs/qcom-cpr.c:1690: undefined reference to `devm_ioremap_resource'
Fix the build error by adding the unspecified dependency.
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
drivers/power/avs/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/avs/Kconfig b/drivers/power/avs/Kconfig
index b8fe166cd0d9f..cdb4237bfd02e 100644
--- a/drivers/power/avs/Kconfig
+++ b/drivers/power/avs/Kconfig
@@ -14,7 +14,7 @@ menuconfig POWER_AVS
config QCOM_CPR
tristate "QCOM Core Power Reduction (CPR) support"
- depends on POWER_AVS
+ depends on POWER_AVS && HAS_IOMEM
select PM_OPP
select REGMAP
help
--
2.25.0.341.g760bfbb309-goog
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply related [flat|nested] 16+ messages in thread