[PATCH blktests v1 0/2] nmve/018 fixes

[PATCH blktests v1 0/2] nmve/018 fixes

[Daniel Wagner]

changes from v0:
  - added "nmve/018: Reword misleading error message"

Daniel Wagner (2):
  nvme/018: Ignore message generated by nvme read
  nmve/018: Reword misleading error message

 tests/nvme/018 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.16.4

[PATCH blktests v1 1/2] nvme/018: Ignore message generated by nvme read

[Daniel Wagner]

nvme-cli writes 'CAP_EXCEEDED' message also on stdout not just
stderr. This lets the test fail as well.

Fixes: 1aee5f430b30 ("nvme/018: Ignore error message generated by nvme read")
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
 tests/nvme/018 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/nvme/018 b/tests/nvme/018
index 0a5b4c2ab019..d0f15db23538 100755
--- a/tests/nvme/018
+++ b/tests/nvme/018
@@ -43,7 +43,7 @@ test() {
 	sectors="$(blockdev --getsz "/dev/${nvmedev}n1")"
 	bs="$(blockdev --getbsz "/dev/${nvmedev}n1")"
 
-	nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" 2>"$FULL" \
+	nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" &>"$FULL" \
 		&& echo "ERROR: Successfully read out of device lba range"
 
 	nvme disconnect -n "${subsys_name}"
-- 
2.16.4

[PATCH blktests v1 2/2] nmve/018: Reword misleading error message

[Daniel Wagner]

'nvme read' is expected to fail, though the error message "ERROR:
Successfully..." is misleading. Reword the error text to clarify the
real indent of the test and what failed.

Reported-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
 tests/nvme/018 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/nvme/018 b/tests/nvme/018
index d0f15db23538..aa9681b312f7 100755
--- a/tests/nvme/018
+++ b/tests/nvme/018
@@ -44,7 +44,7 @@ test() {
 	bs="$(blockdev --getbsz "/dev/${nvmedev}n1")"
 
 	nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" &>"$FULL" \
-		&& echo "ERROR: Successfully read out of device lba range"
+		&& echo "ERROR: nvme read was successful for out of range lba"
 
 	nvme disconnect -n "${subsys_name}"
 
-- 
2.16.4

Re: [PATCH blktests v1 0/2] nmve/018 fixes

[Logan Gunthorpe]

Thanks!

For both patches:

Reviewed-by: Logan Gunthorpe <logang@deltatee.com>

On 2020-01-28 1:44 a.m., Daniel Wagner wrote:
> changes from v0:
>   - added "nmve/018: Reword misleading error message"
> 
> Daniel Wagner (2):
>   nvme/018: Ignore message generated by nvme read
>   nmve/018: Reword misleading error message
> 
>  tests/nvme/018 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

RE: [PATCH blktests v1 2/2] nmve/018: Reword misleading error message

[Elliott, Robert (Servers)]

> -----Original Message-----
> From: linux-block-owner@vger.kernel.org <linux-block-
> owner@vger.kernel.org> On Behalf Of Daniel Wagner
> Sent: Tuesday, January 28, 2020 2:45 AM
> Subject: [PATCH blktests v1 2/2] nmve/018: Reword misleading error message
> 
> 'nvme read' is expected to fail, though the error message "ERROR:
> Successfully..." is misleading. Reword the error text to clarify the
> real indent of the test and what failed.

intent

> 
> Reported-by: Logan Gunthorpe <logang@deltatee.com>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
...
> -		&& echo "ERROR: Successfully read out of device lba range"
> +		&& echo "ERROR: nvme read was successful for out of range lba"
> 

To avoid being picked up by a grep for "success", you could use:
    ERROR: nvme read for out of range LBA was not rejected

Re: [PATCH blktests v1 0/2] nmve/018 fixes

[Keith Busch]

On Tue, Jan 28, 2020 at 09:44:32AM +0100, Daniel Wagner wrote:
>   nmve/018: Reword misleading error message

s/nmve/nvme

Otherwise looks good.

Reviewed-by: Keith Busch <kbusch@kernel.org>