All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: robh+dt@kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, hch@lst.de, ulf.hansson@linaro.org,
	chzigotzky@xenosoft.de, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] of: Add OF_DMA_DEFAULT_COHERENT & select it on powerpc
Date: Tue, 28 Jan 2020 08:26:46 -0600	[thread overview]
Message-ID: <20200128142646.GA17341@bogus> (raw)
In-Reply-To: <20200126115247.13402-1-mpe@ellerman.id.au>

On Sun, 26 Jan 2020 22:52:47 +1100, Michael Ellerman wrote:
> There's an OF helper called of_dma_is_coherent(), which checks if a
> device has a "dma-coherent" property to see if the device is coherent
> for DMA.
> 
> But on some platforms devices are coherent by default, and on some
> platforms it's not possible to update existing device trees to add the
> "dma-coherent" property.
> 
> So add a Kconfig symbol to allow arch code to tell
> of_dma_is_coherent() that devices are coherent by default, regardless
> of the presence of the property.
> 
> Select that symbol on powerpc when NOT_COHERENT_CACHE is not set, ie.
> when the system has a coherent cache.
> 
> Fixes: 92ea637edea3 ("of: introduce of_dma_is_coherent() helper")
> Cc: stable@vger.kernel.org # v3.16+
> Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
> Tested-by: Christian Zigotzky <chzigotzky@xenosoft.de>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
>  arch/powerpc/Kconfig | 1 +
>  drivers/of/Kconfig   | 4 ++++
>  drivers/of/address.c | 6 +++++-
>  3 files changed, 10 insertions(+), 1 deletion(-)
> 

Applied, thanks.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: devicetree@vger.kernel.org, ulf.hansson@linaro.org,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	robh+dt@kernel.org, chzigotzky@xenosoft.de, hch@lst.de
Subject: Re: [PATCH] of: Add OF_DMA_DEFAULT_COHERENT & select it on powerpc
Date: Tue, 28 Jan 2020 08:26:46 -0600	[thread overview]
Message-ID: <20200128142646.GA17341@bogus> (raw)
In-Reply-To: <20200126115247.13402-1-mpe@ellerman.id.au>

On Sun, 26 Jan 2020 22:52:47 +1100, Michael Ellerman wrote:
> There's an OF helper called of_dma_is_coherent(), which checks if a
> device has a "dma-coherent" property to see if the device is coherent
> for DMA.
> 
> But on some platforms devices are coherent by default, and on some
> platforms it's not possible to update existing device trees to add the
> "dma-coherent" property.
> 
> So add a Kconfig symbol to allow arch code to tell
> of_dma_is_coherent() that devices are coherent by default, regardless
> of the presence of the property.
> 
> Select that symbol on powerpc when NOT_COHERENT_CACHE is not set, ie.
> when the system has a coherent cache.
> 
> Fixes: 92ea637edea3 ("of: introduce of_dma_is_coherent() helper")
> Cc: stable@vger.kernel.org # v3.16+
> Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
> Tested-by: Christian Zigotzky <chzigotzky@xenosoft.de>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
>  arch/powerpc/Kconfig | 1 +
>  drivers/of/Kconfig   | 4 ++++
>  drivers/of/address.c | 6 +++++-
>  3 files changed, 10 insertions(+), 1 deletion(-)
> 

Applied, thanks.

Rob

  parent reply	other threads:[~2020-01-28 14:32 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-26 11:52 [PATCH] of: Add OF_DMA_DEFAULT_COHERENT & select it on powerpc Michael Ellerman
2020-01-26 11:52 ` Michael Ellerman
2020-01-27  7:22 ` Ulf Hansson
2020-01-27  7:22   ` Ulf Hansson
2020-01-31 10:40   ` Michael Ellerman
2020-01-31 10:40     ` Michael Ellerman
2020-02-02  0:08   ` Latest Git kernel: avahi-daemon[2410]: ioctl(): Inappropriate ioctl for device Christian Zigotzky
2020-02-02  0:08     ` Christian Zigotzky
2020-02-02  4:37     ` Randy Dunlap
2020-02-02  4:37       ` Randy Dunlap
2020-02-02  8:19     ` Christophe Leroy
2020-02-02 15:02       ` Christian Zigotzky
2020-02-03 17:53         ` Jakub Kicinski
2020-02-03 17:53           ` Jakub Kicinski
2020-02-05 13:03           ` Christian Zigotzky
2020-02-05 13:03             ` Christian Zigotzky
2020-02-05 14:36           ` Christian Zigotzky
2020-02-06  4:35             ` Michael Ellerman
2020-02-06  4:35               ` Michael Ellerman
2020-02-06 14:28               ` Christian Zigotzky
2020-02-06 14:28                 ` Christian Zigotzky
2020-02-08 12:36                 ` Michael Ellerman
2020-02-08 12:36                   ` Michael Ellerman
2020-02-07 14:34               ` Christian Zigotzky
2020-02-07 14:34                 ` Christian Zigotzky
2020-02-07 17:08                 ` Arnd Bergmann
2020-02-07 17:08                   ` Arnd Bergmann
2020-02-08  6:59                   ` Christian Zigotzky
2020-02-08  6:59                     ` Christian Zigotzky
2020-02-08 16:08                     ` Christian Zigotzky
2020-02-08 16:08                       ` Christian Zigotzky
2020-01-27 17:30 ` [PATCH] of: Add OF_DMA_DEFAULT_COHERENT & select it on powerpc Frank Rowand
2020-01-27 17:30   ` Frank Rowand
2020-01-28 14:26 ` Rob Herring [this message]
2020-01-28 14:26   ` Rob Herring
2020-01-31 10:40   ` Michael Ellerman
2020-01-31 10:40     ` Michael Ellerman
2020-02-06  2:03 Yangbo Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200128142646.GA17341@bogus \
    --to=robh@kernel.org \
    --cc=chzigotzky@xenosoft.de \
    --cc=devicetree@vger.kernel.org \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=robh+dt@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.