* [PATCH] Staging: vt6655: device_main: cleanup long line
[not found] <20200129001950.12031-1-simon.fong.ref@aol.com>
@ 2020-01-29 0:19 ` Simon Fong
0 siblings, 0 replies; 5+ messages in thread
From: Simon Fong @ 2020-01-29 0:19 UTC (permalink / raw)
To: linux-kernel; +Cc: Simon Fong
From: Simon Fong <simon.fongnt@yahoo.com>
cleanup a long line coding style warning.
Signed-off-by: Simon Fong <simon.fongnt@yahoo.com>
---
drivers/staging/vt6655/device_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index f69fc687d4c3..0442f71494b2 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -133,7 +133,8 @@ static int device_init_td1_ring(struct vnt_private *priv);
static int device_rx_srv(struct vnt_private *priv, unsigned int idx);
static int device_tx_srv(struct vnt_private *priv, unsigned int idx);
static bool device_alloc_rx_buf(struct vnt_private *, struct vnt_rx_desc *);
-static void device_free_rx_buf(struct vnt_private *priv, struct vnt_rx_desc *rd);
+static void device_free_rx_buf(struct vnt_private *priv,
+ struct vnt_rx_desc *rd);
static void device_init_registers(struct vnt_private *priv);
static void device_free_tx_buf(struct vnt_private *, struct vnt_tx_desc *);
static void device_free_td0_ring(struct vnt_private *priv);
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: vt6655: device_main: cleanup long line
2020-03-08 6:50 ` Greg KH
@ 2020-03-08 13:49 ` Lourdes Pedrajas
0 siblings, 0 replies; 5+ messages in thread
From: Lourdes Pedrajas @ 2020-03-08 13:49 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel
On Sun, Mar 08, 2020 at 07:50:10AM +0100, Greg KH wrote:
> On Sun, Mar 08, 2020 at 12:06:31AM +0100, Lourdes Pedrajas wrote:
> > Code cleanup: long line found by checkpatch.
> >
> > Changes to be committed:
> > modified: drivers/staging/vt6655/device_main.c
>
> Why are these two lines in the changelog text?
>
My mistake, I thought it is correct to include them, sorry!
> >
> > Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> > ---
> > drivers/staging/vt6655/device_main.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> > index 0442f71494b2..88e1284a7743 100644
> > --- a/drivers/staging/vt6655/device_main.c
> > +++ b/drivers/staging/vt6655/device_main.c
> > @@ -1075,7 +1075,8 @@ static void vnt_interrupt_process(struct vnt_private *priv)
> > priv->op_mode == NL80211_IFTYPE_ADHOC) &&
> > priv->vif->bss_conf.enable_beacon) {
> > MACvOneShotTimer1MicroSec(priv,
> > - (priv->vif->bss_conf.beacon_int - MAKE_BEACON_RESERVED) << 10);
> > + (priv->vif->bss_conf.beacon_int -
> > + MAKE_BEACON_RESERVED) << 10);
>
> Now you have another checkpatch warning :(
>
> THe original is fine, the line-length is a "strong hint" that sometimes
> needs to be gone over.
>
> sorry.
>
> greg k-h
I also had my doubts about this one, thank you for clarifying!
Lourdes.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: vt6655: device_main: cleanup long line
2020-03-07 23:06 Lourdes Pedrajas
@ 2020-03-08 6:50 ` Greg KH
2020-03-08 13:49 ` Lourdes Pedrajas
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2020-03-08 6:50 UTC (permalink / raw)
To: Lourdes Pedrajas; +Cc: outreachy-kernel
On Sun, Mar 08, 2020 at 12:06:31AM +0100, Lourdes Pedrajas wrote:
> Code cleanup: long line found by checkpatch.
>
> Changes to be committed:
> modified: drivers/staging/vt6655/device_main.c
Why are these two lines in the changelog text?
>
> Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> ---
> drivers/staging/vt6655/device_main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index 0442f71494b2..88e1284a7743 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -1075,7 +1075,8 @@ static void vnt_interrupt_process(struct vnt_private *priv)
> priv->op_mode == NL80211_IFTYPE_ADHOC) &&
> priv->vif->bss_conf.enable_beacon) {
> MACvOneShotTimer1MicroSec(priv,
> - (priv->vif->bss_conf.beacon_int - MAKE_BEACON_RESERVED) << 10);
> + (priv->vif->bss_conf.beacon_int -
> + MAKE_BEACON_RESERVED) << 10);
Now you have another checkpatch warning :(
THe original is fine, the line-length is a "strong hint" that sometimes
needs to be gone over.
sorry.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Staging: vt6655: device_main: cleanup long line
@ 2020-03-07 23:06 Lourdes Pedrajas
2020-03-08 6:50 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Lourdes Pedrajas @ 2020-03-07 23:06 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Code cleanup: long line found by checkpatch.
Changes to be committed:
modified: drivers/staging/vt6655/device_main.c
Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
---
drivers/staging/vt6655/device_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index 0442f71494b2..88e1284a7743 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -1075,7 +1075,8 @@ static void vnt_interrupt_process(struct vnt_private *priv)
priv->op_mode == NL80211_IFTYPE_ADHOC) &&
priv->vif->bss_conf.enable_beacon) {
MACvOneShotTimer1MicroSec(priv,
- (priv->vif->bss_conf.beacon_int - MAKE_BEACON_RESERVED) << 10);
+ (priv->vif->bss_conf.beacon_int -
+ MAKE_BEACON_RESERVED) << 10);
}
/* TODO: adhoc PS mode */
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] Staging: vt6655: device_main: cleanup long line
[not found] <20200128141426.12230-1-simon.fongnt.ref@yahoo.com>
@ 2020-01-28 14:14 ` Simon Fong
0 siblings, 0 replies; 5+ messages in thread
From: Simon Fong @ 2020-01-28 14:14 UTC (permalink / raw)
To: forest; +Cc: devel, gregkh, linux-kernel, Simon Fong
cleanup a long line coding style warning.
Signed-off-by: Simon Fong <simon.fongnt@yahoo.com>
---
drivers/staging/vt6655/device_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index f69fc687d4c3..0442f71494b2 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -133,7 +133,8 @@ static int device_init_td1_ring(struct vnt_private *priv);
static int device_rx_srv(struct vnt_private *priv, unsigned int idx);
static int device_tx_srv(struct vnt_private *priv, unsigned int idx);
static bool device_alloc_rx_buf(struct vnt_private *, struct vnt_rx_desc *);
-static void device_free_rx_buf(struct vnt_private *priv, struct vnt_rx_desc *rd);
+static void device_free_rx_buf(struct vnt_private *priv,
+ struct vnt_rx_desc *rd);
static void device_init_registers(struct vnt_private *priv);
static void device_free_tx_buf(struct vnt_private *, struct vnt_tx_desc *);
static void device_free_td0_ring(struct vnt_private *priv);
--
2.17.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-08 13:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200129001950.12031-1-simon.fong.ref@aol.com>
2020-01-29 0:19 ` [PATCH] Staging: vt6655: device_main: cleanup long line Simon Fong
2020-03-07 23:06 Lourdes Pedrajas
2020-03-08 6:50 ` Greg KH
2020-03-08 13:49 ` Lourdes Pedrajas
[not found] <20200128141426.12230-1-simon.fongnt.ref@yahoo.com>
2020-01-28 14:14 ` Simon Fong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.