[igt-dev] [PATCH i-g-t] tests/i915/gem_largeobject: Remove test

* [igt-dev] [PATCH i-g-t] tests/i915/gem_largeobject: Remove test
@ 2020-01-29 22:14 Vinay Belgaumkar
  2020-01-29 22:27 ` Chris Wilson
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Vinay Belgaumkar @ 2020-01-29 22:14 UTC (permalink / raw)
  To: igt-dev

Other tests already provide better coverage.

Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/Makefile.sources       |  3 --
 tests/i915/gem_largeobject.c | 88 ------------------------------------
 tests/meson.build            |  1 -
 3 files changed, 92 deletions(-)
 delete mode 100644 tests/i915/gem_largeobject.c

diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index 17397c8f..9191e466 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -294,9 +294,6 @@ gem_gtt_hog_SOURCES = i915/gem_gtt_hog.c
 TESTS_progs += gem_gtt_speed
 gem_gtt_speed_SOURCES = i915/gem_gtt_speed.c
 
-TESTS_progs += gem_largeobject
-gem_largeobject_SOURCES = i915/gem_largeobject.c
-
 TESTS_progs += gem_linear_blits
 gem_linear_blits_SOURCES = i915/gem_linear_blits.c
 
diff --git a/tests/i915/gem_largeobject.c b/tests/i915/gem_largeobject.c
deleted file mode 100644
index fc9296cd..00000000
--- a/tests/i915/gem_largeobject.c
+++ /dev/null
@@ -1,88 +0,0 @@
-/*
- * Copyright © 2008 Intel Corporation
- *
- * Permission is hereby granted, free of charge, to any person obtaining a
- * copy of this software and associated documentation files (the "Software"),
- * to deal in the Software without restriction, including without limitation
- * the rights to use, copy, modify, merge, publish, distribute, sublicense,
- * and/or sell copies of the Software, and to permit persons to whom the
- * Software is furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice (including the next
- * paragraph) shall be included in all copies or substantial portions of the
- * Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
- * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
- * IN THE SOFTWARE.
- *
- * Authors:
- *    Jesse Barnes <jbarnes@virtuousgeek.org>
- *
- */
-
-#include "igt.h"
-#include <stdlib.h>
-#include <stdio.h>
-#include <string.h>
-#include <fcntl.h>
-#include <inttypes.h>
-#include <errno.h>
-#include <sys/stat.h>
-#include <sys/ioctl.h>
-#include "drm.h"
-
-/* Should take 64 pages to store the page pointers on 64 bit */
-#define OBJ_SIZE (128 * 1024 * 1024)
-
-unsigned char *data;
-
-static void
-test_large_object(int fd)
-{
-	struct drm_i915_gem_create create;
-	struct drm_i915_gem_pin pin;
-	uint32_t obj_size;
-	char *ptr;
-
-	memset(&create, 0, sizeof(create));
-	memset(&pin, 0, sizeof(pin));
-
-	if (gem_aperture_size(fd)*3/4 < OBJ_SIZE/2)
-		obj_size = OBJ_SIZE / 4;
-	else if (gem_aperture_size(fd)*3/4 < OBJ_SIZE)
-		obj_size = OBJ_SIZE / 2;
-	else
-		obj_size = OBJ_SIZE;
-	create.size = obj_size;
-	igt_info("obj size %i\n", obj_size);
-
-	igt_assert(ioctl(fd, DRM_IOCTL_I915_GEM_CREATE, &create) == 0);
-
-	/* prefault */
-	ptr = gem_mmap__gtt(fd, create.handle, obj_size,
-			    PROT_WRITE | PROT_READ);
-	*ptr = 0;
-
-	gem_write(fd, create.handle, 0, data, obj_size);
-
-	/* kernel should clean this up for us */
-}
-
-igt_simple_main
-{
-	int fd;
-
-	data = malloc(OBJ_SIZE);
-	igt_assert(data);
-
-	fd = drm_open_driver(DRIVER_INTEL);
-
-	test_large_object(fd);
-
-	free(data);
-}
diff --git a/tests/meson.build b/tests/meson.build
index a417ceb9..7bacaef3 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -164,7 +164,6 @@ i915_progs = [
 	'gem_gtt_cpu_tlb',
 	'gem_gtt_hog',
 	'gem_gtt_speed',
-	'gem_largeobject',
 	'gem_linear_blits',
 	'gem_lut_handle',
 	'gem_madvise',
-- 
2.22.0.245.g4d8ec15c66

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 4+ messages in thread