* [Intel-gfx] [PATCH] drm/i915/gem: Require per-engine reset support for non-persistent contexts
@ 2020-01-30 16:43 Chris Wilson
2020-01-30 16:45 ` Chris Wilson
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Chris Wilson @ 2020-01-30 16:43 UTC (permalink / raw)
To: intel-gfx
To enable non-persistent contexts, we require a means of cancelling any
inflight work from that context. This is first done "gracefully" by
using preemption to kick the active context off the engine, and then
forcefully by resetting the engine if it is active. If we are unable to
reset the engine to remove hostile userspace, we should not allow
userspace to opt into using non-persistent contexts.
Fixes: a0e047156cde ("drm/i915/gem: Make context persistence optional")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Jon Bloomfield <jon.bloomfield@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
index 86eef1bcfcb3..c8417fe3f32c 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
@@ -565,6 +565,10 @@ static int __context_set_persistence(struct i915_gem_context *ctx, bool state)
if (!(ctx->i915->caps.scheduler & I915_SCHEDULER_CAP_PREEMPTION))
return -ENODEV;
+ /* If the cancel fails, we then need to reset, cleanly! */
+ if (!intel_has_reset_engine(ctx->gt))
+ return -ENODEV;
+
i915_gem_context_clear_persistence(ctx);
}
--
2.25.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/gem: Require per-engine reset support for non-persistent contexts
2020-01-30 16:43 [Intel-gfx] [PATCH] drm/i915/gem: Require per-engine reset support for non-persistent contexts Chris Wilson
@ 2020-01-30 16:45 ` Chris Wilson
2020-01-31 10:54 ` Joonas Lahtinen
2020-01-30 20:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Require per-engine reset support for non-persistent contexts (rev2) Patchwork
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2020-01-30 16:45 UTC (permalink / raw)
To: intel-gfx
To enable non-persistent contexts, we require a means of cancelling any
inflight work from that context. This is first done "gracefully" by
using preemption to kick the active context off the engine, and then
forcefully by resetting the engine if it is active. If we are unable to
reset the engine to remove hostile userspace, we should not allow
userspace to opt into using non-persistent contexts.
Fixes: a0e047156cde ("drm/i915/gem: Make context persistence optional")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Jon Bloomfield <jon.bloomfield@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
index da1ba8feeedc..1e173dd5ed54 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
@@ -565,6 +565,10 @@ static int __context_set_persistence(struct i915_gem_context *ctx, bool state)
if (!(ctx->i915->caps.scheduler & I915_SCHEDULER_CAP_PREEMPTION))
return -ENODEV;
+ /* If the cancel fails, we then need to reset, cleanly! */
+ if (!intel_has_reset_engine(&ctx->i915->gt))
+ return -ENODEV;
+
i915_gem_context_clear_persistence(ctx);
}
--
2.25.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Require per-engine reset support for non-persistent contexts (rev2)
2020-01-30 16:43 [Intel-gfx] [PATCH] drm/i915/gem: Require per-engine reset support for non-persistent contexts Chris Wilson
2020-01-30 16:45 ` Chris Wilson
@ 2020-01-30 20:46 ` Patchwork
2020-02-02 11:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-02-02 11:48 ` [Intel-gfx] [PATCH] drm/i915/gem: Require per-engine reset support for non-persistent contexts kbuild test robot
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-01-30 20:46 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gem: Require per-engine reset support for non-persistent contexts (rev2)
URL : https://patchwork.freedesktop.org/series/72785/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7845 -> Patchwork_16342
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/index.html
Known issues
------------
Here are the changes found in Patchwork_16342 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_close_race@basic-threads:
- fi-byt-j1900: [PASS][1] -> [TIMEOUT][2] ([fdo#112271] / [i915#1084] / [i915#816])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/fi-byt-j1900/igt@gem_close_race@basic-threads.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/fi-byt-j1900/igt@gem_close_race@basic-threads.html
- fi-byt-n2820: [PASS][3] -> [TIMEOUT][4] ([fdo#112271] / [i915#1084] / [i915#816])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/fi-byt-n2820/igt@gem_close_race@basic-threads.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/fi-byt-n2820/igt@gem_close_race@basic-threads.html
* igt@i915_selftest@live_blt:
- fi-hsw-4770r: [PASS][5] -> [DMESG-FAIL][6] ([i915#553] / [i915#725])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/fi-hsw-4770r/igt@i915_selftest@live_blt.html
- fi-hsw-4770: [PASS][7] -> [DMESG-FAIL][8] ([i915#725])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/fi-hsw-4770/igt@i915_selftest@live_blt.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/fi-hsw-4770/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_execlists:
- fi-icl-y: [PASS][9] -> [DMESG-FAIL][10] ([fdo#108569])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/fi-icl-y/igt@i915_selftest@live_execlists.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/fi-icl-y/igt@i915_selftest@live_execlists.html
* igt@i915_selftest@live_gem_contexts:
- fi-cfl-8700k: [PASS][11] -> [INCOMPLETE][12] ([i915#424])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html
* igt@prime_self_import@basic-with_one_bo_two_files:
- fi-tgl-y: [PASS][13] -> [DMESG-WARN][14] ([CI#94] / [i915#402]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
#### Possible fixes ####
* igt@gem_ctx_create@basic-files:
- fi-icl-guc: [INCOMPLETE][15] ([fdo#109100]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/fi-icl-guc/igt@gem_ctx_create@basic-files.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/fi-icl-guc/igt@gem_ctx_create@basic-files.html
* igt@gem_exec_suspend@basic-s4-devices:
- fi-tgl-y: [FAIL][17] ([CI#94]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html
* igt@i915_getparams_basic@basic-subslice-total:
- fi-tgl-y: [DMESG-WARN][19] ([CI#94] / [i915#402]) -> [PASS][20] +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/fi-tgl-y/igt@i915_getparams_basic@basic-subslice-total.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/fi-tgl-y/igt@i915_getparams_basic@basic-subslice-total.html
* igt@i915_selftest@live_blt:
- fi-ivb-3770: [DMESG-FAIL][21] ([i915#725]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/fi-ivb-3770/igt@i915_selftest@live_blt.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/fi-ivb-3770/igt@i915_selftest@live_blt.html
#### Warnings ####
* igt@runner@aborted:
- fi-byt-n2820: [FAIL][23] ([i915#999]) -> [FAIL][24] ([i915#816])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/fi-byt-n2820/igt@runner@aborted.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/fi-byt-n2820/igt@runner@aborted.html
[CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1084]: https://gitlab.freedesktop.org/drm/intel/issues/1084
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816
[i915#999]: https://gitlab.freedesktop.org/drm/intel/issues/999
Participating hosts (45 -> 41)
------------------------------
Additional (4): fi-kbl-soraka fi-bdw-gvtdvm fi-hsw-peppy fi-elk-e7500
Missing (8): fi-icl-1065g7 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-cfl-8109u fi-byt-clapper fi-bdw-samus fi-snb-2600
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7845 -> Patchwork_16342
CI-20190529: 20190529
CI_DRM_7845: 87712fc2ff1634223e993da943bc3c9c7ce96bad @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5407: a9d69f51dadbcbc53527671f87572d05c3370cba @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16342: a35e6e581d78fdbfaf896b3197f188aef8168cfe @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
a35e6e581d78 drm/i915/gem: Require per-engine reset support for non-persistent contexts
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gem: Require per-engine reset support for non-persistent contexts
2020-01-30 16:45 ` Chris Wilson
@ 2020-01-31 10:54 ` Joonas Lahtinen
0 siblings, 0 replies; 6+ messages in thread
From: Joonas Lahtinen @ 2020-01-31 10:54 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Quoting Chris Wilson (2020-01-30 18:45:53)
> To enable non-persistent contexts, we require a means of cancelling any
> inflight work from that context. This is first done "gracefully" by
> using preemption to kick the active context off the engine, and then
> forcefully by resetting the engine if it is active. If we are unable to
> reset the engine to remove hostile userspace, we should not allow
> userspace to opt into using non-persistent contexts.
>
> Fixes: a0e047156cde ("drm/i915/gem: Make context persistence optional")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Jon Bloomfield <jon.bloomfield@intel.com>
Maybe worth noting that we might still ultimately end up at using
the sledge hammer called full GPU reset, in the rare cases when
engine reset fails. But it makes sense to avoid the situation
when it's guaranteed to be attempted.
Avoiding collateral damage is a worthy motive for the long
running compute cases.
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: Require per-engine reset support for non-persistent contexts (rev2)
2020-01-30 16:43 [Intel-gfx] [PATCH] drm/i915/gem: Require per-engine reset support for non-persistent contexts Chris Wilson
2020-01-30 16:45 ` Chris Wilson
2020-01-30 20:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Require per-engine reset support for non-persistent contexts (rev2) Patchwork
@ 2020-02-02 11:26 ` Patchwork
2020-02-02 11:48 ` [Intel-gfx] [PATCH] drm/i915/gem: Require per-engine reset support for non-persistent contexts kbuild test robot
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-02-02 11:26 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gem: Require per-engine reset support for non-persistent contexts (rev2)
URL : https://patchwork.freedesktop.org/series/72785/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7845_full -> Patchwork_16342_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_16342_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_16342_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_16342_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_vm_create@isolation:
- shard-glk: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-glk1/igt@gem_vm_create@isolation.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-glk9/igt@gem_vm_create@isolation.html
* igt@perf@enable-disable:
- shard-iclb: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-iclb6/igt@perf@enable-disable.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-iclb3/igt@perf@enable-disable.html
Known issues
------------
Here are the changes found in Patchwork_16342_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#112080]) +7 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-iclb4/igt@gem_busy@busy-vcs1.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-iclb5/igt@gem_busy@busy-vcs1.html
* igt@gem_ctx_persistence@file:
- shard-tglb: [PASS][7] -> [SKIP][8] ([fdo#112179] / [i915#1099]) +19 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-tglb1/igt@gem_ctx_persistence@file.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-tglb1/igt@gem_ctx_persistence@file.html
- shard-skl: [PASS][9] -> [SKIP][10] ([fdo#109271] / [i915#1099]) +18 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-skl6/igt@gem_ctx_persistence@file.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-skl7/igt@gem_ctx_persistence@file.html
* igt@gem_ctx_persistence@rcs0-persistence:
- shard-kbl: [PASS][11] -> [SKIP][12] ([fdo#109271] / [i915#1099]) +19 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-kbl2/igt@gem_ctx_persistence@rcs0-persistence.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-kbl4/igt@gem_ctx_persistence@rcs0-persistence.html
* igt@gem_ctx_persistence@vcs0-persistence:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#112179] / [i915#1099]) +19 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-iclb7/igt@gem_ctx_persistence@vcs0-persistence.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-iclb7/igt@gem_ctx_persistence@vcs0-persistence.html
* igt@gem_ctx_persistence@vcs0-queued:
- shard-apl: [PASS][15] -> [SKIP][16] ([fdo#109271] / [i915#1099]) +19 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-apl2/igt@gem_ctx_persistence@vcs0-queued.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-apl6/igt@gem_ctx_persistence@vcs0-queued.html
* igt@gem_ctx_persistence@vcs1-cleanup:
- shard-tglb: [PASS][17] -> [SKIP][18] ([fdo#112080] / [i915#1099]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-tglb6/igt@gem_ctx_persistence@vcs1-cleanup.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-tglb1/igt@gem_ctx_persistence@vcs1-cleanup.html
- shard-kbl: [PASS][19] -> [SKIP][20] ([fdo#109271] / [fdo#112080] / [i915#1099]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-kbl1/igt@gem_ctx_persistence@vcs1-cleanup.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-kbl6/igt@gem_ctx_persistence@vcs1-cleanup.html
* igt@gem_ctx_persistence@vcs1-hostile:
- shard-iclb: [PASS][21] -> [SKIP][22] ([fdo#109276] / [fdo#112080] / [i915#1099])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-iclb4/igt@gem_ctx_persistence@vcs1-hostile.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-iclb1/igt@gem_ctx_persistence@vcs1-hostile.html
* igt@gem_ctx_persistence@vecs0-persistence:
- shard-glk: [PASS][23] -> [SKIP][24] ([fdo#109271] / [i915#1099]) +18 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-glk2/igt@gem_ctx_persistence@vecs0-persistence.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-glk8/igt@gem_ctx_persistence@vecs0-persistence.html
* igt@gem_exec_schedule@pi-distinct-iova-bsd:
- shard-iclb: [PASS][25] -> [SKIP][26] ([i915#677])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-iclb6/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-iclb4/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
* igt@gem_exec_schedule@preempt-other-bsd:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#112146]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-iclb6/igt@gem_exec_schedule@preempt-other-bsd.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-iclb4/igt@gem_exec_schedule@preempt-other-bsd.html
* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- shard-hsw: [PASS][29] -> [FAIL][30] ([i915#694])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-hsw2/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-hsw5/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
* igt@kms_color@pipe-b-ctm-0-75:
- shard-skl: [PASS][31] -> [DMESG-WARN][32] ([i915#109]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-skl9/igt@kms_color@pipe-b-ctm-0-75.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-skl10/igt@kms_color@pipe-b-ctm-0-75.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][33] -> [DMESG-WARN][34] ([i915#180]) +6 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size:
- shard-hsw: [PASS][35] -> [INCOMPLETE][36] ([CI#80] / [i915#61])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-hsw2/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-hsw5/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size.html
* igt@kms_draw_crc@draw-method-xrgb8888-pwrite-xtiled:
- shard-skl: [PASS][37] -> [FAIL][38] ([i915#52] / [i915#54])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-skl9/igt@kms_draw_crc@draw-method-xrgb8888-pwrite-xtiled.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-skl10/igt@kms_draw_crc@draw-method-xrgb8888-pwrite-xtiled.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-iclb: [PASS][39] -> [INCOMPLETE][40] ([i915#123])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-iclb5/igt@kms_frontbuffer_tracking@psr-suspend.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-iclb3/igt@kms_frontbuffer_tracking@psr-suspend.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [PASS][41] -> [DMESG-WARN][42] ([i915#180]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-apl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-apl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][43] -> [FAIL][44] ([fdo#108145] / [i915#265]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][45] -> [SKIP][46] ([fdo#109642] / [fdo#111068])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-iclb2/igt@kms_psr2_su@page_flip.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-iclb3/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][47] -> [SKIP][48] ([fdo#109441]) +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-iclb5/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][49] -> [FAIL][50] ([i915#31])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-apl6/igt@kms_setmode@basic.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-apl1/igt@kms_setmode@basic.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][51] -> [SKIP][52] ([fdo#109276]) +16 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-iclb2/igt@prime_vgem@fence-wait-bsd2.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-iclb5/igt@prime_vgem@fence-wait-bsd2.html
#### Possible fixes ####
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][53] ([fdo#110841]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-iclb2/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-iclb5/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_exec_balancer@hang:
- shard-tglb: [TIMEOUT][55] ([fdo#112271]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-tglb6/igt@gem_exec_balancer@hang.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-tglb6/igt@gem_exec_balancer@hang.html
* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [SKIP][57] ([fdo#112080]) -> [PASS][58] +12 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-iclb6/igt@gem_exec_parallel@vcs1-fds.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-iclb4/igt@gem_exec_parallel@vcs1-fds.html
* igt@gem_exec_schedule@preempt-contexts-bsd2:
- shard-iclb: [SKIP][59] ([fdo#109276]) -> [PASS][60] +13 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-iclb5/igt@gem_exec_schedule@preempt-contexts-bsd2.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-iclb2/igt@gem_exec_schedule@preempt-contexts-bsd2.html
* igt@gem_exec_schedule@preempt-queue-bsd:
- shard-iclb: [SKIP][61] ([fdo#112146]) -> [PASS][62] +3 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-iclb1/igt@gem_exec_schedule@preempt-queue-bsd.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-iclb6/igt@gem_exec_schedule@preempt-queue-bsd.html
* igt@gem_softpin@noreloc-s3:
- shard-apl: [DMESG-WARN][63] ([i915#180]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-apl1/igt@gem_softpin@noreloc-s3.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-apl6/igt@gem_softpin@noreloc-s3.html
* igt@gem_tiled_partial_pwrite_pread@reads:
- shard-hsw: [FAIL][65] ([i915#694]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-hsw5/igt@gem_tiled_partial_pwrite_pread@reads.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-hsw1/igt@gem_tiled_partial_pwrite_pread@reads.html
* igt@i915_pm_rps@reset:
- shard-iclb: [FAIL][67] ([i915#413]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-iclb2/igt@i915_pm_rps@reset.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-iclb5/igt@i915_pm_rps@reset.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [DMESG-WARN][69] ([i915#180]) -> [PASS][70] +5 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_flip@flip-vs-suspend:
- shard-snb: [DMESG-WARN][71] ([i915#42]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-snb4/igt@kms_flip@flip-vs-suspend.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-snb1/igt@kms_flip@flip-vs-suspend.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-skl: [INCOMPLETE][73] ([i915#69]) -> [PASS][74] +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-skl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-skl9/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][75] ([fdo#109441]) -> [PASS][76] +3 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-iclb7/igt@kms_psr@psr2_primary_mmap_cpu.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-skl: [FAIL][77] ([i915#31]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-skl1/igt@kms_setmode@basic.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-skl1/igt@kms_setmode@basic.html
- shard-glk: [FAIL][79] ([i915#31]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-glk7/igt@kms_setmode@basic.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-glk6/igt@kms_setmode@basic.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv-switch:
- shard-iclb: [SKIP][81] ([fdo#112080]) -> [FAIL][82] ([IGT#28])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-iclb3/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-iclb1/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
* igt@gem_ctx_persistence@vcs2-persistence:
- shard-tglb: [SKIP][83] ([fdo#112080] / [i915#1086]) -> [SKIP][84] ([fdo#112080]) +4 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-tglb2/igt@gem_ctx_persistence@vcs2-persistence.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-tglb1/igt@gem_ctx_persistence@vcs2-persistence.html
* igt@gem_eio@in-flight-immediate:
- shard-kbl: [INCOMPLETE][85] ([CI#80] / [fdo#103665] / [i915#1098]) -> [TIMEOUT][86] ([fdo#112271])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-kbl7/igt@gem_eio@in-flight-immediate.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-kbl6/igt@gem_eio@in-flight-immediate.html
* igt@i915_pm_rpm@pm-tiling:
- shard-snb: [INCOMPLETE][87] ([i915#82]) -> [SKIP][88] ([fdo#109271])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7845/shard-snb1/igt@i915_pm_rpm@pm-tiling.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/shard-snb6/igt@i915_pm_rpm@pm-tiling.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
[IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
[IGT#68]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/68
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112179]: https://bugs.freedesktop.org/show_bug.cgi?id=112179
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1086]: https://gitlab.freedesktop.org/drm/intel/issues/1086
[i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
[i915#1098]: https://gitlab.freedesktop.org/drm/intel/issues/1098
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#42]: https://gitlab.freedesktop.org/drm/intel/issues/42
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7845 -> Patchwork_16342
CI-20190529: 20190529
CI_DRM_7845: 87712fc2ff1634223e993da943bc3c9c7ce96bad @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5407: a9d69f51dadbcbc53527671f87572d05c3370cba @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16342: a35e6e581d78fdbfaf896b3197f188aef8168cfe @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16342/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gem: Require per-engine reset support for non-persistent contexts
2020-01-30 16:43 [Intel-gfx] [PATCH] drm/i915/gem: Require per-engine reset support for non-persistent contexts Chris Wilson
` (2 preceding siblings ...)
2020-02-02 11:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2020-02-02 11:48 ` kbuild test robot
3 siblings, 0 replies; 6+ messages in thread
From: kbuild test robot @ 2020-02-02 11:48 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2552 bytes --]
Hi Chris,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v5.5 next-20200130]
[cannot apply to drm-tip/drm-tip]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-gem-Require-per-engine-reset-support-for-non-persistent-contexts/20200202-183240
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/i915/gem/i915_gem_context.c: In function '__context_set_persistence':
>> drivers/gpu/drm/i915/gem/i915_gem_context.c:569:34: error: 'struct i915_gem_context' has no member named 'gt'
if (!intel_has_reset_engine(ctx->gt))
^~
vim +569 drivers/gpu/drm/i915/gem/i915_gem_context.c
547
548 static int __context_set_persistence(struct i915_gem_context *ctx, bool state)
549 {
550 if (i915_gem_context_is_persistent(ctx) == state)
551 return 0;
552
553 if (state) {
554 /*
555 * Only contexts that are short-lived [that will expire or be
556 * reset] are allowed to survive past termination. We require
557 * hangcheck to ensure that the persistent requests are healthy.
558 */
559 if (!i915_modparams.enable_hangcheck)
560 return -EINVAL;
561
562 i915_gem_context_set_persistence(ctx);
563 } else {
564 /* To cancel a context we use "preempt-to-idle" */
565 if (!(ctx->i915->caps.scheduler & I915_SCHEDULER_CAP_PREEMPTION))
566 return -ENODEV;
567
568 /* If the cancel fails, we then need to reset, cleanly! */
> 569 if (!intel_has_reset_engine(ctx->gt))
570 return -ENODEV;
571
572 i915_gem_context_clear_persistence(ctx);
573 }
574
575 return 0;
576 }
577
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28857 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-02-02 11:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-30 16:43 [Intel-gfx] [PATCH] drm/i915/gem: Require per-engine reset support for non-persistent contexts Chris Wilson
2020-01-30 16:45 ` Chris Wilson
2020-01-31 10:54 ` Joonas Lahtinen
2020-01-30 20:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Require per-engine reset support for non-persistent contexts (rev2) Patchwork
2020-02-02 11:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-02-02 11:48 ` [Intel-gfx] [PATCH] drm/i915/gem: Require per-engine reset support for non-persistent contexts kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.