* [PATCH] dmaengine: fix null ptr check for __dma_async_device_channel_register()
@ 2020-01-31 17:58 Dave Jiang
2020-02-03 4:18 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jiang @ 2020-01-31 17:58 UTC (permalink / raw)
To: vkoul; +Cc: dmaengine, dan.carpenter
Add check to pointer after assignment before accessing members.
Fixes: d2fb0a043838: ("dmaengine: break out channel registration")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
drivers/dma/dmaengine.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
index f3ef4edd4de1..3a62c7839861 100644
--- a/drivers/dma/dmaengine.c
+++ b/drivers/dma/dmaengine.c
@@ -962,6 +962,9 @@ static int __dma_async_device_channel_register(struct dma_device *device,
tchan = list_first_entry_or_null(&device->channels,
struct dma_chan, device_node);
+ if (!tchan)
+ return -ENODEV;
+
if (tchan->dev) {
idr_ref = tchan->dev->idr_ref;
} else {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: fix null ptr check for __dma_async_device_channel_register()
2020-01-31 17:58 [PATCH] dmaengine: fix null ptr check for __dma_async_device_channel_register() Dave Jiang
@ 2020-02-03 4:18 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2020-02-03 4:18 UTC (permalink / raw)
To: Dave Jiang; +Cc: dmaengine, dan.carpenter
On 31-01-20, 10:58, Dave Jiang wrote:
> Add check to pointer after assignment before accessing members.
>
> Fixes: d2fb0a043838: ("dmaengine: break out channel registration")
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-03 4:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-31 17:58 [PATCH] dmaengine: fix null ptr check for __dma_async_device_channel_register() Dave Jiang
2020-02-03 4:18 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.