Re: [PATCH 08/12] dt-bindings: arm: bcm: Convert BCM4708 to YAML

From: Maxime Ripard <maxime@cerno.tech>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-arm-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>, Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	"maintainer:BROADCOM IPROC ARM ARCHITECTURE" 
	<bcm-kernel-feedback-list@broadcom.com>,
	Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
	Sugaya Taichi <sugaya.taichi@socionext.com>,
	Olof Johansson <olof@lixom.net>, Andrew Jeffery <andrew@aj.id.au>,
	Lubomir Rintel <lkundrak@v3.sk>,
	"moderated list:BROADCOM IPROC ARM ARCHITECTURE" 
	<linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>,
	"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
	<linux-rpi-kernel@lists.infradead.org>
Subject: Re: [PATCH 08/12] dt-bindings: arm: bcm: Convert BCM4708 to YAML
Date: Mon, 3 Feb 2020 09:31:51 +0100	[thread overview]
Message-ID: <20200203083151.ghg57pgjlci4y7in@gilmour.lan> (raw)
In-Reply-To: <20200202211827.27682-9-f.fainelli@gmail.com>

Hi,

On Sun, Feb 02, 2020 at 01:18:23PM -0800, Florian Fainelli wrote:
> Update the Broadcom BCM4708 SoC family binding document for boards/SoCs
> to use YAML. Verified with dt_binding_check and dtbs_check.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  .../bindings/arm/bcm/brcm,bcm4708.txt         | 15 ----
>  .../bindings/arm/bcm/brcm,bcm4708.yaml        | 88 +++++++++++++++++++
>  2 files changed, 88 insertions(+), 15 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
>  create mode 100644 Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
> deleted file mode 100644
> index 8608a776caa7..000000000000
> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -Broadcom BCM4708 device tree bindings
> --------------------------------------------
> -
> -Boards with the BCM4708 SoC shall have the following properties:
> -
> -Required root node property:
> -
> -bcm4708
> -compatible = "brcm,bcm4708";
> -
> -bcm4709
> -compatible = "brcm,bcm4709";
> -
> -bcm53012
> -compatible = "brcm,bcm53012";
> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml
> new file mode 100644
> index 000000000000..d48313c7ae45
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml
> @@ -0,0 +1,88 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/bcm/brcm,bcm4708.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom BCM4708 device tree bindings
> +
> +description:
> +  Broadcom BCM4708/47081/4709/47094/53012 Wi-Fi/network SoCs based
> +  on the iProc architecture (Northstar).
> +
> +maintainers:
> +  - Florian Fainelli <f.fainelli@gmail.com>
> +  - Hauke Mehrtens <hauke@hauke-m.de>
> +  - Rafal Milecki <zajec5@gmail.com>
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:
> +      - description: BCM4708 based boards
> +        items:
> +          - enum:
> +              - asus,rt-ac56u
> +              - asus,rt-ac68u
> +              - buffalo,wzr-1750dhp
> +              - linksys,ea6300-v1
> +              - linksys,ea6500-v2
> +              - luxul,xap-1510v1
> +              - luxul,xwc-1000
> +              - netgear,r6250v1
> +              - netgear,r6300v2
> +              - smartrg,sr400ac
> +              - brcm,bcm94708
> +          - const: brcm,bcm4708

I'm under the impression that while the SoC compatible description in
your other bindings is obvious enough, if anything, you should have a
description of the boards. But it's up to you :)

Maxime