[android-common:android-4.19 1/4] drivers/staging/android/ion/ion.c:666:5: sparse: sparse: symbol 'ion_module_init' was not declared. Should it be static?

[android-common:android-4.19 1/4] drivers/staging/android/ion/ion.c:666:5: sparse: sparse: symbol 'ion_module_init' was not declared. Should it be static?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]

tree:   https://android.googlesource.com/kernel/common android-4.19
head:   983e2cdf34d065dd89e93bd096a76994b29aebcd
commit: f64a8b79c0e85440319136ed928f22ed37481742 [1/4] ANDROID: staging: android: ion: enable modularizing the ion driver
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-154-g1dc00f87-dirty
        git checkout f64a8b79c0e85440319136ed928f22ed37481742
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/staging/android/ion/ion.c:666:5: sparse: sparse: symbol 'ion_module_init' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

[RFC PATCH android-common] ANDROID: staging: android: ion: ion_module_init() can be static

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]


Fixes: f64a8b79c0e8 ("ANDROID: staging: android: ion: enable modularizing the ion driver")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 ion.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 49bf964b2879a..0ce0258cd9cbb 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -663,7 +663,7 @@ static int ion_device_create(void)
 }
 
 #ifdef CONFIG_ION_MODULE
-int ion_module_init(void)
+static int ion_module_init(void)
 {
 	int ret;