From: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Rob Herring <robh@kernel.org>,
Boris Brezillon <boris.brezillon@collabora.com>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Steven Price <steven.price@arm.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Sumit Semwal <sumit.semwal@linaro.org>,
dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
linaro-mm-sig@lists.linaro.org, kernel-janitors@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] drm/panfrost: Remove set but not used variable 'bo'
Date: Mon, 3 Feb 2020 14:12:36 -0500 [thread overview]
Message-ID: <20200203191236.GA2913@kevin> (raw)
In-Reply-To: <20200203152724.42611-1-yuehaibing@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1359 bytes --]
Reviewed-by: Alyssas Rosenzweig <alyssa.rosenzweig@collabora.com>, thank
you!
On Mon, Feb 03, 2020 at 03:27:24PM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/panfrost/panfrost_job.c: In function 'panfrost_job_cleanup':
> drivers/gpu/drm/panfrost/panfrost_job.c:278:31: warning:
> variable 'bo' set but not used [-Wunused-but-set-variable]
>
> commit bdefca2d8dc0 ("drm/panfrost: Add the panfrost_gem_mapping concept")
> involved this unused variable.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/gpu/drm/panfrost/panfrost_job.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
> index 7c36ec675b73..ccb8546a9342 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_job.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
> @@ -275,12 +275,8 @@ static void panfrost_job_cleanup(struct kref *ref)
> }
>
> if (job->bos) {
> - struct panfrost_gem_object *bo;
> -
> - for (i = 0; i < job->bo_count; i++) {
> - bo = to_panfrost_bo(job->bos[i]);
> + for (i = 0; i < job->bo_count; i++)
> drm_gem_object_put_unlocked(job->bos[i]);
> - }
>
> kvfree(job->bos);
> }
>
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org,
Steven Price <steven.price@arm.com>,
linaro-mm-sig@lists.linaro.org, Hulk Robot <hulkci@huawei.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH -next] drm/panfrost: Remove set but not used variable 'bo'
Date: Mon, 03 Feb 2020 19:12:36 +0000 [thread overview]
Message-ID: <20200203191236.GA2913@kevin> (raw)
In-Reply-To: <20200203152724.42611-1-yuehaibing@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1359 bytes --]
Reviewed-by: Alyssas Rosenzweig <alyssa.rosenzweig@collabora.com>, thank
you!
On Mon, Feb 03, 2020 at 03:27:24PM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/panfrost/panfrost_job.c: In function 'panfrost_job_cleanup':
> drivers/gpu/drm/panfrost/panfrost_job.c:278:31: warning:
> variable 'bo' set but not used [-Wunused-but-set-variable]
>
> commit bdefca2d8dc0 ("drm/panfrost: Add the panfrost_gem_mapping concept")
> involved this unused variable.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/gpu/drm/panfrost/panfrost_job.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
> index 7c36ec675b73..ccb8546a9342 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_job.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
> @@ -275,12 +275,8 @@ static void panfrost_job_cleanup(struct kref *ref)
> }
>
> if (job->bos) {
> - struct panfrost_gem_object *bo;
> -
> - for (i = 0; i < job->bo_count; i++) {
> - bo = to_panfrost_bo(job->bos[i]);
> + for (i = 0; i < job->bo_count; i++)
> drm_gem_object_put_unlocked(job->bos[i]);
> - }
>
> kvfree(job->bos);
> }
>
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org,
Steven Price <steven.price@arm.com>,
linaro-mm-sig@lists.linaro.org, Hulk Robot <hulkci@huawei.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH -next] drm/panfrost: Remove set but not used variable 'bo'
Date: Mon, 3 Feb 2020 14:12:36 -0500 [thread overview]
Message-ID: <20200203191236.GA2913@kevin> (raw)
In-Reply-To: <20200203152724.42611-1-yuehaibing@huawei.com>
[-- Attachment #1.1: Type: text/plain, Size: 1359 bytes --]
Reviewed-by: Alyssas Rosenzweig <alyssa.rosenzweig@collabora.com>, thank
you!
On Mon, Feb 03, 2020 at 03:27:24PM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/panfrost/panfrost_job.c: In function 'panfrost_job_cleanup':
> drivers/gpu/drm/panfrost/panfrost_job.c:278:31: warning:
> variable 'bo' set but not used [-Wunused-but-set-variable]
>
> commit bdefca2d8dc0 ("drm/panfrost: Add the panfrost_gem_mapping concept")
> involved this unused variable.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/gpu/drm/panfrost/panfrost_job.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
> index 7c36ec675b73..ccb8546a9342 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_job.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
> @@ -275,12 +275,8 @@ static void panfrost_job_cleanup(struct kref *ref)
> }
>
> if (job->bos) {
> - struct panfrost_gem_object *bo;
> -
> - for (i = 0; i < job->bo_count; i++) {
> - bo = to_panfrost_bo(job->bos[i]);
> + for (i = 0; i < job->bo_count; i++)
> drm_gem_object_put_unlocked(job->bos[i]);
> - }
>
> kvfree(job->bos);
> }
>
>
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-03 19:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 15:27 [PATCH -next] drm/panfrost: Remove set but not used variable 'bo' YueHaibing
2020-02-03 15:27 ` YueHaibing
2020-02-03 15:27 ` YueHaibing
2020-02-03 15:41 ` Steven Price
2020-02-03 15:41 ` Steven Price
2020-02-03 15:41 ` Steven Price
2020-02-03 19:12 ` Alyssa Rosenzweig [this message]
2020-02-03 19:12 ` Alyssa Rosenzweig
2020-02-03 19:12 ` Alyssa Rosenzweig
2020-02-12 20:33 ` Rob Herring
2020-02-12 20:33 ` Rob Herring
2020-02-12 20:33 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203191236.GA2913@kevin \
--to=alyssa.rosenzweig@collabora.com \
--cc=airlied@linux.ie \
--cc=boris.brezillon@collabora.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=robh@kernel.org \
--cc=steven.price@arm.com \
--cc=sumit.semwal@linaro.org \
--cc=tomeu.vizoso@collabora.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.