* Re: [PATCH v1] fbdev: simplefb: Platform data shan't include kernel.h
2020-02-04 16:21 [PATCH v1] fbdev: simplefb: Platform data shan't include kernel.h Andy Shevchenko
@ 2020-02-14 14:25 ` Andy Shevchenko
2020-02-14 15:21 ` Hans de Goede
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2020-02-14 14:25 UTC (permalink / raw)
To: linux-fbdev
On Tue, Feb 04, 2020 at 06:21:14PM +0200, Andy Shevchenko wrote:
> Replace with appropriate types.h.
Hans, any comment on this?
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> include/linux/platform_data/simplefb.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/platform_data/simplefb.h b/include/linux/platform_data/simplefb.h
> index 4f733a411d18..ca8337695c2a 100644
> --- a/include/linux/platform_data/simplefb.h
> +++ b/include/linux/platform_data/simplefb.h
> @@ -10,7 +10,7 @@
>
> #include <drm/drm_fourcc.h>
> #include <linux/fb.h>
> -#include <linux/kernel.h>
> +#include <linux/types.h>
>
> /* format array, use it to initialize a "struct simplefb_format" array */
> #define SIMPLEFB_FORMATS \
> --
> 2.24.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1] fbdev: simplefb: Platform data shan't include kernel.h
2020-02-04 16:21 [PATCH v1] fbdev: simplefb: Platform data shan't include kernel.h Andy Shevchenko
2020-02-14 14:25 ` Andy Shevchenko
@ 2020-02-14 15:21 ` Hans de Goede
2020-02-14 18:08 ` Andy Shevchenko
2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz
3 siblings, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2020-02-14 15:21 UTC (permalink / raw)
To: linux-fbdev
Hi,
On 2/14/20 3:25 PM, Andy Shevchenko wrote:
> On Tue, Feb 04, 2020 at 06:21:14PM +0200, Andy Shevchenko wrote:
>> Replace with appropriate types.h.
>
> Hans, any comment on this?
Not really, I've not touched that code in a while.
But I see I'm still listed as the maintainer, the change looks sensible
to me, so:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>> include/linux/platform_data/simplefb.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/platform_data/simplefb.h b/include/linux/platform_data/simplefb.h
>> index 4f733a411d18..ca8337695c2a 100644
>> --- a/include/linux/platform_data/simplefb.h
>> +++ b/include/linux/platform_data/simplefb.h
>> @@ -10,7 +10,7 @@
>>
>> #include <drm/drm_fourcc.h>
>> #include <linux/fb.h>
>> -#include <linux/kernel.h>
>> +#include <linux/types.h>
>>
>> /* format array, use it to initialize a "struct simplefb_format" array */
>> #define SIMPLEFB_FORMATS \
>> --
>> 2.24.1
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] fbdev: simplefb: Platform data shan't include kernel.h
2020-02-04 16:21 [PATCH v1] fbdev: simplefb: Platform data shan't include kernel.h Andy Shevchenko
2020-02-14 14:25 ` Andy Shevchenko
2020-02-14 15:21 ` Hans de Goede
@ 2020-02-14 18:08 ` Andy Shevchenko
2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz
3 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2020-02-14 18:08 UTC (permalink / raw)
To: linux-fbdev
On Fri, Feb 14, 2020 at 04:21:57PM +0100, Hans de Goede wrote:
> On 2/14/20 3:25 PM, Andy Shevchenko wrote:
> > On Tue, Feb 04, 2020 at 06:21:14PM +0200, Andy Shevchenko wrote:
> > > Replace with appropriate types.h.
> >
> > Hans, any comment on this?
>
> Not really, I've not touched that code in a while.
>
> But I see I'm still listed as the maintainer, the change looks sensible
> to me, so:
>
> Acked-by: Hans de Goede <hdegoede@redhat.com>
Thanks!
Seems get_maintainer does not list Bart, so, Cc him here.
>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > > include/linux/platform_data/simplefb.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/include/linux/platform_data/simplefb.h b/include/linux/platform_data/simplefb.h
> > > index 4f733a411d18..ca8337695c2a 100644
> > > --- a/include/linux/platform_data/simplefb.h
> > > +++ b/include/linux/platform_data/simplefb.h
> > > @@ -10,7 +10,7 @@
> > > #include <drm/drm_fourcc.h>
> > > #include <linux/fb.h>
> > > -#include <linux/kernel.h>
> > > +#include <linux/types.h>
> > > /* format array, use it to initialize a "struct simplefb_format" array */
> > > #define SIMPLEFB_FORMATS \
> > > --
> > > 2.24.1
> > >
> >
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] fbdev: simplefb: Platform data shan't include kernel.h
2020-02-04 16:21 [PATCH v1] fbdev: simplefb: Platform data shan't include kernel.h Andy Shevchenko
` (2 preceding siblings ...)
2020-02-14 18:08 ` Andy Shevchenko
@ 2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz
3 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-03-02 15:42 UTC (permalink / raw)
To: linux-fbdev
On 2/14/20 7:08 PM, Andy Shevchenko wrote:
> On Fri, Feb 14, 2020 at 04:21:57PM +0100, Hans de Goede wrote:
>> On 2/14/20 3:25 PM, Andy Shevchenko wrote:
>>> On Tue, Feb 04, 2020 at 06:21:14PM +0200, Andy Shevchenko wrote:
>>>> Replace with appropriate types.h.
>>>
>>> Hans, any comment on this?
>>
>> Not really, I've not touched that code in a while.
>>
>> But I see I'm still listed as the maintainer, the change looks sensible
>> to me, so:
>>
>> Acked-by: Hans de Goede <hdegoede@redhat.com>
>
> Thanks!
> Seems get_maintainer does not list Bart, so, Cc him here.
>
>>
>>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Patch queued for v5.7, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
>>>> ---
>>>> include/linux/platform_data/simplefb.h | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/include/linux/platform_data/simplefb.h b/include/linux/platform_data/simplefb.h
>>>> index 4f733a411d18..ca8337695c2a 100644
>>>> --- a/include/linux/platform_data/simplefb.h
>>>> +++ b/include/linux/platform_data/simplefb.h
>>>> @@ -10,7 +10,7 @@
>>>> #include <drm/drm_fourcc.h>
>>>> #include <linux/fb.h>
>>>> -#include <linux/kernel.h>
>>>> +#include <linux/types.h>
>>>> /* format array, use it to initialize a "struct simplefb_format" array */
>>>> #define SIMPLEFB_FORMATS \
>>>> --
>>>> 2.24.1
^ permalink raw reply [flat|nested] 5+ messages in thread