* [PATCH -next] nfsd: make nfsd_filecache_wq variable static
@ 2020-02-03 1:43 Chen Zhou
2020-02-04 16:40 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: Chen Zhou @ 2020-02-03 1:43 UTC (permalink / raw)
To: bfields, chuck.lever; +Cc: linux-nfs, linux-kernel, yaohongbo, chenzhou10
Fix sparse warning:
fs/nfsd/filecache.c:55:25: warning:
symbol 'nfsd_filecache_wq' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
fs/nfsd/filecache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
index 23c1fa5..22e77ed 100644
--- a/fs/nfsd/filecache.c
+++ b/fs/nfsd/filecache.c
@@ -52,7 +52,7 @@ struct nfsd_fcache_disposal {
struct rcu_head rcu;
};
-struct workqueue_struct *nfsd_filecache_wq __read_mostly;
+static struct workqueue_struct *nfsd_filecache_wq __read_mostly;
static struct kmem_cache *nfsd_file_slab;
static struct kmem_cache *nfsd_file_mark_slab;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] nfsd: make nfsd_filecache_wq variable static
2020-02-03 1:43 [PATCH -next] nfsd: make nfsd_filecache_wq variable static Chen Zhou
@ 2020-02-04 16:40 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2020-02-04 16:40 UTC (permalink / raw)
To: Chen Zhou; +Cc: chuck.lever, linux-nfs, linux-kernel, yaohongbo
Thanks, applying.--b.
On Mon, Feb 03, 2020 at 09:43:57AM +0800, Chen Zhou wrote:
> Fix sparse warning:
>
> fs/nfsd/filecache.c:55:25: warning:
> symbol 'nfsd_filecache_wq' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> ---
> fs/nfsd/filecache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
> index 23c1fa5..22e77ed 100644
> --- a/fs/nfsd/filecache.c
> +++ b/fs/nfsd/filecache.c
> @@ -52,7 +52,7 @@ struct nfsd_fcache_disposal {
> struct rcu_head rcu;
> };
>
> -struct workqueue_struct *nfsd_filecache_wq __read_mostly;
> +static struct workqueue_struct *nfsd_filecache_wq __read_mostly;
>
> static struct kmem_cache *nfsd_file_slab;
> static struct kmem_cache *nfsd_file_mark_slab;
> --
> 2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-04 16:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-03 1:43 [PATCH -next] nfsd: make nfsd_filecache_wq variable static Chen Zhou
2020-02-04 16:40 ` J. Bruce Fields
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.