From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
DRI Development <dri-devel@lists.freedesktop.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v1] drm: shmobile: Platform data shan't include kernel.h
Date: Tue, 4 Feb 2020 21:30:50 +0200 [thread overview]
Message-ID: <20200204193050.GN10400@smile.fi.intel.com> (raw)
In-Reply-To: <20200204182621.GE20396@pendragon.ideasonboard.com>
On Tue, Feb 04, 2020 at 08:26:21PM +0200, Laurent Pinchart wrote:
> On Tue, Feb 04, 2020 at 06:39:34PM +0100, Geert Uytterhoeven wrote:
> > On Tue, Feb 4, 2020 at 5:20 PM Andy Shevchenko wrote:
> > > Replace with appropriate types.h.
> >
> > Thanks for your patch!
> >
> > I have only one very short question: why?
>
> Likewise :-) The patch itself looks fine, but the commit message is a
> bit terse.
The kernel.h for a long time being a dump of a lot of things. I started
cleaning it up a bit. During this I notice that developers too far too lazy to
use appropriate headers. For platform data kernel.h by definition is not
appropriate.
Any suggestion what should I put to commit message?
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v1] drm: shmobile: Platform data shan't include kernel.h
Date: Tue, 4 Feb 2020 21:30:50 +0200 [thread overview]
Message-ID: <20200204193050.GN10400@smile.fi.intel.com> (raw)
In-Reply-To: <20200204182621.GE20396@pendragon.ideasonboard.com>
On Tue, Feb 04, 2020 at 08:26:21PM +0200, Laurent Pinchart wrote:
> On Tue, Feb 04, 2020 at 06:39:34PM +0100, Geert Uytterhoeven wrote:
> > On Tue, Feb 4, 2020 at 5:20 PM Andy Shevchenko wrote:
> > > Replace with appropriate types.h.
> >
> > Thanks for your patch!
> >
> > I have only one very short question: why?
>
> Likewise :-) The patch itself looks fine, but the commit message is a
> bit terse.
The kernel.h for a long time being a dump of a lot of things. I started
cleaning it up a bit. During this I notice that developers too far too lazy to
use appropriate headers. For platform data kernel.h by definition is not
appropriate.
Any suggestion what should I put to commit message?
--
With Best Regards,
Andy Shevchenko
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-04 19:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 16:19 [PATCH v1] drm: shmobile: Platform data shan't include kernel.h Andy Shevchenko
2020-02-04 16:19 ` Andy Shevchenko
2020-02-04 17:39 ` Geert Uytterhoeven
2020-02-04 17:39 ` Geert Uytterhoeven
2020-02-04 18:26 ` Laurent Pinchart
2020-02-04 18:26 ` Laurent Pinchart
2020-02-04 19:30 ` Andy Shevchenko [this message]
2020-02-04 19:30 ` Andy Shevchenko
2020-02-04 19:44 ` Geert Uytterhoeven
2020-02-04 19:44 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204193050.GN10400@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.