[chrome-os:chromeos-4.19 3/3] drivers/gpu/drm/drm_trace.c:239:11-34: WARNING opportunity for simple_open, see also structure on line 287

[chrome-os:chromeos-4.19 3/3] drivers/gpu/drm/drm_trace.c:239:11-34: WARNING opportunity for simple_open, see also structure on line 287

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 730 bytes --]

tree:   https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-4.19
head:   2ef86936fa7b9f135fa6f7a08db0427701107c47
commit: 2ef86936fa7b9f135fa6f7a08db0427701107c47 [3/3] CHROMIUM: drm: Make the drm_trace size configurable

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


coccinelle warnings: (new ones prefixed by >>)

>> drivers/gpu/drm/drm_trace.c:239:11-34: WARNING opportunity for simple_open, see also structure on line 287

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

[PATCH] CHROMIUM: drm: fix simple_open.cocci warnings

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1548 bytes --]

From: kbuild test robot <lkp@intel.com>

drivers/gpu/drm/drm_trace.c:239:11-34: WARNING opportunity for simple_open, see also structure on line 287

 Remove an open coded simple_open() function
 and replace file operations references to the function
 with simple_open() instead.

Generated by: scripts/coccinelle/api/simple_open.cocci

Fixes: 2ef86936fa7b ("CHROMIUM: drm: Make the drm_trace size configurable")
CC: Sean Paul <seanpaul@chromium.org>
Signed-off-by: kbuild test robot <lkp@intel.com>
---

tree:   https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-4.19
head:   2ef86936fa7b9f135fa6f7a08db0427701107c47
commit: 2ef86936fa7b9f135fa6f7a08db0427701107c47 [3/3] CHROMIUM: drm: Make the drm_trace size configurable

 drm_trace.c |    8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

--- a/drivers/gpu/drm/drm_trace.c
+++ b/drivers/gpu/drm/drm_trace.c
@@ -236,12 +236,6 @@ static const struct file_operations drm_
 	.release = seq_release,
 };
 
-static int drm_trace_size_fop_open(struct inode *inode, struct file *file)
-{
-	file->private_data = inode->i_private;
-	return 0;
-}
-
 static ssize_t drm_trace_size_fop_read(struct file *filp, char __user *ubuf,
 				       size_t cnt, loff_t *ppos)
 {
@@ -284,7 +278,7 @@ static ssize_t drm_trace_size_fop_write(
 }
 
 static const struct file_operations drm_trace_size_fops = {
-	.open = drm_trace_size_fop_open,
+	.open = simple_open,
 	.read = drm_trace_size_fop_read,
 	.write = drm_trace_size_fop_write,
 };

[PATCH] CHROMIUM: drm: fix simple_open.cocci warnings

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1548 bytes --]

From: kbuild test robot <lkp@intel.com>

drivers/gpu/drm/drm_trace.c:239:11-34: WARNING opportunity for simple_open, see also structure on line 287

 Remove an open coded simple_open() function
 and replace file operations references to the function
 with simple_open() instead.

Generated by: scripts/coccinelle/api/simple_open.cocci

Fixes: 2ef86936fa7b ("CHROMIUM: drm: Make the drm_trace size configurable")
CC: Sean Paul <seanpaul@chromium.org>
Signed-off-by: kbuild test robot <lkp@intel.com>
---

tree:   https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-4.19
head:   2ef86936fa7b9f135fa6f7a08db0427701107c47
commit: 2ef86936fa7b9f135fa6f7a08db0427701107c47 [3/3] CHROMIUM: drm: Make the drm_trace size configurable

 drm_trace.c |    8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

--- a/drivers/gpu/drm/drm_trace.c
+++ b/drivers/gpu/drm/drm_trace.c
@@ -236,12 +236,6 @@ static const struct file_operations drm_
 	.release = seq_release,
 };
 
-static int drm_trace_size_fop_open(struct inode *inode, struct file *file)
-{
-	file->private_data = inode->i_private;
-	return 0;
-}
-
 static ssize_t drm_trace_size_fop_read(struct file *filp, char __user *ubuf,
 				       size_t cnt, loff_t *ppos)
 {
@@ -284,7 +278,7 @@ static ssize_t drm_trace_size_fop_write(
 }
 
 static const struct file_operations drm_trace_size_fops = {
-	.open = drm_trace_size_fop_open,
+	.open = simple_open,
 	.read = drm_trace_size_fop_read,
 	.write = drm_trace_size_fop_write,
 };