* [PATCH v2 bpf] tools/bpf/runqslower: Rebuild libbpf.a on libbpf source change
@ 2020-02-04 21:50 Song Liu
2020-02-05 21:22 ` Daniel Borkmann
0 siblings, 1 reply; 2+ messages in thread
From: Song Liu @ 2020-02-04 21:50 UTC (permalink / raw)
To: bpf; +Cc: Song Liu, Andrii Nakryiko
Add missing dependency of $(BPFOBJ) to $(LIBBPF_SRC), so that running make
in runqslower/ will rebuild libbpf.a when there is change in libbpf/.
Fixes: 9c01546d26d2 ("tools/bpf: Add runqslower tool to tools/bpf")
Acked-by: Andrii Nakryiko <andriin@fb.com>
Cc: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
---
tools/bpf/runqslower/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/bpf/runqslower/Makefile b/tools/bpf/runqslower/Makefile
index 87eae5be9bcd..39edd68afa8e 100644
--- a/tools/bpf/runqslower/Makefile
+++ b/tools/bpf/runqslower/Makefile
@@ -75,7 +75,7 @@ $(OUTPUT)/vmlinux.h: $(VMLINUX_BTF_PATH) | $(OUTPUT) $(BPFTOOL)
fi
$(Q)$(BPFTOOL) btf dump file $(VMLINUX_BTF_PATH) format c > $@
-$(BPFOBJ): | $(OUTPUT)
+$(BPFOBJ): $(wildcard $(LIBBPF_SRC)/*.[ch] $(LIBBPF_SRC)/Makefile) | $(OUTPUT)
$(Q)$(MAKE) $(submake_extras) -C $(LIBBPF_SRC) \
OUTPUT=$(abspath $(dir $@))/ $(abspath $@)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 bpf] tools/bpf/runqslower: Rebuild libbpf.a on libbpf source change
2020-02-04 21:50 [PATCH v2 bpf] tools/bpf/runqslower: Rebuild libbpf.a on libbpf source change Song Liu
@ 2020-02-05 21:22 ` Daniel Borkmann
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Borkmann @ 2020-02-05 21:22 UTC (permalink / raw)
To: Song Liu; +Cc: bpf, Andrii Nakryiko
On Tue, Feb 04, 2020 at 01:50:37PM -0800, Song Liu wrote:
> Add missing dependency of $(BPFOBJ) to $(LIBBPF_SRC), so that running make
> in runqslower/ will rebuild libbpf.a when there is change in libbpf/.
>
> Fixes: 9c01546d26d2 ("tools/bpf: Add runqslower tool to tools/bpf")
> Acked-by: Andrii Nakryiko <andriin@fb.com>
> Cc: Andrii Nakryiko <andriin@fb.com>
> Signed-off-by: Song Liu <songliubraving@fb.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-05 21:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-04 21:50 [PATCH v2 bpf] tools/bpf/runqslower: Rebuild libbpf.a on libbpf source change Song Liu
2020-02-05 21:22 ` Daniel Borkmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.