All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/7] board/freescale/common/imx: add support for i.MX8QM
@ 2019-09-09 12:14 Maeva Manuel
  2019-09-09 12:14 ` [Buildroot] [PATCH 2/7] package/freescale-imx: add option " Maeva Manuel
                   ` (6 more replies)
  0 siblings, 7 replies; 20+ messages in thread
From: Maeva Manuel @ 2019-09-09 12:14 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Maeva Manuel <maeva.manuel@nxp.com>
---
 board/freescale/common/imx/imx8-bootloader-prepare.sh | 7 +++++--
 board/freescale/common/imx/post-image.sh              | 4 +++-
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/board/freescale/common/imx/imx8-bootloader-prepare.sh b/board/freescale/common/imx/imx8-bootloader-prepare.sh
index df528b0df5..6c49fe02a7 100755
--- a/board/freescale/common/imx/imx8-bootloader-prepare.sh
+++ b/board/freescale/common/imx/imx8-bootloader-prepare.sh
@@ -27,8 +27,11 @@ main ()
 		cat ${BINARIES_DIR}/u-boot.bin ${BINARIES_DIR}/mkimg.commit > ${BINARIES_DIR}/u-boot-hash.bin
 		cp ${BINARIES_DIR}/bl31.bin ${BINARIES_DIR}/u-boot-atf.bin
 		dd if=${BINARIES_DIR}/u-boot-hash.bin of=${BINARIES_DIR}/u-boot-atf.bin bs=1K seek=128
-
-		${HOST_DIR}/bin/mkimage_imx8 -soc QX -rev B0 -append ${BINARIES_DIR}/ahab-container.img -c -scfw ${BINARIES_DIR}/mx8qx-mek-scfw-tcm.bin -ap ${BINARIES_DIR}/u-boot-atf.bin a35 0x80000000 -out ${BINARIES_DIR}/imx8-boot-sd.bin
+		if grep -Eq "^BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8=y$" ${BR2_CONFIG}; then
+			${HOST_DIR}/bin/mkimage_imx8 -soc QM -rev B0 -append ${BINARIES_DIR}/mx8qm-ahab-container.img -c -scfw ${BINARIES_DIR}/mx8qm-mek-scfw-tcm.bin -ap ${BINARIES_DIR}/u-boot-atf.bin a53 0x80000000 -out ${BINARIES_DIR}/imx8-boot-sd.bin
+		else
+			${HOST_DIR}/bin/mkimage_imx8 -soc QX -rev B0 -append ${BINARIES_DIR}/mx8qx-ahab-container.img -c -scfw ${BINARIES_DIR}/mx8qx-mek-scfw-tcm.bin -ap ${BINARIES_DIR}/u-boot-atf.bin a35 0x80000000 -out ${BINARIES_DIR}/imx8-boot-sd.bin
+		fi
 	fi
 
 	exit $?
diff --git a/board/freescale/common/imx/post-image.sh b/board/freescale/common/imx/post-image.sh
index 19d8fffb63..138ea7b123 100755
--- a/board/freescale/common/imx/post-image.sh
+++ b/board/freescale/common/imx/post-image.sh
@@ -32,7 +32,9 @@ linux_image()
 
 genimage_type()
 {
-	if grep -Eq "^BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M=y$" ${BR2_CONFIG}; then
+	if grep -Eq "^BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8=y$" ${BR2_CONFIG}; then
+		echo "genimage.cfg.template_imx8"
+	elif grep -Eq "^BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M=y$" ${BR2_CONFIG}; then
 		echo "genimage.cfg.template_imx8"
 	elif grep -Eq "^BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM=y$" ${BR2_CONFIG}; then
 		echo "genimage.cfg.template_imx8"
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH 2/7] package/freescale-imx: add option for i.MX8QM
  2019-09-09 12:14 [Buildroot] [PATCH 1/7] board/freescale/common/imx: add support for i.MX8QM Maeva Manuel
@ 2019-09-09 12:14 ` Maeva Manuel
  2019-11-08 17:30   ` Gary Bisson
  2020-02-05 10:31   ` Thomas Petazzoni
  2019-09-09 12:15 ` [Buildroot] [PATCH 3/7] package/freescale-imx/imx-sc-firmware: bump to version 1.1 to support i.MX8QM Maeva Manuel
                   ` (5 subsequent siblings)
  6 siblings, 2 replies; 20+ messages in thread
From: Maeva Manuel @ 2019-09-09 12:14 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Maeva Manuel <maeva.manuel@nxp.com>
---
 package/freescale-imx/Config.in | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in
index f010aab87b..5672e09b05 100644
--- a/package/freescale-imx/Config.in
+++ b/package/freescale-imx/Config.in
@@ -40,6 +40,9 @@ config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6UL
 config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7
 	bool "imx7d/imx7ulp"
 
+config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
+	bool "imx8"
+
 config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M
 	bool "imx8m"
 
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH 3/7] package/freescale-imx/imx-sc-firmware: bump to version 1.1 to support i.MX8QM
  2019-09-09 12:14 [Buildroot] [PATCH 1/7] board/freescale/common/imx: add support for i.MX8QM Maeva Manuel
  2019-09-09 12:14 ` [Buildroot] [PATCH 2/7] package/freescale-imx: add option " Maeva Manuel
@ 2019-09-09 12:15 ` Maeva Manuel
  2019-11-08 17:33   ` Gary Bisson
  2020-02-05 10:38   ` Thomas Petazzoni
  2019-09-09 12:15 ` [Buildroot] [PATCH 4/7] package/freescale-imx/imx-sc-firmware: add hash file Maeva Manuel
                   ` (4 subsequent siblings)
  6 siblings, 2 replies; 20+ messages in thread
From: Maeva Manuel @ 2019-09-09 12:15 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Maeva Manuel <maeva.manuel@nxp.com>
---
 package/freescale-imx/imx-sc-firmware/Config.in    |  2 +-
 .../imx-sc-firmware/imx-sc-firmware.mk             | 14 +++++++++-----
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/package/freescale-imx/imx-sc-firmware/Config.in b/package/freescale-imx/imx-sc-firmware/Config.in
index 4a22f72b1f..93dfeb1a68 100644
--- a/package/freescale-imx/imx-sc-firmware/Config.in
+++ b/package/freescale-imx/imx-sc-firmware/Config.in
@@ -1,6 +1,6 @@
 config BR2_PACKAGE_IMX_SC_FIRMWARE
 	bool "imx-sc-firmware"
-	depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X
+	depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X || BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
 	help
 	  System Control Unit Firmware blobs for the Freescale i.MX8
 	  SoCs.
diff --git a/package/freescale-imx/imx-sc-firmware/imx-sc-firmware.mk b/package/freescale-imx/imx-sc-firmware/imx-sc-firmware.mk
index fac20d0c6f..08b562a054 100644
--- a/package/freescale-imx/imx-sc-firmware/imx-sc-firmware.mk
+++ b/package/freescale-imx/imx-sc-firmware/imx-sc-firmware.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-IMX_SC_FIRMWARE_VERSION = 1.0
+IMX_SC_FIRMWARE_VERSION = 1.1
 IMX_SC_FIRMWARE_SITE = $(FREESCALE_IMX_SITE)
 IMX_SC_FIRMWARE_SOURCE = imx-sc-firmware-$(IMX_SC_FIRMWARE_VERSION).bin
 
@@ -18,10 +18,14 @@ endef
 
 IMX_SC_FIRMWARE_INSTALL_IMAGES = YES
 define IMX_SC_FIRMWARE_INSTALL_IMAGES_CMDS
-	# SCFW firmware is needed when generating imx8-boot-sd.bin which
-	# is done in post-image script.
-	cp $(@D)/mx8qx-mek-scfw-tcm.bin $(BINARIES_DIR)/mx8qx-mek-scfw-tcm.bin
-	cp $(@D)/mx8qx-val-scfw-tcm.bin $(BINARIES_DIR)/mx8qx-val-scfw-tcm.bin
+# SCFW firmware is needed when generating imx8-boot-sd.bin which
+# is done in post-image script.
+
+# For i.MX8QM support the SCFW needed is mx8qm-mek-scfw-tcm.bin
+# and mx8qm-val-scfw-tcm.bin
+# For i.MX8QXP support the SCFW needed is mx8qx-mek-scfw-tcm.bin
+# and mx8qx-val-scfw-tcm.bin
+cp $(@D)/*-scfw-tcm.bin $(BINARIES_DIR)/*-scfw-tcm.bin
 endef
 
 $(eval $(generic-package))
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH 4/7] package/freescale-imx/imx-sc-firmware: add hash file
  2019-09-09 12:14 [Buildroot] [PATCH 1/7] board/freescale/common/imx: add support for i.MX8QM Maeva Manuel
  2019-09-09 12:14 ` [Buildroot] [PATCH 2/7] package/freescale-imx: add option " Maeva Manuel
  2019-09-09 12:15 ` [Buildroot] [PATCH 3/7] package/freescale-imx/imx-sc-firmware: bump to version 1.1 to support i.MX8QM Maeva Manuel
@ 2019-09-09 12:15 ` Maeva Manuel
  2019-11-08 17:34   ` Gary Bisson
  2020-02-05 10:38   ` Thomas Petazzoni
  2019-09-09 12:15 ` [Buildroot] [PATCH 5/7] package/freescale-imx/firmware-imx: Maeva Manuel
                   ` (3 subsequent siblings)
  6 siblings, 2 replies; 20+ messages in thread
From: Maeva Manuel @ 2019-09-09 12:15 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Maeva Manuel <maeva.manuel@nxp.com>
---
 package/freescale-imx/imx-sc-firmware/imx-sc-firmware.hash | 4 ++++
 1 file changed, 4 insertions(+)
 create mode 100644 package/freescale-imx/imx-sc-firmware/imx-sc-firmware.hash

diff --git a/package/freescale-imx/imx-sc-firmware/imx-sc-firmware.hash b/package/freescale-imx/imx-sc-firmware/imx-sc-firmware.hash
new file mode 100644
index 0000000000..3b4326302f
--- /dev/null
+++ b/package/freescale-imx/imx-sc-firmware/imx-sc-firmware.hash
@@ -0,0 +1,4 @@
+# Locally calculated
+sha256 d07f8e517e0bd82175d1cd77e01b6702735eb95774053f9c431d1a5016fc7152  imx-sc-firmware-1.1.bin
+sha256 fc93f26e4197b9240c327ce26ae6e02123f022423d4704c7b0448a37372cf2a2  EULA
+sha256 78696664f7afe7f2b081c99af60082d6403fab935b1b10056ed41aec123ff7fa  COPYING
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH 5/7] package/freescale-imx/firmware-imx:
  2019-09-09 12:14 [Buildroot] [PATCH 1/7] board/freescale/common/imx: add support for i.MX8QM Maeva Manuel
                   ` (2 preceding siblings ...)
  2019-09-09 12:15 ` [Buildroot] [PATCH 4/7] package/freescale-imx/imx-sc-firmware: add hash file Maeva Manuel
@ 2019-09-09 12:15 ` Maeva Manuel
  2019-09-13 15:44   ` André Hentschel
  2020-02-05 10:39   ` Thomas Petazzoni
  2019-09-09 12:15 ` [Buildroot] [PATCH 6/7] configs/freescale_imx8qmmek: new defconfig Maeva Manuel
                   ` (2 subsequent siblings)
  6 siblings, 2 replies; 20+ messages in thread
From: Maeva Manuel @ 2019-09-09 12:15 UTC (permalink / raw)
  To: buildroot

  bump to version 8.0 to support i.MX8QM

Signed-off-by: Maeva Manuel <maeva.manuel@nxp.com>
---
 .../freescale-imx/firmware-imx/firmware-imx.hash   |  2 +-
 package/freescale-imx/firmware-imx/firmware-imx.mk | 14 +++++++++++---
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/package/freescale-imx/firmware-imx/firmware-imx.hash b/package/freescale-imx/firmware-imx/firmware-imx.hash
index c22ee4c192..615c549e7d 100644
--- a/package/freescale-imx/firmware-imx/firmware-imx.hash
+++ b/package/freescale-imx/firmware-imx/firmware-imx.hash
@@ -1,4 +1,4 @@
 # Locally calculated
-sha256 a8f099bdf786b2da1e8b43094950c033ccdbf93f1b8a93caffb912e1500cd735  firmware-imx-7.5.bin
+sha256 63ec62f5d229cbed00918c8449173933f1c9d594c59396b8dd217e94f47138b0  firmware-imx-8.0.bin
 sha256 fc93f26e4197b9240c327ce26ae6e02123f022423d4704c7b0448a37372cf2a2  EULA
 sha256 78696664f7afe7f2b081c99af60082d6403fab935b1b10056ed41aec123ff7fa  COPYING
diff --git a/package/freescale-imx/firmware-imx/firmware-imx.mk b/package/freescale-imx/firmware-imx/firmware-imx.mk
index b70b581523..92c090fae0 100644
--- a/package/freescale-imx/firmware-imx/firmware-imx.mk
+++ b/package/freescale-imx/firmware-imx/firmware-imx.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-FIRMWARE_IMX_VERSION = 7.5
+FIRMWARE_IMX_VERSION = 8.0
 FIRMWARE_IMX_SITE = $(FREESCALE_IMX_SITE)
 FIRMWARE_IMX_SOURCE = firmware-imx-$(FIRMWARE_IMX_VERSION).bin
 
@@ -45,13 +45,21 @@ define FIRMWARE_IMX_INSTALL_IMAGES_CMDS
 	cp $(@D)/firmware/hdmi/cadence/signed_hdmi_imx8m.bin \
 		$(BINARIES_DIR)/signed_hdmi_imx8m.bin
 endef
+else ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8),y)
+FIRMWARE_IMX_INSTALL_IMAGES = YES
+define FIRMWARE_IMX_INSTALL_IMAGES_CMDS
+	# SECO firmware is needed when generating imx8-boot-sd.bin which
+	# is done in post-image script.
+	cp $(@D)/firmware/seco/mx8qm-ahab-container.img \
+		$(BINARIES_DIR)/mx8qm-ahab-container.img
+endef
 else ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X),y)
 FIRMWARE_IMX_INSTALL_IMAGES = YES
 define FIRMWARE_IMX_INSTALL_IMAGES_CMDS
 	# SECO firmware is needed when generating imx8-boot-sd.bin which
 	# is done in post-image script.
-	cp $(@D)/firmware/seco/ahab-container.img \
-		$(BINARIES_DIR)/ahab-container.img
+	cp $(@D)/firmware/seco/mx8qx-ahab-container.img \
+		$(BINARIES_DIR)/mx8qx-ahab-container.img
 endef
 else
 define FIRMWARE_IMX_INSTALL_TARGET_CMDS
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH 6/7] configs/freescale_imx8qmmek: new defconfig
  2019-09-09 12:14 [Buildroot] [PATCH 1/7] board/freescale/common/imx: add support for i.MX8QM Maeva Manuel
                   ` (3 preceding siblings ...)
  2019-09-09 12:15 ` [Buildroot] [PATCH 5/7] package/freescale-imx/firmware-imx: Maeva Manuel
@ 2019-09-09 12:15 ` Maeva Manuel
  2020-02-05 11:20   ` Thomas Petazzoni
  2019-09-09 12:15 ` [Buildroot] [PATCH 7/7] board/freescale/imx8qxpmek: update instructions Maeva Manuel
  2020-02-05 10:30 ` [Buildroot] [PATCH 1/7] board/freescale/common/imx: add support for i.MX8QM Thomas Petazzoni
  6 siblings, 1 reply; 20+ messages in thread
From: Maeva Manuel @ 2019-09-09 12:15 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Maeva Manuel <maeva.manuel@nxp.com>
---
 .gitlab-ci.yml                        |  1 +
 DEVELOPERS                            |  4 ++
 board/freescale/imx8qmmek/readme.txt  | 66 +++++++++++++++++++++++++++
 configs/freescale_imx8qmmek_defconfig | 40 ++++++++++++++++
 4 files changed, 111 insertions(+)
 create mode 100644 board/freescale/imx8qmmek/readme.txt
 create mode 100644 configs/freescale_imx8qmmek_defconfig

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 6243107ee9..cad07a6c43 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -178,6 +178,7 @@ freescale_imx6sxsabresd_defconfig: { extends: .defconfig }
 freescale_imx7dsabresd_defconfig: { extends: .defconfig }
 freescale_imx8mmevk_defconfig: { extends: .defconfig }
 freescale_imx8mqevk_defconfig: { extends: .defconfig }
+freescale_imx8qmmek_defconfig: { extends: .defconfig }
 freescale_imx8qxpmek_defconfig: { extends: .defconfig }
 freescale_p1025twr_defconfig: { extends: .defconfig }
 freescale_t1040d4rdb_defconfig: { extends: .defconfig }
diff --git a/DEVELOPERS b/DEVELOPERS
index 58d18a36e8..c7d06e555d 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1400,6 +1400,10 @@ F:	package/python-simplejson/
 F:	package/python-versiontools/
 F:	package/wilc1000-firmware/
 
+N:	Maeva Manuel <maeva.manuel@nxp.com>
+F:	board/freescale/imx8qmmek/
+F:	configs/freescale_imx8qmmek_defconfig
+
 N:	Mahyar Koshkouei <mahyar.koshkouei@gmail.com>
 F:	package/ffmpeg/
 F:	package/mpv/
diff --git a/board/freescale/imx8qmmek/readme.txt b/board/freescale/imx8qmmek/readme.txt
new file mode 100644
index 0000000000..15eecfa83e
--- /dev/null
+++ b/board/freescale/imx8qmmek/readme.txt
@@ -0,0 +1,66 @@
+***************************
+Freescale i.MX8QM MEK board
+***************************
+
+This file documents the Buildroot support for the Freescale i.MX8QM MEK board.
+
+Build
+=====
+
+First, configure Buildroot for the i.MX8QM MEK board:
+
+  make freescale_imx8qmmek_defconfig
+
+Build all components:
+
+  make
+
+You will find in output/images/ the following files:
+  - mx8qm-ahab-container.img
+  - bl31.bin
+  - boot.vfat
+  - fsl-imx8qm-mek.dtb
+  - Image
+  - imx8-boot-sd.bin
+  - mkimg.commit
+  - mx8qm-mek-scfw-tcm.bin
+  - mx8qm-val-scfw-tcm.bin
+  - rootfs.ext2
+  - rootfs.ext4
+  - rootfs.tar
+  - sdcard.img
+  - u-boot-atf.bin
+  - u-boot.bin
+  - u-boot-hash.bin
+
+Create a bootable SD card
+=========================
+
+To determine the device associated to the SD card have a look in the
+/proc/partitions file:
+
+  cat /proc/partitions
+
+Buildroot prepares a bootable "sdcard.img" image in the output/images/
+directory, ready to be dumped on a SD card. Launch the following
+command as root:
+
+  dd if=output/images/sdcard.img of=/dev/<your-sd-device>
+
+*** WARNING! This will destroy all the card content. Use with care! ***
+
+For details about the medium image layout, see the definition in
+board/freescale/common/imx/genimage.cfg.template_imx8.
+
+Boot the i.MX8QM MEK board
+==========================
+
+To boot your newly created system:
+- insert the SD card in the SD slot of the board;
+- Configure the boot switch as follows:
+SW2:	OFF	OFF	ON	ON	OFF	OFF
+- put a micro USB cable into the Debug USB Port and connect using a terminal
+  emulator at 115200 bps, 8n1;
+- power on the board.
+
+Enjoy!
diff --git a/configs/freescale_imx8qmmek_defconfig b/configs/freescale_imx8qmmek_defconfig
new file mode 100644
index 0000000000..b0c433cf4a
--- /dev/null
+++ b/configs/freescale_imx8qmmek_defconfig
@@ -0,0 +1,40 @@
+BR2_aarch64=y
+BR2_ARM_FPU_VFPV4=y
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_14=y
+#GCC version must be inferior to 8_X because of -Wstringop-truncation message error
+BR2_GCC_VERSION_7_X=y
+BR2_ROOTFS_POST_IMAGE_SCRIPT="board/freescale/common/imx/imx8-bootloader-prepare.sh board/freescale/common/imx/post-image.sh"
+BR2_ROOTFS_POST_SCRIPT_ARGS="${UBOOT_DIR}/arch/arm/dts/fsl-imx8qm-mek.dtb"
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_GIT=y
+BR2_LINUX_KERNEL_CUSTOM_REPO_URL="ssh://git at bitbucket.sw.nxp.com/imx/linux-imx.git"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="rel_imx_4.14.78_1.0.0_ga"
+BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="freescale/fsl-imx8qm-mek"
+BR2_PACKAGE_FREESCALE_IMX=y
+BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8=y
+BR2_PACKAGE_FIRMWARE_IMX=y
+BR2_PACKAGE_IMX_SC_FIRMWARE=y
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_GIT=y
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_URL="ssh://git at bitbucket.sw.nxp.com/imx/arm-trusted-firmware.git"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="rel_imx_4.14.78_1.0.0_ga"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="imx8qm"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
+BR2_TARGET_UBOOT_CUSTOM_GIT=y
+BR2_TARGET_UBOOT_CUSTOM_REPO_URL="ssh://git at bitbucket.sw.nxp.com/imx/uboot-imx.git"
+BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="rel_imx_4.14.78_1.0.0_ga"
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="imx8qm_mek"
+BR2_TARGET_UBOOT_NEEDS_DTC=y
+BR2_PACKAGE_HOST_DOSFSTOOLS=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_PACKAGE_HOST_IMX_MKIMAGE=y
+BR2_PACKAGE_HOST_MTOOLS=y
+BR2_PACKAGE_HOST_UBOOT_TOOLS=y
+BR2_PACKAGE_HOST_UBOOT_TOOLS_FIT_SUPPORT=y
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH 7/7] board/freescale/imx8qxpmek: update instructions
  2019-09-09 12:14 [Buildroot] [PATCH 1/7] board/freescale/common/imx: add support for i.MX8QM Maeva Manuel
                   ` (4 preceding siblings ...)
  2019-09-09 12:15 ` [Buildroot] [PATCH 6/7] configs/freescale_imx8qmmek: new defconfig Maeva Manuel
@ 2019-09-09 12:15 ` Maeva Manuel
  2020-02-05 11:12   ` Thomas Petazzoni
  2020-02-05 10:30 ` [Buildroot] [PATCH 1/7] board/freescale/common/imx: add support for i.MX8QM Thomas Petazzoni
  6 siblings, 1 reply; 20+ messages in thread
From: Maeva Manuel @ 2019-09-09 12:15 UTC (permalink / raw)
  To: buildroot

	The ahab-container.img has been replaced by
	mx8qx-ahab-container.img because of the i.MX8QM support

Signed-off-by: Maeva Manuel <maeva.manuel@nxp.com>
---
 board/freescale/imx8qxpmek/readme.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/board/freescale/imx8qxpmek/readme.txt b/board/freescale/imx8qxpmek/readme.txt
index 45f7915fe4..e10138f8f8 100644
--- a/board/freescale/imx8qxpmek/readme.txt
+++ b/board/freescale/imx8qxpmek/readme.txt
@@ -17,7 +17,8 @@ Build all components:
   make
 
 You will find in output/images/ the following files:
-  - ahab-container.img
+
+  - mx8qx-ahab-container.img
   - bl31.bin
   - boot.vfat
   - fsl-imx8qxp-mek.dtb
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH 5/7] package/freescale-imx/firmware-imx:
  2019-09-09 12:15 ` [Buildroot] [PATCH 5/7] package/freescale-imx/firmware-imx: Maeva Manuel
@ 2019-09-13 15:44   ` André Hentschel
  2020-02-05 10:39   ` Thomas Petazzoni
  1 sibling, 0 replies; 20+ messages in thread
From: André Hentschel @ 2019-09-13 15:44 UTC (permalink / raw)
  To: buildroot

On 09.09.19 14:15, Maeva Manuel wrote:
>    bump to version 8.0 to support i.MX8QM
> 
> Signed-off-by: Maeva Manuel <maeva.manuel@nxp.com>
> ---
>   .../freescale-imx/firmware-imx/firmware-imx.hash   |  2 +-
>   package/freescale-imx/firmware-imx/firmware-imx.mk | 14 +++++++++++---
>   2 files changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git a/package/freescale-imx/firmware-imx/firmware-imx.hash b/package/freescale-imx/firmware-imx/firmware-imx.hash
> index c22ee4c192..615c549e7d 100644
> --- a/package/freescale-imx/firmware-imx/firmware-imx.hash
> +++ b/package/freescale-imx/firmware-imx/firmware-imx.hash
> @@ -1,4 +1,4 @@
>   # Locally calculated
> -sha256 a8f099bdf786b2da1e8b43094950c033ccdbf93f1b8a93caffb912e1500cd735  firmware-imx-7.5.bin
> +sha256 63ec62f5d229cbed00918c8449173933f1c9d594c59396b8dd217e94f47138b0  firmware-imx-8.0.bin
>   sha256 fc93f26e4197b9240c327ce26ae6e02123f022423d4704c7b0448a37372cf2a2  EULA
>   sha256 78696664f7afe7f2b081c99af60082d6403fab935b1b10056ed41aec123ff7fa  COPYING
> diff --git a/package/freescale-imx/firmware-imx/firmware-imx.mk b/package/freescale-imx/firmware-imx/firmware-imx.mk
> index b70b581523..92c090fae0 100644
> --- a/package/freescale-imx/firmware-imx/firmware-imx.mk
> +++ b/package/freescale-imx/firmware-imx/firmware-imx.mk
> @@ -4,7 +4,7 @@
>   #
>   ################################################################################
>   
> -FIRMWARE_IMX_VERSION = 7.5
> +FIRMWARE_IMX_VERSION = 8.0
>   FIRMWARE_IMX_SITE = $(FREESCALE_IMX_SITE)
>   FIRMWARE_IMX_SOURCE = firmware-imx-$(FIRMWARE_IMX_VERSION).bin
>   
> @@ -45,13 +45,21 @@ define FIRMWARE_IMX_INSTALL_IMAGES_CMDS
>   	cp $(@D)/firmware/hdmi/cadence/signed_hdmi_imx8m.bin \
>   		$(BINARIES_DIR)/signed_hdmi_imx8m.bin
>   endef
> +else ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8),y)
> +FIRMWARE_IMX_INSTALL_IMAGES = YES
> +define FIRMWARE_IMX_INSTALL_IMAGES_CMDS
> +	# SECO firmware is needed when generating imx8-boot-sd.bin which
> +	# is done in post-image script.
> +	cp $(@D)/firmware/seco/mx8qm-ahab-container.img \
> +		$(BINARIES_DIR)/mx8qm-ahab-container.img
> +endef
>   else ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X),y)
>   FIRMWARE_IMX_INSTALL_IMAGES = YES
>   define FIRMWARE_IMX_INSTALL_IMAGES_CMDS
>   	# SECO firmware is needed when generating imx8-boot-sd.bin which
>   	# is done in post-image script.
> -	cp $(@D)/firmware/seco/ahab-container.img \
> -		$(BINARIES_DIR)/ahab-container.img
> +	cp $(@D)/firmware/seco/mx8qx-ahab-container.img \
> +		$(BINARIES_DIR)/mx8qx-ahab-container.img
>   endef
>   else
>   define FIRMWARE_IMX_INSTALL_TARGET_CMDS
> 

Hi Ma?va,

interesting patchset :)
This patch should take care of places using the ahab-container.img, 
because the name changes with the upgrade. Namely imx8-bootloader-prepare.sh
As you should have easy access to an i.MX8QXP MEK board, could you 
please verify that the version upgrades don't break the build and 
especially the runtime on it?

Best regards,
Andr? Hentschel

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH 2/7] package/freescale-imx: add option for i.MX8QM
  2019-09-09 12:14 ` [Buildroot] [PATCH 2/7] package/freescale-imx: add option " Maeva Manuel
@ 2019-11-08 17:30   ` Gary Bisson
  2020-02-05 10:36     ` Thomas Petazzoni
  2020-02-05 10:31   ` Thomas Petazzoni
  1 sibling, 1 reply; 20+ messages in thread
From: Gary Bisson @ 2019-11-08 17:30 UTC (permalink / raw)
  To: buildroot

Hi Maeva,

Sorry for the (very) late reply.

On Mon, Sep 09, 2019 at 12:14:58PM +0000, Maeva Manuel wrote:
> Signed-off-by: Maeva Manuel <maeva.manuel@nxp.com>
> ---
>  package/freescale-imx/Config.in | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in
> index f010aab87b..5672e09b05 100644
> --- a/package/freescale-imx/Config.in
> +++ b/package/freescale-imx/Config.in
> @@ -40,6 +40,9 @@ config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6UL
>  config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7
>  	bool "imx7d/imx7ulp"
>  
> +config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
> +	bool "imx8"
> +
>  config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M
>  	bool "imx8m"

This isn't sufficient, you also need to make sure to add
BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8 in the
BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU definition as I'm sure it has a
Vivante GPU ;)

Looking at Config.in, seems that MX8MM has the same issue.

Regards,
Gary

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH 3/7] package/freescale-imx/imx-sc-firmware: bump to version 1.1 to support i.MX8QM
  2019-09-09 12:15 ` [Buildroot] [PATCH 3/7] package/freescale-imx/imx-sc-firmware: bump to version 1.1 to support i.MX8QM Maeva Manuel
@ 2019-11-08 17:33   ` Gary Bisson
  2020-02-05 10:38   ` Thomas Petazzoni
  1 sibling, 0 replies; 20+ messages in thread
From: Gary Bisson @ 2019-11-08 17:33 UTC (permalink / raw)
  To: buildroot

Hi Maeva,

On Mon, Sep 09, 2019 at 12:15:00PM +0000, Maeva Manuel wrote:
> Signed-off-by: Maeva Manuel <maeva.manuel@nxp.com>
> ---
>  package/freescale-imx/imx-sc-firmware/Config.in    |  2 +-
>  .../imx-sc-firmware/imx-sc-firmware.mk             | 14 +++++++++-----
>  2 files changed, 10 insertions(+), 6 deletions(-)
> 
> diff --git a/package/freescale-imx/imx-sc-firmware/Config.in b/package/freescale-imx/imx-sc-firmware/Config.in
> index 4a22f72b1f..93dfeb1a68 100644
> --- a/package/freescale-imx/imx-sc-firmware/Config.in
> +++ b/package/freescale-imx/imx-sc-firmware/Config.in
> @@ -1,6 +1,6 @@
>  config BR2_PACKAGE_IMX_SC_FIRMWARE
>  	bool "imx-sc-firmware"
> -	depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X
> +	depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X || BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
>  	help
>  	  System Control Unit Firmware blobs for the Freescale i.MX8
>  	  SoCs.
> diff --git a/package/freescale-imx/imx-sc-firmware/imx-sc-firmware.mk b/package/freescale-imx/imx-sc-firmware/imx-sc-firmware.mk
> index fac20d0c6f..08b562a054 100644
> --- a/package/freescale-imx/imx-sc-firmware/imx-sc-firmware.mk
> +++ b/package/freescale-imx/imx-sc-firmware/imx-sc-firmware.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -IMX_SC_FIRMWARE_VERSION = 1.0
> +IMX_SC_FIRMWARE_VERSION = 1.1

Can you offer a new patch with latest version?
https://source.codeaurora.org/external/imx/meta-fsl-bsp-release/tree/imx/meta-bsp/recipes-bsp/imx-sc-firmware/imx-sc-firmware_1.2.2.bb?h=rel_imx_4.14.98_2.1.0

>  IMX_SC_FIRMWARE_SITE = $(FREESCALE_IMX_SITE)
>  IMX_SC_FIRMWARE_SOURCE = imx-sc-firmware-$(IMX_SC_FIRMWARE_VERSION).bin
>  
> @@ -18,10 +18,14 @@ endef
>  
>  IMX_SC_FIRMWARE_INSTALL_IMAGES = YES
>  define IMX_SC_FIRMWARE_INSTALL_IMAGES_CMDS
> -	# SCFW firmware is needed when generating imx8-boot-sd.bin which
> -	# is done in post-image script.
> -	cp $(@D)/mx8qx-mek-scfw-tcm.bin $(BINARIES_DIR)/mx8qx-mek-scfw-tcm.bin
> -	cp $(@D)/mx8qx-val-scfw-tcm.bin $(BINARIES_DIR)/mx8qx-val-scfw-tcm.bin
> +# SCFW firmware is needed when generating imx8-boot-sd.bin which
> +# is done in post-image script.
> +
> +# For i.MX8QM support the SCFW needed is mx8qm-mek-scfw-tcm.bin
> +# and mx8qm-val-scfw-tcm.bin
> +# For i.MX8QXP support the SCFW needed is mx8qx-mek-scfw-tcm.bin
> +# and mx8qx-val-scfw-tcm.bin
> +cp $(@D)/*-scfw-tcm.bin $(BINARIES_DIR)/*-scfw-tcm.bin

Since we make the user select the CPU used in the other menu, please
split the firmware copy so that only 8X ones are in the image with 8X is
selected.

Regards,
Gary

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH 4/7] package/freescale-imx/imx-sc-firmware: add hash file
  2019-09-09 12:15 ` [Buildroot] [PATCH 4/7] package/freescale-imx/imx-sc-firmware: add hash file Maeva Manuel
@ 2019-11-08 17:34   ` Gary Bisson
  2020-02-05 10:38   ` Thomas Petazzoni
  1 sibling, 0 replies; 20+ messages in thread
From: Gary Bisson @ 2019-11-08 17:34 UTC (permalink / raw)
  To: buildroot

Hi Maeva,

On Mon, Sep 09, 2019 at 12:15:02PM +0000, Maeva Manuel wrote:
> Signed-off-by: Maeva Manuel <maeva.manuel@nxp.com>
> ---
>  package/freescale-imx/imx-sc-firmware/imx-sc-firmware.hash | 4 ++++
>  1 file changed, 4 insertions(+)
>  create mode 100644 package/freescale-imx/imx-sc-firmware/imx-sc-firmware.hash
> 
> diff --git a/package/freescale-imx/imx-sc-firmware/imx-sc-firmware.hash b/package/freescale-imx/imx-sc-firmware/imx-sc-firmware.hash
> new file mode 100644
> index 0000000000..3b4326302f
> --- /dev/null
> +++ b/package/freescale-imx/imx-sc-firmware/imx-sc-firmware.hash
> @@ -0,0 +1,4 @@
> +# Locally calculated
> +sha256 d07f8e517e0bd82175d1cd77e01b6702735eb95774053f9c431d1a5016fc7152  imx-sc-firmware-1.1.bin
> +sha256 fc93f26e4197b9240c327ce26ae6e02123f022423d4704c7b0448a37372cf2a2  EULA
> +sha256 78696664f7afe7f2b081c99af60082d6403fab935b1b10056ed41aec123ff7fa  COPYING

This should be part of PATCH 3/7, no need to separate it.

Regards,
Gary

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH 1/7] board/freescale/common/imx: add support for i.MX8QM
  2019-09-09 12:14 [Buildroot] [PATCH 1/7] board/freescale/common/imx: add support for i.MX8QM Maeva Manuel
                   ` (5 preceding siblings ...)
  2019-09-09 12:15 ` [Buildroot] [PATCH 7/7] board/freescale/imx8qxpmek: update instructions Maeva Manuel
@ 2020-02-05 10:30 ` Thomas Petazzoni
  6 siblings, 0 replies; 20+ messages in thread
From: Thomas Petazzoni @ 2020-02-05 10:30 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon, 9 Sep 2019 12:14:55 +0000
Maeva Manuel <maeva.manuel@nxp.com> wrote:

> Signed-off-by: Maeva Manuel <maeva.manuel@nxp.com>
> ---
>  board/freescale/common/imx/imx8-bootloader-prepare.sh | 7 +++++--
>  board/freescale/common/imx/post-image.sh              | 4 +++-
>  2 files changed, 8 insertions(+), 3 deletions(-)

Thanks, I have applied, but at a later point in the series, i.e after
the imx-firmware-sc change that ensures the proper firmware gets
installed.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH 2/7] package/freescale-imx: add option for i.MX8QM
  2019-09-09 12:14 ` [Buildroot] [PATCH 2/7] package/freescale-imx: add option " Maeva Manuel
  2019-11-08 17:30   ` Gary Bisson
@ 2020-02-05 10:31   ` Thomas Petazzoni
  1 sibling, 0 replies; 20+ messages in thread
From: Thomas Petazzoni @ 2020-02-05 10:31 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon, 9 Sep 2019 12:14:58 +0000
Maeva Manuel <maeva.manuel@nxp.com> wrote:

> Signed-off-by: Maeva Manuel <maeva.manuel@nxp.com>

I have applied after extending the commit log to give a bit more
context about the i.MX8 family, which contains i.MX8QM and i.MX8QP.

I've also updated BR2_PACKAGE_FREESCALE_IMX_PLATFORM and
BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU with this new i.MX platform, as
suggested by Gary.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH 2/7] package/freescale-imx: add option for i.MX8QM
  2019-11-08 17:30   ` Gary Bisson
@ 2020-02-05 10:36     ` Thomas Petazzoni
  0 siblings, 0 replies; 20+ messages in thread
From: Thomas Petazzoni @ 2020-02-05 10:36 UTC (permalink / raw)
  To: buildroot

On Fri, 8 Nov 2019 18:30:26 +0100
Gary Bisson <bisson.gary@gmail.com> wrote:

> This isn't sufficient, you also need to make sure to add
> BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8 in the
> BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU definition as I'm sure it has a
> Vivante GPU ;)

True, I fixed that when applying.

> Looking at Config.in, seems that MX8MM has the same issue.

It was fixed yesterday by commit 7b3c48ed8107c5cd39f5d761734964dcd8c8d408.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH 3/7] package/freescale-imx/imx-sc-firmware: bump to version 1.1 to support i.MX8QM
  2019-09-09 12:15 ` [Buildroot] [PATCH 3/7] package/freescale-imx/imx-sc-firmware: bump to version 1.1 to support i.MX8QM Maeva Manuel
  2019-11-08 17:33   ` Gary Bisson
@ 2020-02-05 10:38   ` Thomas Petazzoni
  1 sibling, 0 replies; 20+ messages in thread
From: Thomas Petazzoni @ 2020-02-05 10:38 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon, 9 Sep 2019 12:15:00 +0000
Maeva Manuel <maeva.manuel@nxp.com> wrote:

> Signed-off-by: Maeva Manuel <maeva.manuel@nxp.com>

I have applied, but with some changes. See below.

> -IMX_SC_FIRMWARE_VERSION = 1.0
> +IMX_SC_FIRMWARE_VERSION = 1.1

The bump to 1.2.1 was already done in commit
b74eaecb2232c4d2b717f867218ad731da836cbc, so I dropped this part.

>  IMX_SC_FIRMWARE_SITE = $(FREESCALE_IMX_SITE)
>  IMX_SC_FIRMWARE_SOURCE = imx-sc-firmware-$(IMX_SC_FIRMWARE_VERSION).bin
>  
> @@ -18,10 +18,14 @@ endef
>  
>  IMX_SC_FIRMWARE_INSTALL_IMAGES = YES
>  define IMX_SC_FIRMWARE_INSTALL_IMAGES_CMDS
> -	# SCFW firmware is needed when generating imx8-boot-sd.bin which
> -	# is done in post-image script.
> -	cp $(@D)/mx8qx-mek-scfw-tcm.bin $(BINARIES_DIR)/mx8qx-mek-scfw-tcm.bin
> -	cp $(@D)/mx8qx-val-scfw-tcm.bin $(BINARIES_DIR)/mx8qx-val-scfw-tcm.bin
> +# SCFW firmware is needed when generating imx8-boot-sd.bin which
> +# is done in post-image script.
> +
> +# For i.MX8QM support the SCFW needed is mx8qm-mek-scfw-tcm.bin
> +# and mx8qm-val-scfw-tcm.bin
> +# For i.MX8QXP support the SCFW needed is mx8qx-mek-scfw-tcm.bin
> +# and mx8qx-val-scfw-tcm.bin
> +cp $(@D)/*-scfw-tcm.bin $(BINARIES_DIR)/*-scfw-tcm.bin

Code inside commands should be indented with one tab. Also, as pointed
out by Gary, it is preferable to only install what we really need, so I
changed this to:

+# SCFW firmware is needed when generating imx8-boot-sd.bin which is
+# done in post-image script.
+ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X),y)
 define IMX_SC_FIRMWARE_INSTALL_IMAGES_CMDS
-       # SCFW firmware is needed when generating imx8-boot-sd.bin which
-       # is done in post-image script.
        cp $(@D)/mx8qx-mek-scfw-tcm.bin $(BINARIES_DIR)/mx8qx-mek-scfw-tcm.bin
        cp $(@D)/mx8qx-val-scfw-tcm.bin $(BINARIES_DIR)/mx8qx-val-scfw-tcm.bin
 endef
+else ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8),y)
+define IMX_SC_FIRMWARE_INSTALL_IMAGES_CMDS
+       cp $(@D)/mx8qm-*-scfw-tcm.bin $(BINARIES_DIR)/
+endef
+endif

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH 4/7] package/freescale-imx/imx-sc-firmware: add hash file
  2019-09-09 12:15 ` [Buildroot] [PATCH 4/7] package/freescale-imx/imx-sc-firmware: add hash file Maeva Manuel
  2019-11-08 17:34   ` Gary Bisson
@ 2020-02-05 10:38   ` Thomas Petazzoni
  1 sibling, 0 replies; 20+ messages in thread
From: Thomas Petazzoni @ 2020-02-05 10:38 UTC (permalink / raw)
  To: buildroot

On Mon, 9 Sep 2019 12:15:02 +0000
Maeva Manuel <maeva.manuel@nxp.com> wrote:

> Signed-off-by: Maeva Manuel <maeva.manuel@nxp.com>

This was already done as part of the bump to 1.2.1 in commit
b74eaecb2232c4d2b717f867218ad731da836cbc

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH 5/7] package/freescale-imx/firmware-imx:
  2019-09-09 12:15 ` [Buildroot] [PATCH 5/7] package/freescale-imx/firmware-imx: Maeva Manuel
  2019-09-13 15:44   ` André Hentschel
@ 2020-02-05 10:39   ` Thomas Petazzoni
  1 sibling, 0 replies; 20+ messages in thread
From: Thomas Petazzoni @ 2020-02-05 10:39 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon, 9 Sep 2019 12:15:05 +0000
Maeva Manuel <maeva.manuel@nxp.com> wrote:

>   bump to version 8.0 to support i.MX8QM
> 
> Signed-off-by: Maeva Manuel <maeva.manuel@nxp.com>

This package has already been bumped to 8.1.1 in commit
3ec818769d5140f337684d8c35497ca940bffa34, so this patch was no longer
needed.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH 7/7] board/freescale/imx8qxpmek: update instructions
  2019-09-09 12:15 ` [Buildroot] [PATCH 7/7] board/freescale/imx8qxpmek: update instructions Maeva Manuel
@ 2020-02-05 11:12   ` Thomas Petazzoni
  0 siblings, 0 replies; 20+ messages in thread
From: Thomas Petazzoni @ 2020-02-05 11:12 UTC (permalink / raw)
  To: buildroot

On Mon, 9 Sep 2019 12:15:09 +0000
Maeva Manuel <maeva.manuel@nxp.com> wrote:

> 	The ahab-container.img has been replaced by
> 	mx8qx-ahab-container.img because of the i.MX8QM support
> 
> Signed-off-by: Maeva Manuel <maeva.manuel@nxp.com>
> ---
>  board/freescale/imx8qxpmek/readme.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/board/freescale/imx8qxpmek/readme.txt b/board/freescale/imx8qxpmek/readme.txt
> index 45f7915fe4..e10138f8f8 100644
> --- a/board/freescale/imx8qxpmek/readme.txt
> +++ b/board/freescale/imx8qxpmek/readme.txt
> @@ -17,7 +17,8 @@ Build all components:
>    make
>  
>  You will find in output/images/ the following files:
> -  - ahab-container.img
> +
> +  - mx8qx-ahab-container.img

Since I did not take your commit for the firmware-imx update, this
change is not needed. Indeed the bump in
3ec818769d5140f337684d8c35497ca940bffa34 and the following fix in
571b8ca09563ffa97a1d0df2fa076530426ab8da ensure that the name is still
ahab-container.img.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH 6/7] configs/freescale_imx8qmmek: new defconfig
  2019-09-09 12:15 ` [Buildroot] [PATCH 6/7] configs/freescale_imx8qmmek: new defconfig Maeva Manuel
@ 2020-02-05 11:20   ` Thomas Petazzoni
  0 siblings, 0 replies; 20+ messages in thread
From: Thomas Petazzoni @ 2020-02-05 11:20 UTC (permalink / raw)
  To: buildroot

Hello Maeva,

On Mon, 9 Sep 2019 12:15:07 +0000
Maeva Manuel <maeva.manuel@nxp.com> wrote:

> Signed-off-by: Maeva Manuel <maeva.manuel@nxp.com>

> diff --git a/board/freescale/imx8qmmek/readme.txt b/board/freescale/imx8qmmek/readme.txt
> new file mode 100644
> index 0000000000..15eecfa83e
> --- /dev/null
> +++ b/board/freescale/imx8qmmek/readme.txt
> @@ -0,0 +1,66 @@
> +***************************
> +Freescale i.MX8QM MEK board
> +***************************
> +
> +This file documents the Buildroot support for the Freescale i.MX8QM MEK board.
> +
> +Build
> +=====
> +
> +First, configure Buildroot for the i.MX8QM MEK board:
> +
> +  make freescale_imx8qmmek_defconfig
> +
> +Build all components:
> +
> +  make
> +
> +You will find in output/images/ the following files:
> +  - mx8qm-ahab-container.img

The file is now really named ahab-container.img


> diff --git a/configs/freescale_imx8qmmek_defconfig b/configs/freescale_imx8qmmek_defconfig
> new file mode 100644
> index 0000000000..b0c433cf4a
> --- /dev/null
> +++ b/configs/freescale_imx8qmmek_defconfig
> @@ -0,0 +1,40 @@
> +BR2_aarch64=y
> +BR2_ARM_FPU_VFPV4=y
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_14=y
> +#GCC version must be inferior to 8_X because of -Wstringop-truncation message error
> +BR2_GCC_VERSION_7_X=y

Which component fails to build like this? Isn't this fixed by using a
newer 4.14 kernel such as 4.14.98 like other Freescale/NXP defconfigs
in Buildroot ?

For a new defconfig, it is really not good if we can't use the current
default version of gcc.

> +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/freescale/common/imx/imx8-bootloader-prepare.sh board/freescale/common/imx/post-image.sh"
> +BR2_ROOTFS_POST_SCRIPT_ARGS="${UBOOT_DIR}/arch/arm/dts/fsl-imx8qm-mek.dtb"
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_GIT=y
> +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="ssh://git at bitbucket.sw.nxp.com/imx/linux-imx.git"

This is not accessible to the public, you need to use public URLs.

Could you fix these issues and send an updated version ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH 6/7] configs/freescale_imx8qmmek: new defconfig
       [not found] ` <20190909090402.11736-6-maeva.manuel@nxp.com>
@ 2019-09-09 12:55   ` Fabio Estevam
  0 siblings, 0 replies; 20+ messages in thread
From: Fabio Estevam @ 2019-09-09 12:55 UTC (permalink / raw)
  To: buildroot

Hi Maeva,

On Mon, Sep 9, 2019 at 6:03 AM Maeva Manuel <maeva.manuel@nxp.com> wrote:

> +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="ssh://git at bitbucket.sw.nxp.com/imx/linux-imx.git"

Please use an external link such as codeaurora repo.

> +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="rel_imx_4.14.78_1.0.0_ga"

This is a bit old now. What about using imx_4.19.35_1.0.0 instead?

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2020-02-05 11:20 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-09 12:14 [Buildroot] [PATCH 1/7] board/freescale/common/imx: add support for i.MX8QM Maeva Manuel
2019-09-09 12:14 ` [Buildroot] [PATCH 2/7] package/freescale-imx: add option " Maeva Manuel
2019-11-08 17:30   ` Gary Bisson
2020-02-05 10:36     ` Thomas Petazzoni
2020-02-05 10:31   ` Thomas Petazzoni
2019-09-09 12:15 ` [Buildroot] [PATCH 3/7] package/freescale-imx/imx-sc-firmware: bump to version 1.1 to support i.MX8QM Maeva Manuel
2019-11-08 17:33   ` Gary Bisson
2020-02-05 10:38   ` Thomas Petazzoni
2019-09-09 12:15 ` [Buildroot] [PATCH 4/7] package/freescale-imx/imx-sc-firmware: add hash file Maeva Manuel
2019-11-08 17:34   ` Gary Bisson
2020-02-05 10:38   ` Thomas Petazzoni
2019-09-09 12:15 ` [Buildroot] [PATCH 5/7] package/freescale-imx/firmware-imx: Maeva Manuel
2019-09-13 15:44   ` André Hentschel
2020-02-05 10:39   ` Thomas Petazzoni
2019-09-09 12:15 ` [Buildroot] [PATCH 6/7] configs/freescale_imx8qmmek: new defconfig Maeva Manuel
2020-02-05 11:20   ` Thomas Petazzoni
2019-09-09 12:15 ` [Buildroot] [PATCH 7/7] board/freescale/imx8qxpmek: update instructions Maeva Manuel
2020-02-05 11:12   ` Thomas Petazzoni
2020-02-05 10:30 ` [Buildroot] [PATCH 1/7] board/freescale/common/imx: add support for i.MX8QM Thomas Petazzoni
     [not found] <20190909090402.11736-1-maeva.manuel@nxp.com>
     [not found] ` <20190909090402.11736-6-maeva.manuel@nxp.com>
2019-09-09 12:55   ` [Buildroot] [PATCH 6/7] configs/freescale_imx8qmmek: new defconfig Fabio Estevam

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.