All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fuse: Support RENAME_WHITEOUT flag
@ 2020-02-05 13:15 Vivek Goyal
  2020-02-06 12:12 ` Miklos Szeredi
  0 siblings, 1 reply; 2+ messages in thread
From: Vivek Goyal @ 2020-02-05 13:15 UTC (permalink / raw)
  To: Miklos Szeredi, linux-fsdevel; +Cc: Amir Goldstein

Allow fuse to pass RENAME_WHITEOUT to fuse server. Overlayfs on top of
virtiofs uses RENAME_WHITEOUT.

Without this patch renaming a directory in overlayfs (dir is on lower) fails
with -EINVAL. With this patch it works.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
---
 fs/fuse/dir.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: rhvgoyal-linux-fuse/fs/fuse/dir.c
===================================================================
--- rhvgoyal-linux-fuse.orig/fs/fuse/dir.c	2020-01-02 12:52:13.706585709 -0500
+++ rhvgoyal-linux-fuse/fs/fuse/dir.c	2020-02-05 08:03:32.953158410 -0500
@@ -818,7 +818,7 @@ static int fuse_rename2(struct inode *ol
 	struct fuse_conn *fc = get_fuse_conn(olddir);
 	int err;
 
-	if (flags & ~(RENAME_NOREPLACE | RENAME_EXCHANGE))
+	if (flags & ~(RENAME_NOREPLACE | RENAME_EXCHANGE | RENAME_WHITEOUT))
 		return -EINVAL;
 
 	if (flags) {


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fuse: Support RENAME_WHITEOUT flag
  2020-02-05 13:15 [PATCH] fuse: Support RENAME_WHITEOUT flag Vivek Goyal
@ 2020-02-06 12:12 ` Miklos Szeredi
  0 siblings, 0 replies; 2+ messages in thread
From: Miklos Szeredi @ 2020-02-06 12:12 UTC (permalink / raw)
  To: Vivek Goyal; +Cc: linux-fsdevel, Amir Goldstein

On Wed, Feb 5, 2020 at 2:15 PM Vivek Goyal <vgoyal@redhat.com> wrote:
>
> Allow fuse to pass RENAME_WHITEOUT to fuse server. Overlayfs on top of
> virtiofs uses RENAME_WHITEOUT.
>
> Without this patch renaming a directory in overlayfs (dir is on lower) fails
> with -EINVAL. With this patch it works.
>
> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>

Thanks, applied.

Miklos

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-06 12:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-05 13:15 [PATCH] fuse: Support RENAME_WHITEOUT flag Vivek Goyal
2020-02-06 12:12 ` Miklos Szeredi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.