Re: [PATCH for-5.0 3/4] Remove the core bluetooth code

["Daniel P. Berrangé" <berrange@redhat.com>]

On Wed, Feb 05, 2020 at 06:46:24PM +0100, Thomas Huth wrote:
> On 05/02/2020 18.40, Aleksandar Markovic wrote:
> > On Sat, Feb 1, 2020 at 7:53 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> >>
> >> On Sat, Feb 1, 2020 at 7:51 PM Thomas Huth <thuth@redhat.com> wrote:
> >>> On 01/02/2020 17.09, Philippe Mathieu-Daudé wrote:
> [...]
> >>>>> index 6099be1d84..ecce4ada2d 100755
> >>>>> --- a/configure
> >>>>> +++ b/configure
> >>>>> @@ -349,7 +349,6 @@ unset target_list_exclude
> >>>>>  # Distributions want to ensure that several features are compiled in, and it
> >>>>>  # is impossible without a --enable-foo that exits if a feature is not found.
> >>>>>
> >>>>> -bluez=""
> >>>>>  brlapi=""
> >>>>>  curl=""
> >>>>>  curses=""
> >>>>> @@ -1151,10 +1150,6 @@ for opt do
> >>>>>    ;;
> >>>>>    --enable-brlapi) brlapi="yes"
> >>>>>    ;;
> >>>>> -  --disable-bluez) bluez="no"
> >>>>> -  ;;
> >>>>> -  --enable-bluez) bluez="yes"
> >>>>> -  ;;
> >>>>
> >>>> Now than I'm bisecting over this commit, I realize removing this
> >>>> option was not a good idea, we should have done like commit
> >>>> cb6414dfec8 or 315d3184525:
> >>>>
> >>>>   @@ -886,10 +885,6 @@ for opt do
> >>>>   -  --disable-uuid) uuid="no"
> >>>>   -  ;;
> >>>>   -  --enable-uuid) uuid="yes"
> >>>>   -  ;;
> >>>>   ...
> >>>>   +  --enable-uuid|--disable-uuid)
> >>>>   +      echo "$0: $opt is obsolete, UUID support is always built" >&2
> >>>>   +  ;;
> >>>
> >>> Looks trivial ... so if it bugs you, just send a patch?
> >>
> >> I thought about it but this won't fix much, it is too late now.
> >>
> >> I simply wanted to share this bugged me so we try to avoid doing the
> >> same mistake again.
> >>
> > 
> > I vote for addition of a change similar to what Philippe described.
> 
> Feel free to send a patch if it bugs you.

I don't think we should do this (nor the original uuid compat hack
above). We don't want to set an expectation that configure arguments
are considered "stable" interface to QEMU requiring back compat.
This will constrain our future build system work as we move to
introduce meson initially and then gradually elminate more & more
of configure until it can be deleted entirely.

Certainly we should document configure arg removals in the release
notes, but we don't need to go beyond that IMHO.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|