All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	libvir-list@redhat.com,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	qemu-arm <qemu-arm@nongnu.org>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH for-5.0 3/4] Remove the core bluetooth code
Date: Wed, 5 Feb 2020 19:53:52 +0100	[thread overview]
Message-ID: <CAL1e-=ivAZCj990c+47kVdcaOUgU5sDvoWZNWAMHmVJWd9L3Vg@mail.gmail.com> (raw)
In-Reply-To: <CAL1e-=jHpNmTdWSiHZ_StC0MXjLLsyq0cfSE=45=6SwoFnfiaA@mail.gmail.com>

On Wed, Feb 5, 2020 at 7:03 PM Aleksandar Markovic
<aleksandar.m.mail@gmail.com> wrote:
>
> > The deprecation policy is primarily intended for notifying of changes
> > to QEMU's stable interfaces ( CLI, HMP, QMP) which affect behaviour
> > and usage of QEMU at runtime & are liable to break apps managing
> > QEMU.
> >
> > Changes to build time options have no strong reason to be subjected to
> > the deprecation process.
>
> This sounds reasonable to me.
>
> But: Should our deprecation policy be clearer on what is subject to
> our deprecation procedure, and what is not?
>
> Regards,
> Aleksandar
>

And, there is even a section devoted to the build system in
https://qemu.weilnetz.de/doc/qemu-doc.html#Deprecated-features :

    B.10 Build system

    B.10.1 Python 2 support (since 4.1.0)

    In the future, QEMU will require Python 3 to be available at build
time. Support for Python 2 in scripts shipped with QEMU is deprecated.

The wording above comes from the file in our source tree: qemu-deprecated.texi .

Shouldn't the cases like "--enable-blues" be documented here? I think
the deprecation of bluetooth devices support should have included a
short section on involved configure options here.

Why is Python 2 support different to "--enable-blues" support? There
should not be some unknown and arbitrary criterium what do and what
doesn't come in this subsection.

Or, if our build system is not subject to our deprecation policy, than
what is the entire subsection "B.10 Build system" doing here, in
section "Deprecated features"?


> > If we remove an option at build time the effect
> > is noticed immediately and the solution is straightforward (stop passing
> > the option). We have added / removed configure options at will with little
> > negative feedback historically. We'll have far biggest changes coming to
> > the build system in future too, with the introduction of meson.
> >
> > I don't think we want to constrain & complicate our work in modernizing
> > the build system by declaring that any changes to it must go through
> > deprecation.
> >
> > Regards,
> > Daniel
> > --
> > |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> > |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> > |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
> >


  reply	other threads:[~2020-02-05 18:54 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20  9:10 [PATCH for-5.0 0/4] Remove the deprecated bluetooth subsystem Thomas Huth
2019-11-20  9:10 ` [PATCH for-5.0 1/4] hw/arm/nseries: Replace the bluetooth chardev with a "null" chardev Thomas Huth
2019-11-20 10:51   ` Peter Maydell
2019-11-20  9:10 ` [PATCH for-5.0 2/4] hw/usb: Remove the USB bluetooth dongle device Thomas Huth
2019-11-20  9:35   ` [libvirt] " Ján Tomko
2019-11-20  9:10 ` [PATCH for-5.0 3/4] Remove the core bluetooth code Thomas Huth
2019-11-20  9:36   ` [libvirt] " Ján Tomko
2020-02-01 16:09   ` Philippe Mathieu-Daudé
2020-02-01 18:50     ` Thomas Huth
2020-02-01 18:53       ` Philippe Mathieu-Daudé
2020-02-01 18:59         ` Thomas Huth
2020-02-05 15:26         ` Paolo Bonzini
2020-02-05 17:40         ` Aleksandar Markovic
2020-02-05 17:46           ` Thomas Huth
2020-02-05 17:54             ` Daniel P. Berrangé
2020-02-05 17:51           ` Daniel P. Berrangé
2020-02-05 18:03             ` Aleksandar Markovic
2020-02-05 18:53               ` Aleksandar Markovic [this message]
2020-02-06  6:49                 ` Thomas Huth
2020-02-05 19:13             ` Philippe Mathieu-Daudé
2020-02-06  9:56               ` Daniel P. Berrangé
2019-11-20  9:10 ` [PATCH for-5.0 4/4] Remove libbluetooth / bluez from the CI tests Thomas Huth
2019-11-20  9:58 ` [PATCH for-5.0 0/4] Remove the deprecated bluetooth subsystem Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL1e-=ivAZCj990c+47kVdcaOUgU5sDvoWZNWAMHmVJWd9L3Vg@mail.gmail.com' \
    --to=aleksandar.m.mail@gmail.com \
    --cc=berrange@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=kraxel@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.