* [Intel-gfx] [PATCH] drm/i915/gt: Apply Enable Boot Fetch to MBC control register
@ 2020-02-06 17:46 Chris Wilson
2020-02-06 17:49 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Chris Wilson @ 2020-02-06 17:46 UTC (permalink / raw)
To: intel-gfx
Mika spotted that we should be setting BIT(4) of MBCTL prior to
execution.
"The driver must set this bit in the following scenarios:
- To reload the HW boot context every time it gets loaded through the OS.
- After an FLR clears the register (the BIOS won’t run afterwards)."
Make it so.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 61106129287f..04901cd1593a 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -778,6 +778,18 @@ cfl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
}
+static void
+gen7_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
+{
+ wa_write_or(wal, GEN6_MBCTL, GEN6_MBCTL_ENABLE_BOOT_FETCH);
+}
+
+static void
+gen6_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
+{
+ wa_write_or(wal, GEN6_MBCTL, GEN6_MBCTL_ENABLE_BOOT_FETCH);
+}
+
static void
wa_init_mcr(struct drm_i915_private *i915, struct i915_wa_list *wal)
{
@@ -962,7 +974,11 @@ gt_init_workarounds(struct drm_i915_private *i915, struct i915_wa_list *wal)
bxt_gt_workarounds_init(i915, wal);
else if (IS_SKYLAKE(i915))
skl_gt_workarounds_init(i915, wal);
- else if (INTEL_GEN(i915) <= 8)
+ else if (IS_GEN(i915, 7))
+ gen7_gt_workarounds(i915, wal);
+ else if (IS_GEN(i915, 6))
+ gen6_gt_workarounds(i915, wal);
+ else if (INTEL_GEN(i915) < 6)
return;
else
MISSING_CASE(INTEL_GEN(i915));
--
2.25.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread* [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gt: Apply Enable Boot Fetch to MBC control register
2020-02-06 17:46 [Intel-gfx] [PATCH] drm/i915/gt: Apply Enable Boot Fetch to MBC control register Chris Wilson
@ 2020-02-06 17:49 ` Patchwork
2020-02-06 17:53 ` [Intel-gfx] [PATCH] " Chris Wilson
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2020-02-06 17:49 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gt: Apply Enable Boot Fetch to MBC control register
URL : https://patchwork.freedesktop.org/series/73107/
State : failure
== Summary ==
CALL scripts/checksyscalls.sh
CALL scripts/atomic/check-atomics.sh
DESCEND objtool
CHK include/generated/compile.h
CC [M] drivers/gpu/drm/i915/gt/intel_workarounds.o
drivers/gpu/drm/i915/gt/intel_workarounds.c: In function ‘gt_init_workarounds’:
drivers/gpu/drm/i915/gt/intel_workarounds.c:978:3: error: implicit declaration of function ‘gen7_gt_workarounds’; did you mean ‘gt_init_workarounds’? [-Werror=implicit-function-declaration]
gen7_gt_workarounds(i915, wal);
^~~~~~~~~~~~~~~~~~~
gt_init_workarounds
drivers/gpu/drm/i915/gt/intel_workarounds.c:980:3: error: implicit declaration of function ‘gen6_gt_workarounds’; did you mean ‘gt_init_workarounds’? [-Werror=implicit-function-declaration]
gen6_gt_workarounds(i915, wal);
^~~~~~~~~~~~~~~~~~~
gt_init_workarounds
At top level:
drivers/gpu/drm/i915/gt/intel_workarounds.c:788:1: error: ‘gen6_gt_workarounds_init’ defined but not used [-Werror=unused-function]
gen6_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/intel_workarounds.c:782:1: error: ‘gen7_gt_workarounds_init’ defined but not used [-Werror=unused-function]
gen7_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
^~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
scripts/Makefile.build:265: recipe for target 'drivers/gpu/drm/i915/gt/intel_workarounds.o' failed
make[4]: *** [drivers/gpu/drm/i915/gt/intel_workarounds.o] Error 1
scripts/Makefile.build:503: recipe for target 'drivers/gpu/drm/i915' failed
make[3]: *** [drivers/gpu/drm/i915] Error 2
scripts/Makefile.build:503: recipe for target 'drivers/gpu/drm' failed
make[2]: *** [drivers/gpu/drm] Error 2
scripts/Makefile.build:503: recipe for target 'drivers/gpu' failed
make[1]: *** [drivers/gpu] Error 2
Makefile:1693: recipe for target 'drivers' failed
make: *** [drivers] Error 2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread* [Intel-gfx] [PATCH] drm/i915/gt: Apply Enable Boot Fetch to MBC control register
2020-02-06 17:46 [Intel-gfx] [PATCH] drm/i915/gt: Apply Enable Boot Fetch to MBC control register Chris Wilson
2020-02-06 17:49 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
@ 2020-02-06 17:53 ` Chris Wilson
2020-02-06 18:33 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Apply Enable Boot Fetch to MBC control register (rev2) Patchwork
2020-02-09 3:11 ` kbuild test robot
3 siblings, 0 replies; 9+ messages in thread
From: Chris Wilson @ 2020-02-06 17:53 UTC (permalink / raw)
To: intel-gfx
Mika spotted that we should be setting BIT(4) of MBCTL prior to
execution.
"The driver must set this bit in the following scenarios:
- To reload the HW boot context every time it gets loaded through the OS.
- After an FLR clears the register (the BIOS won’t run afterwards)."
Make it so.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 61106129287f..bd3c0f7a9c8a 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -680,6 +680,18 @@ int intel_engine_emit_ctx_wa(struct i915_request *rq)
return 0;
}
+static void
+gen6_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
+{
+ wa_write_or(wal, GEN6_MBCTL, GEN6_MBCTL_ENABLE_BOOT_FETCH);
+}
+
+static void
+gen7_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
+{
+ wa_write_or(wal, GEN6_MBCTL, GEN6_MBCTL_ENABLE_BOOT_FETCH);
+}
+
static void
gen9_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
{
@@ -962,7 +974,11 @@ gt_init_workarounds(struct drm_i915_private *i915, struct i915_wa_list *wal)
bxt_gt_workarounds_init(i915, wal);
else if (IS_SKYLAKE(i915))
skl_gt_workarounds_init(i915, wal);
- else if (INTEL_GEN(i915) <= 8)
+ else if (IS_GEN(i915, 7))
+ gen7_gt_workarounds_init(i915, wal);
+ else if (IS_GEN(i915, 6))
+ gen6_gt_workarounds_init(i915, wal);
+ else if (INTEL_GEN(i915) < 6)
return;
else
MISSING_CASE(INTEL_GEN(i915));
--
2.25.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Apply Enable Boot Fetch to MBC control register (rev2)
2020-02-06 17:46 [Intel-gfx] [PATCH] drm/i915/gt: Apply Enable Boot Fetch to MBC control register Chris Wilson
2020-02-06 17:49 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
2020-02-06 17:53 ` [Intel-gfx] [PATCH] " Chris Wilson
@ 2020-02-06 18:33 ` Patchwork
2020-02-06 18:45 ` Chris Wilson
2020-02-09 3:11 ` kbuild test robot
3 siblings, 1 reply; 9+ messages in thread
From: Patchwork @ 2020-02-06 18:33 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gt: Apply Enable Boot Fetch to MBC control register (rev2)
URL : https://patchwork.freedesktop.org/series/73107/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7876 -> Patchwork_16465
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_16465 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_16465, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16465/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_16465:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_gem:
- fi-snb-2600: NOTRUN -> [DMESG-WARN][1] +5 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16465/fi-snb-2600/igt@i915_selftest@live_gem.html
* igt@i915_selftest@live_gt_pm:
- fi-hsw-4770r: [PASS][2] -> [DMESG-WARN][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-hsw-4770r/igt@i915_selftest@live_gt_pm.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16465/fi-hsw-4770r/igt@i915_selftest@live_gt_pm.html
* igt@i915_selftest@live_reset:
- fi-snb-2520m: NOTRUN -> [DMESG-WARN][4] +22 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16465/fi-snb-2520m/igt@i915_selftest@live_reset.html
- fi-ivb-3770: NOTRUN -> [DMESG-WARN][5] +4 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16465/fi-ivb-3770/igt@i915_selftest@live_reset.html
* igt@i915_selftest@live_uncore:
- fi-byt-n2820: [PASS][6] -> [DMESG-WARN][7] +36 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-byt-n2820/igt@i915_selftest@live_uncore.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16465/fi-byt-n2820/igt@i915_selftest@live_uncore.html
* igt@i915_selftest@live_workarounds:
- fi-ivb-3770: NOTRUN -> [DMESG-FAIL][8]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16465/fi-ivb-3770/igt@i915_selftest@live_workarounds.html
- fi-snb-2600: NOTRUN -> [DMESG-FAIL][9]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16465/fi-snb-2600/igt@i915_selftest@live_workarounds.html
- fi-hsw-4770r: [PASS][10] -> [DMESG-FAIL][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-hsw-4770r/igt@i915_selftest@live_workarounds.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16465/fi-hsw-4770r/igt@i915_selftest@live_workarounds.html
- fi-snb-2520m: NOTRUN -> [DMESG-FAIL][12]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16465/fi-snb-2520m/igt@i915_selftest@live_workarounds.html
- fi-byt-n2820: [PASS][13] -> [DMESG-FAIL][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-byt-n2820/igt@i915_selftest@live_workarounds.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16465/fi-byt-n2820/igt@i915_selftest@live_workarounds.html
Known issues
------------
Here are the changes found in Patchwork_16465 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_close_race@basic-threads:
- fi-byt-j1900: [PASS][15] -> [INCOMPLETE][16] ([i915#45])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-byt-j1900/igt@gem_close_race@basic-threads.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16465/fi-byt-j1900/igt@gem_close_race@basic-threads.html
* igt@i915_selftest@live_blt:
- fi-hsw-4770r: [PASS][17] -> [DMESG-FAIL][18] ([i915#553] / [i915#725])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16465/fi-hsw-4770r/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_hangcheck:
- fi-hsw-4770r: [PASS][19] -> [INCOMPLETE][20] ([i915#857])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-hsw-4770r/igt@i915_selftest@live_hangcheck.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16465/fi-hsw-4770r/igt@i915_selftest@live_hangcheck.html
#### Warnings ####
* igt@gem_exec_parallel@fds:
- fi-byt-n2820: [FAIL][21] ([i915#694]) -> [TIMEOUT][22] ([fdo#112271] / [i915#1084])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-byt-n2820/igt@gem_exec_parallel@fds.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16465/fi-byt-n2820/igt@gem_exec_parallel@fds.html
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1084]: https://gitlab.freedesktop.org/drm/intel/issues/1084
[i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#857]: https://gitlab.freedesktop.org/drm/intel/issues/857
Participating hosts (41 -> 40)
------------------------------
Additional (7): fi-kbl-7560u fi-snb-2520m fi-gdg-551 fi-ivb-3770 fi-blb-e6850 fi-skl-6700k2 fi-snb-2600
Missing (8): fi-bsw-n3050 fi-hsw-peppy fi-byt-squawks fi-hsw-4770 fi-cfl-8109u fi-byt-clapper fi-bdw-samus fi-kbl-r
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7876 -> Patchwork_16465
CI-20190529: 20190529
CI_DRM_7876: 6ac39d9964f464065511d439afcf4da065ff96db @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5421: 40946e61f9c47e23fdf1fff8090fadee8a4d7d3b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16465: 7128af3fb576fe49815de056f790f915bf1d40d0 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
7128af3fb576 drm/i915/gt: Apply Enable Boot Fetch to MBC control register
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16465/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Apply Enable Boot Fetch to MBC control register (rev2)
2020-02-06 18:33 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Apply Enable Boot Fetch to MBC control register (rev2) Patchwork
@ 2020-02-06 18:45 ` Chris Wilson
2020-02-07 9:44 ` Mika Kuoppala
0 siblings, 1 reply; 9+ messages in thread
From: Chris Wilson @ 2020-02-06 18:45 UTC (permalink / raw)
To: Patchwork, intel-gfx; +Cc: intel-gfx
Quoting Patchwork (2020-02-06 18:33:34)
> == Series Details ==
>
> Series: drm/i915/gt: Apply Enable Boot Fetch to MBC control register (rev2)
> URL : https://patchwork.freedesktop.org/series/73107/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_7876 -> Patchwork_16465
> ====================================================
>
> Summary
> -------
>
> **FAILURE**
>
> Serious unknown changes coming with Patchwork_16465 absolutely need to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_16465, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
>
> External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16465/index.html
>
> Possible new issues
> -------------------
>
> Here are the unknown changes that may have been introduced in Patchwork_16465:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
> * igt@i915_selftest@live_gem:
> - fi-snb-2600: NOTRUN -> [DMESG-WARN][1] +5 similar issues
> [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16465/fi-snb-2600/igt@i915_selftest@live_gem.html
Oh well.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Apply Enable Boot Fetch to MBC control register (rev2)
2020-02-06 18:45 ` Chris Wilson
@ 2020-02-07 9:44 ` Mika Kuoppala
2020-02-07 9:49 ` Chris Wilson
0 siblings, 1 reply; 9+ messages in thread
From: Mika Kuoppala @ 2020-02-07 9:44 UTC (permalink / raw)
To: Chris Wilson, Patchwork, intel-gfx; +Cc: intel-gfx
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Quoting Patchwork (2020-02-06 18:33:34)
>> == Series Details ==
>>
>> Series: drm/i915/gt: Apply Enable Boot Fetch to MBC control register (rev2)
>> URL : https://patchwork.freedesktop.org/series/73107/
>> State : failure
>>
>> == Summary ==
>>
>> CI Bug Log - changes from CI_DRM_7876 -> Patchwork_16465
>> ====================================================
>>
>> Summary
>> -------
>>
>> **FAILURE**
>>
>> Serious unknown changes coming with Patchwork_16465 absolutely need to be
>> verified manually.
>>
>> If you think the reported changes have nothing to do with the changes
>> introduced in Patchwork_16465, please notify your bug team to allow them
>> to document this new failure mode, which will reduce false positives in CI.
>>
>> External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16465/index.html
>>
>> Possible new issues
>> -------------------
>>
>> Here are the unknown changes that may have been introduced in Patchwork_16465:
>>
>> ### IGT changes ###
>>
>> #### Possible regressions ####
>>
>> * igt@i915_selftest@live_gem:
>> - fi-snb-2600: NOTRUN -> [DMESG-WARN][1] +5 similar issues
>> [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16465/fi-snb-2600/igt@i915_selftest@live_gem.html
>
> Oh well.
But this is expected as the hw will clear it at some point.
-Mika
> -Chris
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Apply Enable Boot Fetch to MBC control register (rev2)
2020-02-07 9:44 ` Mika Kuoppala
@ 2020-02-07 9:49 ` Chris Wilson
0 siblings, 0 replies; 9+ messages in thread
From: Chris Wilson @ 2020-02-07 9:49 UTC (permalink / raw)
To: Mika Kuoppala, Patchwork, intel-gfx; +Cc: intel-gfx
Quoting Mika Kuoppala (2020-02-07 09:44:00)
> Chris Wilson <chris@chris-wilson.co.uk> writes:
>
> > Quoting Patchwork (2020-02-06 18:33:34)
> >> == Series Details ==
> >>
> >> Series: drm/i915/gt: Apply Enable Boot Fetch to MBC control register (rev2)
> >> URL : https://patchwork.freedesktop.org/series/73107/
> >> State : failure
> >>
> >> == Summary ==
> >>
> >> CI Bug Log - changes from CI_DRM_7876 -> Patchwork_16465
> >> ====================================================
> >>
> >> Summary
> >> -------
> >>
> >> **FAILURE**
> >>
> >> Serious unknown changes coming with Patchwork_16465 absolutely need to be
> >> verified manually.
> >>
> >> If you think the reported changes have nothing to do with the changes
> >> introduced in Patchwork_16465, please notify your bug team to allow them
> >> to document this new failure mode, which will reduce false positives in CI.
> >>
> >> External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16465/index.html
> >>
> >> Possible new issues
> >> -------------------
> >>
> >> Here are the unknown changes that may have been introduced in Patchwork_16465:
> >>
> >> ### IGT changes ###
> >>
> >> #### Possible regressions ####
> >>
> >> * igt@i915_selftest@live_gem:
> >> - fi-snb-2600: NOTRUN -> [DMESG-WARN][1] +5 similar issues
> >> [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16465/fi-snb-2600/igt@i915_selftest@live_gem.html
> >
> > Oh well.
>
> But this is expected as the hw will clear it at some point.
What we are reporting is that the bit does not stick after writing it.
We apply the w/a, on module load, resume and after reset; the times that
were mentioned in the excerpt as being when the HW sets it to set. It
was not mentioned that the HW would clear the bit at any other time, at
least in the doc I found (it definitely wasn't mentioned as being a
temporary bit that is cleared by HW when it completed whatever task it
performed).
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Apply Enable Boot Fetch to MBC control register
2020-02-06 17:46 [Intel-gfx] [PATCH] drm/i915/gt: Apply Enable Boot Fetch to MBC control register Chris Wilson
@ 2020-02-09 3:11 ` kbuild test robot
2020-02-06 17:53 ` [Intel-gfx] [PATCH] " Chris Wilson
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: kbuild test robot @ 2020-02-09 3:11 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx, kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3347 bytes --]
Hi Chris,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip v5.5 next-20200207]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-gt-Apply-Enable-Boot-Fetch-to-MBC-control-register/20200209-081806
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/i915/gt/intel_workarounds.c: In function 'gt_init_workarounds':
>> drivers/gpu/drm/i915/gt/intel_workarounds.c:973:3: error: implicit declaration of function 'gen7_gt_workarounds'; did you mean 'gt_init_workarounds'? [-Werror=implicit-function-declaration]
gen7_gt_workarounds(i915, wal);
^~~~~~~~~~~~~~~~~~~
gt_init_workarounds
>> drivers/gpu/drm/i915/gt/intel_workarounds.c:975:3: error: implicit declaration of function 'gen6_gt_workarounds'; did you mean 'gt_init_workarounds'? [-Werror=implicit-function-declaration]
gen6_gt_workarounds(i915, wal);
^~~~~~~~~~~~~~~~~~~
gt_init_workarounds
At top level:
drivers/gpu/drm/i915/gt/intel_workarounds.c:783:1: warning: 'gen6_gt_workarounds_init' defined but not used [-Wunused-function]
gen6_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/intel_workarounds.c:777:1: warning: 'gen7_gt_workarounds_init' defined but not used [-Wunused-function]
gen7_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
^~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +973 drivers/gpu/drm/i915/gt/intel_workarounds.c
952
953 static void
954 gt_init_workarounds(struct drm_i915_private *i915, struct i915_wa_list *wal)
955 {
956 if (IS_GEN(i915, 12))
957 tgl_gt_workarounds_init(i915, wal);
958 else if (IS_GEN(i915, 11))
959 icl_gt_workarounds_init(i915, wal);
960 else if (IS_CANNONLAKE(i915))
961 cnl_gt_workarounds_init(i915, wal);
962 else if (IS_COFFEELAKE(i915))
963 cfl_gt_workarounds_init(i915, wal);
964 else if (IS_GEMINILAKE(i915))
965 glk_gt_workarounds_init(i915, wal);
966 else if (IS_KABYLAKE(i915))
967 kbl_gt_workarounds_init(i915, wal);
968 else if (IS_BROXTON(i915))
969 bxt_gt_workarounds_init(i915, wal);
970 else if (IS_SKYLAKE(i915))
971 skl_gt_workarounds_init(i915, wal);
972 else if (IS_GEN(i915, 7))
> 973 gen7_gt_workarounds(i915, wal);
974 else if (IS_GEN(i915, 6))
> 975 gen6_gt_workarounds(i915, wal);
976 else if (INTEL_GEN(i915) < 6)
977 return;
978 else
979 MISSING_CASE(INTEL_GEN(i915));
980 }
981
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 71196 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915/gt: Apply Enable Boot Fetch to MBC control register
@ 2020-02-09 3:11 ` kbuild test robot
0 siblings, 0 replies; 9+ messages in thread
From: kbuild test robot @ 2020-02-09 3:11 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3424 bytes --]
Hi Chris,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip v5.5 next-20200207]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-gt-Apply-Enable-Boot-Fetch-to-MBC-control-register/20200209-081806
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/i915/gt/intel_workarounds.c: In function 'gt_init_workarounds':
>> drivers/gpu/drm/i915/gt/intel_workarounds.c:973:3: error: implicit declaration of function 'gen7_gt_workarounds'; did you mean 'gt_init_workarounds'? [-Werror=implicit-function-declaration]
gen7_gt_workarounds(i915, wal);
^~~~~~~~~~~~~~~~~~~
gt_init_workarounds
>> drivers/gpu/drm/i915/gt/intel_workarounds.c:975:3: error: implicit declaration of function 'gen6_gt_workarounds'; did you mean 'gt_init_workarounds'? [-Werror=implicit-function-declaration]
gen6_gt_workarounds(i915, wal);
^~~~~~~~~~~~~~~~~~~
gt_init_workarounds
At top level:
drivers/gpu/drm/i915/gt/intel_workarounds.c:783:1: warning: 'gen6_gt_workarounds_init' defined but not used [-Wunused-function]
gen6_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/intel_workarounds.c:777:1: warning: 'gen7_gt_workarounds_init' defined but not used [-Wunused-function]
gen7_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
^~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +973 drivers/gpu/drm/i915/gt/intel_workarounds.c
952
953 static void
954 gt_init_workarounds(struct drm_i915_private *i915, struct i915_wa_list *wal)
955 {
956 if (IS_GEN(i915, 12))
957 tgl_gt_workarounds_init(i915, wal);
958 else if (IS_GEN(i915, 11))
959 icl_gt_workarounds_init(i915, wal);
960 else if (IS_CANNONLAKE(i915))
961 cnl_gt_workarounds_init(i915, wal);
962 else if (IS_COFFEELAKE(i915))
963 cfl_gt_workarounds_init(i915, wal);
964 else if (IS_GEMINILAKE(i915))
965 glk_gt_workarounds_init(i915, wal);
966 else if (IS_KABYLAKE(i915))
967 kbl_gt_workarounds_init(i915, wal);
968 else if (IS_BROXTON(i915))
969 bxt_gt_workarounds_init(i915, wal);
970 else if (IS_SKYLAKE(i915))
971 skl_gt_workarounds_init(i915, wal);
972 else if (IS_GEN(i915, 7))
> 973 gen7_gt_workarounds(i915, wal);
974 else if (IS_GEN(i915, 6))
> 975 gen6_gt_workarounds(i915, wal);
976 else if (INTEL_GEN(i915) < 6)
977 return;
978 else
979 MISSING_CASE(INTEL_GEN(i915));
980 }
981
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 71196 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-02-09 3:12 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-06 17:46 [Intel-gfx] [PATCH] drm/i915/gt: Apply Enable Boot Fetch to MBC control register Chris Wilson
2020-02-06 17:49 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
2020-02-06 17:53 ` [Intel-gfx] [PATCH] " Chris Wilson
2020-02-06 18:33 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Apply Enable Boot Fetch to MBC control register (rev2) Patchwork
2020-02-06 18:45 ` Chris Wilson
2020-02-07 9:44 ` Mika Kuoppala
2020-02-07 9:49 ` Chris Wilson
2020-02-09 3:11 ` [Intel-gfx] [PATCH] drm/i915/gt: Apply Enable Boot Fetch to MBC control register kbuild test robot
2020-02-09 3:11 ` kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.