From: Rob Herring <robh@kernel.org> To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> Cc: Vinod Koul <vkoul@kernel.org>, Dan Williams <dan.j.williams@intel.com>, Masahiro Yamada <yamada.masahiro@socionext.com>, Mark Rutland <mark.rutland@arm.com>, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Masami Hiramatsu <masami.hiramatsu@linaro.org>, Jassi Brar <jaswinder.singh@linaro.org> Subject: Re: [PATCH v2 1/2] dt-bindings: dmaengine: Add UniPhier external DMA controller bindings Date: Thu, 6 Feb 2020 17:54:58 +0000 [thread overview] Message-ID: <20200206175458.GA12845@bogus> (raw) In-Reply-To: <1580362048-28455-2-git-send-email-hayashi.kunihiko@socionext.com> On Thu, Jan 30, 2020 at 02:27:27PM +0900, Kunihiko Hayashi wrote: > Add devicetree binding documentation for external DMA controller > implemented on Socionext UniPhier SoCs. > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > --- > .../bindings/dma/socionext,uniphier-xdmac.yaml | 57 ++++++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml > > diff --git a/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml b/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml > new file mode 100644 > index 00000000..32abf18 > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license new bindings: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/dma/socionext,uniphier-xdmac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Socionext UniPhier external DMA controller > + > +description: | > + This describes the devicetree bindings for an external DMA engine to perform > + memory-to-memory or peripheral-to-memory data transfer capable of supporting > + 16 channels, implemented in Socionext UniPhier SoCs. > + > +maintainers: > + - Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > + > +allOf: > + - $ref: "dma-controller.yaml#" > + > +properties: > + compatible: > + items: > + - const: socionext,uniphier-xdmac You can drop 'items' for a single item. > + > + reg: > + minItems: 1 > + maxItems: 2 You need to say what each entry is: items: - description: ... - description: ... > + > + interrupts: > + maxItems: 1 > + > + "#dma-cells": > + const: 2 > + description: | > + DMA request from clients consists of 2 cells: > + 1. Channel index > + 2. Transfer request factor number, If no transfer factor, use 0. > + The number is SoC-specific, and this should be specified with > + relation to the device to use the DMA controller. > + > +required: > + - compatible > + - reg > + - interrupts > + - "#dma-cells" Add: additionalProperties: false > + > +examples: > + - | > + xdmac: dma-controller@5fc10000 { > + compatible = "socionext,uniphier-xdmac"; > + reg = <0x5fc10000 0x1000>, <0x5fc20000 0x800>; > + interrupts = <0 188 4>; > + #dma-cells = <2>; > + dma-channels = <16>; Not documented. You need at least 'dma-channels: true' to indicate you're using this. But you should be able to have some constraints such as 'maximum: 16'. Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Masami Hiramatsu <masami.hiramatsu@linaro.org>, Jassi Brar <jaswinder.singh@linaro.org>, linux-kernel@vger.kernel.org, Masahiro Yamada <yamada.masahiro@socionext.com>, Vinod Koul <vkoul@kernel.org>, dmaengine@vger.kernel.org, Dan Williams <dan.j.williams@intel.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/2] dt-bindings: dmaengine: Add UniPhier external DMA controller bindings Date: Thu, 6 Feb 2020 17:54:58 +0000 [thread overview] Message-ID: <20200206175458.GA12845@bogus> (raw) In-Reply-To: <1580362048-28455-2-git-send-email-hayashi.kunihiko@socionext.com> On Thu, Jan 30, 2020 at 02:27:27PM +0900, Kunihiko Hayashi wrote: > Add devicetree binding documentation for external DMA controller > implemented on Socionext UniPhier SoCs. > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > --- > .../bindings/dma/socionext,uniphier-xdmac.yaml | 57 ++++++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml > > diff --git a/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml b/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml > new file mode 100644 > index 00000000..32abf18 > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license new bindings: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/dma/socionext,uniphier-xdmac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Socionext UniPhier external DMA controller > + > +description: | > + This describes the devicetree bindings for an external DMA engine to perform > + memory-to-memory or peripheral-to-memory data transfer capable of supporting > + 16 channels, implemented in Socionext UniPhier SoCs. > + > +maintainers: > + - Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > + > +allOf: > + - $ref: "dma-controller.yaml#" > + > +properties: > + compatible: > + items: > + - const: socionext,uniphier-xdmac You can drop 'items' for a single item. > + > + reg: > + minItems: 1 > + maxItems: 2 You need to say what each entry is: items: - description: ... - description: ... > + > + interrupts: > + maxItems: 1 > + > + "#dma-cells": > + const: 2 > + description: | > + DMA request from clients consists of 2 cells: > + 1. Channel index > + 2. Transfer request factor number, If no transfer factor, use 0. > + The number is SoC-specific, and this should be specified with > + relation to the device to use the DMA controller. > + > +required: > + - compatible > + - reg > + - interrupts > + - "#dma-cells" Add: additionalProperties: false > + > +examples: > + - | > + xdmac: dma-controller@5fc10000 { > + compatible = "socionext,uniphier-xdmac"; > + reg = <0x5fc10000 0x1000>, <0x5fc20000 0x800>; > + interrupts = <0 188 4>; > + #dma-cells = <2>; > + dma-channels = <16>; Not documented. You need at least 'dma-channels: true' to indicate you're using this. But you should be able to have some constraints such as 'maximum: 16'. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-06 20:47 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-30 5:27 [PATCH v2 0/2] dmaengine: Add UniPhier XDMAC driver Kunihiko Hayashi 2020-01-30 5:27 ` Kunihiko Hayashi 2020-01-30 5:27 ` [PATCH v2 1/2] dt-bindings: dmaengine: Add UniPhier external DMA controller bindings Kunihiko Hayashi 2020-01-30 5:27 ` Kunihiko Hayashi 2020-02-06 17:54 ` Rob Herring [this message] 2020-02-06 17:54 ` Rob Herring 2020-02-07 1:15 ` Kunihiko Hayashi 2020-02-07 1:15 ` Kunihiko Hayashi 2020-01-30 5:27 ` [PATCH v2 2/2] dmaengine: uniphier-xdmac: Add UniPhier external DMA controller driver Kunihiko Hayashi 2020-01-30 5:27 ` Kunihiko Hayashi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200206175458.GA12845@bogus \ --to=robh@kernel.org \ --cc=dan.j.williams@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=hayashi.kunihiko@socionext.com \ --cc=jaswinder.singh@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=masami.hiramatsu@linaro.org \ --cc=vkoul@kernel.org \ --cc=yamada.masahiro@socionext.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.