All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] docs/arm-cpu-features: Make kvm-no-adjvtime comment clearer
@ 2020-02-06 22:51 Philippe Mathieu-Daudé
  2020-02-07  8:26 ` Andrew Jones
  0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-02-06 22:51 UTC (permalink / raw)
  To: qemu-devel, Andrew Jones
  Cc: qemu-trivial, Peter Maydell, qemu-arm, Philippe Mathieu-Daudé

The bold text sounds like 'knock knock'. Only bolding the
second 'not' makes it easier to read.

Fixes: dea101a1ae
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
v2: Removed unrelated hunk
---
 docs/arm-cpu-features.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/arm-cpu-features.rst b/docs/arm-cpu-features.rst
index dbf3b7cf42..fc1623aeca 100644
--- a/docs/arm-cpu-features.rst
+++ b/docs/arm-cpu-features.rst
@@ -185,7 +185,7 @@ the list of KVM VCPU features and their descriptions.
 
   kvm-no-adjvtime          By default kvm-no-adjvtime is disabled.  This
                            means that by default the virtual time
-                           adjustment is enabled (vtime is *not not*
+                           adjustment is enabled (vtime is not *not*
                            adjusted).
 
                            When virtual time adjustment is enabled each
-- 
2.21.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] docs/arm-cpu-features: Make kvm-no-adjvtime comment clearer
  2020-02-06 22:51 [PATCH v2] docs/arm-cpu-features: Make kvm-no-adjvtime comment clearer Philippe Mathieu-Daudé
@ 2020-02-07  8:26 ` Andrew Jones
  2020-02-07 13:36   ` Peter Maydell
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Jones @ 2020-02-07  8:26 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: qemu-trivial, Peter Maydell, qemu-arm, qemu-devel

On Thu, Feb 06, 2020 at 11:51:48PM +0100, Philippe Mathieu-Daudé wrote:
> The bold text sounds like 'knock knock'. Only bolding the

Who's there?

> second 'not' makes it easier to read.
> 
> Fixes: dea101a1ae
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: Removed unrelated hunk
> ---
>  docs/arm-cpu-features.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/arm-cpu-features.rst b/docs/arm-cpu-features.rst
> index dbf3b7cf42..fc1623aeca 100644
> --- a/docs/arm-cpu-features.rst
> +++ b/docs/arm-cpu-features.rst
> @@ -185,7 +185,7 @@ the list of KVM VCPU features and their descriptions.
>  
>    kvm-no-adjvtime          By default kvm-no-adjvtime is disabled.  This
>                             means that by default the virtual time
> -                           adjustment is enabled (vtime is *not not*
> +                           adjustment is enabled (vtime is not *not*
>                             adjusted).
>  
>                             When virtual time adjustment is enabled each
> -- 
> 2.21.1
> 
>

Not-Not-Reviewed-by: Andrew Jones <drjones@redhat.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] docs/arm-cpu-features: Make kvm-no-adjvtime comment clearer
  2020-02-07  8:26 ` Andrew Jones
@ 2020-02-07 13:36   ` Peter Maydell
  0 siblings, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2020-02-07 13:36 UTC (permalink / raw)
  To: Andrew Jones
  Cc: QEMU Trivial, qemu-arm, Philippe Mathieu-Daudé, QEMU Developers

On Fri, 7 Feb 2020 at 08:26, Andrew Jones <drjones@redhat.com> wrote:
>
> On Thu, Feb 06, 2020 at 11:51:48PM +0100, Philippe Mathieu-Daudé wrote:
> > The bold text sounds like 'knock knock'. Only bolding the
>
> Who's there?
>
> > second 'not' makes it easier to read.
> >
> > Fixes: dea101a1ae
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > ---
> > v2: Removed unrelated hunk
> > ---
> >  docs/arm-cpu-features.rst | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/docs/arm-cpu-features.rst b/docs/arm-cpu-features.rst
> > index dbf3b7cf42..fc1623aeca 100644
> > --- a/docs/arm-cpu-features.rst
> > +++ b/docs/arm-cpu-features.rst
> > @@ -185,7 +185,7 @@ the list of KVM VCPU features and their descriptions.
> >
> >    kvm-no-adjvtime          By default kvm-no-adjvtime is disabled.  This
> >                             means that by default the virtual time
> > -                           adjustment is enabled (vtime is *not not*
> > +                           adjustment is enabled (vtime is not *not*
> >                             adjusted).
> >
> >                             When virtual time adjustment is enabled each
> > --
> > 2.21.1
> >

Applied to target-arm.next.

> Not-Not-Reviewed-by: Andrew Jones <drjones@redhat.com>

:-)  but for the purpose of the commit message I've dropped
the 'Not-Not-' prefix, since we want to have a standard set
of tags in commit message rather than a random accumulation.
(We really should make checkpatch warn about nonstandard tags.)

thanks
-- PMM


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-02-07 13:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-06 22:51 [PATCH v2] docs/arm-cpu-features: Make kvm-no-adjvtime comment clearer Philippe Mathieu-Daudé
2020-02-07  8:26 ` Andrew Jones
2020-02-07 13:36   ` Peter Maydell

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.