[PATCH v2] net: dsa: microchip: enable module autoprobe

[PATCH v2] net: dsa: microchip: enable module autoprobe

[Codrin Ciubotariu]

From: Razvan Stefanescu <razvan.stefanescu@microchip.com>

This matches /sys/devices/.../spi1.0/modalias content.

Signed-off-by: Razvan Stefanescu <razvan.stefanescu@microchip.com>
Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
---

Changes in v2:
 - added alias for all the variants of this driver

 drivers/net/dsa/microchip/ksz9477_spi.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/dsa/microchip/ksz9477_spi.c b/drivers/net/dsa/microchip/ksz9477_spi.c
index c5f64959a184..1142768969c2 100644
--- a/drivers/net/dsa/microchip/ksz9477_spi.c
+++ b/drivers/net/dsa/microchip/ksz9477_spi.c
@@ -101,6 +101,12 @@ static struct spi_driver ksz9477_spi_driver = {
 
 module_spi_driver(ksz9477_spi_driver);
 
+MODULE_ALIAS("spi:ksz9477");
+MODULE_ALIAS("spi:ksz9897");
+MODULE_ALIAS("spi:ksz9893");
+MODULE_ALIAS("spi:ksz9563");
+MODULE_ALIAS("spi:ksz8563");
+MODULE_ALIAS("spi:ksz9567");
 MODULE_AUTHOR("Woojung Huh <Woojung.Huh@microchip.com>");
 MODULE_DESCRIPTION("Microchip KSZ9477 Series Switch SPI access Driver");
 MODULE_LICENSE("GPL");
-- 
2.20.1

Re: [PATCH v2] net: dsa: microchip: enable module autoprobe

[Andrew Lunn]

On Fri, Feb 07, 2020 at 12:46:43PM +0200, Codrin Ciubotariu wrote:
> From: Razvan Stefanescu <razvan.stefanescu@microchip.com>
> 
> This matches /sys/devices/.../spi1.0/modalias content.
> 
> Signed-off-by: Razvan Stefanescu <razvan.stefanescu@microchip.com>
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> ---
> 
> Changes in v2:
>  - added alias for all the variants of this driver
> 
>  drivers/net/dsa/microchip/ksz9477_spi.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/net/dsa/microchip/ksz9477_spi.c b/drivers/net/dsa/microchip/ksz9477_spi.c
> index c5f64959a184..1142768969c2 100644
> --- a/drivers/net/dsa/microchip/ksz9477_spi.c
> +++ b/drivers/net/dsa/microchip/ksz9477_spi.c
> @@ -101,6 +101,12 @@ static struct spi_driver ksz9477_spi_driver = {
>  
>  module_spi_driver(ksz9477_spi_driver);
>  
> +MODULE_ALIAS("spi:ksz9477");
> +MODULE_ALIAS("spi:ksz9897");
> +MODULE_ALIAS("spi:ksz9893");
> +MODULE_ALIAS("spi:ksz9563");
> +MODULE_ALIAS("spi:ksz8563");
> +MODULE_ALIAS("spi:ksz9567");
>  MODULE_AUTHOR("Woojung Huh <Woojung.Huh@microchip.com>");
>  MODULE_DESCRIPTION("Microchip KSZ9477 Series Switch SPI access Driver");
>  MODULE_LICENSE("GPL");

Hi Codrin

You might want to consider adding a Fixes tag?

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH v2] net: dsa: microchip: enable module autoprobe

[Codrin.Ciubotariu]

On 07.02.2020 15:32, Andrew Lunn wrote:
> On Fri, Feb 07, 2020 at 12:46:43PM +0200, Codrin Ciubotariu wrote:
>> From: Razvan Stefanescu <razvan.stefanescu@microchip.com>
>>
>> This matches /sys/devices/.../spi1.0/modalias content.
>>
>> Signed-off-by: Razvan Stefanescu <razvan.stefanescu@microchip.com>
>> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
>> ---
>>
>> Changes in v2:
>>   - added alias for all the variants of this driver
>>
>>   drivers/net/dsa/microchip/ksz9477_spi.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/net/dsa/microchip/ksz9477_spi.c b/drivers/net/dsa/microchip/ksz9477_spi.c
>> index c5f64959a184..1142768969c2 100644
>> --- a/drivers/net/dsa/microchip/ksz9477_spi.c
>> +++ b/drivers/net/dsa/microchip/ksz9477_spi.c
>> @@ -101,6 +101,12 @@ static struct spi_driver ksz9477_spi_driver = {
>>
>>   module_spi_driver(ksz9477_spi_driver);
>>
>> +MODULE_ALIAS("spi:ksz9477");
>> +MODULE_ALIAS("spi:ksz9897");
>> +MODULE_ALIAS("spi:ksz9893");
>> +MODULE_ALIAS("spi:ksz9563");
>> +MODULE_ALIAS("spi:ksz8563");
>> +MODULE_ALIAS("spi:ksz9567");
>>   MODULE_AUTHOR("Woojung Huh <Woojung.Huh@microchip.com>");
>>   MODULE_DESCRIPTION("Microchip KSZ9477 Series Switch SPI access Driver");
>>   MODULE_LICENSE("GPL");
> 
> Hi Codrin
> 
> You might want to consider adding a Fixes tag?

Hi Andrew,

I thought about it, but I wasn't sure this patch is a fix.  And now that 
it includes aliases for all the variants, it might be tricky to add a 
Fixes tag since not all the variants were added at the same time. But I 
can split it into multiple patches, each with its Fixes, if you want me to.

> 
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> 
>      Andrew
> 

Thanks and best regards,
Codrin

Re: [PATCH v2] net: dsa: microchip: enable module autoprobe

[David Miller]

From: <Codrin.Ciubotariu@microchip.com>
Date: Fri, 7 Feb 2020 14:21:32 +0000

> I thought about it, but I wasn't sure this patch is a fix.  And now that 
> it includes aliases for all the variants, it might be tricky to add a 
> Fixes tag since not all the variants were added at the same time. But I 
> can split it into multiple patches, each with its Fixes, if you want me to.

You can put multiple Fixes: tags into a single patch and that would work
for this situation.

Please do that.

Thank you.