From: Gerd Hoffmann <kraxel@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: airlied@linux.ie, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, virtualization@lists.linux-foundation.org,
noralf@tronnes.org, dri-devel@lists.freedesktop.org,
daniel@ffwll.ch, alexander.deucher@amd.com,
spice-devel@lists.freedesktop.org, sam@ravnborg.org,
emil.velikov@collabora.com
Subject: Re: [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}()
Date: Fri, 7 Feb 2020 13:31:43 +0100 [thread overview]
Message-ID: <20200207123143.y3m3moillue6udo6@sirius.home.kraxel.org> (raw)
In-Reply-To: <cd78b79f-ff4e-9c8e-4d87-ce717a717559@suse.de>
> > How about using
> >
> > #define drm_simple_encoder_init(dev, type, name, ...) \
> > drm_encoder_init(dev, drm_simple_encoder_funcs_cleanup, type, name, __VA_ARGS__)
> >
> > instead ?
> I guess you want to save a few lines in the implementation of
> drm_simple_encoder_init() (?) If so, I'd rather try to share more
> internal code among the various init and create functions.
Yes. You have the namestr stuff duplicated in all functions, and with
a #define that goes away.
But maybe that can be simply be dropped? The drivers with a simple
encoder seem to not care much about the name and just pass NULL ...
cheers,
Gerd
WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: airlied@linux.ie, virtualization@lists.linux-foundation.org,
dri-devel@lists.freedesktop.org, alexander.deucher@amd.com,
spice-devel@lists.freedesktop.org, sam@ravnborg.org,
emil.velikov@collabora.com
Subject: Re: [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}()
Date: Fri, 7 Feb 2020 13:31:43 +0100 [thread overview]
Message-ID: <20200207123143.y3m3moillue6udo6@sirius.home.kraxel.org> (raw)
In-Reply-To: <cd78b79f-ff4e-9c8e-4d87-ce717a717559@suse.de>
> > How about using
> >
> > #define drm_simple_encoder_init(dev, type, name, ...) \
> > drm_encoder_init(dev, drm_simple_encoder_funcs_cleanup, type, name, __VA_ARGS__)
> >
> > instead ?
> I guess you want to save a few lines in the implementation of
> drm_simple_encoder_init() (?) If so, I'd rather try to share more
> internal code among the various init and create functions.
Yes. You have the namestr stuff duplicated in all functions, and with
a #define that goes away.
But maybe that can be simply be dropped? The drivers with a simple
encoder seem to not care much about the name and just pass NULL ...
cheers,
Gerd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-07 12:31 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 8:41 [PATCH 0/6] drm: Provide a simple encoder Thomas Zimmermann
2020-02-07 8:41 ` Thomas Zimmermann
2020-02-07 8:41 ` [PATCH 1/6] drm: Move initialization of encoder into an internal function Thomas Zimmermann
2020-02-07 8:41 ` Thomas Zimmermann
2020-02-07 8:41 ` [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}() Thomas Zimmermann
2020-02-07 8:41 ` Thomas Zimmermann
2020-02-07 10:33 ` Gerd Hoffmann
2020-02-07 10:33 ` Gerd Hoffmann
2020-02-07 10:50 ` Thomas Zimmermann
2020-02-07 10:50 ` Thomas Zimmermann
2020-02-07 12:31 ` Gerd Hoffmann [this message]
2020-02-07 12:31 ` Gerd Hoffmann
2020-02-07 13:37 ` Daniel Vetter
2020-02-07 13:37 ` Daniel Vetter
2020-02-07 14:00 ` Ville Syrjälä
2020-02-07 14:00 ` Ville Syrjälä
2020-02-07 14:02 ` Thomas Zimmermann
2020-02-07 14:02 ` Thomas Zimmermann
2020-02-07 16:26 ` Daniel Vetter
2020-02-07 16:26 ` Daniel Vetter
2020-02-07 14:36 ` Noralf Trønnes
2020-02-07 14:36 ` Noralf Trønnes
2020-02-07 16:25 ` Daniel Vetter
2020-02-07 16:25 ` Daniel Vetter
2020-02-10 10:28 ` kbuild test robot
2020-02-10 10:28 ` [PATCH 2/6] drm: Add drm_simple_encoder_{init, create}() kbuild test robot
2020-02-10 10:28 ` [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}() kbuild test robot
2020-02-07 8:41 ` [PATCH 3/6] drm/ast: Use simple encoder Thomas Zimmermann
2020-02-07 8:41 ` Thomas Zimmermann
2020-02-07 8:41 ` [PATCH 4/6] drm/mgag200: " Thomas Zimmermann
2020-02-07 8:41 ` Thomas Zimmermann
2020-02-07 8:41 ` [PATCH 5/6] drm/qxl: " Thomas Zimmermann
2020-02-07 8:41 ` Thomas Zimmermann
2020-02-10 9:08 ` kbuild test robot
2020-02-10 9:08 ` kbuild test robot
2020-02-10 9:08 ` kbuild test robot
2020-02-07 8:41 ` [PATCH 6/6] drm/simple-pipe: " Thomas Zimmermann
2020-02-07 8:41 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207123143.y3m3moillue6udo6@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.velikov@collabora.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=noralf@tronnes.org \
--cc=sam@ravnborg.org \
--cc=spice-devel@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.