From: Ville Syrjala <ville.syrjala@linux.intel.com> To: dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, Thomas Zimmermann <tzimmermann@suse.de> Subject: [PATCH v2 1/6] drm: Include the encoder itself in possible_clones Date: Fri, 7 Feb 2020 15:59:45 +0200 [thread overview] Message-ID: <20200207135950.6655-2-ville.syrjala@linux.intel.com> (raw) In-Reply-To: <20200207135950.6655-1-ville.syrjala@linux.intel.com> From: Ville Syrjälä <ville.syrjala@linux.intel.com> The docs say possible_clones should always include the encoder itself. Since most drivers don't want to deal with the complexities of cloning let's allow them to set possible_clones=0 and instead we'll fix that up in the core. We can't put this special case into drm_encoder_init() because drivers will have to fill up possible_clones after adding all the relevant encoders. Otherwise they wouldn't know the proper encoder indexes to use. So we'll just do it just before registering the encoders. TODO: Should we do something similar for possible_crtcs==0? Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Daniel Vetter <daniel@ffwll.ch> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> --- drivers/gpu/drm/drm_encoder.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/drm_encoder.c b/drivers/gpu/drm/drm_encoder.c index e555281f43d4..f761d9306028 100644 --- a/drivers/gpu/drm/drm_encoder.c +++ b/drivers/gpu/drm/drm_encoder.c @@ -66,11 +66,26 @@ static const struct drm_prop_enum_list drm_encoder_enum_list[] = { { DRM_MODE_ENCODER_DPI, "DPI" }, }; +/* + * For some reason we want the encoder itself included in + * possible_clones. Make life easy for drivers by allowing them + * to leave possible_clones unset if no cloning is possible. + */ +static void fixup_possible_clones(struct drm_device *dev) +{ + struct drm_encoder *encoder; + + drm_for_each_encoder(encoder, dev) + encoder->possible_clones |= drm_encoder_mask(encoder); +} + int drm_encoder_register_all(struct drm_device *dev) { struct drm_encoder *encoder; int ret = 0; + fixup_possible_clones(dev); + drm_for_each_encoder(encoder, dev) { if (encoder->funcs->late_register) ret = encoder->funcs->late_register(encoder); -- 2.24.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Ville Syrjala <ville.syrjala@linux.intel.com> To: dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, Thomas Zimmermann <tzimmermann@suse.de> Subject: [Intel-gfx] [PATCH v2 1/6] drm: Include the encoder itself in possible_clones Date: Fri, 7 Feb 2020 15:59:45 +0200 [thread overview] Message-ID: <20200207135950.6655-2-ville.syrjala@linux.intel.com> (raw) In-Reply-To: <20200207135950.6655-1-ville.syrjala@linux.intel.com> From: Ville Syrjälä <ville.syrjala@linux.intel.com> The docs say possible_clones should always include the encoder itself. Since most drivers don't want to deal with the complexities of cloning let's allow them to set possible_clones=0 and instead we'll fix that up in the core. We can't put this special case into drm_encoder_init() because drivers will have to fill up possible_clones after adding all the relevant encoders. Otherwise they wouldn't know the proper encoder indexes to use. So we'll just do it just before registering the encoders. TODO: Should we do something similar for possible_crtcs==0? Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Daniel Vetter <daniel@ffwll.ch> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> --- drivers/gpu/drm/drm_encoder.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/drm_encoder.c b/drivers/gpu/drm/drm_encoder.c index e555281f43d4..f761d9306028 100644 --- a/drivers/gpu/drm/drm_encoder.c +++ b/drivers/gpu/drm/drm_encoder.c @@ -66,11 +66,26 @@ static const struct drm_prop_enum_list drm_encoder_enum_list[] = { { DRM_MODE_ENCODER_DPI, "DPI" }, }; +/* + * For some reason we want the encoder itself included in + * possible_clones. Make life easy for drivers by allowing them + * to leave possible_clones unset if no cloning is possible. + */ +static void fixup_possible_clones(struct drm_device *dev) +{ + struct drm_encoder *encoder; + + drm_for_each_encoder(encoder, dev) + encoder->possible_clones |= drm_encoder_mask(encoder); +} + int drm_encoder_register_all(struct drm_device *dev) { struct drm_encoder *encoder; int ret = 0; + fixup_possible_clones(dev); + drm_for_each_encoder(encoder, dev) { if (encoder->funcs->late_register) ret = encoder->funcs->late_register(encoder); -- 2.24.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-07 14:00 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-07 13:59 [PATCH v2 0/6] drm: Try to fix encoder possible_clones/crtc Ville Syrjala 2020-02-07 13:59 ` [Intel-gfx] " Ville Syrjala 2020-02-07 13:59 ` Ville Syrjala [this message] 2020-02-07 13:59 ` [Intel-gfx] [PATCH v2 1/6] drm: Include the encoder itself in possible_clones Ville Syrjala 2020-02-07 14:28 ` Thomas Zimmermann 2020-02-07 14:28 ` [Intel-gfx] " Thomas Zimmermann 2020-02-07 14:50 ` Ville Syrjälä 2020-02-07 14:50 ` [Intel-gfx] " Ville Syrjälä 2020-02-07 16:27 ` Daniel Vetter 2020-02-07 16:27 ` Daniel Vetter 2020-02-07 16:34 ` Ville Syrjälä 2020-02-07 16:34 ` Ville Syrjälä 2020-02-07 16:40 ` Daniel Vetter 2020-02-07 16:40 ` Daniel Vetter 2020-02-10 8:16 ` Thomas Zimmermann 2020-02-10 8:16 ` Thomas Zimmermann 2020-02-07 16:36 ` Daniel Vetter 2020-02-07 16:36 ` [Intel-gfx] " Daniel Vetter 2020-02-07 13:59 ` [PATCH v2 2/6] drm/gma500: Sanitize possible_clones Ville Syrjala 2020-02-07 13:59 ` [Intel-gfx] " Ville Syrjala 2020-02-07 16:30 ` Daniel Vetter 2020-02-07 16:30 ` [Intel-gfx] " Daniel Vetter 2020-02-07 13:59 ` [PATCH v2 3/6] drm/exynos: Use drm_encoder_mask() Ville Syrjala 2020-02-07 13:59 ` [Intel-gfx] " Ville Syrjala 2020-02-07 14:19 ` Thomas Zimmermann 2020-02-07 14:19 ` [Intel-gfx] " Thomas Zimmermann 2020-02-07 13:59 ` [PATCH v2 4/6] drm/imx: Remove the bogus possible_clones setup Ville Syrjala 2020-02-07 13:59 ` [Intel-gfx] " Ville Syrjala 2020-02-07 14:20 ` Thomas Zimmermann 2020-02-07 14:20 ` [Intel-gfx] " Thomas Zimmermann 2020-02-07 16:31 ` Daniel Vetter 2020-02-07 16:31 ` Daniel Vetter 2020-02-07 13:59 ` [PATCH v2 5/6] drm: Validate encoder->possible_clones Ville Syrjala 2020-02-07 13:59 ` [Intel-gfx] " Ville Syrjala 2020-02-07 14:25 ` Thomas Zimmermann 2020-02-07 14:25 ` [Intel-gfx] " Thomas Zimmermann 2020-02-07 13:59 ` [PATCH v2 6/6] drm: Validate encoder->possible_crtcs Ville Syrjala 2020-02-07 13:59 ` [Intel-gfx] " Ville Syrjala 2020-02-07 16:39 ` Daniel Vetter 2020-02-07 16:39 ` [Intel-gfx] " Daniel Vetter 2020-02-07 16:49 ` Ville Syrjälä 2020-02-07 16:49 ` [Intel-gfx] " Ville Syrjälä 2020-02-07 17:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm: Try to fix encoder possible_clones/crtc (rev2) Patchwork 2020-02-10 16:36 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200207135950.6655-2-ville.syrjala@linux.intel.com \ --to=ville.syrjala@linux.intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.