* [PATCH] arm64: dts: rk3399: Remove extcon unit address and extcon-cells from Gru
@ 2020-02-07 14:13 ` Enric Balletbo i Serra
0 siblings, 0 replies; 5+ messages in thread
From: Enric Balletbo i Serra @ 2020-02-07 14:13 UTC (permalink / raw)
To: linux-kernel
Cc: Collabora Kernel ML, dafna.hirschfeld, heiko, Matthias Kaehlcke,
devicetree, linux-rockchip, Brian Norris, Marcel Holtmann,
Robin Murphy, Rob Herring, Mark Rutland, linux-arm-kernel
The cros-ec-extcon has no reg property so remove the unit address from
the DT node to make DT compiler happy.
While here, remove the inexistent extcon-cells property from the extcon
nodes.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
Thanks to the Dafna's work and Rob's review I got noticed that the old
txt binding was wrong, and also, that the current cros-ec-extcon node in
Gru is wrong, so sending this patch now that is fresh in our minds and
update the node accordingly. There is an extcon-cells property that seems
to not exist and is not documented, so remove it.
For reference, see https://lkml.org/lkml/2020/2/5/176.
arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi | 4 +---
arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi
index 7cd6d470c1cb..1384dabbdf40 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi
@@ -291,11 +291,9 @@ cros_ec_pwm: ec-pwm {
#pwm-cells = <1>;
};
- usbc_extcon1: extcon@1 {
+ usbc_extcon1: extcon1 {
compatible = "google,extcon-usbc-cros-ec";
google,usb-port-id = <1>;
-
- #extcon-cells = <0>;
};
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
index dd5624975c9b..2f3997740068 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
@@ -570,11 +570,9 @@ i2c_tunnel: i2c-tunnel {
#size-cells = <0>;
};
- usbc_extcon0: extcon@0 {
+ usbc_extcon0: extcon0 {
compatible = "google,extcon-usbc-cros-ec";
google,usb-port-id = <0>;
-
- #extcon-cells = <0>;
};
};
};
--
2.24.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] arm64: dts: rk3399: Remove extcon unit address and extcon-cells from Gru
@ 2020-02-07 14:13 ` Enric Balletbo i Serra
0 siblings, 0 replies; 5+ messages in thread
From: Enric Balletbo i Serra @ 2020-02-07 14:13 UTC (permalink / raw)
To: linux-kernel
Cc: Mark Rutland, devicetree, dafna.hirschfeld, heiko,
Marcel Holtmann, Brian Norris, Rob Herring, linux-rockchip,
Matthias Kaehlcke, Collabora Kernel ML, Robin Murphy,
linux-arm-kernel
The cros-ec-extcon has no reg property so remove the unit address from
the DT node to make DT compiler happy.
While here, remove the inexistent extcon-cells property from the extcon
nodes.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
Thanks to the Dafna's work and Rob's review I got noticed that the old
txt binding was wrong, and also, that the current cros-ec-extcon node in
Gru is wrong, so sending this patch now that is fresh in our minds and
update the node accordingly. There is an extcon-cells property that seems
to not exist and is not documented, so remove it.
For reference, see https://lkml.org/lkml/2020/2/5/176.
arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi | 4 +---
arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi
index 7cd6d470c1cb..1384dabbdf40 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi
@@ -291,11 +291,9 @@ cros_ec_pwm: ec-pwm {
#pwm-cells = <1>;
};
- usbc_extcon1: extcon@1 {
+ usbc_extcon1: extcon1 {
compatible = "google,extcon-usbc-cros-ec";
google,usb-port-id = <1>;
-
- #extcon-cells = <0>;
};
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
index dd5624975c9b..2f3997740068 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
@@ -570,11 +570,9 @@ i2c_tunnel: i2c-tunnel {
#size-cells = <0>;
};
- usbc_extcon0: extcon@0 {
+ usbc_extcon0: extcon0 {
compatible = "google,extcon-usbc-cros-ec";
google,usb-port-id = <0>;
-
- #extcon-cells = <0>;
};
};
};
--
2.24.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: rk3399: Remove extcon unit address and extcon-cells from Gru
@ 2020-02-12 22:24 ` Heiko Stuebner
0 siblings, 0 replies; 5+ messages in thread
From: Heiko Stuebner @ 2020-02-12 22:24 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: linux-kernel, Collabora Kernel ML, dafna.hirschfeld,
Matthias Kaehlcke, devicetree, linux-rockchip, Brian Norris,
Marcel Holtmann, Robin Murphy, Rob Herring, Mark Rutland,
linux-arm-kernel
Am Freitag, 7. Februar 2020, 15:13:24 CET schrieb Enric Balletbo i Serra:
> The cros-ec-extcon has no reg property so remove the unit address from
> the DT node to make DT compiler happy.
>
> While here, remove the inexistent extcon-cells property from the extcon
> nodes.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
applied for 5.7
Thanks
Heiko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: rk3399: Remove extcon unit address and extcon-cells from Gru
@ 2020-02-12 22:24 ` Heiko Stuebner
0 siblings, 0 replies; 5+ messages in thread
From: Heiko Stuebner @ 2020-02-12 22:24 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, Collabora Kernel ML,
dafna.hirschfeld-ZGY8ohtN/8qB+jHODAdFcQ, Matthias Kaehlcke,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Brian Norris,
Marcel Holtmann, Robin Murphy, Rob Herring, Mark Rutland,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Am Freitag, 7. Februar 2020, 15:13:24 CET schrieb Enric Balletbo i Serra:
> The cros-ec-extcon has no reg property so remove the unit address from
> the DT node to make DT compiler happy.
>
> While here, remove the inexistent extcon-cells property from the extcon
> nodes.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
applied for 5.7
Thanks
Heiko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: rk3399: Remove extcon unit address and extcon-cells from Gru
@ 2020-02-12 22:24 ` Heiko Stuebner
0 siblings, 0 replies; 5+ messages in thread
From: Heiko Stuebner @ 2020-02-12 22:24 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: Mark Rutland, devicetree, dafna.hirschfeld, Marcel Holtmann,
Brian Norris, linux-kernel, Rob Herring, linux-rockchip,
Matthias Kaehlcke, Collabora Kernel ML, Robin Murphy,
linux-arm-kernel
Am Freitag, 7. Februar 2020, 15:13:24 CET schrieb Enric Balletbo i Serra:
> The cros-ec-extcon has no reg property so remove the unit address from
> the DT node to make DT compiler happy.
>
> While here, remove the inexistent extcon-cells property from the extcon
> nodes.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
applied for 5.7
Thanks
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-02-12 22:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-07 14:13 [PATCH] arm64: dts: rk3399: Remove extcon unit address and extcon-cells from Gru Enric Balletbo i Serra
2020-02-07 14:13 ` Enric Balletbo i Serra
2020-02-12 22:24 ` Heiko Stuebner
2020-02-12 22:24 ` Heiko Stuebner
2020-02-12 22:24 ` Heiko Stuebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.