All of lore.kernel.org
 help / color / mirror / Atom feed
* [vincent.guittot:sched/pelt 4/5] kernel/sched/fair.c:4011:2: error: implicit declaration of function 'se_update_runnable'; did you mean 'sched_rt_runnable'?
@ 2020-02-07 12:26 kbuild test robot
  0 siblings, 0 replies; only message in thread
From: kbuild test robot @ 2020-02-07 12:26 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 4155 bytes --]

tree:   https://git.linaro.org/people/vincent.guittot/kernel.git sched/pelt
head:   72c9cba7acfa9d51fe5ced5ff3a3cde60c69e022
commit: 26d3f5b799e5a4ee66ed32186e4684a1af702b36 [4/5] sched/fair: replace runnable load average by runnable average
config: m68k-multi_defconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 26d3f5b799e5a4ee66ed32186e4684a1af702b36
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   kernel/sched/fair.c: In function 'enqueue_entity':
>> kernel/sched/fair.c:4011:2: error: implicit declaration of function 'se_update_runnable'; did you mean 'sched_rt_runnable'? [-Werror=implicit-function-declaration]
     se_update_runnable(se);
     ^~~~~~~~~~~~~~~~~~
     sched_rt_runnable
   cc1: some warnings being treated as errors

vim +4011 kernel/sched/fair.c

  3946	
  3947	
  3948	/*
  3949	 * MIGRATION
  3950	 *
  3951	 *	dequeue
  3952	 *	  update_curr()
  3953	 *	    update_min_vruntime()
  3954	 *	  vruntime -= min_vruntime
  3955	 *
  3956	 *	enqueue
  3957	 *	  update_curr()
  3958	 *	    update_min_vruntime()
  3959	 *	  vruntime += min_vruntime
  3960	 *
  3961	 * this way the vruntime transition between RQs is done when both
  3962	 * min_vruntime are up-to-date.
  3963	 *
  3964	 * WAKEUP (remote)
  3965	 *
  3966	 *	->migrate_task_rq_fair() (p->state == TASK_WAKING)
  3967	 *	  vruntime -= min_vruntime
  3968	 *
  3969	 *	enqueue
  3970	 *	  update_curr()
  3971	 *	    update_min_vruntime()
  3972	 *	  vruntime += min_vruntime
  3973	 *
  3974	 * this way we don't have the most up-to-date min_vruntime on the originating
  3975	 * CPU and an up-to-date min_vruntime on the destination CPU.
  3976	 */
  3977	
  3978	static void
  3979	enqueue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags)
  3980	{
  3981		bool renorm = !(flags & ENQUEUE_WAKEUP) || (flags & ENQUEUE_MIGRATED);
  3982		bool curr = cfs_rq->curr == se;
  3983	
  3984		/*
  3985		 * If we're the current task, we must renormalise before calling
  3986		 * update_curr().
  3987		 */
  3988		if (renorm && curr)
  3989			se->vruntime += cfs_rq->min_vruntime;
  3990	
  3991		update_curr(cfs_rq);
  3992	
  3993		/*
  3994		 * Otherwise, renormalise after, such that we're placed at the current
  3995		 * moment in time, instead of some random moment in the past. Being
  3996		 * placed in the past could significantly boost this task to the
  3997		 * fairness detriment of existing tasks.
  3998		 */
  3999		if (renorm && !curr)
  4000			se->vruntime += cfs_rq->min_vruntime;
  4001	
  4002		/*
  4003		 * When enqueuing a sched_entity, we must:
  4004		 *   - Update loads to have both entity and cfs_rq synced with now.
  4005		 *   - Add its load to cfs_rq->runnable_avg
  4006		 *   - For group_entity, update its weight to reflect the new share of
  4007		 *     its group cfs_rq
  4008		 *   - Add its new weight to cfs_rq->load.weight
  4009		 */
  4010		update_load_avg(cfs_rq, se, UPDATE_TG | DO_ATTACH);
> 4011		se_update_runnable(se);
  4012		update_cfs_group(se);
  4013		account_entity_enqueue(cfs_rq, se);
  4014	
  4015		if (flags & ENQUEUE_WAKEUP)
  4016			place_entity(cfs_rq, se, 0);
  4017	
  4018		check_schedstat_required();
  4019		update_stats_enqueue(cfs_rq, se, flags);
  4020		check_spread(cfs_rq, se);
  4021		if (!curr)
  4022			__enqueue_entity(cfs_rq, se);
  4023		se->on_rq = 1;
  4024	
  4025		if (cfs_rq->nr_running == 1) {
  4026			list_add_leaf_cfs_rq(cfs_rq);
  4027			check_enqueue_throttle(cfs_rq);
  4028		}
  4029	}
  4030	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 16752 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-02-07 12:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-07 12:26 [vincent.guittot:sched/pelt 4/5] kernel/sched/fair.c:4011:2: error: implicit declaration of function 'se_update_runnable'; did you mean 'sched_rt_runnable'? kbuild test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.