All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jack Pham <jackp@codeaurora.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
	gregkh@linuxfoundation.org, balbi@kernel.org,
	bjorn.andersson@linaro.org, robh@kernel.org,
	linux-kernel@vger.kernel.org, Andy Gross <agross@kernel.org>,
	Lee Jones <lee.jones@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH v5 11/18] usb: dwc3: Add support for a role-switch notifier
Date: Fri, 7 Feb 2020 16:15:20 -0800	[thread overview]
Message-ID: <20200208001520.GB18464@jackp-linux.qualcomm.com> (raw)
In-Reply-To: <20200207201654.641525-12-bryan.odonoghue@linaro.org>

Hi Bryan,

On Fri, Feb 07, 2020 at 08:16:47PM +0000, Bryan O'Donoghue wrote:
> Role-switching is a 1:1 mapping between a producer and a consumer. For DWC3
> we have some vendor specific wrappers, notably the qcom wrapper that want
> to toggle some PHY related bits on a USB role switch.
> 
> This patch adds a role-switch notifier to the dwc3 drd code. When the USB
> role-switch set() routine runs, the notifier will fire passing the notified
> mode to the consumer, thus allowing vendor specific fix-ups to toggle from
> the role-switching events.

Neat! This could work. But let's see if Felipe likes this approach.

If you need, here's a

Reviewed-by: Jack Pham <jackp@codeaurora.org>

Jack
-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2020-02-08  0:15 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07 20:16 [PATCH v5 00/18] Enable Qualcomm QCS 404 HS/SS USB Bryan O'Donoghue
2020-02-07 20:16 ` [PATCH v5 01/18] dt-bindings: phy: remove qcom-dwc3-usb-phy Bryan O'Donoghue
2020-02-07 20:16 ` [PATCH v5 02/18] dt-bindings: phy: Add Qualcomm Synopsys Hi-Speed USB PHY binding Bryan O'Donoghue
2020-02-07 20:16 ` [PATCH v5 03/18] phy: qualcomm: Add Synopsys 28nm Hi-Speed USB PHY driver Bryan O'Donoghue
2020-02-07 20:16 ` [PATCH v5 04/18] dt-bindings: Add Qualcomm USB SuperSpeed PHY bindings Bryan O'Donoghue
2020-02-07 20:16 ` [PATCH v5 05/18] phy: qualcomm: usb: Add SuperSpeed PHY driver Bryan O'Donoghue
2020-02-07 20:16 ` [PATCH v5 06/18] usb: dwc3: Registering a role switch in the DRD code Bryan O'Donoghue
2020-02-07 20:16 ` [PATCH v5 07/18] dt-bindings: usb: dwc3: Add a gpio-usb-connector example Bryan O'Donoghue
2020-02-07 20:16 ` [PATCH v5 08/18] dt-bindings: usb: dwc3: Add a usb-role-switch to the example Bryan O'Donoghue
2020-02-07 20:16 ` [PATCH v5 09/18] usb: dwc3: qcom: Add support for usb-conn-gpio connectors Bryan O'Donoghue
2020-02-07 20:43   ` Jack Pham
2020-02-07 21:24     ` Bryan O'Donoghue
2020-02-07 20:16 ` [PATCH v5 10/18] usb: dwc3: " Bryan O'Donoghue
2020-02-07 23:49   ` Bryan O'Donoghue
2020-02-07 20:16 ` [PATCH v5 11/18] usb: dwc3: Add support for a role-switch notifier Bryan O'Donoghue
2020-02-08  0:15   ` Jack Pham [this message]
2020-02-08  0:28     ` Bryan O'Donoghue
2020-02-07 20:16 ` [PATCH v5 12/18] usb: dwc3: qcom: Enable gpio-usb-conn based role-switching Bryan O'Donoghue
2020-02-07 20:16 ` [PATCH v5 13/18] arm64: dts: qcom: qcs404: Add USB devices and PHYs Bryan O'Donoghue
2020-02-07 20:16 ` [PATCH v5 14/18] arm64: dts: qcom: qcs404-evb: Define VBUS pins Bryan O'Donoghue
2020-02-07 20:16 ` [PATCH v5 15/18] arm64: dts: qcom: qcs404-evb: Define USB ID pin Bryan O'Donoghue
2020-02-07 20:16 ` [PATCH v5 16/18] arm64: dts: qcom: qcs404-evb: Describe external VBUS regulator Bryan O'Donoghue
2020-02-07 20:16 ` [PATCH v5 17/18] arm64: dts: qcom: qcs404-evb: Raise vreg_l12_3p3 minimum voltage Bryan O'Donoghue
2020-02-07 20:16 ` [PATCH v5 18/18] arm64: dts: qcom: qcs404-evb: Enable USB controllers Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200208001520.GB18464@jackp-linux.qualcomm.com \
    --to=jackp@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=balbi@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.